From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D09AC27C53 for ; Wed, 19 Jun 2024 04:44:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 825216B0117; Wed, 19 Jun 2024 00:44:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ACEA6B011B; Wed, 19 Jun 2024 00:44:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 64D336B011E; Wed, 19 Jun 2024 00:44:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 42C6E6B0117 for ; Wed, 19 Jun 2024 00:44:31 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B8307C0484 for ; Wed, 19 Jun 2024 04:44:30 +0000 (UTC) X-FDA: 82246397100.28.54F672D Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by imf29.hostedemail.com (Postfix) with ESMTP id 02E63120005 for ; Wed, 19 Jun 2024 04:44:27 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BeGUNCFB; spf=pass (imf29.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718772264; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8kSbyK4rfjsHEY+Lpbm26zgIzNqvsWdMEElHVTqPiyk=; b=ekfGvUS3VKwrQQh+JeixL6e5Yxn9/cnSWOx9ZWwoeZ5wC2oG52RQ0KVQ/+c43RYP0QQ/FJ 58zGOiCL4pwppPfZnu+J3MMR0LB71b8WOBEPVynVXFEOsMmnrGhP9JjLzn3tf2RNJ6vLLO OAovdtIXP33bFZza+robxOn7J0towZg= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=BeGUNCFB; spf=pass (imf29.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718772264; a=rsa-sha256; cv=none; b=xtIEGhjiTOwyUVF0cLRHHkkpSOG/UZRr8NxXpwofJJJWlI5nk/X/1fd+x6Ax4fQKpPpAlY v0gqEHMeWalXXeVIgAxlV+cZ1EJ57Mzkkz+u0SlGohZGYtxP/HrZ0DXc+0Ir+8qPzj1bDZ jla4IZx34ZQEyZqxpHaaPlcHL+IWR9I= Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-80f551808e0so232038241.1 for ; Tue, 18 Jun 2024 21:44:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718772267; x=1719377067; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8kSbyK4rfjsHEY+Lpbm26zgIzNqvsWdMEElHVTqPiyk=; b=BeGUNCFBCv+5S/TIgpk3rVsM0Vp/7TT8lHU1uCq02sol4Rry572Gu3Ksmja5926RxP ba/cyi28wKOvPBXy7VswclVE+Rd3qqds+9OF1/gYCTHoD88hWnKQ5RlxbXMuiBmgLyAW la4mHGTNsneuc7Y4lxp3nu8e3HCt9yUEwhTosUwPBfmt0f5bJTAbHk1P1fcoRJbhroTx NLyp+BC023njeO7UyWo5y9ipypXpIaxZhfjYbAGTU8wDfWMdg/kMHSQujyC+tj/D/aN1 40MmIbcSTxCr7XqIqfODBzuuUQLA7xu9L6PruWc4F1a9e0vIfKP6/0T1Dj0ngjukrcQk gJgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718772267; x=1719377067; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8kSbyK4rfjsHEY+Lpbm26zgIzNqvsWdMEElHVTqPiyk=; b=MfGhqgIfjFCK6nqqyEtm88LPVs9yvZ8zgzB49pobQr7sxOjSR11OihAyFEvkwwAYV1 vAm1bq55iyB6vgSh23EIJmc8SdY6dOC5cI44SJVtsvg7ehkYBDqYmlxfdWzpDsQB3BDG n9/Qp8crTxdAMjsPN/98GZxOdjLDhkzRrkYNhIIlJ5EdYCR/u76H8nW+xaqL9SLfAFYe /AVYn1eEDAJBvXfPsWdOvY1SE/JlxsTGLbHubNFBOcWBcPXc5LZXeUA/21mmDBa/YWUQ D9v2As2ODgKx4gvJUzks9wNMhpjKa26LrfbTfNC2K0CaxyNVj1iqd0FgmTf/Z2KtkW16 aEsg== X-Forwarded-Encrypted: i=1; AJvYcCWcJd08lVHYOTO0awDLjybauZgU2y5lmV0+KxZgtEnPt22n1MQAnwRSd54fchHmWnCLc9RgaaRmnsxoKEXzLh5b9go= X-Gm-Message-State: AOJu0YwMlUW4DhkK7BZUxW4O9dsFLcQG3vr1CWAEZV4Rsxw59Vx705hO q7PvlWqyoYBQAkRJcM7OUrGmoVqvwMnTpGQczaDzU0KDs68jDUui/O735QAVJCYrnt2SAGx5dul yqIjajLsNStQo2ianeuKGrAhsAnQ= X-Google-Smtp-Source: AGHT+IHKzo6EwIMqUwbhmwNQAL3um1qjSrNKdFWC9jMclsciycNF3jZF/k86XZVVhAV16DzqmwIyXGJv7yyTrWsC5w8= X-Received: by 2002:a67:eb88:0:b0:48d:943b:43bc with SMTP id ada2fe7eead31-48f130e678cmr1593329137.26.1718772266823; Tue, 18 Jun 2024 21:44:26 -0700 (PDT) MIME-Version: 1.0 References: <20240618072258.33128-1-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Wed, 19 Jun 2024 16:44:15 +1200 Message-ID: Subject: Re: [PATCH v2] cifs: drop the incorrect assertion in cifs_swap_rw() To: Steve French Cc: akpm@linux-foundation.org, linux-cifs@vger.kernel.org, linux-mm@kvack.org, sfrench@samba.org, anna@kernel.org, chrisl@kernel.org, hanchuanhua@oppo.com, hch@lst.de, jlayton@kernel.org, linux-nfs@vger.kernel.org, neilb@suse.de, ryan.roberts@arm.com, stable@vger.kernel.org, trondmy@kernel.org, v-songbaohua@oppo.com, ying.huang@intel.com, Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Tom Talpey , Bharath SM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 02E63120005 X-Stat-Signature: gpcbytpyuc96ispchs89estf8uhbrfs5 X-HE-Tag: 1718772267-220519 X-HE-Meta: U2FsdGVkX190CJmsMhwHoY9bRFo4vLOQuoYhCqmbQiNf/BtxPKknPEKs3YqNWmiu1YOJt1lQgmncN1moXj+I8W+DCcHO1PxXpawK4zSVDcll2lxDGCsUXDmFlQn1WcFbQ1cQryRvFc+/qo1HMlJFwud5XyG8WWXV7qAcqXXOTZA3FzBxwVHDzwjbw5a7S+ky1kAnCkmnjukKAfoB+KAUiynbrd1DpzTxET0WJJNeV3ihJI7WiuyzoFK1IvaDAb6oV1RJPjE15vuvwYB7ETZPesgFSdryBaGU64jrZYRsylm0SwQpsdIQNpwHfv5b6/bZUkc7VwSkMB+qvKmcl7YUakgd/7oQWma/pK74CxBX4O0Uh5Y8Y2y6/uqJmrJW/ouJLKM+WLDVKf7nfCj63JyPy5jrSTwJwBIKT/EZuWGXX8VORqBW1WtmO9bzowAgFV2Ex2Hm/A1JwM+kRKVd4R0LTy+mqlzNBeDuo846HezatceErsiJXCZsrOUI1CprVitJW9z5lKzVj1PhSHJGnRVhYDnQwcVy3Xcnnx6qPvL9vCKenB9qV2aKSc7NcpG0RyuMl87zc9vf03Vp6hI7VQYQ9PjNyBYPJ/WN0wvL9VWRxQI/DEOUZYDFwq9nZ/hdevEej3TaG0x24A3v99pbqHk0ToPynh47MPcE8p5QUMTUctSGiy1SiPXenJ5BMjUpQdpBThlplum23FzDNW4V4oKFeY5v0JA2TZHno6VOiZuhfagNdDbINDu/Z0SQwBoQW75Mb6n3kTCX2sCRnSjnogtLjAMmx8yZ/5qBfHjnMBqVDVo3xQ4M9USxxqg0Th82bio0lA4Dz/d0ZWEbPMxpRgtpXFjnJN0kRJVbiqqmMvkjjrM/uWfXQ3y6COSd8hJv8z5vIsQpRyVBrTnMwv8G+uYs5aTqSykxG7xfbm9FKuJdsbKRvFzz5oi+ui2YZ8NgsBjaBA9qMGOsLErskHrmwUB wQYQvqRY nOpyS/rmGjHUqrtsFLuCQKBIhu2wi/ALb9qbPIPQ08TCJRh/oE4IHft/MGVSSN2VNQoMy6lsCCq8QLJQ/xKUy+PtJbOlQb5REAr4wkDoVR8X8ivP18a86KUp8UR+qf8GvmyNp0efdCj+JDvy/0xqpb24D04WUL1Zdt0xjAeuePwoPjLJJv2kKaz0uumdQjABseS7kL+xd8m3daJ5P/M8Nisjj1yx3IVJp5LVSm09D1sFRwtpanv0i8W6+/ZEEPmJA+/yy+JFPFTBkTYmAXDRcyEcQm416ylr9G3YQtRGq82sAUrpVgryps6qGeptPGcsjSV6c9vKQkjd67133e1p+WJPdJW1LfLOT/TspiCDtv+w8ynTrvMsG06wQsQFN98IKSWMzqDwfvQ6MCcACwX+C8gnrv7QsHwXITvf3aWxp1NQhDMSA74b8YldoN56lnce42gflMMYNuO6u98mNzmbpzK3pJu6JBikcGmkh9oCS3ecrFnl5p8aJoHvsi/HvPMtXOBb+g/tyE2NlXWHW0NSxWg79JsPai44b4NRM+bUHmazqXRJm+UQ7PRnEPPntsAwbsnQUfu3z1fxVmupfQS46MTQJ7+jQJDG/KlRnu2N7PstJZK3ZOH/TmyIHzRrouYgDv+6rOiBYMZb0C1QhELB5SvIe2HCDW/LU3GlbjLblh8IaJ+Yagsm+kmZKnadigDSBpNxpwkOMft8Z+WWi6tixoEx5lqMMS/yvLZ4OKm3e+lsu/L9Z+QwcRTk3lLdo5cUDV98BwsV1XsmXmDk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jun 19, 2024 at 3:48=E2=80=AFPM Steve French w= rote: > > tentatively merged into cifs-2.6.git for-next pending testing and any add= itional review Steve, Thanks! I guess you missed an email from mm-commits. A couple of hours ago, this was pulled into mm-hotfixes-unstable, likely for the same purpose. Will this cause any conflicts when both changes hit linux-next? https://lore.kernel.org/mm-commits/20240618195943.EC07BC3277B@smtp.kernel.o= rg/ Will we just keep one? > > On Tue, Jun 18, 2024 at 3:56=E2=80=AFAM Barry Song <21cnbao@gmail.com> wr= ote: >> >> From: Barry Song >> >> Since commit 2282679fb20b ("mm: submit multipage write for SWP_FS_OPS >> swap-space"), we can plug multiple pages then unplug them all together. >> That means iov_iter_count(iter) could be way bigger than PAGE_SIZE, it >> actually equals the size of iov_iter_npages(iter, INT_MAX). >> >> Note this issue has nothing to do with large folios as we don't support >> THP_SWPOUT to non-block devices. >> >> Fixes: 2282679fb20b ("mm: submit multipage write for SWP_FS_OPS swap-spa= ce") >> Reported-by: Christoph Hellwig >> Closes: https://lore.kernel.org/linux-mm/20240614100329.1203579-1-hch@ls= t.de/ >> Cc: NeilBrown >> Cc: Anna Schumaker >> Cc: Steve French >> Cc: Trond Myklebust >> Cc: Chuanhua Han >> Cc: Ryan Roberts >> Cc: Chris Li >> Cc: "Huang, Ying" >> Cc: Jeff Layton >> Cc: Paulo Alcantara >> Cc: Ronnie Sahlberg >> Cc: Shyam Prasad N >> Cc: Tom Talpey >> Cc: Bharath SM >> Cc: >> Signed-off-by: Barry Song >> --- >> -v2: >> * drop the assertion instead of fixing the assertion. >> per the comments of Willy, Christoph in nfs thread. >> >> fs/smb/client/file.c | 2 -- >> 1 file changed, 2 deletions(-) >> >> diff --git a/fs/smb/client/file.c b/fs/smb/client/file.c >> index 9d5c2440abfc..1e269e0bc75b 100644 >> --- a/fs/smb/client/file.c >> +++ b/fs/smb/client/file.c >> @@ -3200,8 +3200,6 @@ static int cifs_swap_rw(struct kiocb *iocb, struct= iov_iter *iter) >> { >> ssize_t ret; >> >> - WARN_ON_ONCE(iov_iter_count(iter) !=3D PAGE_SIZE); >> - >> if (iov_iter_rw(iter) =3D=3D READ) >> ret =3D netfs_unbuffered_read_iter_locked(iocb, iter); >> else >> -- >> 2.34.1 >> >> > > > -- > Thanks, > > Steve