From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DD15C27C4F for ; Tue, 11 Jun 2024 02:59:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3F9D6B009F; Mon, 10 Jun 2024 22:59:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEF9D6B00A0; Mon, 10 Jun 2024 22:59:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C90086B00A2; Mon, 10 Jun 2024 22:59:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id A99896B009F for ; Mon, 10 Jun 2024 22:59:29 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 560C8C0E6F for ; Tue, 11 Jun 2024 02:59:29 +0000 (UTC) X-FDA: 82217102058.14.B60559F Received: from mail-ua1-f47.google.com (mail-ua1-f47.google.com [209.85.222.47]) by imf25.hostedemail.com (Postfix) with ESMTP id 82E07A0006 for ; Tue, 11 Jun 2024 02:59:27 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YmhtkdfB; spf=pass (imf25.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718074767; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ud8Y/RGuWXbBKz7MlAb9Fh+BQvy1bg4qOh9fhwLLmdc=; b=48jT7BHIFv9fAcNxi2cekh3VMx2To8wWBjXI6YdbALTXkN8m/oS9+QKNg43A+S+tWIXCQP ZbdGW/6Oau0lf70l95DwCautKuaGlhO2erl6gfxaLMI9DHSq04LU7h3rsL1zSQKErtvhng 4PzT71XrH/s58zdQ0IawrTj84/0gpuY= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=YmhtkdfB; spf=pass (imf25.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.47 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718074767; a=rsa-sha256; cv=none; b=vAYqQ0srukhrsOrrT4NIobXwbI4pN1ke5/HxbUwZzYaSFpo18bY3Ol84Cx28yI+0kq5Uto TbmiScAoy8607P2tHZO8IZzKRiIpaSo0qRDpjXlc1wgBsbqjTG9vYCKdfPJKPVGlcvI0Sn UHDsrrjDu9zI9xenQan/OG8ZWiceBkQ= Received: by mail-ua1-f47.google.com with SMTP id a1e0cc1a2514c-80b8efd9adcso561375241.0 for ; Mon, 10 Jun 2024 19:59:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718074766; x=1718679566; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ud8Y/RGuWXbBKz7MlAb9Fh+BQvy1bg4qOh9fhwLLmdc=; b=YmhtkdfBmotcszqTYuz8SAg6iAcZir2WwWVPLs9T+XEN8x5G4VXoN8NI+yjrQB3wiG 9equCxkg1kheR+s4mkxRs3BgmsVlROwF1+vLovfsnbehw4zlTVz90/HF888vmAC+gbuW cpHl+TSJ/0wHNv/eYTqq5QyE6MjAgO6TsZhFHsDTvVqv2x7u9RyrdRp0/YZ+W0/mhaDg /1MTq8FTaeJeJ2RvdLMCi9rq4UtjmHXxTfVnqCKju9Zlx5vLKKIHz7SU9rSh1kktO6Jo 44LU1mK8vRMiyEmIA1FLcd9ZBdxz6B7e6gxdWfN9cYquvFnWcyWwSxaxouma7eq1aT58 BbHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718074766; x=1718679566; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ud8Y/RGuWXbBKz7MlAb9Fh+BQvy1bg4qOh9fhwLLmdc=; b=gaWwLQRozbBBTUNNT3HqZ8oXwle28OQwRW/QtZffqPSafHNSUkLyCKKaAVoiolltL4 R2OPDxeT34XhEJdO1I+8GFjYcV1TjFUfVI/HNXaZvDoWaF5nakZzK2vtpxjYfaREGEaU w40WzXqvI1hIMD+M1OLZVWlJWGlDJNlvC/PSX2di4/3w6dVjjuafZ/pfyh/rjWAWNqvO wj4y/GlexNj459faS9d7QTc2r/dLFPfDWzD5TDcT1lBfxNBz6u34e4PGG86ePfIwWEa/ +BVDgcGKAaRmPrpwWKRjpTlVC310aJierqW3x6JzuWfwgHsBf3vzm4a1R6DUIM1DXWFz XIYg== X-Forwarded-Encrypted: i=1; AJvYcCUqCD2+JTuuFxkPUFcArderykQbBRd1TjviW3IMEQmd96DvvxNnISZRl70oG4CMy56DqpgEcSg3hd9rTlqR1AeI398= X-Gm-Message-State: AOJu0Yy6Xq77MYKcwR9tpfXTNp7IRJwplb+M+F5KiyehnzP5kER89vru Ow7yeiyBTMV3LItvLeq2sGpo97UbB603q8opDHuK6KV4aGj9c147/+yIcmVkI/JiGo0TK6Oimql vm2EuklohWJpaq15+aixnkq2ET+o= X-Google-Smtp-Source: AGHT+IHGZoJCvXd6Cw27+L78MQzXQpSh7YuJ5NtX+G3yz2A+hr/v7wo/fv1uFKyWtllt8qFNormYrYjOq1oGylRcYIs= X-Received: by 2002:a67:ebd0:0:b0:48c:47c3:7857 with SMTP id ada2fe7eead31-48c47c37b1bmr6194902137.29.1718074766436; Mon, 10 Jun 2024 19:59:26 -0700 (PDT) MIME-Version: 1.0 References: <20240611024516.1375191-1-yosryahmed@google.com> In-Reply-To: <20240611024516.1375191-1-yosryahmed@google.com> From: Barry Song <21cnbao@gmail.com> Date: Tue, 11 Jun 2024 14:59:15 +1200 Message-ID: Subject: Re: [PATCH v3 1/3] mm: zswap: rename is_zswap_enabled() to zswap_is_enabled() To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Nhat Pham , Chengming Zhou , Chris Li , David Hildenbrand , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 82E07A0006 X-Stat-Signature: gccjeke4egdxbiq1dqj3xymtm8dekswr X-HE-Tag: 1718074767-296109 X-HE-Meta: U2FsdGVkX19tBIZmURK7WSzyvV6eroZr1Z1eNjWTgBBwYuzA43cia4bTsFfNvjM9tvZDp/XeuCoQ0aGlv0LIVMlEno0ln0KgvZfmuTYIiHmcdYl48c16Xl4EEEdRsj/iszjP24lvKmfe+oDSORipAJu5uz9zdIUfUWRndzhbwhVrePwhalSdqnH33mbxHMP+PQPz0tTvalIsyuc24xORcg/6ula75Rp77oNJ/LGva0PJAsewst4ZjQdq1FJa+RNz5piVUIGz63O2XBOgwaNqeBoE5A9MRsQC+ugHRjFuTIsgTcJPHurYVxKIGk4ZeJWScke2wli9N8Yxz3I3JBt00Oi9LWg9BEc0i9UjQoJDShRsxD6VTlS7bGLnjmHEt8V2INh1WNe7nSER4ChDiJRHkUN+7a/Q2Khx/8HHWF4H8S3m8sk2IZlyh6mXfRfigGnbPj14rn1VUy+PW0UkJGFBZdBsylNzMSxxbXWd7e20aLiHrNVLHxJL7kHtHdVB2gx2YNVJFv/4sxYoU5PxiqJCZtwl/l00F6QLEt+sxtI3ZzJ0W2kniLeBXMw44H0luGwRB0eLhuI5RtKcT+flN0hTZBO6IdOqoegUyDJo9k0BG6YzSX19EggNl2Pb7Sw2VjHfbZwzdG/LqW0FnLavKBeRnspCyy9w+FMBV0YHbbAlnHuYR4zCV728GeMxfFA+qu1OHxgqltTUq5vTZ6aWN64s9DEvjf4P91N9E8KzBh9eZLQz27TyvD1lz4TbQHo3L5IaevZY/Es4IvmeS0O29A1FN14agOMWaXFcSeaz0SOO00sDVWr617iF5S5WfgC3h6n+x0zHUu96/zSV4SQneEqzwgjo4WWlgufqEZNEK+Dg7hWoLLnXBhG8SyjiAV3z5Nzt4SDdCYmx7AJ5n6IY1V8lmbMKB4ZDHZTo877b5C+Se4ovRHsbuNeh4Iit5ZVHgByumpFNtB8K5Nj+WQVeJnt d7a/OYrB kNsgtKkY2pFcYgacpzIQELLN5/T1jA5/zRCVmBLwCdrx+vaaxkvdt1DoWXMHC2swHFN3E6pEAHRd+CEN5BUPgisV/lFDsnDPxtJOcdpKJ2AafhcBxtdknPg8vsHLJ+yU4/xDf4n6eo4IoJ7NvQpY8+1PYQ6KSY+DP+6ZbE8wC0dZ6clnfhRjuwaOY/mejRclmwH7gTBCya8Gyw2TFS8ffTW5cTbQesjRxAscaYMbJZH1tv47GeA5JyAYuCbLQn87BRYq7PMrCHVGrXubpgIdKdfoZGBu891kKgpNXFsbMmWWjjDP65jp7/vRHO0uhjsOLq8Twf1Imv3W3aa+f1Ic0xi+9FUAY2A6x7YL1uOO9DQi8pQqZhfS7gvpJOs305o0pMjf+4XlnjyYC7W0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 11, 2024 at 2:45=E2=80=AFPM Yosry Ahmed = wrote: > > In preparation of introducing a similar function, rename > is_zswap_enabled() to use zswap_* prefix like other zswap functions. > > Signed-off-by: Yosry Ahmed Reviewed-by: Barry Song > --- > include/linux/zswap.h | 4 ++-- > mm/memcontrol.c | 2 +- > mm/zswap.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/include/linux/zswap.h b/include/linux/zswap.h > index 2a85b941db975..ce5e7bfe8f1ec 100644 > --- a/include/linux/zswap.h > +++ b/include/linux/zswap.h > @@ -35,7 +35,7 @@ void zswap_swapoff(int type); > void zswap_memcg_offline_cleanup(struct mem_cgroup *memcg); > void zswap_lruvec_state_init(struct lruvec *lruvec); > void zswap_folio_swapin(struct folio *folio); > -bool is_zswap_enabled(void); > +bool zswap_is_enabled(void); > #else > > struct zswap_lruvec_state {}; > @@ -60,7 +60,7 @@ static inline void zswap_memcg_offline_cleanup(struct m= em_cgroup *memcg) {} > static inline void zswap_lruvec_state_init(struct lruvec *lruvec) {} > static inline void zswap_folio_swapin(struct folio *folio) {} > > -static inline bool is_zswap_enabled(void) > +static inline bool zswap_is_enabled(void) > { > return false; > } > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 1303ed01bb5e5..a811dfff10cda 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -8469,7 +8469,7 @@ void obj_cgroup_uncharge_zswap(struct obj_cgroup *o= bjcg, size_t size) > bool mem_cgroup_zswap_writeback_enabled(struct mem_cgroup *memcg) > { > /* if zswap is disabled, do not block pages going to the swapping= device */ > - return !is_zswap_enabled() || !memcg || READ_ONCE(memcg->zswap_wr= iteback); > + return !zswap_is_enabled() || !memcg || READ_ONCE(memcg->zswap_wr= iteback); > } > > static u64 zswap_current_read(struct cgroup_subsys_state *css, > diff --git a/mm/zswap.c b/mm/zswap.c > index b9b35ef86d9be..a8c8dd8cfe6f5 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -131,7 +131,7 @@ static bool zswap_shrinker_enabled =3D IS_ENABLED( > CONFIG_ZSWAP_SHRINKER_DEFAULT_ON); > module_param_named(shrinker_enabled, zswap_shrinker_enabled, bool, 0644)= ; > > -bool is_zswap_enabled(void) > +bool zswap_is_enabled(void) > { > return zswap_enabled; > } > -- > 2.45.2.505.gda0bf45e8d-goog >