From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2FDCE7716D for ; Thu, 5 Dec 2024 05:00:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F1C7E6B007B; Thu, 5 Dec 2024 00:00:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EA32B6B0082; Thu, 5 Dec 2024 00:00:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D43F16B0083; Thu, 5 Dec 2024 00:00:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AE2426B007B for ; Thu, 5 Dec 2024 00:00:28 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3F933A1381 for ; Thu, 5 Dec 2024 05:00:28 +0000 (UTC) X-FDA: 82859704242.11.7EBC022 Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by imf16.hostedemail.com (Postfix) with ESMTP id 84E1418000C for ; Thu, 5 Dec 2024 05:00:10 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=c+oybVhM; spf=pass (imf16.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733374815; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AzsRhBq8BhSQFnCo4YskzWswq/XF5Fd+zdWe29F6F2s=; b=5cZRcDj/fnXD0K1AJUYqRhNiaN59jMbLUsfP0G2+ML90NQz4LOcBx1cZv3nSyGZmueEuWz cysd6Ajb5MU0SijWPBrpUM3Fp/La5o/HzwfevEm7C0BmKokNlr4FvHKkW/mQ8jARA5bM/d sYKVfqU/NYZmhujXPvp1tDZR8WGwdlc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=c+oybVhM; spf=pass (imf16.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.54 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733374815; a=rsa-sha256; cv=none; b=jCBeIB6cvW+ecFAyzotZs6C7qEIaAuzXIxlmM2otUX2Xjph3Lg97XNTS3STj3JAMB8W81l xpdJtQI1yc9Cn1Xv9zyiBulg7TmJqrK2Kvaz4lKaYQSM22HevvFSDzyfo+amhFdRlYgsro O7XWhVN4mgEmUIC6F+JYAnnYOZ7Wg2o= Received: by mail-ua1-f54.google.com with SMTP id a1e0cc1a2514c-85bbbf20538so111514241.3 for ; Wed, 04 Dec 2024 21:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733374825; x=1733979625; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AzsRhBq8BhSQFnCo4YskzWswq/XF5Fd+zdWe29F6F2s=; b=c+oybVhMj4sofOzbbVuob+W/UfyMzm5gIDgm4kx34nuywI+zGuaVB9dOqONZW4EL8o QTPwXJZzww4+wa2BgVJ/Q+kU+bWoJxQdfbFHHLdp5ofK5NH8gYNdyIb07/mj3XS9RW6M P3mfHct+gO6oTNAdyeiSJk6AnuIjQ/DfhpKBTfXUj5UggrUy+YdRYXR5Zb2swCJ8yve8 shqnIz4KPKtNcZvQ9uu4VYUi2ory9imcyuMKy1rTVUEqR+vwApKVVNQ8oomhdH/c10WX VG7SBwAq4Ov1pRTHkF+2CBymesYBqgty6oJhD/y2Vr82Rh1FWa/JgquQoNqkf/STnJ1Q 3h0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733374825; x=1733979625; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AzsRhBq8BhSQFnCo4YskzWswq/XF5Fd+zdWe29F6F2s=; b=ZaKfGK58otFpL8pWa8ubJB1/gRRZHavEHclAA1EIPxCO3K0LXlW+WVs7e+nQTTP4dp 7Gwb78zVg41mSN0EnmXMQGHtqldf92XTFsj94wkO/j1tcQuQJqRfhGLkaTsZd+ZViDMo 8qTPRu+dWFabHHRZOltEt0JNA4p4UeBNwASxsqBiVKTXwS6ybYVl+bW0KmivvkKoWdP5 gUGPxqZBmd9rYjWV4nWu+iCauO7E2DcpmKCwYQtX77rwUQgjmjd2Tnt22l3IpDbucL6C KxdQnbx24TjAyMrJKqfuIfSdM9XmD57V2O6yTiI5HaNtwnH/ST8MEzDlX5deTrjy1adD 973g== X-Forwarded-Encrypted: i=1; AJvYcCUaf+YzTurPL3s1l4aso74AemHgu+znFo6vec1YmyAXxvKOBauE5VkLjzYahi7EghEGeebX6L0QeA==@kvack.org X-Gm-Message-State: AOJu0YxprxwfwijG3SxR/IrgPOpOsN+CKJWQGARLVq5jC/uc3YoHT574 sSf3aljN5xQm8DKPT824yOCP/v4+9keqhdRF6M5CWHFUs0Go9pg58v+oCUeoXyKVQaRPXs6IyhK F4nZcGcRoj9KwutoNjQExcODFi+E= X-Gm-Gg: ASbGncsM3alXMth/yBkZtKjaRkSgo4cOquMCnfvJLDPCMP6RWGPkNIx4hM3Qsfp60XW U0urgivrZ7+XNZMh24cnlbmFTGiVajWWTpfqIT1hmcNZ/44eK8RXwyKlxPQAQ/xdu8g== X-Google-Smtp-Source: AGHT+IGf5+oZBFNrebFdiC214ro7YEnLr3lIwDKyEMoTQMyP8/SQ0CiENoy9aJg5qpCiMPkTRcp0bSXlqrMZ7XD2dTQ= X-Received: by 2002:a05:6102:50ab:b0:4af:ba51:a25f with SMTP id ada2fe7eead31-4afba51a30amr1826292137.20.1733374825081; Wed, 04 Dec 2024 21:00:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Thu, 5 Dec 2024 18:00:14 +1300 Message-ID: Subject: Re: [PATCH] mm: migrate: drop redundant anonymous statistics for file folios migration To: Baolin Wang Cc: akpm@linux-foundation.org, david@redhat.com, ying.huang@linux.alibaba.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Stat-Signature: y6e3d6gipc6hwiz73uaiqxbri3e7fazm X-Rspamd-Queue-Id: 84E1418000C X-Rspam-User: X-HE-Tag: 1733374810-369012 X-HE-Meta: U2FsdGVkX18+2cg32RFb8p7Q+p8B4yS82Dd36yM3GhkwhB9LJKdkcxbZqK7NXL8//pajgknEZViKG5Skz4hFfUwo5SEWpFuiTohdKBHYvnRo3mp4UsEivZKvTpbLKs9PaF1cmDGFNEj6cWsax6jEtofq+HWB36JBMLqTEyM3EIrHyYtTsa90DnXbjdxW1/ETTW3mzIwYAw6xCSIoKq3C/PFYAQRNulA+0u95rVnYG/fIEEtLAzz2b9d4U29D16cYVYgKIEvoPWXWDFxDS7vJjvkCEIrnRb4L48SYWFDUFmgTREVNrX1BIY0RhfMKVU7aFI/Mik2qpiGE2YEPbJioTurMkFMcC++QlkqI8GuQUUB/lcOGftRJQpK6IfJdNDnXSC+IF8ypnPAWrnQPfWouPAoZ/aSQQnHJGbFuA5WYex9rztyhNJlCrXA9zvJ8dKR1SnTkRVbGzx2CzXw1Wc3HYqZ6Y+JkMgypktDwTSK9spg7xD6STgBkH7N6EREefHMkczXo74/sJc29INbx98uurpfHmCbjxtGwgL3SvZPqS795bI8dLN+2rOiEOYc9A55Xs2R0O/3oZJvKLMMN9x9t92JH7I+j2ajYmA6klUj9AEJpw5bklLL1CFowGliitnfYcunVrdLXxZCEvadMuTo/u7cQLHn1wI6Bzhmq11Gu57HbYACV+P0kxQkWRbypqZ961mjTSnFIC/Wz7apqVzHjvW2plXAcbbmFEToN0VAWc5sS++PpRoDxbGCB2Y2hMLP+27boUWFfjIGhdZZpS6M+v7ASl1+qr1mYxNXyto/TzuGoWWhTwwR+LP4XytA3tSFepaelK4PsJu2IJFGz5+F/i74/N5VrGXxisnqIWCJktmElTeinHyRzz5v6v6mrbmyRS+egTwoOIEWiA8F6OC7WVd3K3gWTF96UOKAaOUeKESLm4vfS32H/xUVZyu7FdeaX1lv2MEnFkrLk0bdwCzs SXXHWLM3 dXirNX8bFZd9cjakHDQp++gky9WQG74zFFEdnk4pFabTSa7rpaiA3zF2EeZs0lkmVy5FntnfHSHEzy0Y51AYQWHU0b00veNLl+hIvW9sjzZHnyYOFbD0ilO6UP4mGj1uEzuli7LrPcXBXgUMlwk40ae8xya4/96qWNul7lReWMsjCTWBWZDYV5lFYwJmJv9adgxhO3UdgrmKqeyCO4gdapJavGkQdp2AFC2Jm7lCTb7u/yE5iH5oPxQN4wQdKiuHUhXbJhNloTR5eT8iJBCae3jkBqvAmY/SvBXd5oEvKRWQOM2Ug8txkw2NdI0wRYoXG2P9CQz2GOxaAalWIWV4zyAzduA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 5, 2024 at 4:54=E2=80=AFPM Baolin Wang wrote: > > Commit 5d65c8d758f2 ("mm: count the number of anonymous THPs per size") a= dds > a new anonymous counter per THP size, however, when folio_mapping() is no= t NULL > during folio migration, it means this is not an anonymous folio, so remov= e the > redundant anonymous statistics in this case. why? Are you sure anon folios won't call __folio_migrate_mapping()? folio->mapping is PAGE_MAPPING_ANON for anon folios. static __always_inline bool folio_test_anon(const struct folio *folio) { return ((unsigned long)folio->mapping & PAGE_MAPPING_ANON) !=3D 0; } > > Signed-off-by: Baolin Wang > --- > mm/migrate.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index e9e00d1d1d19..d7fdfdd23fd0 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -523,8 +523,6 @@ static int __folio_migrate_mapping(struct address_spa= ce *mapping, > */ > newfolio->index =3D folio->index; > newfolio->mapping =3D folio->mapping; > - if (folio_test_anon(folio) && folio_test_large(folio)) > - mod_mthp_stat(folio_order(folio), MTHP_STAT_NR_ANON, 1); > folio_ref_add(newfolio, nr); /* add cache reference */ > if (folio_test_swapbacked(folio)) { > __folio_set_swapbacked(newfolio); > -- > 2.39.3 > Thanks Barry