From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85BC4C25B75 for ; Mon, 3 Jun 2024 04:14:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2FB16B00A1; Mon, 3 Jun 2024 00:14:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CDCC66B00A3; Mon, 3 Jun 2024 00:14:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7DF96B00A4; Mon, 3 Jun 2024 00:14:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 95E826B00A1 for ; Mon, 3 Jun 2024 00:14:54 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1A1721C113C for ; Mon, 3 Jun 2024 04:14:54 +0000 (UTC) X-FDA: 82188261708.23.B892AD9 Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by imf11.hostedemail.com (Postfix) with ESMTP id 58A304000B for ; Mon, 3 Jun 2024 04:14:52 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NwPCwZZB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717388092; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=37IZQZABDOiNZeyUDyoueBUnQROigeKCbWesRBDqED0=; b=s1/f5Y8INRVUhoVR3rAlCNHTCcQ/RjCvDDfPYz+2gBs40o4J/f40uDBVd9HofilO+O18kO wrACFB2cv+6jlI7Gv/5HK4dseT/rkmJUyRHFrCZSZvNaPiGC5NsaR3mZwCMYID6g5S25qO 1b7S4ruz76v1WYUTzfUr13WNWJOftF4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NwPCwZZB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717388092; a=rsa-sha256; cv=none; b=1BV0xEluVWDnoxL+2v6zQRF2xvnMFhcIhl6IsZDmo0N8uA3kp+blStMhgTV47qt0VKTaZ7 /spAFL5qdZGrzL8a7UW6aeFdiNXKIIItSY+SbJgjBftiHq204Fb+vSdkIpCLq6BvzeSZBT XYGyMc2RX589BUgHQhnNEtGVWA/fwQU= Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-80acd145929so1188702241.3 for ; Sun, 02 Jun 2024 21:14:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717388091; x=1717992891; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=37IZQZABDOiNZeyUDyoueBUnQROigeKCbWesRBDqED0=; b=NwPCwZZB7lgTtVvDkXXEYdyWPYZchgiVgdH1tHK4nKBUlH6FX8fy7BI7RxDfruKXrD zWubWFxk1n4AELb6DFxXDfp6zKej43GlMVtVhIq2X3wyylEoyfbnTxkPC8cR3gPd03Y8 z95/eIwl2X9abbIstg3JBsMPar2SYWxngmpOynn4DDb+i26hAx/+miSPYRymaiZvu2Zk 4dW6Yy3d7QCzLnIhexe1qzbnu3OzsG7akkdx2FSC3JMd6InMgDFQhYO2hGzISxpixCi0 0QO/q+ULelTHtuC3rSQ3/ldOndOsJhS55eSdwk7SapjSRTcSdi0Bim3JP9uswqZzF+Xu U/OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717388091; x=1717992891; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=37IZQZABDOiNZeyUDyoueBUnQROigeKCbWesRBDqED0=; b=IWpyN18KRujVOhO3OCvZUghJ7I9GirDoOwtIbAcZxkkjGPa7BKr97N4Pz21uX89W1H 9tDNhW5j0FOpdmTeiYElT7crgihoOy4JuoRhgdN9JbgQjawh6ET7Vlv+TSJxXb8GlJ8n Ok6UUEZGBVxf7svZNrWh2PY4P8lV7KAnheoK+p1vRnMk+OilMSGjJUFPi4en2+em8Y9i Xc1Qm6CWgOcPhEqb6+AIxmrtBWqqqG4AOSr9CVXZQsdOKNyryTEPu4rli61rQq7wV184 vnJgfsayK3AeOBX1eIilTgRi3v9YplpKk28dtl2vF8aji6K1I21duPo/6iiRrLYj7+NL CpMQ== X-Forwarded-Encrypted: i=1; AJvYcCW/hgbnvTVnd4g038L0s+0ySQN1sIGAmOItxiT3/Pfb5QsBVdSATLW54DvbPnWzJc3m931240XVRadkkHHI743/p+Q= X-Gm-Message-State: AOJu0Yx+qPOtByDkroQd3jpQxteHiiybiB10qVOPk8aFp2WNe8eOldK3 2xUY1koiCuYU/bVlgwLFtaU8OmMgAhrBz5xNKlMLKYb2kgfrEacynvXYCKprxa6yqa0rCavBfSt 5NmL26bsnBl6xpsOV0Ihwcf0kOgc= X-Google-Smtp-Source: AGHT+IHLgm5hHl+4guZ+jWuNcHq4/8HeEKFBWSVNOcnSXqXSHICiDXYna8aTf1gin+ISl2r1exDJw1ciwMTphRosYh0= X-Received: by 2002:a05:6102:354a:b0:48b:932a:9603 with SMTP id ada2fe7eead31-48bc207ea8fmr7951260137.1.1717388091342; Sun, 02 Jun 2024 21:14:51 -0700 (PDT) MIME-Version: 1.0 References: <20240603033118.76457-1-ioworker0@gmail.com> In-Reply-To: <20240603033118.76457-1-ioworker0@gmail.com> From: Barry Song <21cnbao@gmail.com> Date: Mon, 3 Jun 2024 16:14:39 +1200 Message-ID: Subject: Re: [PATCH 1/1] mm/mlock: implement folio_mlock_step() using folio_pte_batch() To: Lance Yang Cc: akpm@linux-foundation.org, ryan.roberts@arm.com, david@redhat.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, fengwei.yin@intel.com, ying.huang@intel.com, libang.li@antgroup.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 58A304000B X-Stat-Signature: hdszgraidq5tbj15d1aaxj34g4trrrgp X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1717388092-870120 X-HE-Meta: U2FsdGVkX1+hKsLj7v26IWDLJfCAppM5XXK62c//Fndxgo3j7yatM23y6/m89aj8b+c23MC+rqh9srl5jlck1nktGqp5NQLFRa61gFThw9+H3DQj5KuEIhofc9Py7jyI6WSmwcKX1LlP9uN8wsOJgxg3MiKYGSNj4zvh/yFtNUvoeNscwH70nl/aTF6lIqLLbgqv5lQXTkIK0/SU0AXNMUk++0O+6gK9RybffDOIVoOvOgKZ+cnUw5LZrhPaLE0CLdWh5qneNtdK3up8labfuMwrzCxz+fYrhaaYv19iaTS5VmRDm+i3uKNGUSUlDcwkiOwlEYDid7kqv6Fn5jz8m7BlHIQUO+/z51yAPQNX0Tt33oC234w9RUrbDhMv+erCH+r+3pIKDBS/M0pCIosG10Ai9sw/OPINCMHUT4fD82voKlVm5wobHJKkyTz7a8mKyHFrUPgiqa9koffrbZZahwn1ZHlmK+jhR7kxmPJCTg6bHkAgKXqxIWUaWvAMsbovaaLeMSid6UrgQv66cClPWNfhFgk0YVWrlVyFcqo48X79DabEZ07G/VFtin3/9TEn1uVchOqDMHZNUFm4wlJEpkgnaaz1usG4bEZstYshQbK3nZrT4Vv2QnyGXx0vzUVhuXHN2nNZ242cs3U8jE+Not4/CGKY+ufKurWyCUYWY6hikYn/ewzcKq9lz64WejtqvSbVb/npCTjXHv6iP6o4ZM5GfvCUdv42Qt6rmKbKxunDHtzej1c6zHDEPgXrStE+MlsSRdzDe84bAzcrqR5pJsSLri22lOc+0OOdRVDytN2DJol6zfA38ZashuvetZfHuz7KkhF+8H+vJSUHib0KWVzBWbgHv8I8VhaBFAbDszS35vvCmEBx0dDhHgmz7+TNQ8QExgBPKtyv70jmvS82b68x29N0R9CqPmLPie1Ybkn+VW3hrtwguZrLad0VYOppdDDf9Ip0cu0gpEYlJFR nMkk3JWY 5IMLDC2BtQ530EU+lN8e4teUqEvyuaN8OsHzxoKrpkOwh7pnQJmYawfe4IWu3qMvjJ/tPCbgv09ssIe4fExoZzCHlJsJoj6+wMCaL9CslYzJFfD8mLIl/CpU8L7SF6IAaQl0SptGXIkOJMxxWUynqU4/HMOgLFp8FZWl5cblQO/PWgxPzMxBn4eSzjxu80L8J5kcuG1AJ0zUw9lBzZoc7c1YhmvxYR/haBRIMqmIqpFRVzZZtIVM+Iv+/gz9bAn1oHOcP63Kqc/ztqbieoqvu6uMq13xzQG4piKT4HOXcfIvdHOn6zAmZE5aeqglzHlU24FeCQqOu5i2EewIxGbH2XIFpdax6SjiydLibrRg9TCBaso+hEwwJ+nErvhb5PqrDanQLO38fAIBT6y3o4nSc7xeBN/cWV3rOKY3RR0K2282LNKFV9cVScV6sc6oUWVeEdS14YRkhozvDgy4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jun 3, 2024 at 3:31=E2=80=AFPM Lance Yang wro= te: > > Let's make folio_mlock_step() simply a wrapper around folio_pte_batch(), > which will greatly reduce the cost of ptep_get() when scanning a range of > contptes. > > Signed-off-by: Lance Yang > --- > mm/mlock.c | 23 ++++++----------------- > 1 file changed, 6 insertions(+), 17 deletions(-) > > diff --git a/mm/mlock.c b/mm/mlock.c > index 30b51cdea89d..1ae6232d38cf 100644 > --- a/mm/mlock.c > +++ b/mm/mlock.c > @@ -307,26 +307,15 @@ void munlock_folio(struct folio *folio) > static inline unsigned int folio_mlock_step(struct folio *folio, > pte_t *pte, unsigned long addr, unsigned long end) > { > - unsigned int count, i, nr =3D folio_nr_pages(folio); > - unsigned long pfn =3D folio_pfn(folio); > - pte_t ptent =3D ptep_get(pte); > - > - if (!folio_test_large(folio)) > + if (likely(!folio_test_large(folio))) > return 1; > > - count =3D pfn + nr - pte_pfn(ptent); > - count =3D min_t(unsigned int, count, (end - addr) >> PAGE_SHIFT); > - > - for (i =3D 0; i < count; i++, pte++) { > - pte_t entry =3D ptep_get(pte); > - > - if (!pte_present(entry)) > - break; > - if (pte_pfn(entry) - pfn >=3D nr) > - break; > - } > + const fpb_t fpb_flags =3D FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRT= Y; > + int max_nr =3D (end - addr) / PAGE_SIZE; > + pte_t ptent =3D ptep_get(pte); > > - return i; > + return folio_pte_batch(folio, addr, pte, ptent, max_nr, fpb_flags= , NULL, > + NULL, NULL); > } what about a minimum change as below? index 30b51cdea89d..e8b98f84fbd2 100644 --- a/mm/mlock.c +++ b/mm/mlock.c @@ -307,26 +307,15 @@ void munlock_folio(struct folio *folio) static inline unsigned int folio_mlock_step(struct folio *folio, pte_t *pte, unsigned long addr, unsigned long end) { - unsigned int count, i, nr =3D folio_nr_pages(folio); - unsigned long pfn =3D folio_pfn(folio); + unsigned int count =3D (end - addr) >> PAGE_SHIFT; pte_t ptent =3D ptep_get(pte); + const fpb_t fpb_flags =3D FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; if (!folio_test_large(folio)) return 1; - count =3D pfn + nr - pte_pfn(ptent); - count =3D min_t(unsigned int, count, (end - addr) >> PAGE_SHIFT); - - for (i =3D 0; i < count; i++, pte++) { - pte_t entry =3D ptep_get(pte); - - if (!pte_present(entry)) - break; - if (pte_pfn(entry) - pfn >=3D nr) - break; - } - - return i; + return folio_pte_batch(folio, addr, pte, ptent, count, fpb_flags, N= ULL, + NULL, NULL); } > > static inline bool allow_mlock_munlock(struct folio *folio, > -- > 2.33.1 >