From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1374C3DA6E for ; Wed, 3 Jan 2024 09:16:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F9498D0056; Wed, 3 Jan 2024 04:16:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A7DC8D0053; Wed, 3 Jan 2024 04:16:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54A888D0056; Wed, 3 Jan 2024 04:16:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 407E68D0053 for ; Wed, 3 Jan 2024 04:16:18 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 15F1AC084E for ; Wed, 3 Jan 2024 09:16:18 +0000 (UTC) X-FDA: 81637443636.14.A879626 Received: from mail-vs1-f42.google.com (mail-vs1-f42.google.com [209.85.217.42]) by imf09.hostedemail.com (Postfix) with ESMTP id 49CA014001F for ; Wed, 3 Jan 2024 09:16:16 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dFbrEmKM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.42 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704273376; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=t82DvQRTG298BUBLOAer4xENGrEI3zmV+/IMzTQEgcs=; b=rmZCwvplJPFyQpNKIIbWDfIGa8svWkgUfrzSEbMAJUgGOvqI5VnfwBjvp4xQQpfN3JCKhv KAw3PVonMzPUFMcRrK8fHACCH1MjLSj1eFDebfLtJbEu1K9wSgILZlTkiFUDiNwx5p/8Zf /mSMUUd8FB/LqzcK6Kb+WQ0BIrnhto8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=dFbrEmKM; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.42 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704273376; a=rsa-sha256; cv=none; b=U1NQayAMVPWV+vHmTGjH2sszqft3DOjG84EAHVf7FLPW2rC42DDESVdvfYWZa8cG1baRKq 0Pyjsgv417gFh8Gg0ORkc6iIeZ4W+aGwwP0SAD4EkKlv7TKlRrppkcOZLizen/OlLmx03U qD09H5lR8dUDyBR34+dXZwheMHjGq04= Received: by mail-vs1-f42.google.com with SMTP id ada2fe7eead31-466fe71b2c2so759928137.3 for ; Wed, 03 Jan 2024 01:16:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704273375; x=1704878175; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=t82DvQRTG298BUBLOAer4xENGrEI3zmV+/IMzTQEgcs=; b=dFbrEmKM+b1CbSQnbpRU9K1w/ipagtFShIbAznYgoxs2LhX3NinDr+03tIIjebixPg LhzEAD1wB+VGxkAv4d/X+EZQbkkcW9owoJQM88M//yFVI78NPa4pPtQ8FE62jOxAc6Ml duoe6EG5myNL+NpznSTIScITLidfcrv8S6ltIrSIw/pTK9DAf3phKSG/+J8l2Qoh9PR+ W02Jpw1XyuUkb74H6bgXyCG0P8OWfQmtDbo644ref/q9dGfTQHI8olFLvfavwpSw5Qw2 mwhsUUiWUmdao89gBzrbef0/Pp7XXl8n+zcq5G5UCz774OWEim+odS3ta1jY6IyLRRq5 kz2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704273375; x=1704878175; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t82DvQRTG298BUBLOAer4xENGrEI3zmV+/IMzTQEgcs=; b=C2ZMagUxGOsuDvozjACTjnsXVXUNn6WcUjdDh4bC+yO5khjvOj7YRstM/oBwtf6sJd SqznHQckM8bDQkWvyk4HHz4LZGg2h89j3gaUTxCsEtyzSHKrD3k4hPYe+9OrySfgs2XI kr3gYnI2mcQomSK5N5l4a/tHyo9vp4NcSfyX32Pz1+n8EP4P8Y5d9yZSBzoCOvZdyF6V gUEClHbSkvQsAuYdZr0RFNNjA5Sf9xbs9kcV+5dzFinNQdZFvmiu975O37namS1TQoid udt5rMd0+zWQuQo+89BVBJLx2OcpTibiorttelZ1EtTEMWiwNNJ5ip4+IdYZwKzjzjy8 zAIg== X-Gm-Message-State: AOJu0Yz4F6eObsP0TxXkZ72ELVAdI4V2KfU9ty5BSpR1IwBTS3OrcqCU 1147efzjIZvmNHK1msJ+ARleoBJjIct8E6XZDC8= X-Google-Smtp-Source: AGHT+IHJ2UO4pzIeejnYr+cSzh5/Fb5rhQZC0jUOQNubsrz2bkA0F4sygUNjJgzC6lVHboLIpcMP+wQ4HKcl2x4bhJY= X-Received: by 2002:a05:6102:dd4:b0:467:8ac7:5822 with SMTP id e20-20020a0561020dd400b004678ac75822mr1511710vst.35.1704273375361; Wed, 03 Jan 2024 01:16:15 -0800 (PST) MIME-Version: 1.0 References: <20240102153828.1002295-1-ryan.roberts@arm.com> <29007216-8A9B-4CA2-8A87-EB33E338CBA7@oracle.com> <84b43094-9b16-40a5-94e8-6dd4e859a01f@arm.com> In-Reply-To: <84b43094-9b16-40a5-94e8-6dd4e859a01f@arm.com> From: Barry Song <21cnbao@gmail.com> Date: Wed, 3 Jan 2024 22:16:03 +1300 Message-ID: Subject: Re: [RFC PATCH v1] tools/mm: Add thpmaps script to dump THP usage info To: Ryan Roberts Cc: William Kucharski , Andrew Morton , Zenghui Yu , Matthew Wilcox , David Hildenbrand , Kefeng Wang , John Hubbard , Zi Yan , Alistair Popple , "linux-mm@kvack.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 49CA014001F X-Stat-Signature: gx7uqyd5a9unb84f8s6yi1qdda4feemq X-HE-Tag: 1704273376-977922 X-HE-Meta: U2FsdGVkX187fLGErPZAX6RLxetdMREFr+QzcdtMReYdAtbv+bHzW8cncfi+RHUBDfJpKUPrYU5XnApOney2eVBW4Vgx4IGB/PEsyDjr1HroEEEfUSkbFYg9aoB6eaeNRXV5jZIIxfRbrA/wwc0QrENkgQolQuLfrdST+Xtqsc8ZEMCVL3MuxrOwsclevj0LwtCs1dDOi7BzEfyECOkEvNZZK73booyKrR6NNdEyCIZMheQbg/AlJV1U9fm24B09X2fRcTZq5FqXaS1oXTYM5HAjUdnwV/bFnRrDHoUED90xAqc1XemEtYlyDCRX5sRGmSyTmbdPZRhklLOZL/5sMHqWP11Dv9l88EaIvtmF41gOSY15+vdMMrC1X0zvLNKS9uZ7c/B7l6aPzhj7MSPJL7n3q90iKyZ+U5BCYP5A6lO9YX2NYOhsc7qIgcsnm72fn7SF0AHMA8ArKIA9zGCPGyuwHRlM3lgi9iaMta2UfkcGwRqPClvvkdqHUqUX2XWkj/9wqyScVf3J/EohiWayYhgMrIIocE4dgjBprDQYz+54R3bY2KOv5dAGR0vN/darhaIeSooJi6slKUhwK38318wDDFkV3lcCZEm+eSLjw+MQuj2qJcHqG3i/knnTXGfXu51hugToxoyhl5PE25N5uOK0SOTmP8kFR5YYkt6U71Z1wJloTrMBkEPgz32SHZwNPVTUKIrqf1QU5FEgmVzRYfzhkCrjbniLx+ojDdSB8kyJN4vlulenwS5+G8JIKezA/XFCdwyxtDR4yuVQGqcPj/HNj74GNAvQ+wvv65WkQQpXeozNhTHF7tIgA+g3AlLAnSCBVHiXcdvnP60kTqmEcwIv20u4AuyDWAzwNulegIdhAtzOaSDjWVCOQ1WTAt7qbxKZauH9fMg3er1I4CiYmIoF2NiOIuKCCZ5ZKo1SuhNQ1PKHGTFqvj1itwr3beYa+OGZoV3fvFzhV75B7lz 7dTog7nH 4U65L27qHVdupQKLu39yFjC43VCOnI09lTVSAaQMOPMFhT/20cJ8bvDLgYplquDuHdK93SSg2MF2GPsx1GnPm9d0GO9yp7q0QgWqPb1hX5qXACerODiwagV6NIYROzHJahZSwbJyFRXoH/Kr2GwXf7K4qd68KxNeWpvSqFFbz0y01w9sdxe0i+SabISuefT4zIPfz6OnVE6thfW1VOIVUJ+GgEJ+FxZDoZz9ST299nsY7sBUgty27OquwIlSATxuEeHnBtGzxOS4iyTJHVEkBL6EHfP/+4/SCnuVJOGS3iEZ5rkj1PN9xzo1QOYpvLEdvdBZigDxL13cMLnq5p3du5CKlcDjgDufu3ospiZDB0zeAZ3F0755UUToRFy924mnASGxbEbn6pmargwExlPpHsgywmp3C5Nq4Bdn2WST9fxsWc86YAYiVPx2Abkc+smVW1V78vz4RqmhqphyObx0WqUG/Wl5ymchECOxBdBzZe2ZalcjR5kcRDc1qZ6nbcSZI7HwZODbmlYRhomz+dkgAyCh29DMFAWwrg1jD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jan 3, 2024 at 9:25=E2=80=AFPM Ryan Roberts = wrote: > > On 03/01/2024 08:07, William Kucharski wrote: > > > >> On Jan 2, 2024, at 23:44, Barry Song <21cnbao@gmail.com> wrote: > >> > >> Hi Ryan, > >> > >> I ran a couple of test cases with different parameters, it seems to > >> work correctly. > >> just i don't understand the below, what is the meaning of 000000ce at > >> the beginning of > >> each line? > > > > It's the pid; 0xce is the specified pid, 206. > > Yes indeed. I added the pid to the front for the case where you are using > --cgroup without --summary; in that case, each vma will be printed for ea= ch pid > in the cgroup and it seemed sensible to be able to see which pid each vma > belonged to. I don't understand why we have to add the pid before each line as this tool already has pid in the parameter :-) this seems like duplicated informatio= n to me. but it doesn't matter too much as this tool is really nice though it= is not so easy to deploy on Android. Please feel free to add, Tested-by: Barry Song > > > > > Perhaps the pid should be printed in decimal? > > I thought about printing in decimal, but every other value in the vma is = in hex > without a leading "0x" (I'm trying to follow the smaps convention). So I = thought > it could be more confusing in decimal. > > I'm happy to change it to decimal if that's the preference though? Althou= gh I'd > like to continue to present it in a fixed width field, padded with 0s on = the > left so that everything lines up. > > > > > -- William Kucharski > > > >> /thpmaps --pid 206 --cont 64K > >> 000000ce 0000aaaadbb20000-0000aaaadbb21000 r-xp 00000000 fe:00 > >> 00426969 /root/a.out > >> 000000ce 0000aaaadbb3f000-0000aaaadbb40000 r--p 0000f000 fe:00 > >> 00426969 /root/a.out > >> 000000ce 0000aaaadbb40000-0000aaaadbb41000 rw-p 00010000 fe:00 > >> 00426969 /root/a.out > >> 000000ce 0000ffff702c0000-0000ffffb02c0000 rw-p 00000000 00:00 0000000= 0 > >> anon-thp-aligned-64kB: 473920 kB (100%) > >> anon-cont-aligned-64kB: 473920 kB (100%) > >> 000000ce 0000ffffb02c0000-0000ffffb044c000 r-xp 00000000 fe:00 > >> 00395429 /usr/lib/aarch64-linux-gnu/libc.so.6 > >> 000000ce 0000ffffb044c000-0000ffffb045d000 ---p 0018c000 fe:00 > >> 00395429 /usr/lib/aarch64-linux-gnu/libc.so.6 > >> 000000ce 0000ffffb045d000-0000ffffb0460000 r--p 0018d000 fe:00 > >> 00395429 /usr/lib/aarch64-linux-gnu/libc.so.6 > >> 000000ce 0000ffffb0460000-0000ffffb0462000 rw-p 00190000 fe:00 > >> 00395429 /usr/lib/aarch64-linux-gnu/libc.so.6 > >> 000000ce 0000ffffb0462000-0000ffffb046f000 rw-p 00000000 00:00 0000000= 0 > >> 000000ce 0000ffffb0477000-0000ffffb049d000 r-xp 00000000 fe:00 > >> 00393893 /usr/lib/aarch64-linux-gnu/ld-linux-aarch64.so.1 > >> 000000ce 0000ffffb04b0000-0000ffffb04b2000 rw-p 00000000 00:00 0000000= 0 > >> 000000ce 0000ffffb04b2000-0000ffffb04b4000 r--p 00000000 00:00 0000000= 0 [vvar] > >> 000000ce 0000ffffb04b4000-0000ffffb04b5000 r-xp 00000000 00:00 0000000= 0 [vdso] > >> 000000ce 0000ffffb04b5000-0000ffffb04b7000 r--p 0002e000 fe:00 > >> 00393893 /usr/lib/aarch64-linux-gnu/ld-linux-aarch64.so.1 > >> 000000ce 0000ffffb04b7000-0000ffffb04b9000 rw-p 00030000 fe:00 > >> 00393893 /usr/lib/aarch64-linux-gnu/ld-linux-aarch64.so.1 > >> 000000ce 0000ffffdaba4000-0000ffffdabc5000 rw-p 00000000 00:00 0000000= 0 [stack] > > Thanks Barry