From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54AD9C00A94 for ; Fri, 12 Apr 2024 13:16:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E02FA6B008A; Fri, 12 Apr 2024 09:16:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB34C6B008C; Fri, 12 Apr 2024 09:16:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C7ADD6B0092; Fri, 12 Apr 2024 09:16:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A7AD36B008A for ; Fri, 12 Apr 2024 09:16:43 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2B0CFA1706 for ; Fri, 12 Apr 2024 13:16:43 +0000 (UTC) X-FDA: 82000929486.24.91D8875 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) by imf19.hostedemail.com (Postfix) with ESMTP id 9486D1A001B for ; Fri, 12 Apr 2024 13:16:40 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GR3E7xb2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.167.182 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712927800; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RaYxYtWvNMFaNldP/aYNqxGnYuMXv6GVR7VYUwwylGk=; b=L2PeqToxBSXZp1kVV786rFWH5N7a40tOFOIrBPLNoBMB+1B8BOeO9GJbYS4s4+3NpvSKAw XNMGJKBVKaE6KExZUsEBVww29SEIc6MeufvHJWx6fNuKAYeWWXW+Yp1sFerfICaSK4W0tp DPrI21TLWUfqDz2ud8ASZrAaZyUPWYw= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GR3E7xb2; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf19.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.167.182 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712927800; a=rsa-sha256; cv=none; b=tNGoIg83PoukFXUgMcnzEFUuiIULB2+Af12BtQQeN+kV6Q5VzBD7yOXRKeZWKE1xA0sW8P 4uZoNCEFrax4FDa/+xqiI9ivpuTAX8SBL+81930upGHu9Mo15ERCK3EBvjrMrUXOxPwebC ySB1GiQg1SaJUBuENjVTZq9NTkbPEY8= Received: by mail-oi1-f182.google.com with SMTP id 5614622812f47-3c61135ff5fso177721b6e.3 for ; Fri, 12 Apr 2024 06:16:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712927799; x=1713532599; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=RaYxYtWvNMFaNldP/aYNqxGnYuMXv6GVR7VYUwwylGk=; b=GR3E7xb2QJKnHn/WshavCkOBJnsXEnWl5UvFW64+2dGZVPLyfCPnWwUSlkLxWE+lJQ o68Sa5IeIJVAZSI78ou+PIoipLVS6P4CtoZenyDAiFhHX3nP87eKl2E1AGA08pqXH8mt 60rhFjOgRtwBNrcZ5JAz0o3grPagCsmqP1j0qONSCuOw+WyB3gEIep+rY9THBtddsVAq rELyRhSLZF0vbgOVBkisyuo1qpS5rBFWsBpRFCjNItWoULj1CI6BipQESrKSkGYazht2 ruZdWOJ5IbahqM9EbgReJanutDPDnRRLxsrfTFYjCpJNDpDGzQtJpQHBKoDS2Puws/o7 jryg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712927799; x=1713532599; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RaYxYtWvNMFaNldP/aYNqxGnYuMXv6GVR7VYUwwylGk=; b=J/6PVN+I+p7tNkk+H4Csk0mQc/tNnaLdFfAXj8Y6rRsyir6e9A5LNWUza541Xlq12L 9mJwiWttLncl6kRx2pCN16jYwwN2rWfMC6LdsHfauNtSmj+AVbMkDglThsiGY4z/NAAu ZO7eONibhqa1sMcUI5CZSaJisapOpoywnAWYkyi1EmGHaQP098syTg5skj2FDCxo+u1K 2cwVmQi2I/DiBC/Dp0i1osqzzcZe8AH2hfIJYnICoK5U/V4zRhfdmGU0IBaCuWt/POUv yslsPad1ZfvjIsfmWpFGnAR8dRfOvuAEKOHFfOGMhMydCB5rdJUe43W7TV8qB7DDcOKY xPbA== X-Forwarded-Encrypted: i=1; AJvYcCWesY9DH/74kjy7gJi4VT5TzlN5A9UnsSRKTNAtOiGLIYug9XUeCktnA5JVCak9nJ922a5glFEAUGtN8Z+eXgj3ow8= X-Gm-Message-State: AOJu0YyL62SNzdEp3H7TKTVlbNuEBO9Q5i0NWci4JKGSSJ4Qf6547i3s vHY0RSY03GYn1CiFyQrquePun/k/wRS9osLcJIvq0Djzs+3ddUr+zOzluG+nFx7wpCDlXPDdtTK I6sUM5V5TN+zX60B5IQ5G9dcZQMw= X-Google-Smtp-Source: AGHT+IFDlRFnfXi1bBqNb6N3frPAReRPsPCLumbfedSGtSCvNR8lgoxsFYGeR/zhRMKi+xGAPf3L8PF+2wDDs+u6Joo= X-Received: by 2002:a54:4e82:0:b0:3c6:500:a14f with SMTP id c2-20020a544e82000000b003c60500a14fmr2595421oiy.5.1712927799490; Fri, 12 Apr 2024 06:16:39 -0700 (PDT) MIME-Version: 1.0 References: <20240412114858.407208-1-21cnbao@gmail.com> <20e36996-0c78-4b81-8e91-1035d5ce0652@redhat.com> In-Reply-To: <20e36996-0c78-4b81-8e91-1035d5ce0652@redhat.com> From: Barry Song <21cnbao@gmail.com> Date: Sat, 13 Apr 2024 01:16:28 +1200 Message-ID: Subject: Re: [PATCH v6 0/4] mm: add per-order mTHP alloc and swpout counters To: David Hildenbrand Cc: akpm@linux-foundation.org, linux-mm@kvack.org, cerasuolodomenico@gmail.com, chrisl@kernel.org, kasong@tencent.com, linux-kernel@vger.kernel.org, peterx@redhat.com, ryan.roberts@arm.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, yosryahmed@google.com, yuzhao@google.com, corbet@lwn.net Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: gxbsccfboxjw7c8j7pcyooug1caxjnoj X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 9486D1A001B X-HE-Tag: 1712927800-320031 X-HE-Meta: U2FsdGVkX19YiYF3+YjNhjt3IklZif30Tdbzs2QQyhN0EfaLUunEH++bENPHKUnVS+C9BRsi00VJtbV9ZvMfjyQnuDETjP0nnzR3aG1QwEmz0v2eQLBqj1FwhJDZKSi0hkHkjtP0oNDJ5nmkbCX54I0J5gxC9UBB8wXp42cEWXdLsZ+bkt21PV3bVgGqDBHCaJ4YJINoEFyh+cEpwi0eKV2Ct0DhHxtmcEBY1bKR6mzhxw2+BmEhNXfP4siER6h2/BRgiYMe5hsXTPQ/ZePCDjHPCdF8VmFecCdjP/eJD04HkVqIiqoLpfWdT5z+nMr7++T+KJJCJ1i3XMoDB1MDn1npuqpAV581Sv5hc9XN6ivWLhg/yH+P038J83LplDhpgyMMY/JEeghk1MVMkPslT9fFPnhypkLsJSlazPukkBj044bkfYIXBV2cpHzXjjpcOe95PLeXZTp+6X4EFmSGBhYyd7U3r03DtmbQ7Zpv+837VyeX2HdzNtNfUKMwr59ImxEaDrc2HAGQKFY54VpuxMQXaMnc1pxUOVxVlezz67lXY2gMIefyaDSTrQjPOw34HLKMJ6PgsqcHMDqWLxK+WREPI85bYVqyNhFEBzLfhe6ZFczckzO3yanNEqfmN5Iv9VTHcot5hjlvHUfQAJJltcGo9ypbfYhPNIN3nYI+0bNMmWnMHGVmEevrChub8Lrot2tOIqMUw3xqKM1Uxxdt55hylqPG/TzkTcw8bDj+xXBc3RtSHK7TEsolbF8lFdZX7QccKHQXoEFS97EgGxzLJPCtBITxkAK8ay6R4UrlcsrPPvDtwXOD2DG8Tj9NmlmNfZKyW3+Anqbr1PFnSwiU9j/E0fQCFVVw6QitxOCVvaaXh3+4CqUzlL9JLXJ9i2Mrww4+gFIY6NpntPA03Urb9P1TevJFr8mUx5h98Kq6Pp9m8XnFh+VnvfB5NUgUAR7z0qB4UdZrZqjE3BgDtWG LXExvHyr rIPwvIO39vCmzEMMXN1qHjOSWkAehFNrNUc6e X-Bogosity: Ham, tests=bogofilter, spamicity=0.000480, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Apr 13, 2024 at 12:54=E2=80=AFAM David Hildenbrand wrote: > > On 12.04.24 13:48, Barry Song wrote: > > From: Barry Song > > > > The patchset introduces a framework to facilitate mTHP counters, starti= ng > > with the allocation and swap-out counters. Currently, only four new nod= es > > are appended to the stats directory for each mTHP size. > > > > /sys/kernel/mm/transparent_hugepage/hugepages-/stats > > anon_fault_alloc > > anon_fault_fallback > > anon_fault_fallback_charge > > anon_swpout > > anon_swpout_fallback > > > > These nodes are crucial for us to monitor the fragmentation levels of > > both the buddy system and the swap partitions. In the future, we may > > consider adding additional nodes for further insights. > > > > -v6: > > * collect reviewed-by tags for patch2/4, 3/4, 4/4, Ryan; > > * move back to static array by using MAX_PTRS_PER_PTE, Ryan; > > * move to for_each_possible_cpu to handle cpu hotplug, Ryan; > > * other minor cleanups according to Ryan; > > Please *really* not multiple versions of the same patch set on one a > single day. Ok. I will leave more time for you to review the older versions before movi= ng to a new version. For v5->v6, it is quite a straightforward re-spin though I can understand it might be a bit annoying if you got v6 while you were reading v5. > > -- > Cheers, > > David / dhildenb Thanks Barry