From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37AC4CD343F for ; Tue, 3 Sep 2024 21:37:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AB3718D01E3; Tue, 3 Sep 2024 17:37:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A621B8D016E; Tue, 3 Sep 2024 17:37:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DC7D8D01E3; Tue, 3 Sep 2024 17:37:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 6BB868D016E for ; Tue, 3 Sep 2024 17:37:00 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EA645140A97 for ; Tue, 3 Sep 2024 21:36:59 +0000 (UTC) X-FDA: 82524737358.28.2A37BE4 Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) by imf10.hostedemail.com (Postfix) with ESMTP id 3309DC000D for ; Tue, 3 Sep 2024 21:36:58 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iy1ucoLQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.50 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725399312; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7w1vlARH9zyVfcMgOZVvOysSX5U8D2E5LJv6StNTa30=; b=YGZI8EQ+IrILBuU5ydg1Ra6glU5Jnb/8U1p2+FyZ577gH5ZByLgt8WPX22Py6XTCFFD+r5 ZPHsopqtIN0iTLfo1fIQ5SHwC9OiAhJ6m4k8hgC4VG4Vslk5dzL0NWQ2R+Pj1xcQ/0D7cr 6XH78kPOTLeXNoTN0ZIxVDXqWbF7nl0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725399312; a=rsa-sha256; cv=none; b=MCMy+0MTcOTSMkceE29rPH+5yJ72GeGrNjghaFIVTwZjix1MBIO+QFnPTaFmnaVyBT6WIn blc8f9iH6XJFPdRTZXnYF+umqIUBux4k+SpLVoRhWq76Zpa10h12g0BwWvuZ9Q3V0/+xsw TjJvjvOQRlEJwF3ABPCLsayzxXUeXVw= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iy1ucoLQ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.50 as permitted sender) smtp.mailfrom=21cnbao@gmail.com Received: by mail-vs1-f50.google.com with SMTP id ada2fe7eead31-498dccd3ce5so64083137.1 for ; Tue, 03 Sep 2024 14:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725399417; x=1726004217; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7w1vlARH9zyVfcMgOZVvOysSX5U8D2E5LJv6StNTa30=; b=iy1ucoLQG5YbYmofJeOz2LsoKDflaQWkV1U+bqzm9Qdm71JNGjrPj0rmcGonWHYU17 cOkDJW6AV2YFrlqYUYP8YEgv6Yll2ZlCQGFjhNfSLuKMTcWOVZCR2Zu/NnL1a/vPKtnV VZKuRcz+09h02eP+Uz2CBBPehIOVzOorn31o+7f0UBtmQcW5TBiTEofOoR+SqvnMPvf9 s2eE+NEZwn8Sz3kHJKiA51pRp6ezeiy0chI77j13rSa3HipQizMYzqacw0JernbyFD4b Oe/FSe6QDRVYmT2msiBx+xb+RQ4G7j1eGsQlqog7maVj9ya4QSCtX4nOttYRttpA5/9P RYyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725399417; x=1726004217; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7w1vlARH9zyVfcMgOZVvOysSX5U8D2E5LJv6StNTa30=; b=V+wJMT/nW4lb3Navuy4gXIkKZ2WXY2MX4yDM0AEjTzxjb9fwh4EUebdXT8iwcrGt5y UJJ/gynz3KMlZXE/vCImrtFYO/Vqatbsvjf78OpeLeDELnvJNRgRV+e+1hjcY2lHVUAw syXmV3vxkbltFBJdrgmIxoPfkSUY0lDSAu5IQL1mfnHsxLgkZQkg8jKs8OGPdtMNu3L9 VdI8mSbujJKgfZmirqzgiRuOx7MCTM1HzGfLBFhWmdIIB3wFlG52MlvJup43aghxQBt0 l6vm2ByuBuM4A3XWmdH9AKp3rd0phpH7DcfTm5uUT8+IUj9s4WrhgMqFoOWsOY8AC4xb LQuQ== X-Forwarded-Encrypted: i=1; AJvYcCVTFvAcRXZ+n2s04+r+J6BRkGH3M+RGzebl0ABBCP/pD6yFev/vzDAvmTW6RhnfHPX+McMxSyWIOw==@kvack.org X-Gm-Message-State: AOJu0YwlUbzAP0YGkpHMafsaY5i/V7Wra72F7QzUjXVcp/BvDy2baD5g Dsm2OvBpCHp5ETQ+MQIM8eW3s1xWo+jPXAbiWPoLsQ+jvVKHOJugFKQXIbIRfttanr5PvNoGAyC iSp9ttSjqIqDaAfm3u2gj0p3ctgY= X-Google-Smtp-Source: AGHT+IE1VTcc+43kHJF1X7BqHxNRXquZPm4QywfmSshwZ7gDMTOu4VhzyjyjQxzUe+Y4ceY2tC2bRRg8bns6pHslWnc= X-Received: by 2002:a05:6102:942:b0:48f:c062:75ae with SMTP id ada2fe7eead31-49a5ae57710mr22471813137.8.1725399417234; Tue, 03 Sep 2024 14:36:57 -0700 (PDT) MIME-Version: 1.0 References: <20240821074541.516249-1-hanchuanhua@oppo.com> <20240821074541.516249-3-hanchuanhua@oppo.com> <20240903130757.f584c73f356c03617a2c8804@linux-foundation.org> In-Reply-To: <20240903130757.f584c73f356c03617a2c8804@linux-foundation.org> From: Barry Song <21cnbao@gmail.com> Date: Wed, 4 Sep 2024 09:36:45 +1200 Message-ID: Subject: Re: [PATCH v7 2/2] mm: support large folios swap-in for sync io devices To: Andrew Morton Cc: Yosry Ahmed , Kairui Song , hanchuanhua@oppo.com, Usama Arif , linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, hch@infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3309DC000D X-Stat-Signature: 48qxs6j884nuc68bddrs4wt6iicgcmn7 X-Rspam-User: X-HE-Tag: 1725399418-630271 X-HE-Meta: U2FsdGVkX1+/6eGhXAQogtjEzpy9eK+rLT0BuwzNjuub0hkQAj6/zDJWYeM7kXHRigYuDDpsIm2AJZfg+mrVd62QwasjJLGfprZoVDzgwqsYCXyYib3XPB8dh0tqM6Y1/MMTaE0iA4EyX6yVQ+El9HHYNUSGCwgX2MaRyZx5tzUriGQe4mZZUw46giZVjx+u9XrKjyEa93UR0gML/bxLvGX25OXO9uoWDktx6kpWuB+J93r/gTlh09hHCbWgets2c7cPuKzJUXEFB4/Qvsa25UD7nUVlemFWB5GoVK+2mKVY3wZebdDYUBHU0sNMtj0//UhIfytVlLBYljthLdlTtbfim9N9Y6kcc6/FURm/NlS1x5Qo2TbE7tpKsFbc3RQ9KfryYxT6Lij+f0PA99jFsgnLzHBZWSAB2/mfN1O9cK14YEQtQ+CCWPaBVhydm9+MciffnQ920RR10nMz+rMt/lELu5h1rARi9Q++mWCjZqDILOVp8a+Rr0tjkNYqtVTQII+RiPFewBdd987kZeaoAUv2NT1uC/A0mg8lBs9PJ3jxy2e9J1IoCFoFOgiYog//LrxP5ZUlIqI+8kswD906BPt2XDxekAHZxPmyJ5stReVUU3r1EariQuNLBzm+uBrdl9MR3d+EYSZDuLuAomxsENFcmRXf7qL6K1JggOl5s00jmF2ZNhN4LDoxge9NJ3bt5DKdvUEFd7aw3GJ2UU8JYQ2JfwBapdDqnfarnU3Ba4Y5+WW+xmUr5KpJt99lXAp1RyXKFOA0RdVkaVDQ+yHHMKoaXQ8bPXpWG07qGvQGoWudoWHa5E5R2TfvdLrUemYoXzDNSeRqjlrHWVkvGnpSANujAjGJVOorlDUhUqZPo9PxlpTRBpHXkaMjOPB7fWP2LihQ1lfquEtNj+YQ6rj05SXRjC/DyLSZEURkR+mN+z62JnmPXFN2c5pqeyux9RDuBHjwEvcU+tPC/WvlwhJ 7A1NkBDx u3bIQkwW7mw/7Q0pVxrxzye6syXWqB22rCNOUHr1WKUg5pwgH+mhwf3A0eDb16aL3AzH/0IxNPHRnqr22M1lADfGVpuQWovkpAojrnbaUXAk21ZrrYOg2v+97+wr5XDDTN0JzQv+4UAow5939cJxr7Z5crBPvh0Qx+tLh4tZpoxa8MffwTsY9cyLhTbnUUv4eR0XqeekCaUWi5/2CAy3QX+dewLIk2i1Gk27lZ0qpPx/dmWLzfmQYXXE6ihDerFtrvqKZNCuvgOlR2KINBlb8AjkxvT7jmPqU3b7dxilQ8+iorWiU8nutbssrIjSeBcsLP3DnjUUOWc0408IyvRA85hvMY7f3IuOGvaocBfTwh+b6l9COaDj4oGoqzN8Z2QrzmpK5OocYt6SifwWHadPFfex5N6PqJF6iJPAU5EGOhOetPqpegNeCUh9XQwBYiGCpfq9aatWrMj6qHABfEkaGnLhlgw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 4, 2024 at 8:08=E2=80=AFAM Andrew Morton wrote: > > On Tue, 3 Sep 2024 11:38:37 -0700 Yosry Ahmed wro= te: > > > > [ 39.157954] RBP: 0000000000000000 R08: 0000000000000000 R09: 00000= 00000000007 > > > [ 39.158288] R10: 0000000000000000 R11: 0000000000000246 R12: 00000= 00000000001 > > > [ 39.158634] R13: 0000000000002b9a R14: 0000000000000000 R15: 00007= ffd619d5518 > > > [ 39.158998] > > > [ 39.159226] ---[ end trace 0000000000000000 ]--- > > > > > > After reverting this or Usama's "mm: store zero pages to be swapped > > > out in a bitmap", the problem is gone. I think these two patches may > > > have some conflict that needs to be resolved. > > > > Yup. I saw this conflict coming and specifically asked for this > > warning to be added in Usama's patch to catch it [1]. It served its > > purpose. > > > > Usama's patch does not handle large folio swapin, because at the time > > it was written we didn't have it. We expected Usama's series to land > > sooner than this one, so the warning was to make sure that this series > > handles large folio swapin in the zeromap code. Now that they are both > > in mm-unstable, we are gonna have to figure this out. > > > > I suspect Usama's patches are closer to land so it's better to handle > > this in this series, but I will leave it up to Usama and > > Chuanhua/Barry to figure this out :) I believe handling this in swap-in might violate layer separation. `swap_read_folio()` should be a reliable API to call, regardless of whether `zeromap` is present. Therefore, the fix should likely be within `zeromap` but not this `swap-in`. I=E2=80=99ll take a look at this w= ith Usama :-) > > > > [1]https://lore.kernel.org/lkml/CAJD7tkbpXjg00CRSrXU_pbaHwEaW1b3k8AQgu8= y2PAh7EkTOug@mail.gmail.com/ > > Thanks. To unbreak -next I'll drop the two-patch series "mm: Ignite > large folios swap-in support" for now. > > btw, next time can we please call it "enable large folios swap-in > support"? "ignite" doesn't make much sense here. sure. > Thanks Barry