From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5915BD59F6D for ; Wed, 6 Nov 2024 19:54:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E8F996B008A; Wed, 6 Nov 2024 14:54:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E18606B00AC; Wed, 6 Nov 2024 14:54:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C92226B00AD; Wed, 6 Nov 2024 14:54:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 51D346B00AC for ; Wed, 6 Nov 2024 14:54:32 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id B391EAC788 for ; Wed, 6 Nov 2024 19:54:31 +0000 (UTC) X-FDA: 82756720452.09.715EA63 Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) by imf17.hostedemail.com (Postfix) with ESMTP id 09B2040021 for ; Wed, 6 Nov 2024 19:54:02 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FfSTMMpa; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.171 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730922702; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8djmRG6h4bc+SzaVCVnhZXth6QCnXFelnjwgthXVPkM=; b=o/wF93KUQwhzSR1m+wUUmIMgNWB9TdkXU+LzSxxdAgCaLI3NOaR/PXobmb15Eepe39zeha q6ACJIKfuLT7Wu2q/vcv/Fg3nQ6aPllj23sNWOLDl64ghhLh0hfN+2Q6P5orMKK8/gJQPG ttTjk+7uZw3MvFd1J+4pvhZVDX9dJhQ= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FfSTMMpa; spf=pass (imf17.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.171 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730922702; a=rsa-sha256; cv=none; b=dckzfMZc8nVsKTZaBhGxiAKONAOuRJ/2a4bFLUlnyK+SMZQgtYT1Hy/TKkNLlisSgZyHmQ V8DtS4ILc3J2Apha4Jawbti3PfLTedHQ1zfr1GuuFmKa6Ps59/48pvvjPfGLoVOf2xJXFR 2NejdxvkNubpkMIQsaoTvChc6fm9n/0= Received: by mail-vk1-f171.google.com with SMTP id 71dfb90a1353d-50d32d82bd8so62838e0c.1 for ; Wed, 06 Nov 2024 11:54:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730922869; x=1731527669; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8djmRG6h4bc+SzaVCVnhZXth6QCnXFelnjwgthXVPkM=; b=FfSTMMpav84V80fMWKnMsVEgx7D6n46b9rfps4BftEzZa+vnVo4RoLc+r1NsznsvMV QgRhjmh8EYLWeMOWmKS9U7Q1Z99EvQWRpgvVGCBNnAAf3n2lAOcDB3WYEb3ZCGJ6DXcC rWaauAiQMxBLz5ipTcNTHStz+q8hh8aMSQp+fmjek+mZ3jJvzxx72yBzH4jDiwr8Hff3 6EbjQMieyF6qSwO2prc3cfo3kVJarT8Y2XZkVT8gF5HnvkLVHOwdZVIaYbxmI1MtWn0o GRLj916CthxkIeABvBlJltARcGvvQ56Dyq0Exqj+5DAEeHfmiu5oJEZ6sR7XV6logdBV 95rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730922869; x=1731527669; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8djmRG6h4bc+SzaVCVnhZXth6QCnXFelnjwgthXVPkM=; b=tyl7/BgpB0PRwH2gKmZjvFRaMPbXQD/jJQgv3h12RhSZBRdIlpxRwG1+RRSJyD7iBj p749tFD8Xq5qG+D2kfI5L2aagXlsknIogiLeBA54r/mY341hdgpTV3K3DA9ofJHadHSZ jSNrAaTXggw+P64SSFbRrIRYeDTVIOyWZ/hkaOoDMSvukoGaidus5p7+J78/Nc037MC9 hWBHxpD+PzqXcdpXEVzZm3L/3chcADA7uzRs4By/zu+J0EXi9IPeAL0sQzcDccoJl3MG TilXUKpJUmTm2OXDYSalq65E0kZRC4D6kDLHI2jiIB0i0KL1Wr9RJJGldNTkgxMj0rfw WfMA== X-Forwarded-Encrypted: i=1; AJvYcCWjzCa9CNh/MNv7GTWttElJge7GLGVGrqXzo+LrZJYTWZX4iHE66IuLOjTshRcRrcGYzCgefs6tMA==@kvack.org X-Gm-Message-State: AOJu0YzsE2bEfJCB1s/t9b5ydo/oIn4j+fhHZZWhoTdYxRFEoiw0JhmR 5yN92Bp7reRuPbiODrLTMmKsZYN9A+FDLBnE9KnK5eRsXoJONig7CWE/DQW/11ypx7/7uYFR886 Fxm499iAfcwmc7qsVgknOtODy6Mc= X-Google-Smtp-Source: AGHT+IHNLGON3XgJjzhfsZjCa80/60Rzycgq4mwsbD8ta/w3VL6D9p7b8x3gwVlqUR1ma+wIeq/Zh5/NDQKuNOJVOBM= X-Received: by 2002:a05:6102:1627:b0:4a4:8d64:74bd with SMTP id ada2fe7eead31-4a954259b7bmr24525962137.4.1730922868682; Wed, 06 Nov 2024 11:54:28 -0800 (PST) MIME-Version: 1.0 References: <202411062130.JXvq8Cjt-lkp@intel.com> In-Reply-To: <202411062130.JXvq8Cjt-lkp@intel.com> From: Barry Song <21cnbao@gmail.com> Date: Thu, 7 Nov 2024 08:54:17 +1300 Message-ID: Subject: Re: [akpm-mm:mm-unstable 27/106] mm/page_io.c:220:3: error: call to undeclared function 'count_objcg_events'; ISO C99 and later do not support implicit function declarations To: kernel test robot , Kanchana P Sridhar Cc: Barry Song , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , Nhat Pham Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 09B2040021 X-Stat-Signature: n3uhw5n6y8ppahgpt7ijpzfnnzha9846 X-Rspam-User: X-HE-Tag: 1730922842-863008 X-HE-Meta: U2FsdGVkX1/h1iZPjkRcb2ziObDEoIejo0dZIYFeC1jl1BIkFZVTKtKMw9oh2FMEL+yJrihso3uFHuVBITV2NQuwK9NZUGg8s8ULu3GUHMEAVe/1tI7Z4M81VTfvwlBmqXslLMSdhaZoG+ArCmuM1RZVgAQSqQVN/9u1BpGFXorg292/2OTU1ziWzziD3crvxvRMqA9MJNvneMlhgJ8I9/ruAczwXn0PsFqKhLdzUEfbTfcBVfaCxCe0WL7Zr8ckpmnzXGAUxwvQq6jULgpH5pSqmHkQrzmA1J2HpxJev1JOPc+/M52lhscGRRLWkcLr1zLLa7i/o+V5uSRncX3dhjCMBeUAcJukEJL4ZCJoH7RsUKAKZXRLQh24ovlwFqizUV2pyN6bsGljxc3l9y9f5r2c4eqQ95RZOh05AC1+aIWA9iK6Z0L6BIIp10O7StYYcj1ajSRU1LdXccLOvhHPyD9za2YsfV52X3PBWQFQRfYaVZYFgoN/T01omCRifsi5hwY5p5o84Ase2CuSOttavvm25PHoT+6BqunlT5zP53W+1MCjcZnUDDPATeBT//BcP4bjziwvOFcWogjEuQ6bXS6qlksFOvhyo72CgW413kqkHulcRBntGwZIfmigAyUlFioG/3Z2ty8lWkAuy9vKIEF4wJdrt674hKsEDFdCWDcybKE/457G3adXoUfaU1XppXHvwzCSR1QwVuJbvwyqDGk/naN3//+i2QaeF21Zccqm0/4dygVXE5oqDWuqjSH3a+yYQAOLx2xHPt41jPDcUUqifhOzaao7L++5V+xNKdRBn4Zg9hhw9RM8ul1n+jRAD/HvYPXi/818I0cMEZtBTRNFc6KMe4mHPxaEkLMLVIAATyZ5jxDAePeqvbBrNvx1FbE1MqeBfGhdL915jONcQekvzMU7CeLysi2WKQtNeBYUZsGksYgGrdUxR2kap3jVdoc0CnSisUs+MBsrnm+ q4GLKMic Liy+uTRXSlgbauAe+6J4tBs+nF04fvX027AA2elJgpTZq36UpmnzGdGxf66gE8Net2vdr8q2NdhWd1+QdlUPY8D7JLtmq96pSuCnwJJKIeV7czZfJaKEdib2yfSdJoMFdsOOkKpUrKIPAvA/yuCKIQXH6svbCwYBZrIdqGnJyvfS5wxqTS8maDKWqojFp84bt3Svqyb/mDmjqpRQLiF2Upwuf0jwmVJfSs9nL1aOS/+h80/3HfiTJRrDQyBSym3vfXOU2GhhPaHc6/bUtxt5AUiuIpT8fpTjnyX5ZyrbbopJUxvai1IXnRRwdpP3P+wTgYadRtCTR/YAuWFlAliQwGISEnmSrTsdVcSvbBXgaMi7/20TluK+WT9n2Um77rLiFw/U/g3T0EzQYT3dlKfF7uSVzGVtCedHeblTsYc3/uQ4pK4Df3alafY/f4CYcQYFVf4LlevH859PjztEwsUpO8IY3nxLn+JEoefh1mpqCzGJej3LWJeBYV8pNnfksSFeFd0Dpnf8tZetqYTNogKptgmkqWg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 7, 2024 at 2:24=E2=80=AFAM kernel test robot wr= ote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-un= stable > head: 7994b7ea6ac880efd0c38fedfbffd5ab8b1b7b2b > commit: c10966f19a878a66206327ebe3b85500f59f47e2 [27/106] mm: count zerom= ap read and set for swapout and swapin > config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241106/20= 2411062130.JXvq8Cjt-lkp@intel.com/config) > compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51= eccf88f5321e7c60591c5546b254b6afab99) > reproduce (this is a W=3D1 build): (https://download.01.org/0day-ci/archi= ve/20241106/202411062130.JXvq8Cjt-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new vers= ion of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202411062130.JXvq8Cjt-lkp= @intel.com/ > > Note: the akpm-mm/mm-unstable HEAD 7994b7ea6ac880efd0c38fedfbffd5ab8b1b7b= 2b builds fine. > It only hurts bisectability. > > All errors (new ones prefixed by >>): > > In file included from mm/page_io.c:14: > In file included from include/linux/mm.h:2213: > include/linux/vmstat.h:504:43: warning: arithmetic between different e= numeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-= enum-conversion] > 504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + > | ~~~~~~~~~~~~~~~~~~~~~ ^ > 505 | item]; > | ~~~~ > include/linux/vmstat.h:511:43: warning: arithmetic between different e= numeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-= enum-conversion] > 511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + > | ~~~~~~~~~~~~~~~~~~~~~ ^ > 512 | NR_VM_NUMA_EVENT_ITEMS + > | ~~~~~~~~~~~~~~~~~~~~~~ > include/linux/vmstat.h:518:36: warning: arithmetic between different e= numeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-c= onversion] > 518 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip = "nr_" > | ~~~~~~~~~~~ ^ ~~~ > include/linux/vmstat.h:524:43: warning: arithmetic between different e= numeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-= enum-conversion] > 524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS + > | ~~~~~~~~~~~~~~~~~~~~~ ^ > 525 | NR_VM_NUMA_EVENT_ITEMS + > | ~~~~~~~~~~~~~~~~~~~~~~ > >> mm/page_io.c:220:3: error: call to undeclared function 'count_objcg_ev= ents'; ISO C99 and later do not support implicit function declarations [-Wi= mplicit-function-declaration] > 220 | count_objcg_events(objcg, SWPOUT_ZERO, nr_page= s); > | ^ > mm/page_io.c:220:3: note: did you mean 'count_objcg_event'? > include/linux/memcontrol.h:1763:20: note: 'count_objcg_event' declared= here > 1763 | static inline void count_objcg_event(struct obj_cgroup *objcg, > | ^ > mm/page_io.c:532:3: error: call to undeclared function 'count_objcg_ev= ents'; ISO C99 and later do not support implicit function declarations [-Wi= mplicit-function-declaration] > 532 | count_objcg_events(objcg, SWPIN_ZERO, nr_pages= ); > | ^ > 4 warnings and 2 errors generated. Is it because Kanchana's "mm: change count_objcg_event() to count_objcg_eve= nts() for batch event updates" doesn't exist? Hi Andrew, is it possible to take this one also into mm-hotfixes-unstable? commit 206ad49987b4670e01a3a0fd5673a823a94499d5 Author: Kanchana P Sridhar Date: Mon Sep 30 22:32:19 2024 -0700 mm: change count_objcg_event() to count_objcg_events() for batch event updates With the introduction of zswap_store() swapping out large folios, we ne= ed to efficiently update the objcg's memcg events once per successfully stored folio. For instance, the 'ZSWPOUT' event needs to be incremente= d by folio_nr_pages(). To facilitate this, the existing count_objcg_event() API is modified to= be count_objcg_events() that additionally accepts a count parameter. The only existing calls to count_objcg_event() are in zswap.c - these have been modified to call count_objcg_events() with a count of 1. diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 15c2716f9aa3..524006313b0d 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -1764,8 +1764,9 @@ static inline int memcg_kmem_id(struct mem_cgroup *me= mcg) struct mem_cgroup *mem_cgroup_from_slab_obj(void *p); -static inline void count_objcg_event(struct obj_cgroup *objcg, - enum vm_event_item idx) +static inline void count_objcg_events(struct obj_cgroup *objcg, + enum vm_event_item idx, + unsigned long count) { > > > vim +/count_objcg_events +220 mm/page_io.c > > 204 > 205 static void swap_zeromap_folio_set(struct folio *folio) > 206 { > 207 struct obj_cgroup *objcg =3D get_obj_cgroup_from_folio(fo= lio); > 208 struct swap_info_struct *sis =3D swp_swap_info(folio->swa= p); > 209 int nr_pages =3D folio_nr_pages(folio); > 210 swp_entry_t entry; > 211 unsigned int i; > 212 > 213 for (i =3D 0; i < folio_nr_pages(folio); i++) { > 214 entry =3D page_swap_entry(folio_page(folio, i)); > 215 set_bit(swp_offset(entry), sis->zeromap); > 216 } > 217 > 218 count_vm_events(SWPOUT_ZERO, nr_pages); > 219 if (objcg) { > > 220 count_objcg_events(objcg, SWPOUT_ZERO, nr_pages); > 221 obj_cgroup_put(objcg); > 222 } > 223 } > 224 > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki > Thanks barry