From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D02B4C52D7C for ; Wed, 21 Aug 2024 21:13:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FBAA6B01F8; Wed, 21 Aug 2024 17:13:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5842F6B01F9; Wed, 21 Aug 2024 17:13:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44BA86B01FA; Wed, 21 Aug 2024 17:13:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 25B076B01F8 for ; Wed, 21 Aug 2024 17:13:22 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9B418A937D for ; Wed, 21 Aug 2024 21:13:21 +0000 (UTC) X-FDA: 82477503402.29.92EFC7F Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com [209.85.222.50]) by imf29.hostedemail.com (Postfix) with ESMTP id CA0AD120014 for ; Wed, 21 Aug 2024 21:13:18 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="iu7SzUX/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.50 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724274739; a=rsa-sha256; cv=none; b=izsDJAYAp/g7dKGbo620Fu118ug3dV2+jREiM+YtePkQ1CGUBE7CUen7Bj37pPrylXx/xx XeeReXNA34CYfVLh9QBmKQfAxx1oaqeRJcichcPh0mtaSiCEe4Gtly71906eB6EJuXr46r zSPXXa6Dgn6Vu4uaUlHT+PfJRVpqBXc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="iu7SzUX/"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf29.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.50 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724274739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m2O1JoDxU9kDe9y5+KIXDvq6QJWLz1iNgPtLbdhgykc=; b=ZjguwGTvEYI4pToPrURmm1hsC8HVvKmzsAZjXXQYy+Zs1cAyxAITLlbHTxsxoY8ZP36jib xGJPKcAO2kEFXpi2PCv+dVgolZVxVTU617bB+cIpVn8LP89/VzSxEZnbZtMAXN+C/d3U+v Rvq4HodOMk2lRQqZDs6u0t0CIgey3go= Received: by mail-ua1-f50.google.com with SMTP id a1e0cc1a2514c-84300e0ed69so48099241.3 for ; Wed, 21 Aug 2024 14:13:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724274798; x=1724879598; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=m2O1JoDxU9kDe9y5+KIXDvq6QJWLz1iNgPtLbdhgykc=; b=iu7SzUX/XjZ9EtMe6sfCP6Llm56kpi0Sl/lB3PTAPRCzYlTOuus8ellYmCHCgK1fIG t4pi7j8h3cosnQ1/ilIng7lV3cIj6VG9CZRw8moD+WGc5I03+StO0cD+SD8e/d/s3Aa7 d5ZnfCyiMWoi6NwVj0IRzfe1CBpH0hJfALc2sTUk33l2biga6R0gQKf+9errgT08DR6z brYQcH7zIIRYpXAKLkY7dnPPTkl1ag+Sr7TKNUuK/xkqE1lUDVzZTbpN9ufcO4XvE8+7 HaBe4ud4Q8p7rItJsqVbuyOuFaWpGCknoTGMKlvJayGglZjFq2sH9XCckdEemD33Lj0J Aq7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724274798; x=1724879598; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m2O1JoDxU9kDe9y5+KIXDvq6QJWLz1iNgPtLbdhgykc=; b=OkMlr1vWA2Z4AEzvOLHuf7R/yy5n4E97HBJAfEAQZ0e2Xwhx6ISz/8H5Pj0xso1Ygz wfB3xqZTVcha3COQapyfwf/6S1SA/LnK/n1qoNi/Yah9AaMiGRI5nS0YPq0uGBpoIYc8 WOghf0rFbeCklVaNblyOvaqFnFtHfMPXMZBsvgRXEyIAfz9b/PMhmRQTzaPhOPPfzpNR U0t3zVAjpnPGpCPpZXQRWxaJPdaIAulX9ndjMLuEchUN+ITs2z7j33Afsy3fUvQ1Oa7j GTo9pLb8c8E2UrAJRg7GuNzZEX8Vcudwyctg3h/Ou9cconN6NcXzpdGHTJGz9m6OQtLu AYOw== X-Forwarded-Encrypted: i=1; AJvYcCU/KpYfxqCQUa/N/nU3q/koBSUyemo1ujzBudUe/5h3I7L53+LDBMYcrukCskuO+m/swBYQOr3itA==@kvack.org X-Gm-Message-State: AOJu0Yyxb8tIrE4khhQyHzZ6UYwBG/2mBJh2a/ro+SfQAqQI8mzLl8mn 3ZoON37nE2xX8ZpXNjctLV8g8U4bpjzNQHV/vzLtnx8+R1/kjpsDRqNyQg2gEXzu6NbA2OYEtNR cHrM+m0hyUHjGo2/KFnN1RNehfD4= X-Google-Smtp-Source: AGHT+IH1ZeFh/1Y3kn9DHRZ43+4kdmu5+2f/xLgaBgzi5/jsg9ZnudHuJB5WU+nuIc6BsfXEGG56PqGfzMBkJR8ie7s= X-Received: by 2002:a05:6122:4698:b0:4fc:e713:6572 with SMTP id 71dfb90a1353d-4fcf1b98922mr5165569e0c.11.1724274797848; Wed, 21 Aug 2024 14:13:17 -0700 (PDT) MIME-Version: 1.0 References: <20240821074541.516249-1-hanchuanhua@oppo.com> <20240821074541.516249-3-hanchuanhua@oppo.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Thu, 22 Aug 2024 05:13:06 +0800 Message-ID: Subject: Re: [PATCH v7 2/2] mm: support large folios swap-in for sync io devices To: Shakeel Butt Cc: hanchuanhua@oppo.com, akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com, hch@infradead.org, ryncsn@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: CA0AD120014 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: rmzywbyki6gwp4ik31q1saegqtxrw6xr X-HE-Tag: 1724274798-366140 X-HE-Meta: U2FsdGVkX1/XQRT1O7O3wzRqhNA7jUWJfhNLGj874UMfdXMFnA6N+JcozEw4EcK+794KbJEuRyJmJifjkcwDmP/CjOetuMLT8pDtuXWY0vWyfE3INQsq4gOOi4OXJhOUm5LWTSnZWonOJtgNDI4hP9MpoLtulAfcR6Ac+j1fRm+4JXh4MbjJDSJRhbm+woc9sAABd3GM0vkGzzuAb0xgiuVCZTsTh+ZfeltsnFf5pVVHSY014n5/vF9Ev6gwK39+rNvikHJxhqfX2ST77DxL3f9WK6R0RliO0KxatDmj3r1160Y5oA3R0GMe4x6UUgeHScccxixr3teevjI8LcBBZTI0T7uXfIl0zw3Hw+Rcs4dcUb8B57A9ei2DWa+4B3uVI7c0gEfk5f9nlLIwQ3sYzLx/Lsb6JbBwg/SU8NmOUVO3ij+srjYV551BKI/0nZ7Uvq/dhJc448CbevRElrIWabsJ94nDnVJCX+2DXAetP0GPa1JTBMvRdVTsR7jl7ZHEZYMIfhf3DYAwRJo+LUD+SUJUB0kIWKZ6njLzUqDTJD+lUUpue/DbHYG3faM5t69fvtBh+VKthS+hyzBJcOmsIeptgO//21Q4MJfrWiW8sgzmNteUrQA1DrTsz8Mgk5CRvoJ75QAHY4NGoqIhEUaX+99VzWuUvaRmt4Jqv6fH0OWysY051YrBylCRDcCc6PdRF5dxLtHlTk2Fv6Nv4fMR9Tb9CCHKLhphpfuNE0S1FOPsJXg0K25UeIuFYH5KC/b9aJozvmM/65hm6yS6E/n68SC1qErem0I+xjp9PIiB/wecg+0QIxyzD6QIirtsC1NMQUrMNxx1TG6VKeIKtqCTix0iNSvRXETgVUQYMeKpBrH6dNm2eA+J5xBE+qPRY1Z93ekpjE+69rSZEDHSgHwkRMIxcNCezs2BtMivWp6AOGZEPHVWMd0CYve6MDlJeYV3rwVeKgI7snAh21wDyUD G/WT+s27 PkP33BxT2eiooptrmGLvo60b/fvyG1Y5IcxrnTgufsM7Gncps7FGXkUzMibK0I/C0ZFvteIn5Kb5PYWgTzsxRyrlSgUoiMzR8GkZ56I5TF0I/5iVGjEwdVAiQQpWaAKRJF5ikUh1hbrZS2nQBU932sgSDtUDIWtwbsyYxIPbaDUO4SIfnEyUMs3XyrBDkFrKzHnomLlqWUbq6JAErx2HM0W2rmn8kJQMwBt/gXJsr1suns9U2e+SuDYWjK6O/G3gvI5gJkwV8Aud/XHmo2gIR9MrgU0mfFjCbmeWTIWbEq5Q2wLGCKYH90OYfKZFXiXwXQeH9RvFKp1IgEnXYLbsehxMxTpEhdkb6hVlt5b93/4mN99yRlbNYWM/cwv3dyVk/ddJAny8ur3dao4nWaWuINsLHPlUis3lhW0PR+7Vl2AXrAd56dMcSnLtdiyAReu23Q5Up X-Bogosity: Ham, tests=bogofilter, spamicity=0.000101, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 22, 2024 at 1:31=E2=80=AFAM Shakeel Butt wrote: > > On Wed, Aug 21, 2024 at 03:45:40PM GMT, hanchuanhua@oppo.com wrote: > > From: Chuanhua Han > > > > > > 3. With both mTHP swap-out and swap-in supported, we offer the option t= o enable > > zsmalloc compression/decompression with larger granularity[2]. The u= pcoming > > optimization in zsmalloc will significantly increase swap speed and = improve > > compression efficiency. Tested by running 100 iterations of swapping= 100MiB > > of anon memory, the swap speed improved dramatically: > > time consumption of swapin(ms) time consumption of sw= apout(ms) > > lz4 4k 45274 90540 > > lz4 64k 22942 55667 > > zstdn 4k 85035 186585 > > zstdn 64k 46558 118533 > > Are the above number with the patch series at [2] or without? Also can > you explain your experiment setup or how can someone reproduce these? Hi Shakeel, The data was recorded after applying both this patch (swap-in mTHP) and patch [2] (compressing/decompressing mTHP instead of page). However, without the swap-in series, patch [2] becomes useless because: If we have a large object, such as 16 pages in zsmalloc: do_swap_page will happen 16 times: 1. decompress the whole large object and copy one page; 2. decompress the whole large object and copy one page; 3. decompress the whole large object and copy one page; .... 16. decompress the whole large object and copy one page; So, patchset [2] will actually degrade performance rather than enhance it if we don't have this swap-in series. This swap-in series is a prerequisite for the zsmalloc/zram series. We reproduced the data through the following simple steps: 1. Collected anonymous pages from a running phone and saved them to a file. 2. Used a small program to open and read the file into a mapped anonymous memory. 3. Do the belows in the small program: swapout_start_time madv_pageout() swapout_end_time swapin_start_time read_data() swapin_end_time We calculate the throughput of swapout and swapin using the difference betw= een end_time and start_time. Additionally, we record the memory usage of zram a= fter the swapout is complete. > > > [2] https://lore.kernel.org/all/20240327214816.31191-1-21cnbao@gmail.co= m/ > Thanks Barry