From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDCC3E6C5E4 for ; Tue, 3 Dec 2024 00:24:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A3236B0089; Mon, 2 Dec 2024 19:24:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6536B6B008A; Mon, 2 Dec 2024 19:24:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 541E16B008C; Mon, 2 Dec 2024 19:24:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 32FAF6B0089 for ; Mon, 2 Dec 2024 19:24:26 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9D70812042A for ; Tue, 3 Dec 2024 00:24:25 +0000 (UTC) X-FDA: 82851750912.23.634148E Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) by imf28.hostedemail.com (Postfix) with ESMTP id 2F765C0014 for ; Tue, 3 Dec 2024 00:24:08 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=F8l+kRzo; spf=pass (imf28.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.161.53 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733185458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=769c20wy0Vv+GBDNra53cIKjEqA3OwLkS64TJk5Hd40=; b=GNcPrh+DJAo6pJC3kxjGqTptdJFeGlbPuR0m7IQE0YUTq6qruMroUgOT0rGKTvG3K4KF84 mAI6ANzyIO2VLCITjdLS4w6yD1yIYNq/mAvoQOLVGSNjxAanFa1yLuV/ooxFulQOXd65cL 2Z9Hzviz6UWIvytqUe3lZMmFO0NSdfk= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=F8l+kRzo; spf=pass (imf28.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.161.53 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733185458; a=rsa-sha256; cv=none; b=Rt8niIFOY1ECs6sX+KNqEfp1OASx+vyMWMs85o8BBwQnR5qYlLIgCXgrFbpZX0BmYguoO7 nILttILppG+KJ3nGG5VN58EwHIAEUK9ww/FdksPk8t3NBWr9Y64lvowPZuxTTwdlEaNe8i j8ObyOh9F1ZoOfAdPabExR0FDle3wY8= Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-5f1f81e51b1so2190494eaf.3 for ; Mon, 02 Dec 2024 16:24:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733185463; x=1733790263; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=769c20wy0Vv+GBDNra53cIKjEqA3OwLkS64TJk5Hd40=; b=F8l+kRzodHwKKnU8tCLKA78IFsge4xac88Yx18fcySjYh3AHfhVrcjRvlDy2YlArWC DU9R7qpwaxGYXPrVpHdleBU+Qp17U16xIsTRC5telSfS/y/9kOHEiiF34DZmCgcaOSiz TX9795jhfqjQwmLfp9gf1TuF5O++AMmXM8wpO83US8jfZSOBjEpuu2AK6j2aNP9+jqW4 sKCC+XVGVxjZp6DhTyAyDHQZU1epmCPuxtqwi9TSClhByUIChZW3C3h3iDPkqu2xyABa f3XEvDmNDFVdrbOG0m5UyF82pnpSkyffvCSspguYAsi8LA7l/rZqrH4BaPCYRswHMdG3 7c3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733185463; x=1733790263; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=769c20wy0Vv+GBDNra53cIKjEqA3OwLkS64TJk5Hd40=; b=AaBV0UE4UcUWVq8MUpSQ4R+2TAkI56OXkiWir64QsdSWbWOkGOgkk3DFZBaSXxLgOP 75g2NMFKX+t/CnP5yDVEq8Saul0ZFOPft0e81xFZ49NY/gDbf8uOD0E2XvOLxRCGHV4X 6GX5m51rdTgZmpFmEWbuwLn8/G7HVmPIBK2mMFSid2Cot+NYPKKKwUFl1qGJAzVg7TUT VAWyGSukZu+YwoFcIvymCMMeTNIG5eDW3tUfSyEp6Lv77tE25gNwqNSGvaRzA+/+Jind mzo+JL/VW3qm5614HGEpQXasjzSl2TeuDt16Z9jYHK/7IW1xmiwprGFrWTAz5lm3aX6m GNSg== X-Gm-Message-State: AOJu0YwQz/61pg4J9h9BZ/GY0+QGxEtSK5Ej4qIX0a3qYC7lrF1RW/pq q0efpTQbYTeZAIMMkivGyIl7vKIx10RDVg5ZT1VaQ3ojD9HFg+lpRo9v7lGwEANHWEdDnT/U/ae IZOQKHXM0SunIe8H6BbhzRL0HEPA= X-Gm-Gg: ASbGncvp1mkrj9wiUscg7Q8N/8WjD8C5uP6Z6cKVuue2tRp5Tmvr5tl3W8ABmWukUOC lZzGCnP4X6mqSHmzb+z2sAd6PPh8EyPDDkgUTgrwO9CIXda7xGtY2NxjoFvWA1BN2GQ== X-Google-Smtp-Source: AGHT+IEFO7KqdcLAxyn/uQOZcHSTfFKHJ188mKQ98vsbqhUJI1Nakeqcl4diWmzwM+nQJadnACQQqvfmmPle1QCzT8k= X-Received: by 2002:a05:6359:230b:b0:1c3:94:8ffa with SMTP id e5c5f4694b2df-1caeabc2133mr97690755d.22.1733185462641; Mon, 02 Dec 2024 16:24:22 -0800 (PST) MIME-Version: 1.0 References: <20241202184154.19321-1-ryncsn@gmail.com> <20241202184154.19321-2-ryncsn@gmail.com> In-Reply-To: <20241202184154.19321-2-ryncsn@gmail.com> From: Barry Song <21cnbao@gmail.com> Date: Tue, 3 Dec 2024 13:24:11 +1300 Message-ID: Subject: Re: [PATCH 1/4] mm, memcontrol: avoid duplicated memcg enable check To: Kairui Song Cc: linux-mm@kvack.org, Andrew Morton , Chris Li , Hugh Dickins , "Huang, Ying" , Yosry Ahmed , Roman Gushchin , Shakeel Butt , Johannes Weiner , Michal Hocko , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2F765C0014 X-Stat-Signature: hb51osomp8guky3o3t8csyc5tm93r966 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733185448-551540 X-HE-Meta: U2FsdGVkX188CxS4mBS7cMEmgye7jhBWOlD2uJeWvPhrUFDq/xgsNA/GVglvrfwgzBHg+rSOWGBcg8qnBVmQFcqWw12ldPIeTcd/HyVOZXU9ejodQdmdBixmsMo0L4sMi+P89yg9ksQ9wbud6IG8JlQtw0FK6dHvfW/nhzAlq4yej05lWYE9Ri7wvi6G19RUBmw6y3/F2i0/DQ7gAUdtklt+oFPkLaC5sAG7E8kFxOsggv39c8oJeZoEEdgYNjQiSboQlZd+c+PH86KVCUD9iwux5IvNkhQ14gvnBtThVC6e7MpvABL0VXG8yQurOe8xwKyGCCL2FEUPMhfVDBaHGj7dEKCwPcscrEDR+T4BVaxKCcu/ALSMS/cPtvPY18EsaZZIAinoqIXcYq7axb6qOCwILyyOmcICghVMX7ixqzQ7GftBoBGY6Xy19l0vEhxcUNwyKewfvBKT7zdm8i0BSKjI07VN1bEi/9gRdNe6qV1hZeQWzAYcVvM4blDlMZ671HDHB85Gb+eYJCah2XGpiF4BHjh4OrYw5xWGXZXvBMH+uJ5TilsMONGHircdbVSZ385WZui4zmS4vjH7lCdSFsL3/oPHwwLWC3+xuV+/7KLgxOfd9q51ICJeWButocKETk2HnLEOcZWXe3VI8xpQsJmzcajY8A/MYDXjXiiWa74DnLlHDHubSJx3+3z+2HJguuuDyDnQa8Oyab045HcoMIVc0R06qQvQuxWVBb2NbPCfxhMHYRGT7fKFl0IyZbRWgsn191RRs0tfyvkxCpqzFM5nUROJee6N8TwysYte2ENRFblcbHTQ7pKrwFLe9zq7enEK+dwJh73/aZKw4y70SBDNIzp7i9AoPdUq2VBTmsLORNznwPotOk/578SG2/XE0ABtQf/NwzYeupCYnnbO8b+08FdsKlw7rBH57Y0DQlU7YuPn5hyNye8ZXyaT6Ctjdcy4DhfNm64I3YoMyjD wrMxz9/u mQK3uOMldNcgp8tVAkqX6XSIcgAOv6quuat4JDAqiRPJHjixQmyWwhgvqpRMZVesPLn9I+YllzjtktNlgnjp9K4HLcuGJIoiZpiJTEE3lXgxKHP0dCgvjc8kMMaPEwuK7etbwNHqL1ywKe74LttLwQzxvjJoQ0/heONRHz94h8tZcibBOlryIMcVGYUbD4gl5oAUiFbn1hN/INt5VrGjiXaivnptSqgdJMSgpqfSEMtnw14osmbZZ7zNX1iy8fODGuh6fSqFExWrzFF+h5wqiKtzwL3iMZrj/Gp890OqUvkS/sPxc+pKwVwMXcXobBG2nfTowz3azIMXl3cAV9J7a9BXt6GkNaRDuHjtNnWfPswHVTr8+AbSNvB29jijw5tIGqR3hh8kLIGN1OOs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 3, 2024 at 7:42=E2=80=AFAM Kairui Song wrote= : > > From: Kairui Song > > mem_cgroup_uncharge_swap() implies a mem_cgroup_disabled() check, > which is already checked by the caller here. Skip it by calling > __mem_cgroup_uncharge_swap() directly. > > Signed-off-by: Kairui Song Reviewed-by: Barry Song > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 7b3503d12aaf..d3d1eb506eee 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4615,7 +4615,7 @@ void mem_cgroup_swapin_uncharge_swap(swp_entry_t en= try, unsigned int nr_pages) > * let's not wait for it. The page already received a > * memory+swap charge, drop the swap entry duplicate. > */ > - mem_cgroup_uncharge_swap(entry, nr_pages); > + __mem_cgroup_uncharge_swap(entry, nr_pages); > } > } > > -- > 2.47.0 >