From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEB1BC3DA61 for ; Mon, 29 Jul 2024 20:11:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B1196B007B; Mon, 29 Jul 2024 16:11:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 360E56B0083; Mon, 29 Jul 2024 16:11:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2287A6B0085; Mon, 29 Jul 2024 16:11:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 04F346B007B for ; Mon, 29 Jul 2024 16:11:31 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 55F2780665 for ; Mon, 29 Jul 2024 20:11:31 +0000 (UTC) X-FDA: 82393885182.29.951DF9E Received: from mail-vs1-f45.google.com (mail-vs1-f45.google.com [209.85.217.45]) by imf14.hostedemail.com (Postfix) with ESMTP id 891B3100029 for ; Mon, 29 Jul 2024 20:11:29 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ICCBTtp6; spf=pass (imf14.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.45 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722283818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qPLL7oK5NWSnf3Du8VFLvWdadYL/N547QaYJmd35X80=; b=aqSm1P3uiajzLQhJu65eptmaZQMnpLu4k9saKiCfuMS/wGguXw7+JKPF8cVDgsDleSb1HC oJkA7O0zWEgcQdPSNq0QkSQLJQHavWTzoYELaxQv1dGaKEv2bVYfCot/JhTEUgg0eNLXBx lBEF/tx/MgEPs0ZpXqTUS+EkH4tBSXw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ICCBTtp6; spf=pass (imf14.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.45 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722283818; a=rsa-sha256; cv=none; b=P/DFJWlBUkIOvFJcFLU7QA4FiyELV05FlSsnO/j/gOmsOVEuhPOLoVaz/c9+EFbbgrUKUz 4Si1alL9GMVSEDv81RxgO+mxSbU418GCl15IxanMQaEoHZO7c9Yvte5kv6bMUpRwpW8xpg 0JaNNY+TNQEHJ781T6FE4oH5AbiKtNU= Received: by mail-vs1-f45.google.com with SMTP id ada2fe7eead31-492aae5fde6so779027137.1 for ; Mon, 29 Jul 2024 13:11:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722283888; x=1722888688; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qPLL7oK5NWSnf3Du8VFLvWdadYL/N547QaYJmd35X80=; b=ICCBTtp6nu+I2tiNYhTQjknW1nGcsxoakS3HhPzafhu/A7lWNDhzEIuinc1sO2qE/A sv/YTKrh7XgnkJXdxaE6IJedCYeFE+d+ws/MDbOCrR5J+8Oph6wvfDBkFbwvEu0H3SQv WzdqVlTACi4u7JqRPXE5Ve20CZy2mScuE5gG9nR+fpMSdXoPWU556BIFCWlMEgWGSgB+ 3bY5SHB9AB528nlpEYowSMnZvTaNqeo5xZB58ynuUhHIxpa9AX0FkJIk4D+wSm62hnDJ XFM+fvz7YbnqBpw6cCkzQQapijSVgqbaz0bHOkOwUQutfxP+UM6wSRojdTTmdEqLfvv6 r/lA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722283888; x=1722888688; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qPLL7oK5NWSnf3Du8VFLvWdadYL/N547QaYJmd35X80=; b=tpIxOebH/bqKUnk5DaChWjyQMRpv3SkuVU2O9hbTps0m5BP6IdkH69dBEURqvd9lca Pd19sOJZcCuy7pKD3SJDu7ph0YBCh1/kqMbLB1TKe3NfZc+mpUlUeIKd+70F+mREd+uS 4d1JOhQPNraXvAZY0WveCf5Yeq1PM9TjgalPNfAFGjT1hIJNyDi+OKi8BcZBXTFPMW5c Zzc1/6oQ5HTT7Ppsqx70vArK2njg1BrBfc8NNjNWcHbo6IeT7LhWG5bSu/j6DiO3wEtN svuVM0aakB1G6DSSwEMGJZpra4KqoQsMHw/z41k8JHtEx4WG4AfsCgpCaj7JxiEjDaN2 /ZJw== X-Forwarded-Encrypted: i=1; AJvYcCWcXoeXJiS4dCfSfnUJzz8T/bXvncbSXlhI1tZrewbu8H4zwXPdSbN0+AssySradzKSE53uRCBN+Wdw4yBapTFKn0w= X-Gm-Message-State: AOJu0YyX4sFRzsJcD9WNBUAbQgH8lNGugRtJFUwcYiWL/4RPIw/mpdRg oSbZZzJKOacm93eeVFatI3fwSW1P51IOEmldcPLiRun5QAixotNAHdlRFvp+TE4pIoerYNeO42n Mp0j1Ek1WkWbh/iI7cvfCo5Wnnkg= X-Google-Smtp-Source: AGHT+IHd+nBXvg6pkdA+BF/xs2oc5XnZGbHOsQZcL7cT6AxlgOvYwlNzjIsDUCBcU0+re0Ax/kHIWKPT3WmZF97pqDE= X-Received: by 2002:a05:6102:944:b0:48f:2afe:88f1 with SMTP id ada2fe7eead31-493fa1e8642mr10606701137.16.1722283888443; Mon, 29 Jul 2024 13:11:28 -0700 (PDT) MIME-Version: 1.0 References: <20240726094618.401593-1-21cnbao@gmail.com> <20240726094618.401593-5-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Tue, 30 Jul 2024 08:11:16 +1200 Message-ID: Subject: Re: [PATCH v5 4/4] mm: Introduce per-thpsize swapin control policy To: Christoph Hellwig Cc: Matthew Wilcox , akpm@linux-foundation.org, linux-mm@kvack.org, ying.huang@intel.com, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, xiang@kernel.org, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 891B3100029 X-Stat-Signature: x3shm688ykpamrhc4sw43zrghot8s6s8 X-Rspam-User: X-HE-Tag: 1722283889-273067 X-HE-Meta: U2FsdGVkX1+4uZPhdhhYVE77b6AQh4LB9fWYxsfe7rht+xzdsba9Gawz7sHoC4M/XGV739znXb+JAYb0p81fKdYoAnMHK9cSqgMq+UTBXLYIMgItkHy8y6joH+v/umI2XHMLFPsmB+9CyOrtLPQ6BP3uSD3HvXBwsMULZ0B39+VcgRlpb4BatcG4sl/sIKXFrLLSm+L8mHqrp9xSlBRl2c64QIV0ma0UoR4f/KzKexF9zUeHTFLW+ASzUuOHFsb4cSdM5d0f02M11px1IJuxcm4EA2L43UyKawaHhZYVn4PwV0018qEsgwv2HsjvsxTetLw5g90lBF+RoW1fiDBOf7NjjGRxYzTOCtGmIU8coJQ74Sw6tPfCObKOujTrvdY3ZJxzjB6tYwwy5BR+k4j+BCVlZdIMnGyVulSgu2g1KsVJJX7rv8Fd2LUBMNCpU9sSM9KoJc+AvgFJg8xtMDY8XKos3s7ccMIwFXfvDQuHnB9S8/BtdUSczEfVz60OwYtrCbLGhOstbUNh0ffJxWPdYlOgyS/ewmEhHP/jH9if1a7cAAS1ld2Ez79kTV8xOplh0L6BTOt9NdiB2/d/FBw67YkVtoMGgeLerjnUor7eLdN2zQpbtGIq2vrWQgcUZwkd1L48L19VwuxmCGenvjCa47jCM6VHJBy9XUba0HeSjxZeOKR/DSj4t8dd8RM0fTThPH0H7lJOe8GfJQBwDRu52pTH4JVOtjc5R54+r5JbVAA5htUluissWlA0D7w5omJaOs9xD5GZgbKaWm6NOe+9JpdDHdAXFXZZryZRFL79OZgcL5pZHA1rVxvtBGXyWkcadQY+xD4GM9NAUye8ed01p1GG3SZF5Ir6cVo0V8KBacL/r3hFLrXtw+bNcXs4SOsCQU66Y7+1GZ60Kbav+Qc64sEQ2mEtNK9fYsQyAykkaHzYSxBulcv6vmXFoP0LcEXjrTi3fY1dN4a7Kuyq2/q 0sAAYBJT MX8/TXIG9sWT1+fxE1jqLHdeZkhDBK4omb7ISCYO9Cw9L86kgsRASn/oSDOLVz6ezQ2h2Z+JG6ZpQCyPjDNhti2uejqtAS8TTIyNUb3mjeNVYut4NakZLDsWNnl9LjAs5vjt0bXuOXi/bhGJibc6wOzC9DcYYwl1l/ILoNL5Ibq2BHq70UA3q7CHFQ4bCM4mkilMXuezCrEK2mNuo3bWFyQgvsXy9m2zbOKyzsiM1ws6tedduZ7o00SIBJkTfFcnfJB6yPW3fUOf7GqTwfwygjAVWyjYcZikPOFdJkMiy6G1WNBoG0q1UEXszFGx0prswanrnMXh1lULhQ2ixiIYohsFa9r0VEbmrxtiSrNR50MX3ozM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 30, 2024 at 4:11=E2=80=AFAM Christoph Hellwig wrote: > > On Mon, Jul 29, 2024 at 04:52:30AM +0100, Matthew Wilcox wrote: > > I strongly disagree. Use the same sysctl as the other anonymous memory > > allocations. > > I agree with Matthew here. The whole anonymous memory allocation control is still used here. this is just an addition: anonymous memory allocation control & swapin policy, primarily for addressing SSD concern not for zRAM in the original v4's comment. > > We also really need to stop optimizing for this weird zram case and move > people to zswap instead after fixing the various issues. A special > block device that isn't really a block device and needs various special > hooks isn't the right abstraction for different zwap strategies. My understanding is zRAM is much more popularly used in embedded systems than zswap. I seldomly(or never) hear who is using zswap in Android. it seems pointless to force people to move to zswap, in embedded systems we don't have a backend real block disk device after zswap. >