From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81240C47DD9 for ; Wed, 28 Feb 2024 09:34:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 139816B00A9; Wed, 28 Feb 2024 04:34:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EA7D6B00AA; Wed, 28 Feb 2024 04:34:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF3846B00AB; Wed, 28 Feb 2024 04:34:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DDCBD6B00A9 for ; Wed, 28 Feb 2024 04:34:21 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 94D0880F65 for ; Wed, 28 Feb 2024 09:34:21 +0000 (UTC) X-FDA: 81840701922.03.44E5469 Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by imf06.hostedemail.com (Postfix) with ESMTP id 0583818001B for ; Wed, 28 Feb 2024 09:34:18 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=c8u2HBMI; spf=pass (imf06.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.175 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709112859; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JrofktxwInA3vcID9wwrk0HbtLWVMB1feXE92jqNChU=; b=I6gjMmBuI77ZNLm0dFyzk3+D0mvy4h4iUOQKnZix4iDJRy52rceCTBCggo/eZSW8AyjEse 4nwSiF25hNbbDIEo+bBxZ97+DqdospRIJsLpqFCiuorErFpjgvbQDN4pFVYygsJcA94gTl h8V89B/ytgmrrnZatum6lvogz7kliEM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=c8u2HBMI; spf=pass (imf06.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.175 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709112859; a=rsa-sha256; cv=none; b=w1f6Vd4XZumMTyGsw0WAz4Yrl5twNww0zGX5GACdAkzDcoHKHztIQW9KwMNG7h1hbdc0LD bmZ4meEsQpAWWN0Shqo5jKj9jQwCBTUf2cH/qhVvC29/nYsgYxmBysm5/1wKKJ+cH7QRmu C7KKiZaPNDOOIMEfdTyvyxi/3JY3MxA= Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-4d341065550so54138e0c.0 for ; Wed, 28 Feb 2024 01:34:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709112858; x=1709717658; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JrofktxwInA3vcID9wwrk0HbtLWVMB1feXE92jqNChU=; b=c8u2HBMIfr5DqSvhhyY3w+VhU5Y+XULZz/FrOg0LxAd/fFMX7xnCcoHJ8Ma0YW81TV wikj22FAvyI1aiAbmjOP5dBLd27fXzGrUgSrQF4iG1hD+cmjCtKojq+e+i29CYkynM3i mCnUmM0MKz3Afxwyd/M3KdWte4ZcjNU+EfCnPkirqEgRaCp4RGoj1jo1LZgpZJxiLhIQ J1YGl95kKFW5Jya5NhXPn0RtaxK4dTOOfRa/EXT1ECKuYUH7SM3Afh2hY5LAo1KO6HWz 4bWWub4hqWSIitKCLsP9sBCsOAq36BiQaqeo6cxDzHe/baZi5k51D7xJmDHQkCKo0oVk z0Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709112858; x=1709717658; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JrofktxwInA3vcID9wwrk0HbtLWVMB1feXE92jqNChU=; b=I+qq04stxDgh8ey08GVuYSgdCiAslqLzUQNKWEcCuab8YQgHe7kAOMNisX5MNBqVWx zYxo+WjOZ6pKPcEP/n8pO6S50WhagkFd8QCka4x0IknYC4wVxYemJxAc3rxGZfkNLmOG rza2vY6HXBW5uPUwIiH9ea7qCQWbswvzlrGWiZ/uJC80GOvO81dmkDC3nxFPK7O9nPAS D1HJNiIr6pQItdmQI6IrM1z47/WWHn2r5DHU6+dTVtO4eUxKMv7IYH4p+ERQUz+ubVbN QLg4B+hRcPAaiSEPwIzvPFy1QTjPUrQa4/oiyR2A/owu96pFjnNfZyN+YUnlqPqWaey8 5qZg== X-Forwarded-Encrypted: i=1; AJvYcCWyIUza1qfjETDjO6ZVXOSvhkqPOEmJ//zyVdqZ4A3hvKQeq+MZipi0QLXnFx4dQJJ3LRYgnOkOj6qulFbk8l1B8Vc= X-Gm-Message-State: AOJu0Yz8EYsHEU8MuSt6AgkhRhWWSIJ/iYr8z2B6ChIuH6QrPT+qsqeE y2/YvHZASblZmPf1KwhukPjKmiyi4feJQprlf0i0QlXBSvtBGafWSoqdpeyx5DB84CqtSTg4DWB 38Ea0FNQcvIT0vvs/DOYTSGP6ITU= X-Google-Smtp-Source: AGHT+IF0+UYaaN6m0QRKJndax7JXEHR+fygNk1XN64sj9tDZQvEktqzoxCNdUl67Oa9NtNbY9GdEofhoM8AuRFGfE3s= X-Received: by 2002:a1f:cdc3:0:b0:4b8:383e:8266 with SMTP id d186-20020a1fcdc3000000b004b8383e8266mr8069276vkg.11.1709112858035; Wed, 28 Feb 2024 01:34:18 -0800 (PST) MIME-Version: 1.0 References: <84d7cd03-1cf8-401a-8edf-2524db0bd6d5@oppo.com> In-Reply-To: <84d7cd03-1cf8-401a-8edf-2524db0bd6d5@oppo.com> From: Barry Song <21cnbao@gmail.com> Date: Wed, 28 Feb 2024 22:34:06 +1300 Message-ID: Subject: Re: [PATCH] mm/vmalloc: Fix return value check for vb_alloc To: =?UTF-8?B?5YiY5rW36b6ZKExhb0xpdSk=?= Cc: "akpm@linux-foundation.org" , "urezki@gmail.com" , "hch@infradead.org" , "lstoakes@gmail.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 0583818001B X-Rspam-User: X-Stat-Signature: 7t1bm9fbqkfgo79x7z8izg393n6me65c X-Rspamd-Server: rspam01 X-HE-Tag: 1709112858-759481 X-HE-Meta: U2FsdGVkX19VlXs+1jIK9nOrsmLiGW64cWJLHrcOIKgvd8Q8S12iDRPDI0Ll3oc1IbtcydLbzmVWOEJYXgkNxRUw57Ya8xvKf2SMoTm2gXF0UfXC5s2tKTAfqKt80lI9Kfqsgv29I8j4017AOiJ+pmYLmXSRE6V60UlrecGrVHGP3VmCBS4d7nhGAXg1pDMwciFQJLOLa9lx8x0YJraaBNw0so1QVY0FrtJOGEPTKdp7W+tDEoAe0Og6jnUnTD7o8ZQyrVBwewOIQAZqsckMoE4t+LuL64S5KNwIt9L8zMxbTuUAr/6CMkbFcXrSa37O9NZgh2JxbzpzleOwxstFQBXXhA69G2CN02Qrigsxyqi8pKDYiUwZDZYmGJeMxSluWRoxDSX1sb13JHhCc1ZDKKDE8nOhlTeivYCSFbMq/VlZ50LxYtMjxgEmBLo080c2OfIUSkQKi7tbHjDAhf9uXp8bxSqJRtJL7WSjkfLl05Sdbaml5APJDQ0OA4BoYhqGnRQVYNqGax79Ky5I0v5WL0opBMZ62MT86wNJOd9EXq5x/p5DymmJR7m0qF3V3HVYfwAi0ahvczAr1juNivEvwOwSeY3K8yGPGSQSmvJielE/yWspGe8ikA4YkA/UfhcCKYKzOVW99VLh39D1/MdR9voR3nwv5D7gPWy5qCfvusFMUc8tepY51oS8HdrI3rScgkVUyXewX+luWkQBgSoPLvnJS+6oocPzv0OIEfB7wBXt5gKNpNz/0SLayIbQkRJXIC4qLcx7v0f/7zv3836flGWVRagUzjSQiaPRtMtnFN6/YbvhnSSe9QcPvQ4/omftifwikRXLPP/MFrZWVuMMSQPBPe8qgUPtsomGfStDSwD0ooJpFnL5LBTa/6I9Npkkf73A3g+Js6D/2+nPtV9ziSXaEsgvoXKhnIWMIuCKvTq7sCKsvlO/9nhKvpWITXg/YESNiJ03DcDSDzJvIZ0 /KAKI8Ee NQqlaYv4G0DhCnR+w7N70mkAjf6OgXZ1+FDD0SfKTqWi56dj4th2Wl/9dhDadQGQ3T0ozLFKLc63ws+Kva8GuAU7lwLmPA1gozU2tqvMzPLJssWT2aYyhCpvlOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 28, 2024 at 9:51=E2=80=AFPM =E5=88=98=E6=B5=B7=E9=BE=99(LaoLiu)= wrote: > > If vm_map_ram(page, 0, 0) would cause panic by vmap_pages_range_noflush, = so > change IS_ERR to IS_ERR_OR_NULL to fix this. > > Signed-off-by: Hailong.Liu > --- > mm/vmalloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index d12a17fc0c17..109732006cf7 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -2387,7 +2387,7 @@ void *vm_map_ram(struct page **pages, unsigned int > count, int node) > > if (likely(count <=3D VMAP_MAX_ALLOC)) { > mem =3D vb_alloc(size, GFP_KERNEL); > - if (IS_ERR(mem)) > + if (IS_ERR_OR_NULL(mem)) it seems the only case for vb_alloc to return NULL is size =3D 0, isn't it a bug of caller? > return NULL; > addr =3D (unsigned long)mem; > } else { > -- > 2.34.1 Thanks Barry