From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69435C5321D for ; Tue, 27 Aug 2024 02:18:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D77BB6B0082; Mon, 26 Aug 2024 22:18:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D00EA6B0088; Mon, 26 Aug 2024 22:18:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7AC86B0089; Mon, 26 Aug 2024 22:18:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 999B36B0082 for ; Mon, 26 Aug 2024 22:18:33 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 11536C14C6 for ; Tue, 27 Aug 2024 02:18:33 +0000 (UTC) X-FDA: 82496416506.19.6E199BC Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com [209.85.222.51]) by imf18.hostedemail.com (Postfix) with ESMTP id 46EC61C000F for ; Tue, 27 Aug 2024 02:18:31 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RAu5W0Nu; spf=pass (imf18.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724725025; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=siwGY23HicvLdKsR6KM27bLimkfR2eAsbuCl3IO9Kxs=; b=NoyzDy0Q1U1C/8ct+oRgNACu/TbGppVV1oT2Q4zdqx7+1h+rotz971+aZtwDnJBv10N+s0 44Yqay/v+jzGP4pn8PDOSAhcKlb0T8WXYTQre+3MES2wMTJgzqy5G4aYFJqaieuYRx8/Us ZNqINe4aXiwUpe2jlK+BjICeVS20o1Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724725025; a=rsa-sha256; cv=none; b=BqMusrb6a7u9eRXx6+p6wKxkibgEvK1eTD0uUItruYW9aQkBb8X2LXrYZhFbfndac57Him tvadYhcF+o2Eh3nGG4jOR3SPbEGCA8fuF87wmDTIuKzcYWVsMtqYlhrdaWRaxf5sd1zu8d iqFEz95ED4ciEWchNZEmeYQQjiOctM4= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RAu5W0Nu; spf=pass (imf18.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.51 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ua1-f51.google.com with SMTP id a1e0cc1a2514c-842f91f2545so1352614241.3 for ; Mon, 26 Aug 2024 19:18:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724725110; x=1725329910; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=siwGY23HicvLdKsR6KM27bLimkfR2eAsbuCl3IO9Kxs=; b=RAu5W0Nupo3jssidx/k1PRm/poCSWHUK7jFyESkzo03IdidFD+9swxhOvfF+qDQBFP AjboOWjKhLnUVn9KhxYXz2RIR4EC55x/qxTA6OUZoNCSyCFUT7fJbiI7EvLsWvx+uxne Q05p7EF73prPWAOQd/px2liE3tnnFJJPbrWSKRQ8wbNU+VfwJ0VJQiJeF1eO4s/WrCrp tPlCu/2zf4AQwDRHYWgul+MPaAi9OrPjGWEku5jPZdrzKw40wkNAUvNzRr/O11y3mRzd TF9BvipX8YRhFx01x1yZFtsSEQ0L6oFY5WbvRd5Q16I2a4YgpYNSTw0WZqbzkzr74IPA 8vqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724725110; x=1725329910; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=siwGY23HicvLdKsR6KM27bLimkfR2eAsbuCl3IO9Kxs=; b=OwS5K5vmiZvukWLAcJnxbpM6iIe7NrtOgCxCGSwLY0OXKnQIxxjYL2taCwlLWJY3vT yaljP2/crZWIecPCEB5tUvBtcYG8VJGaszZHMMW8Ind3v6D4pI0k1tmb485N4/HE2+xe ZYPd+CtVKd8fygLN6ypjZHs308CSwBpfwyN3wKqafl/sokAxWzJ012pmhIgI8J46E7sf 6hUsVxbqupDstDggqKzLASkueRsuZ9faSGXiG8ApE5cZhouOGxhO50qMlVqr+T2sPTIk AeTStchDDN6l8NjpHTlc1NT+nDmXjg7m+kfSPWVqz1a6WGn6ByEclokzEGj2oIzUaaWs /BUw== X-Forwarded-Encrypted: i=1; AJvYcCX3FSr7pU6sWF0ZY42uRPup/1ajy0MvxuEvIwxOROpZ74f5Tks49jbiFQ9kiSTo2Pbo47oIlTWrQg==@kvack.org X-Gm-Message-State: AOJu0YzpknwQp+82Z2wG63Ed6gZBOO3jSS7P7zL+cFcQUW9Ee+gU/B8Q DqVjLT1qnBKHn9qVYGDjxnIqz9e25guErhKfYGmczWUkarNGbYN+RXC1Q98L3rMdl4TrpwnKwQK OqwnEjZ7qQVpb7AWRjavQOjeQLzw= X-Google-Smtp-Source: AGHT+IFfU6dexOxTYKGD0IqP4V6YvktCXOJAeKUjoJ/4ETcAySvDOxI/AIKRNHHl4Dk1+gNo98G5yZ6BK2o0fJhXGSE= X-Received: by 2002:a05:6122:c9c:b0:4d3:3846:73bb with SMTP id 71dfb90a1353d-4fd1a734ddcmr15194320e0c.7.1724725110178; Mon, 26 Aug 2024 19:18:30 -0700 (PDT) MIME-Version: 1.0 References: <20240827021351.iq6i7zkwm32xili3@oppo.com> In-Reply-To: <20240827021351.iq6i7zkwm32xili3@oppo.com> From: Barry Song <21cnbao@gmail.com> Date: Tue, 27 Aug 2024 14:18:18 +1200 Message-ID: Subject: Re: [PATCH v2] mm: add lazyfree folio to lru tail To: Hailong Liu Cc: Lokesh Gidra , Suren Baghdasaryan , Nicolas Geoffray , Michal Hocko , gaoxu , Andrew Morton , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Shaohua Li , yipengxiang , fengbaopeng , Kalesh Singh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 46EC61C000F X-Stat-Signature: dqbheu4w6fgokdgwaj5gchhokbhwcab4 X-HE-Tag: 1724725111-801186 X-HE-Meta: U2FsdGVkX1/NvZtDzgrZ7Q++rI2WrvO4pNqJwBMAlzAhRUTTneyugmPDkxEf6yCTxqBlW+SVs8vl53+5ho6DF2soQCiEW233KGURhBEN9WcE7fgnIITjEi5rDonhOdtQv+sVJiE1Bsiq5yjR18R5/xODY5BRsHS8sgdBEXDvnKEScNogBWOk84QOBau8tpIA7jOJEOc7C2X/dQgz95nqov3wrg+PWVKDn8TLihBkKH7k8l8pPYpUTTsQFvMtQyfKPLGYT3X8IQmyGBtWWyfwXHUWrPbBe+4UJWnbKOyUNBbbvKUj0W0g7YxpW14SYvxM2YFxgcuVa/kb7eCKpaKHEkXcgWZq/AXFkQWKyHk2um5HZ/ug7FGB3ZiWyxtLvwgXX7XZWewcjTnbeDKOVo8DTnXjqGdOdYqjE08ayCA1ig4ZZtdza3nnBjPWSRhRU/snoOear2BLlQK/9l+QL1i28dhEPYl2b3lbRsD8OJjqJvS0Qmbhx4ZWuEy+mXxqfwNUO8Nx8pz/veMCYtgESL714AhCTX+bD5IzyIVWC+TG7iUhxIecov06T4EipKvNZfaMxxax8h8ss8iOBvRVh6qE03IOWeahUc0d+F+cZ580Eo5+zaeCLonKPG4aiePpfTCD2pFGcpQIonccbJZjJoACK+fytj7uqN8BhFdrZtIVL7lm9WQeEgtRCa0+RW+pSCmFvAPfI7Z88YUkZCl9gH68TFJbPDKB15LOpdc1sIGCodo0JylmoUqLfCms1UWflT9DvNEn21Xw6G20zM190eegyv/GXWoztIDmcSw1Sb6WbcX7z0u9+QFQOolUPbJeU6+a/rbdsknopXvsktPzqM2x0sR8v7U7AmvvZpHD22zXZTVlHHG1hKNJ4eapf59hdgBOs9xWdskLKrmnip9go1nJf6LCByN21hQ78prLWJOD/ZQ1pVBEooA1o+FdPVIzXHM801qtws1XQRkQJhUwc4l l4lT739i YRVXMvvEZzE4FcGnSuLUTCwpQ4ewke5QsB0xrJLYYFpV+Fy4fLXQgpU5mNtAAI1x/opEz1wCUzWsJUqIhCY7WqyCxWevWetTV+VIW9YuqVXAPn0mg/5uYk3m6qLPnTmIAgp8EqeSvftSuypQz6na7Md2HCt30Pln0ZajjWKRbcs1+my567Q+9QPXMfBgp1K0t2WBwyYCqOf4vfkG8Cv3h6eXiTTioe6JOjWx1fEJFjCwPJ/YFr+/N7Dc6GfoHXL9JPh5W528es/taqMTaTGr/F25AQzlBJ+kDF5G3jQitwoUmjtKJHJvvDbm4Fe6JYOYPzGp1ajtIq/4HFZyrUOKVbuiRpFcCLWhOO6L2q39ySM2+WY5kIygQLmlu9TRArXPUXlGr9aJCFKmwzas= X-Bogosity: Ham, tests=bogofilter, spamicity=0.149178, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Aug 27, 2024 at 2:13=E2=80=AFPM Hailong Liu = wrote: > > On Mon, 26. Aug 09:37, Lokesh Gidra wrote: > > > > IMHO, within LRU_INACTIVE_FILE, MADV_FREE'ed pages should be > > prioritized for reclamation over file ones. > > > > > > > > Adding Lokesh. > > > Lokesh, could you please comment on the reasoning behind the above > > > mentioned change? > > > > Adding Nicolas as well, in case he wants to add something. > IMHO, lruvec_add_folio is enough. if lruvec_add_folio_tail why not use > MADV_DONTNEED instead? In MM the reclaim policy prefer to reclaim file ca= che, if > MADV_FREE'd pages directly add to the tail, they might be reclaimed insta= ntly. > Also the benefit of workingset_refault_file cannot be convinced for me. My understanding is that MADV_DONTNEED will immediately free the memory, whereas MADV_FREE will release memory only under memory pressure. If memory pressure is low, the anonymous memory may still be gotten back without causing page faults. This might be what Lokesh is aiming to achieve= . > > So we should know the reasons and the benefits of the changes. page fault= s or ? > > > > > > > > > > > > > > > > > -- > > > > > Michal Hocko > > > > > SUSE Labs > > > > > > > > > Thanks Barry