From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B4F2C4345F for ; Wed, 17 Apr 2024 01:48:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2C2F86B0089; Tue, 16 Apr 2024 21:48:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 249E16B0095; Tue, 16 Apr 2024 21:48:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C47A6B0098; Tue, 16 Apr 2024 21:48:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E2F8C6B0089 for ; Tue, 16 Apr 2024 21:48:50 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7576B140A99 for ; Wed, 17 Apr 2024 01:48:50 +0000 (UTC) X-FDA: 82017340020.07.FF9D80D Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by imf12.hostedemail.com (Postfix) with ESMTP id B9A3040013 for ; Wed, 17 Apr 2024 01:48:48 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GqWWq75z; spf=pass (imf12.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713318528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7SrHxFpWuBTItyVrePiXT24pFyRWs6NH9bSHsOAYtzE=; b=JkasdGGy6Yc0Mlu9ZrpElckdK96Zh1vw9OiNKCxUQuZd9/cJKaZfMqPylkN6uRiNMai5wY fCwNCui5hnQ8CEwgHLemJKvvVG/ipKXJ4Tsa7uSOGy8ZLzgqseGN4RMPlzM/PK82qLw1gr 6CWjw8nxoVO3QziNdwDQAQYJEkVYNGg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GqWWq75z; spf=pass (imf12.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713318528; a=rsa-sha256; cv=none; b=FvGPdqNHt94E+37FXbojwJBLRqKHlZBHXm6mv7AEJkx8+FXXJpJmNj84hPsuMMRxe3b/m2 Iq1CwL6SsaFw78BXksNlFoXF6OLB5Bl6Fr2gLv+C8YMQ4Y2IIzsiN8S2TwPd1X9FwTVp/F hzfkR5IW19kIbhodOuw/mbG4wpBdccw= Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-7eb7f34f36dso444474241.1 for ; Tue, 16 Apr 2024 18:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713318528; x=1713923328; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7SrHxFpWuBTItyVrePiXT24pFyRWs6NH9bSHsOAYtzE=; b=GqWWq75zhcR4dpSu5uj7qdiv0m9dAxMJhx88tqahw0Hl+R9L0fFi9vxFsfXHWIgWux iJvBcVenndKivUJeYPPKVrcnolblkSW6yLOQQHE5wVIhStfi93M1ZouW5Z8kBcse8Uel Ape8YA2hwZQf80+3sRUp9VWWk68b1VlaLJMx9r8ZLP6WXE2CzB1ML8URxwDz8mfErqnX BqHOfhnBDkxUjMfmNAsOTEn9Ib4mja0VwKAYv+Y/Exl1EFxS8JNCIOXlpHY1eM3Jd2YP aDMGym2w5mtfjGi/cDt5uKY4pNJWlgCSp5vHtJvQVkJJAAvJjnqRyUD4m9QASmZ2xVR5 R5Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713318528; x=1713923328; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7SrHxFpWuBTItyVrePiXT24pFyRWs6NH9bSHsOAYtzE=; b=nfEenY4vNFwUxv4x7zlFSayaeyq3t8EZlZl152+f8+8z6EeLPrafOQSrl9KZmu9CQN TcftwGHcyV3+/rLSapA4FyQt9VLjKnMbCq04W5VQ0Nv9lDdwUa/Q2ytYrhBO04jCA4KD +B0waGp2ur/YvMEZPuH7dgkk0A0eEt3Rhjiz5bKWfy90fkpeeISuGcAl1L1kV0iFCcEx kWAdfNnhpgg5Ih6NJLE027Dg/BHQBXwr+efOQSRhaWiyPzMGR/pgFCYAYZxhOXNFXQAW v7QDuY/vCWzWp7h9lL76zYIKsLpsYLLT7bwwuhsi+fZMPr7pJAyXLL4l6GoNH99JUQPs 4I8g== X-Forwarded-Encrypted: i=1; AJvYcCW7Kr5VwKeOHB2QXoEmqt9NT3ftyJYC50rlsyr7lIEnI4r1vEBJEA7xCDUpLvEyMyy6Up+LI5u9qXXtPMMkVcaJ18g= X-Gm-Message-State: AOJu0Yw1oaEBq3qLCONZPjDUumnfhic0bT3QFyBZroxKuJaC60WI1vNy LnlFPa6fHVTJURWL223VcHm4DBEPlhW25L6YEMWrkIvSgJayUDo50vVZanmrx2STyvVts5Osg2w nEs+uVDjSr9lJ41TNdtIeXBc43QE= X-Google-Smtp-Source: AGHT+IF9lpDTjWQIcigPB+h4sbtTvxRRF8oiDCuU6wuf/PRbZk+mTw2Vqu1AkZMGTqLugUpj6sHE/ok2j7k6siFqACI= X-Received: by 2002:a05:6102:e0b:b0:47a:516d:69df with SMTP id o11-20020a0561020e0b00b0047a516d69dfmr10048709vst.6.1713318527827; Tue, 16 Apr 2024 18:48:47 -0700 (PDT) MIME-Version: 1.0 References: <20240409082631.187483-1-21cnbao@gmail.com> <20240409082631.187483-6-21cnbao@gmail.com> <87frvk24x8.fsf@yhuang6-desk2.ccr.corp.intel.com> <87bk6822gh.fsf@yhuang6-desk2.ccr.corp.intel.com> In-Reply-To: <87bk6822gh.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Barry Song <21cnbao@gmail.com> Date: Wed, 17 Apr 2024 13:48:36 +1200 Message-ID: Subject: Re: [PATCH v2 5/5] mm: add per-order mTHP swpin_refault counter To: "Huang, Ying" Cc: akpm@linux-foundation.org, linux-mm@kvack.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hanchuanhua@oppo.com, hannes@cmpxchg.org, hughd@google.com, kasong@tencent.com, ryan.roberts@arm.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, yosryahmed@google.com, yuzhao@google.com, ziy@nvidia.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: zieoxo33te3igd9x3rxje1uoixks1h3a X-Rspamd-Queue-Id: B9A3040013 X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1713318528-475391 X-HE-Meta: U2FsdGVkX1+X2ADiot2hejjr0g4cN4GiTDM0uUiDv14niMu7yxMEYLpmXxZ4bDiRm+Pw4iHsz9RzkwDGf/Ka4QEmMaEnaF21yAraao+Ne7i0g4Vc/dqDcYdI05Gug5NzBPM7z8aSS4caICfCzWvSFwleS7K+MWIDVMdqMad/xOOlg5WR1pVx8ysYrnwuBX68VE9Fmlk3q+EN8smYwn7s7iqTYkwrR6Aqwrn6w1GcIFBL+/GW12txdoRR29H2lorY82eQhbkkY28q3zEZcUtbBJb6aUBgQUq6FLWc3FjQizqR3cVdzqAw3s+p5myJUkfBQWC6prFMskG0aStb3LqsP6viqexp8c7PiwEaR5EdpWtS096g5S3sidDe7A00Ou64ImgQtwLRiZIfJDzYv7omyjn2rgSRdDw+zAGLga0rgsyexJ0JGD+fRZIh2Aq7Uj/mxYAGp2F4C4AeO/DqpqTjE5R1AzF36yaG4NUkLR29ijRbI87u/BjPMYyhnRvKM2THI0IGhd9CpjZkMQ+T2Ju7WO2yFNgbrAIMcahZEV2Cvamk+s3g6ljzzKq7lpEJXfiuoUe96T2DfCI3trXVmJMuuhS02G0QfltjQAI4cO/jpH8hNxYlNFhH8P1QkUT+eZMSNI6WunSxSybcSTi/ojo5Up3PnMpAspiMjzYtt54H7PnjJMJPm7EH3gMweii9wCvk3OoOvgyJHrgGCMvAzS1BpCxsw/Svofg377xN/V8fkqf12noqiJSf/E78kmcX/G3GTA/4kwRrvOyp3bNdm1Zp2/NmHocFe7W/K/BVJr9rpYIAYAhBg4PwROgnDyCsVbe7GZPq6iyCZw6KazzEyaJ/wDQzep1/+v7u9P9w7Ba/XjsoQZ18+U6dBihHe9wOqKkDvKA0D0LX56wibL7n9jJaSA1pniFwJHAda4TsPmQKGjjh9K2C8eE6rdrHZYeIsixLA926E3wWvBRAueYlLTG 6eJMDK1m pZbM3l+oNVDbXtSZSEMswdJ4nmA7nUy1peX1BXkodL41LvbztV2syKeSXu4zVpxixAoRUh6y9egcSnOCmwg+6mHii0/VIwb0vcW5/YjYgSb6YDeoATKKJXBdaXpDBbLNFv8s2PxL4kybWOGt6AffDmelUPycf0+7vOpLmAAYFV0TFvKAPniZKoCLdCOJQizfx+kmt5VBNPJ3p0cDyE/Fw4D78xMaUVp4psrIhxoJxniIx36bMXZzwmBusAgsIAH7u66Q9zkNZm1a3NDU3g8p5cI2PwxXLFgSa8ZSVI1koewpa7+cZ9GteR2A6HzLt7t2wOzH4d4UKKgt7lV8rzH0PJDb1uK8Bg2Ez0lrJFJMBwT4z5vessDD+j+2NMRcVpVa+Hbt8pN9WFBSC13IX4RDiTArZJ8ey3qJD8CTFQzPBEzkOyomsVkpiHgu0oKIqJIdMVIoXm4RBn+XuWg7GkfqzSNFGWkoe2bL9yVTxVkiPqgUTU6NOZJuSJlomYNDkH3QxIMImCi1j+gZrUv2zYendaGwWsA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 17, 2024 at 1:40=E2=80=AFPM Huang, Ying = wrote: > > Barry Song <21cnbao@gmail.com> writes: > > > On Wed, Apr 17, 2024 at 8:47=E2=80=AFAM Huang, Ying wrote: > >> > >> Barry Song <21cnbao@gmail.com> writes: > >> > >> > From: Barry Song > >> > > >> > Currently, we are handling the scenario where we've hit a > >> > large folio in the swapcache, and the reclaiming process > >> > for this large folio is still ongoing. > >> > > >> > Signed-off-by: Barry Song > >> > --- > >> > include/linux/huge_mm.h | 1 + > >> > mm/huge_memory.c | 2 ++ > >> > mm/memory.c | 1 + > >> > 3 files changed, 4 insertions(+) > >> > > >> > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h > >> > index c8256af83e33..b67294d5814f 100644 > >> > --- a/include/linux/huge_mm.h > >> > +++ b/include/linux/huge_mm.h > >> > @@ -269,6 +269,7 @@ enum mthp_stat_item { > >> > MTHP_STAT_ANON_ALLOC_FALLBACK, > >> > MTHP_STAT_ANON_SWPOUT, > >> > MTHP_STAT_ANON_SWPOUT_FALLBACK, > >> > + MTHP_STAT_ANON_SWPIN_REFAULT, > >> > >> This is different from the refault concept used in other place in mm > >> subystem. Please check the following code > >> > >> if (shadow) > >> workingset_refault(folio, shadow); > >> > >> in __read_swap_cache_async(). > > > > right. it is slightly different as refault can also cover the case foli= os > > have been entirely released and a new page fault happens soon > > after it. > > Do you have a better name for this? > > MTHP_STAT_ANON_SWPIN_UNDER_RECLAIM > > or > > MTHP_STAT_ANON_SWPIN_RECLAIMING ? > > TBH, I don't think we need this counter. It's important for you during > implementation. But I don't think it's important for end users. Okay. If we can't find a shared interest between the implementer and user, I'm perfectly fine with keeping it local only for debugging purposes. > > -- > Best Regards, > Huang, Ying > > >> > >> > __MTHP_STAT_COUNT > >> > }; > >> > >> -- > >> Best Regards, > >> Huang, Ying > >> > >> > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > >> > index d8d2ed80b0bf..fb95345b0bde 100644 > >> > --- a/mm/huge_memory.c > >> > +++ b/mm/huge_memory.c > >> > @@ -556,12 +556,14 @@ DEFINE_MTHP_STAT_ATTR(anon_alloc, MTHP_STAT_AN= ON_ALLOC); > >> > DEFINE_MTHP_STAT_ATTR(anon_alloc_fallback, MTHP_STAT_ANON_ALLOC_FAL= LBACK); > >> > DEFINE_MTHP_STAT_ATTR(anon_swpout, MTHP_STAT_ANON_SWPOUT); > >> > DEFINE_MTHP_STAT_ATTR(anon_swpout_fallback, MTHP_STAT_ANON_SWPOUT_F= ALLBACK); > >> > +DEFINE_MTHP_STAT_ATTR(anon_swpin_refault, MTHP_STAT_ANON_SWPIN_REFA= ULT); > >> > > >> > static struct attribute *stats_attrs[] =3D { > >> > &anon_alloc_attr.attr, > >> > &anon_alloc_fallback_attr.attr, > >> > &anon_swpout_attr.attr, > >> > &anon_swpout_fallback_attr.attr, > >> > + &anon_swpin_refault_attr.attr, > >> > NULL, > >> > }; > >> > > >> > diff --git a/mm/memory.c b/mm/memory.c > >> > index 9818dc1893c8..acc023795a4d 100644 > >> > --- a/mm/memory.c > >> > +++ b/mm/memory.c > >> > @@ -4167,6 +4167,7 @@ vm_fault_t do_swap_page(struct vm_fault *vmf) > >> > nr_pages =3D nr; > >> > entry =3D folio->swap; > >> > page =3D &folio->page; > >> > + count_mthp_stat(folio_order(folio), MTHP_STAT_ANON_SWP= IN_REFAULT); > >> > } > >> > > >> > check_pte: