From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39E69E77198 for ; Mon, 6 Jan 2025 09:04:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9DAA96B0082; Mon, 6 Jan 2025 04:04:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9896D6B0088; Mon, 6 Jan 2025 04:04:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 851FA6B0089; Mon, 6 Jan 2025 04:04:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 68CD16B0082 for ; Mon, 6 Jan 2025 04:04:02 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 02F191413A8 for ; Mon, 6 Jan 2025 09:04:01 +0000 (UTC) X-FDA: 82976439924.23.CDC39A4 Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) by imf16.hostedemail.com (Postfix) with ESMTP id 17FB8180010 for ; Mon, 6 Jan 2025 09:03:59 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EGMGXyIa; spf=pass (imf16.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736154240; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eFxTtDgk1DzZsZQ3ygFGMHqYYaI93o+Qf7G7yIH5Azk=; b=cInmBeM8EBSDsKdkP48eFVFI8MjtkneTJoa7FT8ikR1cc6za3ooGSq7A3HoZPvhq27WGNK MPmYxOaszAkhuFF0r3s3W+wWf0XkRIPUhOi1j3ZBv1ylQAhzb5cc1z0SUzzOM7kIuD2GPy g8iNdz36gRGdwwj3apvGDuTbYBRRll0= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=EGMGXyIa; spf=pass (imf16.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736154240; a=rsa-sha256; cv=none; b=3rp/atTmWlmpEb+BHHYHbhAXyaT/t9UF9OSCR291FHlofA7DfjbysrN8vEXE4piCY3fdkG SX5m6n8IZQcl2qPIEQgcxU8VJxRZyKm9zG1YEWT6wYDubOAVidgXb6jxWXqqjb3iwxRVRj nME+Fri6ubGFNA5fWMtg5EkBCqHvzqA= Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-85c4e74e2baso2592041241.0 for ; Mon, 06 Jan 2025 01:03:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736154239; x=1736759039; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eFxTtDgk1DzZsZQ3ygFGMHqYYaI93o+Qf7G7yIH5Azk=; b=EGMGXyIaPGN3jN1tMKOvQRj82YKLRw6Jevp5gqOMDRkbS/xBsJ4t2iwgjtws7H+TNx /kWYe8vRVZdOpIL1cBZwa/2PdcmlAwPUPbDt600aflwR5i23/MXhDBfxtxJ1dHAlWZ2Q OBum1Op7kEuIowwZ8VI7tRO3L2Jhx8xUnVq7pXh3yL2RGTbAhiTVWPL3nAV0A+iU/A24 onxGHo6w6rkrEQpQ17z8dRSCs1wfHJdgQ6G2a8e0BYzXCdtBjgRfz9b/CQyAppzegZO2 qZNugLDjAhyx0KFIV99rd6k+afisOwslxX9tZ6DJWKazcXuRK/7qRaYk+7mtOUPxd/8a Ht/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736154239; x=1736759039; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eFxTtDgk1DzZsZQ3ygFGMHqYYaI93o+Qf7G7yIH5Azk=; b=OMLMqmUmGLvNcyeoui/8AAFagCZ/VKvQ6DRXdBgLBst5WWXxxZUboMITpFeo/tYrnV lFTzVe3TwzTWwK/iNWE/Hqhjz4M4wl700z6Xa3CptLpr6aB9VJFO/YdhEyctuaV2c3o/ uf1+P/8LbNu0UuDSQfU1lwFOjvdUjHJlDQFpxix8E566HHIuJpRYgI9tbRD9zNyAwrpd 69xkGaRewWR4OvJYSVdth2q3ImaNT4s9gOyi19R9ZMB1BURGiiEtikMndgB51jM64Y5h 9Ac8NWzSTTr1bF0RnEvPGn9VOK5J0QX9n/67JGc8kYdnmKUJPSy+stFH6ytB5PJSNIiz UsUw== X-Forwarded-Encrypted: i=1; AJvYcCU689c9fvJwYAOKrCQWIe8JqBvpz3imSqexcYUHlOiX18rzXWsxu5/VUEBr/cHy5T1UQ3Jc7UICDA==@kvack.org X-Gm-Message-State: AOJu0YzfqWhpY0D7CIqwXg5WzJiydxXCHUTHQBUsN0CdbViSY0GXmBZl iEtJiO2BJJr+QcGMwSVRMrJ4OznlDEpD04SJXgsLfRsyKhQS3hx5D1eVmU7p/JTF9v/ge/RDZ3I tMuONuFvNB2IfposlIiFV6S26ioc= X-Gm-Gg: ASbGncteCPNS16WsgYT5fEEvdMYhtXS0A0UOPkXLLDzipnL4UIHhlix32hkTkqfaM02 aVgVSOg2G+iEYh2tVwpevsymLr+9aTgB07+bAT3Sm/G/tGD7OJLUh6Y3XMEjLw3jOYGsbbCGm X-Google-Smtp-Source: AGHT+IGwF5u5tAifgOYHybaFWllpmt6FYSuR30rbFw3ny0sRMYsqv6sxNn2xOvl/ZEYg65NFBsY/fXPifuwkCo/Lph4= X-Received: by 2002:a05:6102:508d:b0:4af:e0d4:70df with SMTP id ada2fe7eead31-4b2cc49c342mr33101717137.27.1736154239114; Mon, 06 Jan 2025 01:03:59 -0800 (PST) MIME-Version: 1.0 References: <20250106031711.82855-1-21cnbao@gmail.com> <20250106031711.82855-2-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Mon, 6 Jan 2025 22:03:48 +1300 Message-ID: Subject: Re: [PATCH 1/3] mm: set folio swapbacked iff folios are dirty in try_to_unmap_one To: Baolin Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, linux-kernel@vger.kernel.org, ioworker0@gmail.com, david@redhat.com, ryan.roberts@arm.com, zhengtangquan@oppo.com, ying.huang@intel.com, kasong@tencent.com, chrisl@kernel.org, Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Stat-Signature: mk1o7mzn3ncpa4m8bmbwfryjk7x3wpb4 X-Rspamd-Queue-Id: 17FB8180010 X-Rspam-User: X-HE-Tag: 1736154239-734651 X-HE-Meta: U2FsdGVkX1+jjlsyyFIyo9i1W6Sy7d64IFYVzmlJk8PNZgK+liTT+i598HPAiKrm7WBcLRWzoAtoxxF18NMqVF0XTOo7URY1afGXv16sT75XS07fcPc2Mu0WT/FlZvpFmwzgwRKhVqr2e6lsy3szSq9QN7MYP5+A4YPSDi7Fyji4WXQi1d/NPFcAwbDz5WDCCyBbF6QZw2KOOFzMSpXBbZ9D0DugyWTRR8ijJ8Us1dRS+JaoJvwyH7dPuJLlpdYjGLo+fXYOzpp5oljBrjkcbIqKP7R199pcQEk9ZsHxTDj9tqbP4P96hs6glJVHSsFnNbYirUUhdr/Qj8i8dXxA00Wg/HoA6j6oBU+sFWqHDkktGAYEZSA2Kr5nvTRPvdIseyg8OAcQhAbECzYIE6wsBAQSubind4In5fnzvd0QrTCDoURYSN0gJb6ZMWgAsviR2SlqWV7iId15BHMkRlutvMBW2JZxPZdBWAuS2oNZ8zTPsAZ+0BlmDtYMmtKq/PUdbHXj9EFBrunqXrl3JMfQKmfcC3LwAfaRsuNtshK7UtZentkwSoF/sfrzQqJngjYSAlcXcTe5i2N1rdMOJ+AGyZuOwf9zFd/PywLc5RbsarQ9fZbCEwsAO62JCVN1CmwdQ1DYxAgyWiyOWlqkqCts/NC0VJLQjK1x0tgAIsf8PodrTBI7ZINoui3ux6aBCxnzjWNTlo5au0PgWiQTTVgAeQEVpLiTCnEuPf5U7O0kZvTK4YlZ7wR8FIja2oKm5EAGm6/eihFGrmplkcuIHFgyl/omTvFjcv0Okp6igYTrNMk7+iTS+BQAcH44viEaHgGFhYADg93iNQVdYgy5QM8C8+mgcwLbsK6apmL6Ou2tggfDA895eqAQofyW19vpdKtl4Df2yoSM/WMT8y/5vpNSCNTeUPC/xdFEtepME6ipu0qZ7XgmExP0xE/nz7wTBenXMlrwrJc6HeXHAUho5wc 3KzZKpPO cXmpPBEWVrQk8Y0aLjwccnKdvdm/sEkUNVmvzSjahu2LWgNpEk6AH6xFYei14tRBpt7u4i3vB9IAJxs8qS+vxZ+2bskkSzc4Ifde0/buZQE7jOaccfFufPW1yofZgJH8mFYfTDcsR9mTxlRGnzQFR/qG1UxT7lCBtj8PHz1qcDDmHRNFv3CZX3hxVjRIRSQ4BR1zi8mpAxk69K9kRXmKn8yKB+yXXPfVf95HzdIpr/yVFedmy9GmFwTzL2dImCkxTz2MyJ9BwhUvBp58UUop3Yoha/C0z9Q8+QlaoteyKD9IAl3sfh4YiUeLdmp6x5l4N2REwvrQLkokGwvl524ldDrofVOR3AGYMSxGTUrhI10zMmiC5NB3ey6r74T6vsUt4bjjHJIoF5N8ySC8SG44TfwSGvQj6f1vGP4buLI2HboKHOuMVEhIiqqxPVQ== X-Bogosity: Unsure, tests=bogofilter, spamicity=0.479326, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 6, 2025 at 7:40=E2=80=AFPM Baolin Wang wrote: > > > > On 2025/1/6 11:17, Barry Song wrote: > > From: Barry Song > > > > The refcount may be temporarily or long-term increased, but this does > > not change the fundamental nature of the folio already being lazy- > > freed. Therefore, we only reset 'swapbacked' when we are certain the > > folio is dirty and not droppable. > > > > Suggested-by: David Hildenbrand > > Signed-off-by: Barry Song > > The changes look good to me. While we are at it, could you also change > the __discard_anon_folio_pmd_locked() to follow the same strategy for > lazy-freed PMD-sized folio? it seems you mean __discard_anon_folio_pmd_locked() is lacking folio_set_swapbacked(folio) for dirty pmd-mapped folios? and it seems !(vma->vm_flags & VM_DROPPABLE) is also not handled properly? Thanks barry