From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C09C28B28 for ; Sun, 9 Mar 2025 20:44:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2B55A280002; Sun, 9 Mar 2025 16:44:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2642F280001; Sun, 9 Mar 2025 16:44:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12DF0280002; Sun, 9 Mar 2025 16:44:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id EC889280001 for ; Sun, 9 Mar 2025 16:44:37 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 65C1AA5AE2 for ; Sun, 9 Mar 2025 20:44:38 +0000 (UTC) X-FDA: 83203191036.12.2AD9616 Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by imf19.hostedemail.com (Postfix) with ESMTP id 8B0B51A0007 for ; Sun, 9 Mar 2025 20:44:36 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="nOU/a4fQ"; spf=pass (imf19.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.175 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741553076; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yvrDsI1J3tG/TSDdED8w2Ch7rRwrU6CBDxBSV0mPWdQ=; b=nNSWoPGge1eXHdrmUJoLL0p8EYw99JfXkgNwQUQ7FpTG6rCi2hfpEWI7IeN5wpR6YV7s2c xnODpTOlrwQ15ozoFdIMr8RfrKrOcabI3JY0AmE3FrGWuKV9e8kCSJ+J76XbuwynyDyrJA Vhez6nh3WQYNaH45F8Db7kXQRwj3fVk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="nOU/a4fQ"; spf=pass (imf19.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.175 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741553076; a=rsa-sha256; cv=none; b=AE/8K4JnjTuEB0aa6GGT4HDgeHrn0dtHPhmR27zNb/72H/Tg6hActHLc13PbYmUUoOmxXZ x0AyMy+rsloAIx7/LcSxpU7FnacFVvNd2sFarqSLMhrFXbaamQB/9wA5fGaoPoQ3avVkm9 W+XLPVFvbkh7w1gd3ZtDe+UCYgebyYE= Received: by mail-vk1-f175.google.com with SMTP id 71dfb90a1353d-5239b9120f9so3636738e0c.0 for ; Sun, 09 Mar 2025 13:44:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1741553075; x=1742157875; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yvrDsI1J3tG/TSDdED8w2Ch7rRwrU6CBDxBSV0mPWdQ=; b=nOU/a4fQMfsP7tWMNiNg8LwxOYOKO+/0BFP5zeRXagsOUVN4Uz/4IIxgS715R+kXnd f9l60JMijr34KMmvdcRnRerwjdL3xKthRvrH6z2lFVsCmH5z+/ctPTjyM3Ig0Am8htNO PkHnZF7yaEG3Ogz5yssyHqTwtOwDexC/vj7mw4ezskaEaCtoiqVcX0Z3EOLEDBLEobw3 e9lNvrgNzbNTBD6dS0o6FTELAm7kvTuiLzdia8e+pPq61MKAQ3y0D7Iv8hBlYTsRzCYw +jWRngaBTFwKUs16Wf4q9i1JK2ZOZd/OTk+kRgYKJiOjkm0oiaxXCpnZXdFwvwSZLZeb mgiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741553075; x=1742157875; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yvrDsI1J3tG/TSDdED8w2Ch7rRwrU6CBDxBSV0mPWdQ=; b=iDD0/0EJ30Ui4t/RdObIYaLDQoOACbps6TUUlpkaH0g7kZitBxF4D46CdeyXNxHiZR pC4UYy1/ndiAroYWZgMZs0RDDCN4x5jSpK9wB/3dNxydkBq3hMFuo98bwHLHyLnJoMMl /1xE3Z3fRQuXApenAb3pFdgrIBCHv2Afomwvgt9DpFB8fh01melfH7of8pU785lsaBLj prKxk9r/Ug/5RDI3PCaBGYV+ao8kRzPr9VcRVKPia79odRJy2U59KjdHHZLrdDL0tQKR z8Fp4PSd3PG+4LQUrlfmihxJATMkl00DrLM8t3nHx6LEnBSYVngqqeG55Xfrr7FLJAkJ /OGQ== X-Forwarded-Encrypted: i=1; AJvYcCXPxC2mwCXU9FMmUMMf6Vqp50m5FDWBrjGzSpbFy6RIZDBjBqf4HQTLArvqYhIRfRehsgTJ+ZfxgA==@kvack.org X-Gm-Message-State: AOJu0Yz1SZe7Hv/hn5lec4Eylq1v2Z3JVnRGiizk8n7mOloTtwOuR3Pe HESgTsv7wIuEuA12C4CZZPo56jJ/lAYWn0es/rthZgfXPugueIvS8353p9gvIHYYGUC7SVVJs6i VMHBzAe9U66Heu23VnqBFIWocicE= X-Gm-Gg: ASbGnctK013164gN8V5pK789+h5EV4hYz6ddHWYEVVeO0hYTEt7Rzr+LFQaJXTNsjJg ti9b4vZXyf/HYyqHSRO4YY1vjWGtM8egAaSryYVb4aXnKugXpKur0fZTifuizxy3VAkJz2uKFCl 4iKXc0wJZoZQ0gTKq7wdxZN9koNQ== X-Google-Smtp-Source: AGHT+IF4rSovFL92tiVeoNmP5FW72Wgm2iOpb/wwZFrycgcomuo9wT0IlSjS9+PtPLBPjoTIr73RgtmsgZ6scrTwal4= X-Received: by 2002:a05:6122:54b:b0:520:4996:7cf2 with SMTP id 71dfb90a1353d-523e417412amr6593147e0c.10.1741553075580; Sun, 09 Mar 2025 13:44:35 -0700 (PDT) MIME-Version: 1.0 References: <20250307120141.1566673-1-qun-wei.lin@mediatek.com> <20250307120141.1566673-3-qun-wei.lin@mediatek.com> <20250309010541.3152-1-hdanton@sina.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Mon, 10 Mar 2025 09:44:24 +1300 X-Gm-Features: AQ5f1JrAaeOU1N8syinZxuUc9DAB-NUSYostf2nwMh6oACAXHjD8P521aBmLDzY Message-ID: Subject: Re: [PATCH 2/2] kcompressd: Add Kcompressd for accelerated zram compression To: Nhat Pham Cc: Hillf Danton , Qun-Wei Lin , Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 8B0B51A0007 X-Stat-Signature: 1grm94wrwddoxqbrak1robpkd8hw4jwn X-Rspam-User: X-HE-Tag: 1741553076-184463 X-HE-Meta: U2FsdGVkX1+laERwQH4E1gdaai1ZodwtQ4RBTSjisN2HATrxAsj3YLRN5QUv5updQZlxWKcOxGrT5bgTlQUnTEoAYSJebAeS7opxG5cMFuXyrVl13q/C+uSsbmF5diR8oa+XJKotmD40xi7b4AbF11D8oNIB4pk4SpCIVAJsmc6/qESl52reo4mLMUKwa9nOnkYCUtx4vj5jZKjImL9Rj0ocwIm433uj0LovX6jyhWg+Au1dAx9WsdnohBbfa9YXV5QzPP1WnG9Cgio/W6dZcxNuvIuNFLSOe1LmqoMIX1xI4Bix70btWyfKUsQ6CWH7tZnGe12vsuYDuuu6v2MR69XrfGQEj9LPfV3ITUAk6eh6qig+h6jHx3YUYWkRxjs8+Rp+R44RlvL4ienuiARWch+854kbtep+epwJJKyAAJddHJZXdLviJyHM4mORMb+LY5Xy2z7LewXpXHfh0fVcUDCvkTDvjhyJE10LeeRjgZCOw3qMWoRC2fgxDnDIihovGXDvlcFnBLvXygDcQ/zDROW2wHmMWJoqeo7mlXuFXzi37HO7xUiHvpl6azyw1f9LaY9aKMuJXCPQmGRcRQ95ntprXNiUNTxg7Em2M8FRBC5QG1sro1r4uFoAATnNcmrxxOhgHbJ+x1vCZ8Vy+N77CP6Myzb0PbO3sBqP3qh440VteSS2h9s8F0VR3/UhB3btnvsjr0omvzcvet0OmTlfncT/2jqeeJ62Xlu/kvp7fYom/YdjUCxClWdJeP5OlhZMojGyJaGltYAhDrcF6zgOFLW21gHne7WsNmVJGOZ3PoRbCpbRkOXnTttjcY+fkXHvz8vT1rgpFG5g4dPY/jwreSD5aO15PbwFqBm0Lk8qRrh9NK2iJWHmiCUI9eb3HEI1U19DzNgvfcYdOi+raYRqBzbDfnOjOTxk1OTwfKy1dxvlIwmDSlLqHfHeue9h++ykRuixewqkb3p7pVBPb+e NqTVicvb ltGbhGeBXKmDSIO6pCspUsWGX47qhzCENfM1Hb1hJ5/752geW9ZRphrfybld8XqmdR2zYCxp0He0xbb7w2IsZG8tHTyQMM3CNl9BtNxDnXwvum0+OUhF6i2OS1MvpzybK8Ll0at4Nr1fcbNTVl5M8z7E+NeJpw04h5PkGFrMMNPVce0GgGGmw0P6XMOKcvDKmSwDeBHcoalFtM8rJS/d9ahbYXJTikyNu/IckHkPF4g5hBpckQpaaU8Do0CR+/CLMz7DQPAgCFQN0m6XBixl+a3Jo67Apc8vNIMasD5pLh3hnuS52+P8qPGjDqEhFzL35C17ENIZ2cMtoiZKtpfHrfw4Ib3P1vzSy4A1nVn8hfnsWLvc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.026112, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Mar 10, 2025 at 8:56=E2=80=AFAM Nhat Pham wrote= : > > On Sat, Mar 8, 2025 at 5:05=E2=80=AFPM Hillf Danton wr= ote: > > > > Could you explain what nr_kcompressd means, Qun-Wei, to quiesce barking= lads? > > Who's the "barking lads" you are referring to? Please mind your language. I also feel extremely uncomfortable. In Eastern culture, this is an extreme= ly vulgar word, more offensive than any others. I strongly feel that this violates the mutual respect within the Linux community. This is a serious case of verbal abuse. Regardless of the existence of nr_kcompressd, it is still unacceptable to invent an interface that requires users to figure out how to set it up, whi= le kswapd can launch threads based on NUMA nodes. This should be transparent to users, just as kswapd does. void __meminit kswapd_run(int nid) { ... if (!pgdat->kswapd) { pgdat->kswapd =3D kthread_create_on_node(kswapd, pgdat, nid, "kswapd%d", nid); ... } pgdat_kswapd_unlock(pgdat); } On the other hand, no one will know how to set up the proper number of threads, while direct reclaim can utilize each CPU. Therefore, listing nr_kcompressd does not change the essence of my question. Thanks Barry