From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B88BC54E41 for ; Sat, 24 Feb 2024 22:33:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 545FA6B00DB; Sat, 24 Feb 2024 17:33:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F5F86B00DC; Sat, 24 Feb 2024 17:33:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BE346B00DD; Sat, 24 Feb 2024 17:33:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 29BB46B00DB for ; Sat, 24 Feb 2024 17:33:56 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F3F0E40439 for ; Sat, 24 Feb 2024 22:33:54 +0000 (UTC) X-FDA: 81828151188.08.4E9198A Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by imf15.hostedemail.com (Postfix) with ESMTP id 3613CA000C for ; Sat, 24 Feb 2024 22:33:52 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=F5cnKja+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.167.174 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708814033; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l6gPHmRlLFFQMWkc4uxPzbDvlnlcPP+R+SMH5i+OHHA=; b=4nuaqTYwwDePxzNMH8YRKusSo26uAFu9mn+/QQpX8QWYrYTmnmcDECQ/93PkQgloO2v9QJ r/6CJAGB/8dhJ0zj0X7NME/vt4fnlX+JKMTM3VCbQVQncfUmS1McMG/Xm3bNEzlY5Tnkwu LIT4nolpUYT0jdE7SoNqZtaEf7E28fc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=F5cnKja+; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.167.174 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708814033; a=rsa-sha256; cv=none; b=JMpgBuY6I0eWVz0UbJwgsi1rSyOEpfgAc4JhGwwRf8jkvfQJWuYhAY4fv3YaQQ7kNKXsl1 lN7LEo0YUjIQrmdzkzEDpbSQxJU1pl2pKFnmcVKVHYnRnwCL/y25Xo1ORwm9nbPUh7/rUj QJYoc6jxO/K0CLRDUPXl2AKEAXMLwIk= Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-3c049ccb623so1806933b6e.1 for ; Sat, 24 Feb 2024 14:33:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708814032; x=1709418832; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=l6gPHmRlLFFQMWkc4uxPzbDvlnlcPP+R+SMH5i+OHHA=; b=F5cnKja+g53b9L2SWAyyNdQZi1+0u6QWSvF9H120pnbDpj2p5PBJH8GjeCxY21r3Gw MwG3kmUvmv1a1pcdCtVB2FIvcnuW5m5GBYVPcp/Ae3A4eaIWP6NF8F+YgkqlWG8/uIMS 7D+yrW3eV/eKUQhaw5Z3maMlxdph43HBk2SKRno0m7l4kqMqGI6H9TbKOQr0ubpGO0Ok KZfKq3wNN44dOrvArVjujj8z5LmwyLs178OKHL/Aq9Zlb5rwLPFJNp8XDN+cMvBLXXlI DIkwYWZY+3prqmYvPfSZCAJdGB2QUoqDDZVkjQ17GpcXWQX2z8mHBzrPNJjieEtm7EEQ vu9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708814032; x=1709418832; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l6gPHmRlLFFQMWkc4uxPzbDvlnlcPP+R+SMH5i+OHHA=; b=ch9+E9s++HfJaxv1mrgV/0Lw+Ix7WEd2mG5Hcr+T+3Y3s1LTIsXhUXBLEASK4c3ytv U/qVYH57zAwZfGAs+KLXrBtztoVt6CEDwMrMEXb1mHYidsTSKE8tdlqygcgH6kcdtqAr BZkhmrOMaM3wwT4T4SFAqltq3Sfpj5cCsS2fOIdLqiIdUdxGYDM6CdDvmdZqLzrKAZ7t HvA3REsQUGaguV/0i2C32qSjZp7JpLjz09ej2ESDBnoew9t8YjGS1/P3i2n+/VpyyWan aB0kSULGSmZe4oCmQ8jp9TecjcqXNcO3TOoZgmFZHvozZFcsVf9GMzi7JU0YTpbe1EhS 1YhQ== X-Forwarded-Encrypted: i=1; AJvYcCXAaKpQHOIFTHM+g1eGfjGS8iqs1+/fGVM38ZlmMsWJrMkCjQLYHTueTeYG1Ia0l6AG2RfdfZ6YGuuZqZSiCo0VLew= X-Gm-Message-State: AOJu0YwWY0ZsOErzu3RQar6dPA5wIEd5Pn4KEwYJrtX7XXaGp8bVDwH+ 6IxgE539ew8dlwJz8wfw/SJch6BHLMxHJi9oW/J7FZqVDI7btB6T1SWYCdigw8S/S0abm/gwizq nK5KinpTg5L6xsCHi/Ux24zJnUYZJJEeeeGU= X-Google-Smtp-Source: AGHT+IEixbNflSAfDemWTfeO2tzJy5oyppYUIZrtnSDDjXS2qZU3KwpIovwEEi3NVJMYFTxUs4wxrPGKGjadb4aHu9Q= X-Received: by 2002:a05:6808:238b:b0:3be:a516:6ed5 with SMTP id bp11-20020a056808238b00b003bea5166ed5mr3578004oib.57.1708814032281; Sat, 24 Feb 2024 14:33:52 -0800 (PST) MIME-Version: 1.0 References: <20240224215023.5271-1-21cnbao@gmail.com> <20240224220819.49277-1-sj@kernel.org> In-Reply-To: <20240224220819.49277-1-sj@kernel.org> From: Barry Song <21cnbao@gmail.com> Date: Sun, 25 Feb 2024 11:33:40 +1300 Message-ID: Subject: Re: [PATCH] Docs/mm/damon/design: describe the differences for pageout's virtual address and physcial address To: SeongJae Park Cc: corbet@lwn.net, linux-mm@kvack.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Barry Song , Minchan Kim , Michal Hocko , Johannes Weiner Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 3613CA000C X-Stat-Signature: riy1sq3cmohtybdpketowe6xpfyyomia X-Rspam-User: X-HE-Tag: 1708814032-507903 X-HE-Meta: U2FsdGVkX18m5jTwS5iv+CsDexDFSsr5f3ZBmZt4KcZoP/WlIZ61qTifC6/9x7rmLldlOTNObwEcj4S5jUP2EjyFgOqOMaGW63ENzsVxrCbD7Ep+tB+bcP1VThGdOlxWLZO1AyAQCFZGH2SudWZHlDn7V3ESSGBB7u1kx4QOkwr70rB4bCsXzCuxWOviyeq2ROQOScyk8ItBwsDkbqxpYcYw05ywsbGhhMb9D0LpCr1T0knF3VBsRFEzOtlvaUntskcVnp0Uc6HEggZuABZkIUYCnRh+/YlbY5a0BoVeDHsEmiA8w0Q9s+Ofh3bktcfvaxOlBVpJY+lM/2gQrsNOs+UeZ6Kvec+f4aLsKd4IhWzBatjiDMqGS7Z73V70WZAKJRXHLSAhhXzZe/KBovS2fZmXf06J+kodJ9nOZaeLrHYkOT+mGhrRRSLj0/CcVykpMET7mbf+QCPfQN6D0UDGCgJrKTEME73iFaPUemczu24CKMS9Y1vQ4HD/8+K/oY00u+KA43BCZbu1XLk/Dqcr75afqCdyHYRXUOu43jwratWRIf04N9tv9rzTWQEku3K4VVjkVQdXISTBaaPiD6PxmWYwmAILYWDQg7g34I7/UDfxVFBfw1MQF6ZB3/b3H7jQ0k5D/rFJCVQlHD6W89o/1fapaKxwOEyiwz5Z2ZjYYEE4EwfHkLMOI4KBw/0Putc6z/y828p+Ez0oid9cMx2VuyXZbGsK5u0blOq7EpVTMtuMCHF8DRA+SXnbNJicc/9/LYagTSj8luNnuBr1IUqqhi9kj/0seiwF2x0KDNcgqhxKGt0U+d4KXobP6/GHVnaGpFN/49JkvJWTRpFOKPs5LkkSRUp2JuaQBpzJ7KLs2Qfj/5nFPahoaum8gJRXga1L9GAMaqWM+Xu4SXFwkkK0bUhTM/NwcFJl7bxKnthQkXl83mKgq0bp45N6acQozKTsNPYEEWtq2+0GAog/Byz 7Oqpipcr igPkB8jm8jEJ/KPc8YBe2FR8rFSDeFIPSgL/nTMtaD3uzwpLTA1O9f9WekFv+OIwYYJG2vZkMDEzIALbahNOkCBO/eqk8SSUXkyaEoZia9hMHPgg+vd+eiPvi2phaaiFlriGQ/zWbTfVoSY7KdxuwJmFZ2k9rkKo+LVZyVDDloQdwaekfH0B/66/wN9rvvhPfjM+DswZxVW523SvncBjTN2c2uoZaTck1REsYyTSNDoKWcyjT4ntfNBzkQWgW8skGBx6UaaYYe8e6g9PGL0ZOuf9WQS54Fs+vwDPOFZ95tXn4vhDNMxV/xrCamlvKj/ycgfSXrjV+iOh1UpLc1D5tlEFKVWv0juZTUp8K2oshofTp9bJZETB5dBfO5MjlSMjRB+f0vhn1yJs7dZykPmZMMv0E4JJX4l+G0lAuvKr69kaWtcIKJ/8qc7nvV9L1vAwgVZyYMx2/l6zpwxGV7iNOyEq9uXKvkrxuIKq0MkodK5VRpGBFdvRh63RypHp0TPzgGJ5TZuVMNi4c8gQ5zSvGWLD+sn4rFGpg0UufGY2iCSe4hXb2MEGwdw9T5iHzytx8WPji3qn52W6JGoGMm+BqNTaadaRUVCYT7SeO5ZsCMich+hQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000508, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Feb 25, 2024 at 11:08=E2=80=AFAM SeongJae Park wrot= e: > > Hi Barry, > > On Sun, 25 Feb 2024 10:50:23 +1300 Barry Song <21cnbao@gmail.com> wrote: > > > From: Barry Song > > > > The doc needs update. As only in the case of virtual address, we are > > calling madvise() with MADV_PAGEOUT; but in the case of physical > > address, we are actually calling reclaim_pages() directly. And > > madvise() with MADV_PAGEOUT is much more aggresive on reclamation > > compared to reclaim_pages() on paddr. > > Thank you for this nice patch :) > > > > > Cc: SeongJae Park > > Cc: Minchan Kim > > Cc: Michal Hocko > > Cc: Johannes Weiner > > Signed-off-by: Barry Song > > --- > > Documentation/mm/damon/design.rst | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon= /design.rst > > index 8c89d26f0baa..6c50743552f5 100644 > > --- a/Documentation/mm/damon/design.rst > > +++ b/Documentation/mm/damon/design.rst > > @@ -315,7 +315,13 @@ that supports each action are as below. > > Supported by ``vaddr`` and ``fvaddr`` operations set. > > - ``cold``: Call ``madvise()`` for the region with ``MADV_COLD``. > > Supported by ``vaddr`` and ``fvaddr`` operations set. > > - - ``pageout``: Call ``madvise()`` for the region with ``MADV_PAGEOUT`= `. > > + - ``pageout``: Call ``madvise()`` for the region with ``MADV_PAGEOUT`= ` if > > + the region is using virtual address; otherwise, call ``reclaim_page= s()`` > > + for the region if physical address is used. > > + ``madvise()`` with ``MADV_PAGEOUT`` is aggressively reclaiming me= mory > > + when pages are not shared by multiple processes. Differently, paddr= 's > > + pageout will do the best-effort reclamation by scanning PTEs to fi= gure > > + out if pages are young, if not, pages are reclaimed. > > I think this might be too much details. Especially, explanation of > ``MADV_PAGEOUT`` might better to be done on it's document. We wouldn't w= ant to > update two places for future changes to ``MADV_PAGEOUT``. What do you th= ink > about making it simple and independent from the implementation detail? F= or > example, > > - - ``pageout``: Call ``madvise()`` for the region with ``MADV_PAGEOU= T``. > + - ``pageout``: Reclaim the region. make sense. as someday we might rename reclaim_pages to reclaim_folios or something else. and we might not use madvise() for vaddr any more, who know= s:-) so it is more sensible to remove the details. I will send v2 to follow your proposal. > > Thanks, > SJ > > > Supported by ``vaddr``, ``fvaddr`` and ``paddr`` operations set. > > - ``hugepage``: Call ``madvise()`` for the region with ``MADV_HUGEPAG= E``. > > Supported by ``vaddr`` and ``fvaddr`` operations set. > > -- > > 2.34.1 Thanks Barry