From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A86AC3DA7F for ; Wed, 31 Jul 2024 05:05:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE2416B0082; Wed, 31 Jul 2024 01:05:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B91A06B0083; Wed, 31 Jul 2024 01:05:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A321D6B0085; Wed, 31 Jul 2024 01:05:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 821EE6B0082 for ; Wed, 31 Jul 2024 01:05:31 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B9AFF80209 for ; Wed, 31 Jul 2024 05:05:30 +0000 (UTC) X-FDA: 82398859620.21.3E636C3 Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by imf05.hostedemail.com (Postfix) with ESMTP id 01E00100016 for ; Wed, 31 Jul 2024 05:05:27 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZpA19lpb; spf=pass (imf05.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.47 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722402273; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xn+7YwKXTJEDk+Hqw80LqfVKiLUraDj++Wq5QfpnOJE=; b=ZVcNNuUiCpDG7rRxfeDOlQvEVrDun4EONlkF45zu+lGchOc6jBYPCydSzvpYE0g/L8W4nv bYh+LkJ7glW+7iaUt2e/6/x7JRc0/ydRwEZLIvoD3/ynJPZGGGwXsQnmbZgI+h0mGastbI qAeiosrUITLGOXUEDzo+xx9ecOqtnbs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722402273; a=rsa-sha256; cv=none; b=KUw7D6YcFOq+E7hdYwiVBevdn5dvvwGXxy50ehK6x286n2US7DT2UdtuMwHe/eIWfapx1h QkTI/noN1EcspjB0pEi+iK5UQWqva2tMFk23plqqL86Htbfea4oWxybZF5kMIVek15SCLp bhdhsRuQi+ZEcYZhl4p0LJGaviHw9t8= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=ZpA19lpb; spf=pass (imf05.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.217.47 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-vs1-f47.google.com with SMTP id ada2fe7eead31-4928989e272so1365223137.2 for ; Tue, 30 Jul 2024 22:05:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722402327; x=1723007127; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Xn+7YwKXTJEDk+Hqw80LqfVKiLUraDj++Wq5QfpnOJE=; b=ZpA19lpbdkgqHPpRNzIC/pM3PbZdVbGw6Ib5PhDTA6UiUTr707tUxe2GTHrikEKQD9 ZQIWW226VhctmekmV7vGhz6gAD0zDUnAw+9bFaBBV/byvWc0FczXJu83kZDPQJnNs6u2 KKzf2Ghu4Z3GIdJchh+3NH42i+vHOPx9SYq1cFsiTVlLq/EWF+6k3VaA7+FsMfWgdc4y BFXLoZmcAklMfyONOeELQZK+UlvonsfwrA+qEKmXaU1TD6lwPYBzBHDUm5I2BCvNzGrD XBrIL2iKRZ+0kyDnJFnII/1LHViJENUP+DrjSL+4MJHDxvFf1gj416dY95WhfJb88FW0 AxIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722402327; x=1723007127; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xn+7YwKXTJEDk+Hqw80LqfVKiLUraDj++Wq5QfpnOJE=; b=R1otJL7dCVsKsQUiQ2n9/+OH/bvzuc1sun5TJP7kCbbTmAIrkmgiySl83GzE2WWMni quamnRSELV2QuvyyuFRlrvXapLfXWRJjFaVumYEbDvDyndVFCzj/NvqC9h7k8pZ71N5U 7U+/A4jSiNGCERb/i66F68CQHma/EAQdxNOlquZGY08yUQ0gmANxc6WyCxzdVrmrXCsz bPUVGFUIcGBIlalU8m3DABaCqnBngdC8efbJ+dnBO4ak2zcTYsllw7XlDwbx2FBZOEUK vj1kK5p4IzvmeIedOrhoXri5D+4E/TWdzIpr+eDb67IRyQXbLmebOr8gQ5AyRm3/sWf2 eFJA== X-Forwarded-Encrypted: i=1; AJvYcCUT5y6AwU13Ny7la+2znrkD0EiebGQJnu1wyFeJP/q/1bCEkCKS8rx8Bhn28F9DvpMQavEPsn/wvJ0+Bq0MPn9Zrmo= X-Gm-Message-State: AOJu0Yy7EthG3qL+FQmOuNMHMEA/DsUBvmHVF1qI4zTT5DZXRtv/yaWl 2R+FME8/ViC777KIV827ZnerSNevUC4RO9+Fwh5A+S3ZSUFmouXUamMO9HoOKVN3odp3R+MECsa 6E2dnzFNpbGusFtN3MN5JxSjPDxs= X-Google-Smtp-Source: AGHT+IG+taccu8vxFmzYT8IWmHvg8VnBpcE12YA8ZxKB8a6+TKfwHMeZQTcTfllGTQHXaviRyTU3+dnUyBZflxRjeFQ= X-Received: by 2002:a05:6102:358d:b0:48f:c062:75ae with SMTP id ada2fe7eead31-493fa819b11mr15925091137.8.1722402327038; Tue, 30 Jul 2024 22:05:27 -0700 (PDT) MIME-Version: 1.0 References: <20240731000155.109583-1-21cnbao@gmail.com> <20240731000155.109583-2-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Wed, 31 Jul 2024 13:05:15 +0800 Message-ID: Subject: Re: [PATCH RFT v2 1/4] vpda: try to fix the potential crash due to misusing __GFP_NOFAIL To: Jason Wang , penguin-kernel@i-love.sakura.ne.jp Cc: akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, hailong.liu@oppo.com, hch@infradead.org, iamjoonsoo.kim@lge.com, lstoakes@gmail.com, mhocko@suse.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, torvalds@linux-foundation.org, urezki@gmail.com, v-songbaohua@oppo.com, vbabka@suse.cz, virtualization@lists.linux.dev, "Michael S. Tsirkin" , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Maxime Coquelin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 01E00100016 X-Stat-Signature: ym784pxx14snzf8odqq3z9knh1kojbo4 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722402327-274078 X-HE-Meta: U2FsdGVkX1/8sQFMdTVKQRgR8dypTSYzyBQvLMCIByZOh4XdxdrJuXFjsCSb7s+u12RCbKqJpxAuGzxZxIAyTWHm2/AsO9XA0hi8XDLPMkMheNkAN+baaoR+8iPHAhsjpBpeIesjpKIi+bQcIqQ0ePwcwokNRHsWu/ddE85yPquCpI0HwNYL0ZuSFU3/AYo6dM5YL6BjUgISMJ8eyDoP89CpLHkIUM3U0b12fi00BWxgCxckmAvu7BimQMLXCwFCxccz0rIk/WhKseYFZIM+KEGuHWRt8HOuVu5R4RId+CSRouriC8wc9cYEQWZiRoeYks7iwrIqOnfQqJXcfIpM2Grf/6qKQl1G2xjGNGRoCjKNyuMAS0vRI1D1QExtGp80ATJJdMDkvNf1T8L2hm8X7EUm3is2RQUWYLuT3J3zIJzsn7WetDmFKu8J7ep09rticsKb/v28UV/OtUUdknZ8NUogviOb1wa6Chsooh5wGVGBCjOCW4Y41tkmIGg9gq5cJ6hZvbYAxHSaJJpcyo5hL8vUH/e3aG6qc+y1S8k6WjwnlkqWtjp1v16AVWQlkdlZQdgUm0cKyggbFx2pv123NSE+6M5DVVfrnq2qhGg9aEvf08HMbJC/CHBJJgcBS6/GOMvpOeF8Y6xcPD+CGItuwkXX+Wi8rZnWOkKhRPf3kUh1tt7Rd8iWrPwQ9D7ZWBTT+dmyR1tUbB5z9hP7aQ/OChsOlzGhVW0u+8BThJxF7j70UWO4BlWie/eoo+BKTEDkXo/xb/M0O6lnHanFLzniAQ7R6Y4Tr8JOc81iT6yoGEuk0poiIErDWBa0gB1qSUSJ/PzpYPzNPVjx82vXUkgSuTTZg4PxY8hI621Cs0IZB3cHmcuhAE2NnFwIAn0VeQ7UBikhMCQF09NA8wC0rnytZHZDx8qcr/aatM8mQvhMCtmTwqGC8X9l/z75qNco0m1ZwF2u1DXSXG9shjUosvk eGpRHZXB QY+031ix2fHhdd9m+kEEwGxUTPRxYjXaxkwMs++N729eytk0jnnitgy01ngYB1wbLIjioEzZa75gTdA1ffj3+AN2zM/N9ZaC2G7xc4eeDzTUkFfrZi4pZJKa3IjLCVCKL2zGL1xOXfOqb1UeSHJ+CJGBVRWMHuSx22efpGtM96nPiEyGKU2j99JL05zsSyeXBNtCBIAaIAOkGiajFiRX512BC6quc11QNy1IOZaLr9uXXFqa08EK/o+UUErjL4VO0q0Z0QoEqSoGqsLmVu60CwpycFwu0zm+Oo2P8X7xjPBNOHgOYzc+wSTKRb13bEyMc2nfjVyuASudlWk7K7Kv1VTZP1BTng1DYwDX8vGsKeuVO6aO9/iQcw/HXqD5lKr8J9VUL+vRRA6YNT2wMbWZ8z2e8bOx3isLTUbvUtdvIs8ixQ2EPGYzfWGXCB7MaU9fTQ1g64q9i3ete6pcv7zrlZTaw77d1WCzt7Ly+09z8T9n3C7XVcCEMLFspfu0edsMLki744Xawzv+IwmIE7wXMnNqgv6f2X8u6cZSk7fml8ndv3UraU5M6JghISIq0HxtuD2f/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Jul 31, 2024 at 12:13=E2=80=AFPM Jason Wang w= rote: > > On Wed, Jul 31, 2024 at 12:12=E2=80=AFPM Barry Song <21cnbao@gmail.com> w= rote: > > > > On Wed, Jul 31, 2024 at 11:58=E2=80=AFAM Jason Wang wrote: > > > > > > On Wed, Jul 31, 2024 at 11:15=E2=80=AFAM Barry Song <21cnbao@gmail.co= m> wrote: > > > > > > > > On Wed, Jul 31, 2024 at 11:10=E2=80=AFAM Jason Wang wrote: > > > > > > > > > > On Wed, Jul 31, 2024 at 8:03=E2=80=AFAM Barry Song <21cnbao@gmail= .com> wrote: > > > > > > > > > > > > From: Barry Song > > > > > > > > > > > > mm doesn't support non-blockable __GFP_NOFAIL allocation. Becau= se > > > > > > __GFP_NOFAIL without direct reclamation may just result in a bu= sy > > > > > > loop within non-sleepable contexts. > > > > > > > > > > > > static inline struct page * > > > > > > __alloc_pages_slowpath(gfp_t gfp_mask, unsigned int order, > > > > > > struct alloc_co= ntext *ac) > > > > > > { > > > > > > ... > > > > > > /* > > > > > > * Make sure that __GFP_NOFAIL request doesn't leak out= and make sure > > > > > > * we always retry > > > > > > */ > > > > > > if (gfp_mask & __GFP_NOFAIL) { > > > > > > /* > > > > > > * All existing users of the __GFP_NOFAIL are b= lockable, so warn > > > > > > * of any new users that actually require GFP_N= OWAIT > > > > > > */ > > > > > > if (WARN_ON_ONCE_GFP(!can_direct_reclaim, gfp_m= ask)) > > > > > > goto fail; > > > > > > ... > > > > > > } > > > > > > ... > > > > > > fail: > > > > > > warn_alloc(gfp_mask, ac->nodemask, > > > > > > "page allocation failure: order:%u", or= der); > > > > > > got_pg: > > > > > > return page; > > > > > > } > > > > > > > > > > > > Let's move the memory allocation out of the atomic context and = use > > > > > > the normal sleepable context to get pages. > > > > > > > > > > > > [RFT]: This has only been compile-tested; I'd prefer if the VDP= A maintainers > > > > > > handles it. > > > > > > > > > > > > Cc: "Michael S. Tsirkin" > > > > > > Cc: Jason Wang > > > > > > Cc: Xuan Zhuo > > > > > > Cc: "Eugenio P=C3=A9rez" > > > > > > Cc: Maxime Coquelin > > > > > > Signed-off-by: Barry Song > > > > > > --- > > > > > > drivers/vdpa/vdpa_user/iova_domain.c | 31 ++++++++++++++++++++= +++----- > > > > > > drivers/vdpa/vdpa_user/iova_domain.h | 5 ++++- > > > > > > drivers/vdpa/vdpa_user/vduse_dev.c | 4 +++- > > > > > > 3 files changed, 33 insertions(+), 7 deletions(-) > > > > > > > > > > > > diff --git a/drivers/vdpa/vdpa_user/iova_domain.c b/drivers/vdp= a/vdpa_user/iova_domain.c > > > > > > index 791d38d6284c..9318f059a8b5 100644 > > > > > > --- a/drivers/vdpa/vdpa_user/iova_domain.c > > > > > > +++ b/drivers/vdpa/vdpa_user/iova_domain.c > > > > > > @@ -283,7 +283,23 @@ int vduse_domain_add_user_bounce_pages(str= uct vduse_iova_domain *domain, > > > > > > return ret; > > > > > > } > > > > > > > > > > > > -void vduse_domain_remove_user_bounce_pages(struct vduse_iova_d= omain *domain) > > > > > > +struct page **vduse_domain_alloc_pages_to_remove_bounce(struct= vduse_iova_domain *domain) > > > > > > +{ > > > > > > + struct page **pages; > > > > > > + unsigned long count, i; > > > > > > + > > > > > > + if (!domain->user_bounce_pages) > > > > > > + return NULL; > > > > > > + > > > > > > + count =3D domain->bounce_size >> PAGE_SHIFT; > > > > > > + pages =3D kmalloc_array(count, sizeof(*pages), GFP_KERN= EL | __GFP_NOFAIL); > > > > > > + for (i =3D 0; i < count; i++) > > > > > > + pages[i] =3D alloc_page(GFP_KERNEL | __GFP_NOFA= IL); > > > > > > + > > > > > > + return pages; > > > > > > +} > > > > > > + > > > > > > +void vduse_domain_remove_user_bounce_pages(struct vduse_iova_d= omain *domain, struct page **pages) > > > > > > { > > > > > > struct vduse_bounce_map *map; > > > > > > unsigned long i, count; > > > > > > @@ -294,15 +310,16 @@ void vduse_domain_remove_user_bounce_page= s(struct vduse_iova_domain *domain) > > > > > > > > > > > > count =3D domain->bounce_size >> PAGE_SHIFT; > > > > > > for (i =3D 0; i < count; i++) { > > > > > > - struct page *page =3D NULL; > > > > > > + struct page *page =3D pages[i]; > > > > > > > > > > > > map =3D &domain->bounce_maps[i]; > > > > > > - if (WARN_ON(!map->bounce_page)) > > > > > > + if (WARN_ON(!map->bounce_page)) { > > > > > > + put_page(page); > > > > > > continue; > > > > > > + } > > > > > > > > > > > > /* Copy user page to kernel page if it's in use= */ > > > > > > if (map->orig_phys !=3D INVALID_PHYS_ADDR) { > > > > > > - page =3D alloc_page(GFP_ATOMIC | __GFP_= NOFAIL); > > > > > > memcpy_from_page(page_address(page), > > > > > > map->bounce_page, 0, P= AGE_SIZE); > > > > > > } > > > > > > @@ -310,6 +327,7 @@ void vduse_domain_remove_user_bounce_pages(= struct vduse_iova_domain *domain) > > > > > > map->bounce_page =3D page; > > > > > > } > > > > > > domain->user_bounce_pages =3D false; > > > > > > + kfree(pages); > > > > > > out: > > > > > > write_unlock(&domain->bounce_lock); > > > > > > } > > > > > > @@ -543,10 +561,13 @@ static int vduse_domain_mmap(struct file = *file, struct vm_area_struct *vma) > > > > > > static int vduse_domain_release(struct inode *inode, struct fi= le *file) > > > > > > { > > > > > > struct vduse_iova_domain *domain =3D file->private_data= ; > > > > > > + struct page **pages; > > > > > > + > > > > > > + pages =3D vduse_domain_alloc_pages_to_remove_bounce(dom= ain); > > > > > > > > > > > > spin_lock(&domain->iotlb_lock); > > > > > > vduse_iotlb_del_range(domain, 0, ULLONG_MAX); > > > > > > - vduse_domain_remove_user_bounce_pages(domain); > > > > > > + vduse_domain_remove_user_bounce_pages(domain, pages); > > > > > > vduse_domain_free_kernel_bounce_pages(domain); > > > > > > spin_unlock(&domain->iotlb_lock); > > > > > > put_iova_domain(&domain->stream_iovad); > > > > > > diff --git a/drivers/vdpa/vdpa_user/iova_domain.h b/drivers/vdp= a/vdpa_user/iova_domain.h > > > > > > index f92f22a7267d..17efa5555b3f 100644 > > > > > > --- a/drivers/vdpa/vdpa_user/iova_domain.h > > > > > > +++ b/drivers/vdpa/vdpa_user/iova_domain.h > > > > > > @@ -74,7 +74,10 @@ void vduse_domain_reset_bounce_map(struct vd= use_iova_domain *domain); > > > > > > int vduse_domain_add_user_bounce_pages(struct vduse_iova_domai= n *domain, > > > > > > struct page **pages, int= count); > > > > > > > > > > > > -void vduse_domain_remove_user_bounce_pages(struct vduse_iova_d= omain *domain); > > > > > > +void vduse_domain_remove_user_bounce_pages(struct vduse_iova_d= omain *domain, > > > > > > + struct page **pages)= ; > > > > > > + > > > > > > +struct page **vduse_domain_alloc_pages_to_remove_bounce(struct= vduse_iova_domain *domain); > > > > > > > > > > > > void vduse_domain_destroy(struct vduse_iova_domain *domain); > > > > > > > > > > > > diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/= vdpa_user/vduse_dev.c > > > > > > index 7ae99691efdf..5d8d5810df57 100644 > > > > > > --- a/drivers/vdpa/vdpa_user/vduse_dev.c > > > > > > +++ b/drivers/vdpa/vdpa_user/vduse_dev.c > > > > > > @@ -1030,6 +1030,7 @@ static int vduse_dev_queue_irq_work(struc= t vduse_dev *dev, > > > > > > static int vduse_dev_dereg_umem(struct vduse_dev *dev, > > > > > > u64 iova, u64 size) > > > > > > { > > > > > > + struct page **pages; > > > > > > int ret; > > > > > > > > > > > > mutex_lock(&dev->mem_lock); > > > > > > @@ -1044,7 +1045,8 @@ static int vduse_dev_dereg_umem(struct vd= use_dev *dev, > > > > > > if (dev->umem->iova !=3D iova || size !=3D dev->domain-= >bounce_size) > > > > > > goto unlock; > > > > > > > > > > > > - vduse_domain_remove_user_bounce_pages(dev->domain); > > > > > > + pages =3D vduse_domain_alloc_pages_to_remove_bounce(dev= ->domain); > > > > > > + vduse_domain_remove_user_bounce_pages(dev->domain, page= s); > > > > > > unpin_user_pages_dirty_lock(dev->umem->pages, > > > > > > dev->umem->npages, true); > > > > > > atomic64_sub(dev->umem->npages, &dev->umem->mm->pinned_= vm); > > > > > > > > > > We miss a kfree(pages); here? > > > > no. > > > > i've moved it into vduse_domain_remove_user_bounce_pages. > > > > > > Ok, but it seems tricky e.g allocated by the caller but freed in > > > callee. And I think I missed some important issues in the previous > > > review: The check of user_bounce_pages must be done under the > > > bounce_lock, otherwise it might race with umem_reg. > > > > > > So in the case of release(), we know the device is gone, so there's n= o > > > need to allocate pages that will be released soon. So we can pass NUL= L > > > as a hint and just assign bounce_page to NULL in > > > vduse_domain_remove_user_bounce_pages(). > > > > > > And in the case of vduse_dev_dereg_umem(), we need to allocate the > > > pages without checking user_bounce_pages. So in > > > vduse_domain_remove_user_bounce_pages() if we can free the allocated > > > pages as well as the pages in the following check > > > > > > if (!domain->user_bounce_pages) > > > goto out; > > > > > > What do you think? > > > > I am not a vdpa guy, but changing the current logic is another patch. > > From mm perspective, I can only address the __GFP_NOFAIL issue. > > > > I actually prefer you guys handle it directly:-) I'd rather report a B= UG > > instead. TBH, I know nothing about vpda. > > Fine, let me post a patch for this (no later than the end of this week). > Jason, Thank you very much. Also, Tetsuo reminded me that kmalloc_array() might be problematic if the count is too large: pages =3D kmalloc_array(count, sizeof(*pages), GFP_KERNEL | __GFP_NOFAIL); You might want to consider using vmalloc_array() or kvmalloc_array() instea= d when you send a new version. > Thanks > > > > > > > > > Thanks > > > > > > > > > > > > > > > > > Thanks > > > > > > > > > > > -- > > > > > > 2.34.1 > > > > > > > > > > > Thanks Barry