From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 803F6C43334 for ; Wed, 8 Jun 2022 07:48:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC4086B0075; Wed, 8 Jun 2022 03:48:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C73286B007E; Wed, 8 Jun 2022 03:48:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3ADF6B0080; Wed, 8 Jun 2022 03:48:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id A57496B0075 for ; Wed, 8 Jun 2022 03:48:30 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7311D20BB1 for ; Wed, 8 Jun 2022 07:48:30 +0000 (UTC) X-FDA: 79554291180.10.8FB0930 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) by imf06.hostedemail.com (Postfix) with ESMTP id 0739C180034 for ; Wed, 8 Jun 2022 07:48:29 +0000 (UTC) Received: by mail-ej1-f52.google.com with SMTP id fu3so38259140ejc.7 for ; Wed, 08 Jun 2022 00:48:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kXkJZDN5f41vCkZwW8ZE7hb5zQfmu2jYPyBC+wVy0V8=; b=eNf6oOTDd4otQkXVR6HRhBsozVbIZwZyj++kC1qQELl8tphSLEM/Hu7EmLxoB3GLLo mKqHWgCo7DltiHf+Z0vuFYCL3ghZSenJBKEylJBKWkgx2ZZ//nPKQUEtVIFDBJnwsK1u 14uL/3oKR+8p+woV2hkpDEFVK7PrNRfZNr7YXGN0GJTFMxksR2wV/9vlyQ+Ec7zTivEN q0s3MfmTZy6AC9GeJtv6VZfz8wmBxvsHmXZmYzWKXVyWdbhuaKpHghNzNV8f8YiQhGrU pZ2k6A5QDSe+DeMhczhQAGKEqlntx/szER82q86xUWbNSbpJLGXHG5LyxviMC0DflYu/ 2ZDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kXkJZDN5f41vCkZwW8ZE7hb5zQfmu2jYPyBC+wVy0V8=; b=fDN/dXDCGZ+mONTfNVfCySdSiOszvfA5WTdms7MJ4I2rsv5K/s1oynbwlWTEztfNkR ftmPiDs5cAVzKFEU5ndOhnV7tTA3Nd/b6Nj5GMhBMxWND1wExBm50SOYKgWLliiCmmBL RARS5L0YYbUAEJxvHj2YX/ETE/+f9noKDPhkt2KPi/l8+AUr6u0/30Ek8+JtlU4BZe8t NppWcflFP51xT1BiXLTA2g2TZkjjFYKh/Rq17NwyFhvoEfS0W0oxbtLt7Muo7MRy45Y4 CJvF0E4nvoUMQqmpKocLgYyf/FGyfuYSQdtayWnIRVnA/+aHiNGswr0tHpdxrADwIamb o3YA== X-Gm-Message-State: AOAM530hax3OA52qubp2RhIIu1wfX+p2ps0vQK8XY5LpMBnuDgy0c43Y pKdSxpp7AdnEJZV61P+Mc39A0W+k99ZpDkYuJ7Q= X-Google-Smtp-Source: ABdhPJxSeTe7VJehA0LRTPFttB6Zx5E5UjOZxX/dzRtWP2rBcx1ZeTzlRRrljEuS9xzqsTj0W3eVnJ09RbifGzFqMlI= X-Received: by 2002:a17:907:a0c8:b0:711:d82a:1caa with SMTP id hw8-20020a170907a0c800b00711d82a1caamr10971990ejc.702.1654674508479; Wed, 08 Jun 2022 00:48:28 -0700 (PDT) MIME-Version: 1.0 References: <20220518014632.922072-1-yuzhao@google.com> <20220518014632.922072-8-yuzhao@google.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Wed, 8 Jun 2022 19:48:17 +1200 Message-ID: Subject: Re: [PATCH v11 07/14] mm: multi-gen LRU: exploit locality in rmap To: Yu Zhao Cc: Will Deacon , Andrew Morton , Linux-MM , Andi Kleen , Aneesh Kumar , Catalin Marinas , Dave Hansen , Hillf Danton , Jens Axboe , Johannes Weiner , Jonathan Corbet , Linus Torvalds , Matthew Wilcox , Mel Gorman , Michael Larabel , Michal Hocko , Mike Rapoport , Peter Zijlstra , Tejun Heo , Vlastimil Babka , LAK , Linux Doc Mailing List , LKML , x86 , Kernel Page Reclaim v2 , Brian Geffon , Jan Alexander Steffens , Oleksandr Natalenko , Steven Barrett , Suleiman Souhlal , Daniel Byrne , Donald Carr , =?UTF-8?Q?Holger_Hoffst=C3=A4tte?= , Konstantin Kharlamov , Shuang Zhai , Sofia Trinh , Vaibhav Jain , huzhanyuan@oppo.com Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: zdjmp3wk7winh48uc8ip496nx3618jdb X-Rspam-User: Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=eNf6oOTD; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.218.52 as permitted sender) smtp.mailfrom=21cnbao@gmail.com X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0739C180034 X-HE-Tag: 1654674509-424086 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 8, 2022 at 7:07 AM Yu Zhao wrote: > > On Tue, Jun 7, 2022 at 1:37 AM Barry Song <21cnbao@gmail.com> wrote: > > > > On Mon, Jun 6, 2022 at 9:25 PM Barry Song <21cnbao@gmail.com> wrote: > > > > > > On Wed, May 18, 2022 at 4:49 PM Yu Zhao wrote: > > ... > > > I can't really explain why we are getting a random app/java vm crash in monkey > > test by using ptep_test_and_clear_young() only in lru_gen_look_around() on an > > armv8-a machine without hardware PTE young support. > > > > Moving to ptep_clear_flush_young() in look_around can make the random > > hang disappear according to zhanyuan(Cc-ed). > > This sounds too familiar -- let me ask again: was the following commit > included during the test? > > 07509e10dcc7 arm64: pgtable: Fix pte_accessible() > > If not, it will cause exactly the problem you described. And what > about this one? > > e914d8f00391 mm: fix unexpected zeroed page mapping with zram swap > > Missing it also causes userspace memory corruption on Android, i.e., > random app crashes. > According to zhanyuan's testing, we can confirm the above two commits can fix the random android crash. Thanks Barry