From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C612D65553 for ; Tue, 26 Nov 2024 20:31:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C188B6B0088; Tue, 26 Nov 2024 15:31:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC9166B0095; Tue, 26 Nov 2024 15:31:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A688A6B0099; Tue, 26 Nov 2024 15:31:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 85CE06B0088 for ; Tue, 26 Nov 2024 15:31:40 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 04A25C0AA0 for ; Tue, 26 Nov 2024 20:31:39 +0000 (UTC) X-FDA: 82829391876.29.CDC4FF8 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by imf12.hostedemail.com (Postfix) with ESMTP id 0C56740013 for ; Tue, 26 Nov 2024 20:31:35 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TVjQbFvA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.167.169 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732653096; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9gjTHY0fbWwVB9qUJSPvNg/0dgFPa2rgePIKF8vPu1U=; b=m+Erq+ywS5zri3VtS3bEwdr4I/CT7eXjXePFZl0w04PgkHmsQc7ZCA4+RtKSehFUgIrQ62 J0sngL1NccXBJrI1KF7YECKfn0pf2Z+BlNAz39ejrYvl8gGN8c+wP789qufeeRkEUf/sza lmaKl0FNa74mWFAqOi2lIS03yAn6vaE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732653096; a=rsa-sha256; cv=none; b=t9eTOZfmYJ35nzB55AthmJQoiPIs3nq8voyZzg2zpOG/nTTIWQ0sL+QIj5KAwUNYr+pJGt 46d3p5e9YKQxP+KVn2tWUys7/w+J7ffJUWFX1T0Mf/NnHeUyNL47msrArlEikaP6urf/KD ZNhb9S5EcLuEMlcGwSk9gy8Cp4MaAZo= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=TVjQbFvA; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf12.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.167.169 as permitted sender) smtp.mailfrom=21cnbao@gmail.com Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3ea369fdb0cso1816705b6e.3 for ; Tue, 26 Nov 2024 12:31:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732653097; x=1733257897; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9gjTHY0fbWwVB9qUJSPvNg/0dgFPa2rgePIKF8vPu1U=; b=TVjQbFvAi6TlyZMrphwmvvK7hHDHLTkSzpsCBraeRypinTaEhnlj0DALUIvrhLdrnE LdfzaLCzGFMoCohEUcCPDXcyvnTKr4sQ6HWyoc1cE0z656nwAcGMaB+6BTvRgUE1i1oO ior84PKGeqDa9A9tM+ZZsFObK9bvhX5Jp64vgYlqiR3ktKmrweUoxbMBTqoKZsZQyBXJ /6cHvCqXP5g66nzniAwMfS11fcUVOyzYBpvu6w/a7/LCdo5e/pA50zm0z4grdM3fmAGl DIfw8xHmerfp9y4o2siAME+VpQaIcceEX+QbOKc8kMVvbhwOK/hqoVTHtkGAbgr4aUsU NERw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732653097; x=1733257897; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9gjTHY0fbWwVB9qUJSPvNg/0dgFPa2rgePIKF8vPu1U=; b=mh0yBwl2bk98PA/Sgk3NsxxG9Tp0H4xqBs4YAPkC52aFT07ZfMWwlTfqicrQLcrkvm 7IvDTwWWQ57gZJme3Ghu899vOPCagDbsjwimlf66eJu5wnlc4eLDIkhpA6TT2PWYOWkm YrWctPLN7Ho/qHXISEarC0F9fmZkR50WLdcJ12dgOGwx7dG2+Zuph4Y4l+GSCYH8L1tS nX0BVN6yDAbHdv01F78KNlJ0MR/82Wnj1/Qj5vVVRMKXp0VRoz13N5F9z5mp2/vm/Aeh eaj/2mQQm6GamjiIM3aCyllDoTv0JLVR+1cVBMCG/7o/i3my7JUYz4y0FE9N+6XX46jZ 95mw== X-Forwarded-Encrypted: i=1; AJvYcCVikVKQ90JFDy1iGViuGZZMdZa/J2ypw3cleESxObXL9oGGoqm9ykJITKbINMBnUBNzGoJLCiq+0Q==@kvack.org X-Gm-Message-State: AOJu0YyPeC/fT1Gx5mTaLzoxbVUSmdhHPAyl72l0Wkc9b33KEO1oB2Cc /MwSkjMSUc5EwFE8vLYlPvjj7ZHE5jUvCappOLVB+uqSMYzfi2OHdtxKur3e0uBLvRJFCxeukit ky7GhNJLiR5Bsm8YjzMGD3AewfgU= X-Gm-Gg: ASbGncvFOesQ+t6YOChaZDPoOBYmbYeQgSu+erLP9TOXCKJrwlbFo/yIflGoMk7SzBo KqG8rKSdMpV601bX7yDXvpJR7WhVC3sH/8UCQB6UdX+9hnuNmH8nFq1KEmAXobvS0Bw== X-Google-Smtp-Source: AGHT+IHX0xA90/BP+CpxOr92hSLE1ZVzAKd62w1U6QyGxX5avTxepVooRHKRvk5bnySqPf3CpUQ+GdN24c6b6SX1+Bo= X-Received: by 2002:a05:6358:5289:b0:1ca:9839:5d1e with SMTP id e5c5f4694b2df-1cab15f2a96mr123649155d.12.1732653097116; Tue, 26 Nov 2024 12:31:37 -0800 (PST) MIME-Version: 1.0 References: <20241121222521.83458-1-21cnbao@gmail.com> <20241126050917.GC440697@google.com> <20241126105258.GE440697@google.com> In-Reply-To: <20241126105258.GE440697@google.com> From: Barry Song <21cnbao@gmail.com> Date: Wed, 27 Nov 2024 09:31:26 +1300 Message-ID: Subject: Re: [PATCH RFC v3 0/4] mTHP-friendly compression in zsmalloc and zram based on multi-pages To: Sergey Senozhatsky Cc: akpm@linux-foundation.org, linux-mm@kvack.org, axboe@kernel.dk, bala.seshasayee@linux.intel.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, kanchana.p.sridhar@intel.com, kasong@tencent.com, linux-block@vger.kernel.org, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, surenb@google.com, terrelln@fb.com, usamaarif642@gmail.com, v-songbaohua@oppo.com, wajdi.k.feghali@intel.com, willy@infradead.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, zhengtangquan@oppo.com, zhouchengming@bytedance.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: u1jskwaiffgocyb48ei7yd5n9zay33f9 X-Rspamd-Queue-Id: 0C56740013 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1732653095-951338 X-HE-Meta: U2FsdGVkX19iY1rZmKXinEMCriqgYgtYWA3NXxF4YhHb/V9mHYu8EHZOujLYz+v9MmBWU2ox4tiQsf8f/xJydisXC6An2QDbruLS4Np54o771iANErMPMHyS//4vOWwYltXb9G7POYegQFf8b9dNeFOjFyPTMPvBpIV8IqdApqDxZxVrqcwXOrUlGj3moBAFDM67N31thbl20L8oFfKgDdaGC7TWyoi497iPL82I8cp5nkZUt23HGCNa/PcjmSaF4/bXerHKLANKQsMwS2iwseFPWkSniL0t3O3FU2/XttuIsBXNePN1M0KO0sLbWC00cxi5rdbxWLi1/8mxtI/foYn1m8JHBnBDHfvMkyY4vlg6T+fCICD9/cAD88VRdWHTVX/fd9Ug7TCK9lckHHIlXKwhwgWwPbRBme9c9NPS+Ocuay0tF9gklOxWPdJS+rgPBt1GH0BAgLLXryo8P9Mx+/tqRHr0FHgpRtlPK3AQxQGvV+/mm4+5Mrss6kWfvHv9erS+e8Z5d/LptlPe9Ith+YONYbmTH3eKbIawmgmyDDkuWMDNzdUwB4K8BIjtIMGu9XpMQsvl2Re6rGzJt9FxEzq0IukNWvWuhwdQKSl/E8+hdD6AQmihgzl7DowRiATXlg8Q0VyIwbSb5Nu/YCVOgiVmB9eccI1qiRv/iDWDfaS6n/J/YiHHWSB4p1iBDO71NSBYioXnuS33CgBQQVr6nRIgq6YjPaBS0Kv7vpOtb9rF3CF5TFC2+/xeZbdrJltuUiSz/M7uhgj1o97dk1A4wlo8r08UjINVxsXOD9hexbLaBAwNeKDLwEC47HSD77uhlAo6Da95BFRywXNHiDHf01sucE/sarerAGV4mgKyYAF5LHitTjT38T1cRmvRHpoDkSUAYZaPjsBZw6IDLhkP7w39gGTy/QV4WMxYV9Jx6wcDrNKPz3JjcmL2e2XHQogTIIese9hMYV00I1RoblG qsXlXHVG mjvnA1G4+aR8jTh7dRqgI+nNI6mMNhV3eedxXcyb9+rSVLNIHfr1ux//VVVq1Ici+9D7HkowCMx5alQDLMPgrk1j5UL7Jg75RLlnL7ZdYr1xFEnX+dcOh4Ohe3ZWoEF3VDl2vBDm4hYYApMM+8xMNN8t5Jvv3Z/NxQTFrIbWeJL8T6xKlflNpbcqOJiKNdkexQIcnp02rDt/86M+Lwm4oXoCTFiUMj16RXwzPF1O8YbnsURKjNNkcQlukmrQVlaOeUPNo3QmJXpBxvhaDBactS5HIZh3MZLpiczkv6URodOsNw5smz/e/fGv8Fh1N1eyQD4H6uSpJIAjbJkExvIuDwFBQIZ7pbIhJSZBxrVyJUc61PKLPDhANQh9mkA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000307, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 26, 2024 at 11:53=E2=80=AFPM Sergey Senozhatsky wrote: > > On (24/11/26 14:09), Sergey Senozhatsky wrote: > > > swap-out time(ms) 68711 49908 > > > swap-in time(ms) 30687 20685 > > > compression ratio 20.49% 16.9% > > I'm also sort of curious if you'd use zstd with pre-trained user > dictionary [1] (e.g. based on a dump of your swap-file under most > common workloads) would it give you desired compression ratio > improvements (on current zram, that does single page compression). > > [1] https://github.com/facebook/zstd?tab=3Dreadme-ov-file#the-case-for-sm= all-data-compression Not yet, but it might be worth trying. A key difference between servers and Android phones is that phones have millions of different applications downloaded from the Google Play Store or other sources. In this case, would using a dictionary be a feasible approach? Apologies if my question seems too naive. On the other hand, the advantage of a pre-trained user dictionary doesn't outweigh the benefits of large block compression? Can=E2=80=99t both be used together? Thanks Barry