From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F88C4345F for ; Mon, 15 Apr 2024 08:18:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86F276B0098; Mon, 15 Apr 2024 04:18:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8467B6B0099; Mon, 15 Apr 2024 04:18:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70F0A6B009A; Mon, 15 Apr 2024 04:18:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4F4D86B0098 for ; Mon, 15 Apr 2024 04:18:17 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 141CF1A0491 for ; Mon, 15 Apr 2024 08:18:17 +0000 (UTC) X-FDA: 82011063834.05.A2808D8 Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 50B132001A for ; Mon, 15 Apr 2024 08:18:15 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Gtqn4cke; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.172 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713169095; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oID6k0K7GpiA2A/EofE3sQH6GFlWrzXGisMuO/HP8VE=; b=HUPOSlgrwnmYfM49AiH7DoSnP7sH7xExomQYH7JCuBjkvFYsGiQrSX4ZKJKP+aTtYHyQkA SXq/yAxG4alLhavFKMKkenle1qsFjtFZdZGEvduXltNGG/rCUp4vhQGgbxA9Mbw11cIUBC U1rDFYzd02Q+lsp2z5CAboVtaDyUIg0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Gtqn4cke; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.172 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713169095; a=rsa-sha256; cv=none; b=pQa7Ses53saXGtpsuroMcW19MT+3jja2Ak+lI480+OiGNdpb542yfuqRiqjIYfTOGa5Fvc qcWkzbJSnjZ3gSoygL/jE8bq7WE66p5NnIe1yCvuwfTlJ1wCghYk7UzhbUYgKXQ2l18JFQ W2G5mKor8+6TMxXViPXgQNP5gu8kDko= Received: by mail-vk1-f172.google.com with SMTP id 71dfb90a1353d-4dabc6f141bso1031749e0c.2 for ; Mon, 15 Apr 2024 01:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713169094; x=1713773894; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oID6k0K7GpiA2A/EofE3sQH6GFlWrzXGisMuO/HP8VE=; b=Gtqn4ckeV0rnudphtroUsgoZy4cmAfNtJbImECWg3XORYb5AMd2tK5Y18NZtChZGQL Rwk3QjfPSkiqj5N+lHdT3xCQDSgS/3WGCh4uFBN4QXZ2rkDRFZ50wE85L9tZmPqXQgm5 t5kPEjpjTPk/mb9ASzq0fjSNHUOa30HKr7DmBHH5xIeQMlR2WK3oWBxoE66ZabpJ1Mjr fXlJcXIlhWP2B4nKI16W7Zte2VxI894frbYgm3JRQSYASKT0aNvR/tdAhYbNOq7S62S7 Ek9/YRChjU8JN5/1yVOWrwwtxbX8oxN/bYq0m8msJDnIOb8jYzeR0CWGjoWJ0ixISA9b bmmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713169094; x=1713773894; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oID6k0K7GpiA2A/EofE3sQH6GFlWrzXGisMuO/HP8VE=; b=Z4ccPxDqGZTmgvQSB8ZD/ahMETGGSSNE2Qw2tQGQLnRPLeg9Vqi/Hxe7OwG5FRcgwC 4mzTMCC4IiqA70oEACXFwbSjSdj6zWEYuFv3oZfC6U5U0TB7BYweWfAD6CTo/6B7qfZQ J1kaeVMOV0ZkDn3XnoCYjVax28b1ziUTzMOmDBY133HBG5adm/sjCwDA1dM7oEkuKTvQ eKUAOuhOmdrFLkIeE88w9bFxiuqi8I1SNCZRMVs0+ywNZsDmE+cYpWJX9bPs4S99rhE0 QzLLEch2vpzUEqEaexsX8Qm7mZanR96KexS27ezJzuQmySvZ6yyiRWiuqRBo1vfNmZAO Gw5A== X-Forwarded-Encrypted: i=1; AJvYcCX55GZo67neuey7NFh1jvxEvHDwVBBpKQTL+Xx1EteVtmvzv3S1YxurjHQ2KdI+N0kv3yahFcGnT1naLTIc4dfAAl8= X-Gm-Message-State: AOJu0YzPagoE6eTvee+gdDuH9uJXKNlZgFLEuh7YhbUxbaE233iW+dY2 oFhBOiQMmyikZTKhN2dPNIQk9ExDZcWwezaYsXP6uFjLg5hRR9elza1BlTPcU1jOxSq60ZVOHXa O8jNFSU9+AhgH6nzyuliUZ3J4f9I= X-Google-Smtp-Source: AGHT+IHp8tcvfaBUYaejDqJsyEHlhB7i5t/nsjtOEoNVjkEkXZ0q5H11IKnXwFR2T2H2roU4JyIg91ydMpiVWP7zgNY= X-Received: by 2002:a05:6122:3c56:b0:4da:9d3e:a7df with SMTP id fv22-20020a0561223c5600b004da9d3ea7dfmr6852817vkb.5.1713169094457; Mon, 15 Apr 2024 01:18:14 -0700 (PDT) MIME-Version: 1.0 References: <20240415081220.3246839-1-wangkefeng.wang@huawei.com> In-Reply-To: <20240415081220.3246839-1-wangkefeng.wang@huawei.com> From: Barry Song <21cnbao@gmail.com> Date: Mon, 15 Apr 2024 20:18:03 +1200 Message-ID: Subject: Re: [PATCH rfc 0/3] mm: allow more high-order pages stored on PCP lists To: Kefeng Wang Cc: Andrew Morton , Huang Ying , Mel Gorman , Ryan Roberts , David Hildenbrand , Barry Song , Vlastimil Babka , Zi Yan , "Matthew Wilcox (Oracle)" , Jonathan Corbet , Yang Shi , Yu Zhao , linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 50B132001A X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 1w5yxg8fc7r3m6pdiiqnmcrrhq1dn7ab X-HE-Tag: 1713169095-97118 X-HE-Meta: U2FsdGVkX19RwmieDMjTqiIZAtLMcX4yGSi02bgBhQMrT2HSaFx9GpZeHToa1axzFsFdbmYXYW377F+Jgbp+2ViXf5bLT42y6hVpwlnkGAULpskVP6ekyW/eammcXN1eQ6999jYb7MEfR+b7ivhfSzEF+jqTiqhdcZllhcWvpSvtTQBzapDnCXsgCbeXuFT7MoBITO3WiCImZvyk30xgZPJzuOFAxkFnvXRJDD7aO+mvFHqvZECrYKi2o3K4PcNaxVjo/QS91KbpXYG8x7bwd5EN2Aw2Ua7dUsHwhk+fgM8VpHGgCDcnehJd4LBy2SNryuW1zP7gKQfFJ2TJXyNBrp9Veurboyf1AhR3OeLmaZzBka/LVy3INznpMFzjzVk9kwQYGUk0+D1x6OWlgCUy7ea+/13nYiBGQrKCBsyJji6OvQE3DVBzN97EU0Vqi6vtf9/S/nO0g07lYiGNOlAQYKG3QpLTJcR8Y2pLgWQWmvg/itkJsZjjTp8raXZGre2FjY0DDVUO1jUsZpPsaelcHI6jEjkWL3gKp8CRccY1myk03kSMdQVeyDcWxXmqBLGi+qkIWF9gLKLBPpDwQHwCD7Mowd9ejpRfMqserqhuljkQMaGM0grYoeQMRbFTEDimJ/Z1ZGPSVCpZbwzlOeR5dT9bFxsab0B1twyAoW13Vll+egc8eMamc8ol1JCi+KzoaLw/5c8ye7MAzDmvqTo6cfkM77U+g6/S1bOnzW6wYM5e32NM89FWLHcUd2tFLAbUYQ0l1U4nZ41OWBwKbkq4oBm6FsRs7S2BW8OxsKtAwQhNa+n45W56XxwDyOsm2D7E+wtjBe4Xk7N9zw9dS7W13+bOXal6DDQuAn8PaygI/rUqiRuynaycMM/zAuSyLZfNNGDo5eqpY5ecH5j2rEIHZvouHYIhXsSl0DE9OtoUiUBTG8FXpdL5vIyTR6RQtbVyF7FLGP9OItOyWcvn7Pc Mz2EIbb8 LP03cP/dBPdTf+HhZpTLHPFU+688J7lQ7Rbm7ycccJ8OJFMgBd61/jtpHxIVI5XDOa/Ss9aslCZS/XuqixySSmKaKK7JAkSLs6QLj8ilIgEpyFv7DlVKNe0tpja19k+Kl/XFSKiBQe1sEI6isSSBzC0LjlYXpiR/4xIFO7apm/T/dyLF9KTPfaQ1uZPwz6oQCY23rc+qVx82Udry7RKOQg8FGFsiGKZ9pk7kXXROdulSb/MY4OMR5pvNgs1fIKXwJU0fwt+nQmXBm1ivx7o8C5jK3PFZvzytUyClBbnOM9Db00jZZ3X+8ZR4b6Dz8UJwAe9BQA3vSLvU7guw/76k4653sdzinPLOSZVQLnvj4zHroh08JhCcaWHddIigSQvEp554HANSI8cLBSjqPyjmcZmvW7CdsYUjyY18jqcpcpmmcPXfjgw79Bf8nNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 15, 2024 at 8:12=E2=80=AFPM Kefeng Wang wrote: > > Both the file pages and anonymous pages support large folio, high-order > pages except PMD_ORDER will also be allocated frequently which could > increase the zone lock contention, allow high-order pages on pcp lists > could reduce the big zone lock contention, but as commit 44042b449872 > ("mm/page_alloc: allow high-order pages to be stored on the per-cpu lists= ") > pointed, it may not win in all the scenes, add a new control sysfs to > enable or disable specified high-order pages stored on PCP lists, the ord= er > (PAGE_ALLOC_COSTLY_ORDER, PMD_ORDER) won't be stored on PCP list by defau= lt. This is precisely something Baolin and I have discussed and intended to implement[1], but unfortunately, we haven't had the time to do so. [1] https://lore.kernel.org/linux-mm/13c59ca8-baac-405e-8640-e693c78ef79a@s= use.cz/T/#mecb0514ced830ac4df320113bedd7073bea9ab7a > > With perf lock tools, the lock contention from will-it-scale page_fault1 > (with 90 tasks run 10s, hugepage-2048KB never, hugepage-64K always) show > below(only care about zone spinlock and pcp spinlock), > > Without patches, > contended total wait max wait avg wait type caller > 713 4.64 ms 74.37 us 6.51 us spinlock __alloc_= pages+0x23c > > With patches, > contended total wait max wait avg wait type caller > 2 25.66 us 16.31 us 12.83 us spinlock rmqueue_= pcplist+0x2b0 > > Similar results on shell8 from unixbench, > > Without patches, > 4942 901.09 ms 1.31 ms 182.33 us spinlock __alloc_= pages+0x23c > 1556 298.76 ms 1.23 ms 192.01 us spinlock rmqueue_= pcplist+0x2b0 > 991 182.73 ms 879.80 us 184.39 us spinlock rmqueue_= pcplist+0x2b0 > > With patches, > contended total wait max wait avg wait type caller > 988 187.63 ms 855.18 us 189.91 us spinlock rmqueue_= pcplist+0x2b0 > 505 88.99 ms 793.27 us 176.21 us spinlock rmqueue_= pcplist+0x2b0 > > The Benchmarks Score shows a little improvoment(0.28%) from shell8, but t= he > zone lock from __alloc_pages() disappeared. > > Kefeng Wang (3): > mm: prepare more high-order pages to be stored on the per-cpu lists > mm: add control to allow specified high-order pages stored on PCP list > mm: pcp: show each order page count > > Documentation/admin-guide/mm/transhuge.rst | 11 ++++ > include/linux/gfp.h | 1 + > include/linux/huge_mm.h | 1 + > include/linux/mmzone.h | 10 ++- > include/linux/vmstat.h | 19 ++++++ > mm/Kconfig.debug | 8 +++ > mm/huge_memory.c | 74 ++++++++++++++++++++++ > mm/page_alloc.c | 30 +++++++-- > mm/vmstat.c | 16 +++++ > 9 files changed, 164 insertions(+), 6 deletions(-) > > -- > 2.27.0 > >