From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9B0ACF0430 for ; Wed, 9 Oct 2024 02:09:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C894F6B009D; Tue, 8 Oct 2024 22:09:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C3A566B009F; Tue, 8 Oct 2024 22:09:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ADA106B00B8; Tue, 8 Oct 2024 22:09:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8EFD36B009D for ; Tue, 8 Oct 2024 22:09:19 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9BD68120EFF for ; Wed, 9 Oct 2024 02:09:17 +0000 (UTC) X-FDA: 82652431638.07.33AEBC7 Received: from mail-vk1-f173.google.com (mail-vk1-f173.google.com [209.85.221.173]) by imf27.hostedemail.com (Postfix) with ESMTP id 78DB940002 for ; Wed, 9 Oct 2024 02:09:17 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Y8NQirSz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728439714; a=rsa-sha256; cv=none; b=pq8SaWQbYrIL4fOfH+DRzj1jxago6qa6DpYYzcK0FDRpLb0RpJdkCiWW3REcl6kXEZZV32 o/HxYD2gcyk6ubctZvu2eUjKcEqdJryfpbz/vbfwex1gba5Cd5yFctQ8kzpt3CmI+XksIr RzPaZw6ldxoUPQ1gjCI5mx1ud1UIvek= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Y8NQirSz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf27.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.173 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728439714; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qb1GBUE5bd79oRRfoU1wYzeVHp7KyK+orebRrydrldU=; b=g34zDO3wTd044CQDHzy1gl8GVKsv7srK5QT5BNLz5q1vHgaTHPDqw5KrvXdHT8ttyzvd+e /gFgzQ9Kpf4HAGvNzE91QpFI+90zMtWgRLQje5Z+yw8bNx+BtwHSm7Avp3FiknHRooOmw9 Nb4/iKARf8aRu+/XZP1uUzQxNc1lx0k= Received: by mail-vk1-f173.google.com with SMTP id 71dfb90a1353d-5078bbc3a0bso1745839e0c.1 for ; Tue, 08 Oct 2024 19:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728439756; x=1729044556; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Qb1GBUE5bd79oRRfoU1wYzeVHp7KyK+orebRrydrldU=; b=Y8NQirSzv7p3caN1xfsyuYb+t0KVJ6NxT94fuGRWw05UOB/txClVdmB7YhLbTGhbRJ HvZdkDTbUWWRy86Q7X/fIf2Yl42BdqgMX7cYaQHeqLv1k6e6/wQTZD5Wg14FbJ1fFsw1 Zj/RWVFN/EOwkDOttlruuB8oLDkk4W3bJpGxDUH7i5LlfDCdsvRtihpGA70bc4xXhC69 3J9LTJYJtrhXMYEkLb18+oyJU/fqxC4gDMjsv1CL9mcjoGwtigqBseFbB7b2KGxY7ml7 PJdCBvJwpJdo7kRgCGT9fmeubX98jJDC0IaqmgKAeOfdHv7Va/bm3D/QnOptJDQ502bm xpZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728439756; x=1729044556; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qb1GBUE5bd79oRRfoU1wYzeVHp7KyK+orebRrydrldU=; b=T39wxasoYjKUd4yjT3vTNwGKsAbdJUvJLrUIZzNThwWAD6dS1YBKuHhIW5Ozin1SuD /heawqVPmlwzHMBdIOApsHOvIzZj9VBHxoHW5jovPFhHp7ks8Cclq4rSNUQZJzxwgTS3 rCsC3BG//VbOZZyMhbjQx01yV6L2hlIcpN3BPyp+oucnWokzdDsB7NjRRU7m4Jt6oDLi Gq/4lN8v9X7dE8cSKynMxvX+wATeeAFHyepAvCOH0LyRH4u4RLNQTpmpq4z/ZD2LBQQg gOlnPn2Id3udUUy/Avt3tf8gFj29oa0uVIOJ8kM9MqX2qNCYjOOP615NNJLYmglOa0ME EKFQ== X-Forwarded-Encrypted: i=1; AJvYcCW1G0vWBln/OlB5EVzJqeWiHc11r84/jMdyH76KqBkb+P7zCD8b5Bs7kGQdE8xl2FigIkiH30gs+w==@kvack.org X-Gm-Message-State: AOJu0YxKsuGN0irreJwPW+RQLBv9mR8ByRaJFbngET/8KPnORM6Zo4YC 7sd9L/dPRhViOKiPpKhwWLZC0ePHWmmfWM2EV9HWmfJbYx8ES1pvva3FbQ4FmtcnhIN40j742b/ UhtIFU5/p5CJPvPor7xFKHdQFZ6M= X-Google-Smtp-Source: AGHT+IFu39wHmH+QO6CWG2Nv6HuHj1Qac8nNN58a1in00REEJe3X0XIxdNjzyUdLEZls7XOWPAn3Cnyf1yghCNWk3tQ= X-Received: by 2002:a05:6122:2a42:b0:50a:c73e:b337 with SMTP id 71dfb90a1353d-50cf09d1e41mr496087e0c.6.1728439756402; Tue, 08 Oct 2024 19:09:16 -0700 (PDT) MIME-Version: 1.0 References: <20241008191329.2332346-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20241008191329.2332346-1-andriy.shevchenko@linux.intel.com> From: Barry Song <21cnbao@gmail.com> Date: Wed, 9 Oct 2024 10:09:05 +0800 Message-ID: Subject: Re: [PATCH v1 1/1] mm: Remove unused stub for can_swapin_thp() To: Andy Shevchenko Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Chuanhua Han , Barry Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 78DB940002 X-Rspamd-Server: rspam01 X-Stat-Signature: ck1ej6jguzo5zjrzryt8mf8po73bszk3 X-HE-Tag: 1728439757-792808 X-HE-Meta: U2FsdGVkX1/SMCFRDW8USzzwZKsSMu+k/u3pWcqB9pNdM+o3Z7V0csGOYhImwonk+rOvoR31SmolMDHWfftDERi8Olr+3TMH0Ato0SsIg0PyTr1O0VLnbhyN635eyKRodrsKUo2p0TMY2UP1J2hkR99XzfECHSi5gohT5N/y9uoAN/+RkW4p37PPYRH1tMSgiemuk73twISRWpZAwBO09FdOc2OVpYAI7S7hOY1JKZXj9uAgFZYusU9Zt8c0OI7IMCChfoKBqwIY7dYxpdPKgFjDFrm4RHTAzjIErvFDfc0kPnR/mX/yETnmn/PmXp32iyFecbmAc1F5EJyEU2K3sUgrCtWgkddvB7725qs4y8TqxROwlnSvw7/Ddsoik5OvvTVLKJP5C9s9+iY1rbFqn2+X2cZD9cv42h8XzSoTSrkvGEfNoJruzTO/K/L6RZWvMFDjTZHXF2PTlr2oUqVxm0uEBHQhbMRGuOjdZg/fVdI77d0+JkpOeLXcXwE4P0oTqlVwUzR9rvSMJkNXno1Q3n9cRZxcjQvH5OAfqmP4xepxdaUuHazQ5q3VHytyk1CB5OryBfAJWrBU4dXo+WZ7XoOMlyLfDpbMEddEMNFnmqA+VXVpxCUNG15+6P80X5Efjf3Y+C/+rpLhWq96hVBmSUPyC/1gkSKgWGGcU0EzIkorgmJFtMzITOD2zys95JxuWjzEYtDj8E1gOj/1AD53XV/Kh2S3viliGV3ez6Dn6DxX47G5q9voHIESgMtsnag0rvlgDKUmlEdVPEXq5aNrw0gyORbjn8KjKzWeGlxCrttSHtNznHh62CVnqDRXcVPJoThQTXhxm/3EpLoTD1D7fnd/56a6eXLuZl+6kveBooFNZ4EXqVNLZa7NKSRntMwo5W2CuQT3T7i976SCxNuntmTVkMai1pxc6np+ieHbBf/jTwPalCWesEo6IaqOf8tUBq59bZ/BBEGJOO6Vnxx AOIBe2Gz IR53SzqUfEYIjC00ZmnRo/noQo3NlOrD/3sMoa/5VahZnNuE5YgIC2vYgh1o/c9uiELweFxCb4FZW9/izontjwdFmjkVDqqoW6b/dhyqs82OBhvjMTDXbXzoO1VH6keUsfo60eZSBL6XJTYT2LgK7QQe6PDoyLAcTTlHDFewxKPcrAGo3PDMJN+fPdbpUDmysI3o/IEownmlEjevrWNfDweQ0lPN+84Iu2Fxi+HaxFULXRhsclOyQ5Kgu7ZKUz5AweGezlMNq12kB/FevLjZLfB0Afe1gOpcnMxNCVZNsuIkD+eYPj2tDN0bJjVFthvFkLJ0KRcOZtHQoDEONuCCppY53LiZXdJ395PgWTOLO0fh0tzCwckBDsGun3U+kTaSigKX+fYQMh5aRe/fEr9pORY8spD26LhpQnGTM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Oct 9, 2024 at 3:13=E2=80=AFAM Andy Shevchenko wrote: > > When can_swapin_thp() is unused, it prevents kernel builds > with clang, `make W=3D1` and CONFIG_WERROR=3Dy: > > mm/memory.c:4184:20: error: unused function 'can_swapin_thp' [-Werror,-Wu= nused-function] > > Fix this by removing the unused stub. > > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static > inline functions for W=3D1 build"). > > Fixes: 242d12c98174 ("mm: support large folios swap-in for sync io device= s") > Signed-off-by: Andy Shevchenko Acked-by: Barry Song > --- > mm/memory.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/mm/memory.c b/mm/memory.c > index 2366578015ad..c0869a962ddd 100644 > --- a/mm/memory.c > +++ b/mm/memory.c > @@ -4181,11 +4181,6 @@ static struct folio *alloc_swap_folio(struct vm_fa= ult *vmf) > return __alloc_swap_folio(vmf); > } > #else /* !CONFIG_TRANSPARENT_HUGEPAGE */ > -static inline bool can_swapin_thp(struct vm_fault *vmf, pte_t *ptep, int= nr_pages) > -{ > - return false; > -} > - > static struct folio *alloc_swap_folio(struct vm_fault *vmf) > { > return __alloc_swap_folio(vmf); > -- > 2.43.0.rc1.1336.g36b5255a03ac > >