From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5358AC27C79 for ; Mon, 17 Jun 2024 23:37:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C3FA38D000A; Mon, 17 Jun 2024 19:37:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC8658D0001; Mon, 17 Jun 2024 19:37:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A424F8D000A; Mon, 17 Jun 2024 19:37:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7C1868D0001 for ; Mon, 17 Jun 2024 19:37:02 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 24E2CA196F for ; Mon, 17 Jun 2024 23:37:02 +0000 (UTC) X-FDA: 82241993484.22.E521E9E Received: from mail-ua1-f41.google.com (mail-ua1-f41.google.com [209.85.222.41]) by imf28.hostedemail.com (Postfix) with ESMTP id 5A939C0017 for ; Mon, 17 Jun 2024 23:37:00 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=D7JcE77E; spf=pass (imf28.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.41 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718667412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nhizp+dF8ZrSnke5zqlKT0QIEG/gsRHpPFFjzvmIY04=; b=FnYJlsXn1l3zyb6fmnvjZKIR212ZjQ5/Hf2zs6I29zu11zW7Qsk/9ZDJhEZdaEXEKokRC5 PtKyKTpdShHsRXudJIwTzNq/DJnLN19LH9/qCa6/sbw8Dt0WeAHaRv6HjmLs5EFG2+wTBj 7XlkLmIPtYtMsstFk6y22ZZgQTXY65U= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=D7JcE77E; spf=pass (imf28.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.41 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718667412; a=rsa-sha256; cv=none; b=1kfMYT7BOfwTqsWqJUKFp6Mgm5hvDoGVU/qk9c5pi4FlSmRwxHBMWfnBwJq/wpBagCtmCS ESTEtIPBeXE6uXezDMl1ByKapfrofwRbs/vBBl4D5IGjtTMm9ry+gk9baaf13gXHVqkLSP T0i+lSkJDYK/cHK1FQsKOoav0nk5KcU= Received: by mail-ua1-f41.google.com with SMTP id a1e0cc1a2514c-80d6cf96e13so1318827241.0 for ; Mon, 17 Jun 2024 16:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718667419; x=1719272219; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Nhizp+dF8ZrSnke5zqlKT0QIEG/gsRHpPFFjzvmIY04=; b=D7JcE77EtazJdh0qF1MfllTTkRimITHEkxk/2no3nzNA7LGN78nBLv483G6ot+tovv HHZQbM+EpGjRzu5eHSfRfecQuTsnEhYLxDit5qC+34pqEon+DjM63jG7sp2Bom0+KUIa uewjc+XkiA2QnnKneC8hCAhzAjkfP4sIvYp4FuIA2hz8hq0YSD9611hFmJuCC0XcTEOV qaN2eiFmrf67+o3vOMUW7xFKUXmhZUp+RNyWGTRtfqZUCDqfaUAqCZwOck1fXZEp94FG gz//i327Fyrl9+4HcUhKhyXzn3qt7bw6zwLLCsQ0cq7vkuONbRFRxIR+UjyNAPSXXC5g BHdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718667419; x=1719272219; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nhizp+dF8ZrSnke5zqlKT0QIEG/gsRHpPFFjzvmIY04=; b=VqMMX+89UVGTAjGiy3vH34aNwhMBzWkSmBhGLtoscAvlxOB17bYFIt26IUbYDq2i6B y1g4zmY10SR8k5ggiPp8RfSKvSRsgKcfBAyiIb7n0fAoPEzDZMOpMhr9z5h/apcaRiVP BivJf2/UesWv0zxufVeMd/vEdGRUp+e84h2cQOvd2aekxhJHK+uzG81QTKE8g32vqMuG Kqxw7nhFPHnyxs0B4UGCUzKYGomM9Iz+wDteeZ8AHWsoUerYVNXr11PS6QsvHPaMbzlG gwxyDZ9nmJNw57CA0K6Jhs46uGMGePQtpa3WudHtDg6/Cu6gYIlXUj+focf/WXnP9Qvi UhTw== X-Forwarded-Encrypted: i=1; AJvYcCXTbzKIzZXBaJkJlOiHOSXjcdvFcSsnpRKPxCu/esKIuvwzPhLXkcRcLCOOyJcKzYsdngwRJMFKlBq6JyEU6XPr0jA= X-Gm-Message-State: AOJu0Yx7E1z2KRi3kwFDOj1lXplvuGMKYs4QBv7LVCQGLklE6hmPwhZ7 PD8X6ZOBqt9SMcp3sLyssAluCE3KhPzt+AOdmBLy59mfZqGm6ZDF2luBVAUygAAFaZwlWAlmAcI WUeZQ3ONqr0qGD6MztlJAHRpfEA/7N75BEpw= X-Google-Smtp-Source: AGHT+IFCS2bVgLk/ekfAlsUvwV4e8SIR8lXBrgMBaenoAYKDucebqzO1jk380x7p4Elm+ckdtYWRm9uFHquEVPeH258= X-Received: by 2002:a05:6102:5893:b0:48d:8199:cc9d with SMTP id ada2fe7eead31-48dae3cc51dmr11582455137.27.1718667419275; Mon, 17 Jun 2024 16:36:59 -0700 (PDT) MIME-Version: 1.0 References: <20240617220135.43563-1-21cnbao@gmail.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Tue, 18 Jun 2024 11:36:47 +1200 Message-ID: Subject: Re: [PATCH] nfs: fix the incorrect assertion in nfs_swap_rw() To: Matthew Wilcox Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, sfrench@samba.org, Barry Song , Christoph Hellwig , NeilBrown , Anna Schumaker , Trond Myklebust , Chuanhua Han , Ryan Roberts , Chris Li , "Huang, Ying" , Jeff Layton , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5A939C0017 X-Stat-Signature: s5qfinuabzs18bfuda5549ofczjzifx1 X-Rspam-User: X-HE-Tag: 1718667420-109046 X-HE-Meta: U2FsdGVkX1/vnvIrE4hAXIq4o2r7jumR1lmMx1V2xGZ97sXBQApkauanPUzVTJWJAA8BXS3++KgOzd11fAhKKV1OnZBrLG52BP4KOiYHkQLKaXmlpTezMnywrodnbvmhoi7yN4fhyIP/QDCXgRzz1pAZSrJt2qoCYX0TmxEcQbaiA7EvodtcJQUxGbIXM0xplWq8vMJMzaGSboBSKmsLMmpitM5u1s7UIsl/mDA/b+i7zT+sH/1M5DhOrbrrkYA9fJ3lSL5gZrscD2ewdpwUe6gMNneArj9zn80ZlDBvVt5ktp01ugg295CglQEgaa9oJWmUizatVAUt/77okB6U6kKmPQxgJrWyKPAZpl+Dz4W74Bs/0LOEgw/cB9plSz4qx/ya8gPkC8IqcqCtu7DoHnqyU1gyUkYrH/NFUm3VGC1pNUDQfQuY2CoJRzeP56BIzKPmD0tWRnnY4fkD6Dgi9saUegSCLJCKmDstjglB8iKMQ5SRmbYR5z/5NVA+5F4MVgPqnmU2eAo3NN8CoOvPAFD87TbP9tUxyiWOFj8BcZYPo86Rd68YP0kqcuaS7J7KF4tBbdzAmHBuqIHtXnE4BAxYN1xTFMg7mzDAMQZnh6zUGGvsu96o8DTosyNd/zIKjdcfRuGjIwSgXtdAe+VRcF4ToY0KwNOUXsf4rV2R3z9y5DOiMrkRxhHRChQsZAiRXn26EX1Zsm4di4BXJfDQuVjwW966PQJSEPCKUzDsZppt7QJZJVercYvwJ1kVR9Iqv29oLr3j4XWBqIUB+Ruws7EmSqJOzf19ock0NVudN3hjj7yo1MTSXiZEcvralGj3ao9EFA2H5I2h7AGOIPFPyQDtP66ccTlh4SyGLEK1PX6sCnBe4ZwcqNOqygEqurrUkWHQ8RWuRmaylpbsqqzm10S/j8qpnFnaqm0SyEXYS2HtEA+OQN35NEksIRCZjqPUCNjycAZa+8lqdK6q6ep 5LCaCGrj m5UAnTTjuxmSQ1Us5NPYn1dYYA9isfj4zVQ0+HpIcHHkMUhiu3zjBn1EpoZ8wzG0NSFRIQTB6gTy+5BF/SdEMavJU9488jyR7QU+r8x11IfeGMjsELhkKwOHQtSlXysQXJ4MCg6ewckbD9LuPf1FT1IZ9yBFdhbCB4NqEjSGI/dQbbFkzmI3PPWr/AvPJKBu0hJsyli/UxkoafFpWTQ3y14IMcyo7es7yRzA4/tEQZgztidze51yZ5lTo/nYeT/o5MGao/ekFnwA7mbqD7cYrmYoiYOboKBaJcaxXJIpz03PQaKwLFKAtIiqEBJSTm4qGT2tRwnRGO3cKSMvHf3U52HAuQFO91mKx8XRmh/Cv1cFkByy2eFAp54rjojm9dDIc8xIMw7CT+TqD7ykP1cdpf4+Vaw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001440, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jun 18, 2024 at 11:17=E2=80=AFAM Matthew Wilcox wrote: > > On Tue, Jun 18, 2024 at 10:01:35AM +1200, Barry Song wrote: > > +++ b/fs/nfs/direct.c > > @@ -141,7 +141,7 @@ int nfs_swap_rw(struct kiocb *iocb, struct iov_iter= *iter) > > { > > ssize_t ret; > > > > - VM_BUG_ON(iov_iter_count(iter) !=3D PAGE_SIZE); > > + VM_WARN_ON(iov_iter_count(iter) !=3D iov_iter_npages(iter, INT_MA= X) * PAGE_SIZE); > > Why not just delete the assertion like Christoph did? I'm fine with either option. While maintaining this, my thought at the time was that I might want to reassess this assertion once mTHP swapout is supported on swapfiles later.