From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 132C9C3DA59 for ; Fri, 19 Jul 2024 07:43:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 865776B0088; Fri, 19 Jul 2024 03:43:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 816176B0089; Fri, 19 Jul 2024 03:43:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6DD976B008C; Fri, 19 Jul 2024 03:43:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4ED4B6B0088 for ; Fri, 19 Jul 2024 03:43:53 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DF03C160337 for ; Fri, 19 Jul 2024 07:43:52 +0000 (UTC) X-FDA: 82355713104.24.DE32401 Received: from mail-vk1-f180.google.com (mail-vk1-f180.google.com [209.85.221.180]) by imf25.hostedemail.com (Postfix) with ESMTP id 14966A0004 for ; Fri, 19 Jul 2024 07:43:50 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RchHdXj4; spf=pass (imf25.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721375009; a=rsa-sha256; cv=none; b=ORbdNoc73LmFIlQkhot0S8kOxWyfI8IyplK1qGJZr1JZ1VyA9jw21waNi/Pku7i3LaIls+ jJNrc4x3e4kJ6UHfyFztdPaewmTJYLFl2mLwk9jdbqpkkDxyv85IgHHojCDn7riOY9kGHl dAXoZKWDf5niF7eCoHYCSXVXrLoVMzk= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=RchHdXj4; spf=pass (imf25.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.180 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721375009; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f4h9csehFTyyi0bw/5SmrlOG4XEPT9wQx4z/OOZq3zE=; b=Y/hAuqUyREUdmx61yEY222i4UA8qe1Dbr8og9HMqVagpCsofA/WyRaSWBxz9OukuuPfJb4 zNyde5HagBC+ilzNX5SmlDteyIFKDGyPR0QOdoO77NLnTyin7KUwICOlRYGvjlCGMKBcVm neHXhqxgdae1/g9IL4L+GINFO28lPjs= Received: by mail-vk1-f180.google.com with SMTP id 71dfb90a1353d-4f481c2bc80so609512e0c.0 for ; Fri, 19 Jul 2024 00:43:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721375030; x=1721979830; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=f4h9csehFTyyi0bw/5SmrlOG4XEPT9wQx4z/OOZq3zE=; b=RchHdXj4i+Q99Dx9kq708goPKdrHcTJqIBsrTXKhm8FdbcGVNjquECMfdxjuYtC4fg yQYdmBtfluzP8jnDveCbZ32oLCvGpb0GJ3MpbDfy7rhI/t99JTIKusyGqktdc9+AqnRX du4dmecKsh7Hdo+NWWMbLA/npSPeGyyUTYYw8oJgVATx7nl3Dd4navvidQ/MaBiPkvsl gv1zF4vz5GwZzZYxiz0liP3FiyknDZpYQnsbQL2GMH+oo+JN9nzCrHbhvgKUDBBnCKWw JeWoLX77vLyr+AUUhr/8UcYsPTQZpsOXg5ZJP2RTYA6NyuOGoYg2t0hT5ly9ngxailuL oXow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721375030; x=1721979830; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f4h9csehFTyyi0bw/5SmrlOG4XEPT9wQx4z/OOZq3zE=; b=H5lk10xfkkPyEhEv1ZXvg+1y2Blr2yxaySZqlOs7q0YzpDjL75ciuKckluZf2u6p0d jQWTpJ+qHT22lXqa7m0UPslC9Fe/LJYTvRaQXz5HTS6TqM3dnGjxLR+HotBfMmKatWEn GHbcubu+5ZiGXvQeCM9xQZpbPeOZlNt+pW9ANNi15tKDni27HiOR1wMlNeFLAianJA8B UNcssUlBxs10Bbbf0bdI3qBmXMMStow6ecFX1jQkUVq+qK6rX35z4PWZx9eyeKOf6YDp p2pZPTqI8DKsM8q0O9kvQ+NdpNizOfMkqwmOKI/PD3KCqP9yW0ghP4R75udpjcwIMMCj k8Nw== X-Forwarded-Encrypted: i=1; AJvYcCUzdcu1PwSphJGYxZo9kbgNzWyWmlMMkuB2YMNOYBwrepROtImyOcjTFZDk1tpubZiL1Z86DRPRW4bT8kfv6iYleqg= X-Gm-Message-State: AOJu0YwRCh9qYQMy/Pv19zJJr1h75izbyCselKr6M950yjDg4tyWCa/1 9zx2UsrzgMD9PrqPFancG7uSP45Vk/mK8z9+BO4l4t3kmnYoFDxMYR3vyhbkGb8CuGzRTOWFQ5z ICu4gpC+9VKZ2vfKkAptMeSMwYEg= X-Google-Smtp-Source: AGHT+IGcEnOhFEG/aWUxTIBw34hCDkGchaa/ySkAgabhfifuirW5xYWpwWy8nNpH6qhnRZGC1xxdH6c3kZ6iqX/PAKI= X-Received: by 2002:a05:6122:c9b:b0:4eb:5fb9:1654 with SMTP id 71dfb90a1353d-4f4df6e5d5emr9671027e0c.8.1721375029978; Fri, 19 Jul 2024 00:43:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Fri, 19 Jul 2024 19:43:38 +1200 Message-ID: Subject: Re: [PATCH RFC] mm: warn potential return NULL for kmalloc_array and kvmalloc_array with __GFP_NOFAIL To: Christoph Hellwig Cc: Michal Hocko , akpm@linux-foundation.org, linux-mm@kvack.org, Barry Song , Uladzislau Rezki , Lorenzo Stoakes , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 3q4nrfzse7omwd51q8c551hk6zdshk7d X-Rspamd-Queue-Id: 14966A0004 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1721375030-306530 X-HE-Meta: U2FsdGVkX18BVvCzgxFlR27bsGYZJT0bxVsDEMfx7YEwpu71396hf27Otq0/3CNBXhDuJDoKQlxnyAPYDkmxV9Fx25Z34M7xkUWrouaoTnibl/9ApmHTI9BBnayxH2G8qL2n3sWmHc7dOGNZrC5owy4YlnBpSYrk2Tgp+irb9M5GB3PAwh1P/ah0JfAzaJARR1kFP/g5BBUvyaNquVgZTmtLT0ZmWe6qJqqJEiwehaz4tFkkXsuDOBKDVkYGPlYH3JNx0cSW+6cIfLxpTcOn+pJmryE4Qzl6MdBHWE+G/k/170T3FQQyLWuRMo6gwwY3A5ps8LK6G0MpMEQ6aH03uC52vbUqVrqOAf2pkWQs4Mht0zxl9cqdtIDPC/GjuKZ7aU+Ml8N9B2x4fq4/ejxGwxxhCBBx+ZmMah5lDf3C3JBO+ocMW4XHGWxymT0HbTnyu2mZOaRX9KVv58MawcCaqdi9H2MKmK7GZeZKzRmhbU9WKfjl8/KXQ1n9d5dgtjXxmWHRRJnp3qj0jnwJlZGdeD2Jdw7JhNuxU1KSpY3ZHY0As5dh049n30ftn5GUc7SPW55WxqvkzPAjOA6cZOMHxW4xqUvYhRiYrbPYgU5mblvujw+edYDaCYvosTQnKWo/w3XGHU0BEql25+UAOaCOSd++34Eis1ByJgmWWDJ67w9Fb1OAhviJDcMdxUEK95RnvEPqpn0afbFBpo9FJcLbeh+i9pevRqBPmgpH1X97/3NSM+0bTIozDG5hgQ1wUmEc9OENb8QWM48SbYOAXXmHwgotxAjKTX6pUU4ov+pYVXoekzIX6MXHarRgPp+5QdPIvr2eK840xtanfj44OiwJtXFVSdgKmqqDbiAXbwJ7gSneiBd/ZFTm9WYHBefW3U79KHYBZBoR5CRvw34VPcIUbF4hWagv5+vZqh6zfFLbGaTh0sIB46Nev3M/fWXxmgno5Hh0LdkaDBNvAzTijFs UR9LGjK2 pqDkHRFihHBinBU4B2fG6+2t9CvR/WtLMwVqmprM4sv/PE1hL5gZsErnoLinAnUp5AKy+a7kKS6mQZy45NWDu2uBOiBP2ImdlQIAN1IEFlPcjViaFIUmZdDNqvST3Htuv7wfJvjx6RYk4M2eJ6bqbQGmg5BFkEsr00qaemic02xlDks5czs+QB8NYpBcQj2tgVS9a4LJlMZYrDeQQWfdDEFub8rarR6L2ka+8bjX8Lymv2nYn/hDblMPZrrKK9rXzheMtbqxUCvXjHVmsoqLHmrXRrcXYfcn3jNTXez01m13nb/8lB4F4gDHf48yfLic6DhUGTLosLQ7P09hCo5hGrXMe/awkhRvhdgIc8u8JB2uuQSGW/3Tbx6aisWPFATgLHQvWh3/41j7qEUTIRefjXo5wFmMjXrqrPURctKX6duSUD3N5BOW4qkDFWEGFo9lCVbDurfzv8OGy/BtQaT2JAeoINCITTWD9NwZI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jul 19, 2024 at 7:37=E2=80=AFPM Christoph Hellwig wrote: > > On Fri, Jul 19, 2024 at 09:02:01AM +0200, Michal Hocko wrote: > > > Additionally, at least drivers/vdpa/vdpa_user/iova_domain.c is > > > incorrect with GFP_ATOMIC > > > | __GFP_NOFAIL. > > > > This is broken! Please bring this up with the maintainer of the code. > > No the only issue in this vdpa mess :( > > But I wonder if we should have a macro/BUILD_BUG_ON magic to catch > totally obvious bugs like this. I doubt this is going to work as users can use a variant to save gfp_flags. On the other hand, isn't it necessarily a bug of vdpa, why can't it be mm? if mm disallows GFP_NOFAIL, there must be a doc to say that; if it allows, we should never return NULL. >