From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BBE4C54E5D for ; Tue, 19 Mar 2024 11:09:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E0FFE6B0085; Tue, 19 Mar 2024 07:09:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DBF9E6B0088; Tue, 19 Mar 2024 07:09:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CAE926B0089; Tue, 19 Mar 2024 07:09:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BBC036B0085 for ; Tue, 19 Mar 2024 07:09:32 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 5CEDB121180 for ; Tue, 19 Mar 2024 11:09:32 +0000 (UTC) X-FDA: 81913517784.13.BFFCB67 Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com [209.85.222.45]) by imf28.hostedemail.com (Postfix) with ESMTP id 670C6C000D for ; Tue, 19 Mar 2024 11:09:30 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=V7JDWQiz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.45 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710846570; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iFFMom5/ZZ+nxNfevDyTk4uvoxRGCKNnKvOL6LWtnZw=; b=V6eUwmiUH+84oqeFBpNaNDNMHXo2dps4qJPk041ZnXeQKilX6EsBbZHlkbB5Xtl87BtsGP Ghtv9rYywsjS7WYaAlYUWtuu7ZrGMvir6hQwmcLfoGpOCh2QLFEUpqsa7ooNX0RNhZ6uXj KEIFqFA63jH6gqau/zxHbpknAR6QQpg= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=V7JDWQiz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.222.45 as permitted sender) smtp.mailfrom=21cnbao@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710846570; a=rsa-sha256; cv=none; b=jrCk3Hqpa9JdoeqWbzBS4LkfvXGWgtXoCzQlCYoV0dqmd1T/HyNzEXpF7AIbHn6mvB4Prh TLuwDtba54lJGmHs7PmCKfy5nlwgk9BtPPyhUete6g3brNK9vkxKuEuaFoK0EalIx+AOHF RpbNdIFR8u7HsHWNouvbmnTVL6HU57c= Received: by mail-ua1-f45.google.com with SMTP id a1e0cc1a2514c-7e083af7ceaso480102241.3 for ; Tue, 19 Mar 2024 04:09:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710846569; x=1711451369; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iFFMom5/ZZ+nxNfevDyTk4uvoxRGCKNnKvOL6LWtnZw=; b=V7JDWQizaBtGRZUKcCeGPpsOtrLbjsOLGtXrVxeSYjKI0qcGgM27cNP25B9iWBJsrU ue+BTJOw9CiP5bOokIPWJaedbnpI37g2v8AyipM2lydkTpJs5sayjaG/AJuBSoDqh46/ I/rqBvB9bJyZpkUmzgvDCFwcThJbTsTycHuLiMS6d3C6iFQWD0URR6JFzqkYlUHQYicv M/qzxkq368JwP7IvBiiQhnR6Uyg8e/UfFBRb33y8QXmhjzNhgEbKN2lUdn5n3Fej6Ol9 uqYaCYnjGMCJkzCD/8ILkCZpYuMF3/IVINxF1UfnyqglZ3YCFlPvW0VEcASIgHyCV4zW 5bBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710846569; x=1711451369; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iFFMom5/ZZ+nxNfevDyTk4uvoxRGCKNnKvOL6LWtnZw=; b=CFMQZql5y6C8Sgq37euCHfGBcgnQMKxlJ/Wk94mQaw2ZcYVFHaIODepN6h7l5OJtpB tSrPI6bUU9Yt9op38TTTMFQjgm/+nnW/mA+9ALxGcaNBW9vtDUjE3hMAqloUbKZZ6RO4 hI8VlFS/1aRlOIt1CYCPjw7+HxQIbPPgU2+k3RP2snJPtoAbXdveN6ILNIQwRBwW2Qr+ rabAp2pXuKmDbWaWEB49jindwhHkMTregGtcz+Hv4dIH/OER/N4UPWNtnQbNnHbn1wFH 8SlRPBg+yRzFW8jAZ78pQk9bJE/z64cPla65NGwRbz+QA0Uw9lmTrKCrYMOGSI+2xbU+ 1YJg== X-Forwarded-Encrypted: i=1; AJvYcCW8iEItgbBffi3NBjdGaS0MsWHsSokGyA/90vDwGoanRuCX2XrbpsKPJz3kpUx6g7mr22XgvToM/9s0EmTdUzKmtkc= X-Gm-Message-State: AOJu0Ywo3dKnlVhqHDzXHM0X4us6cLi7JUofKKYLkR+CPwwoN253ntf/ Z3gtO4TX1kUsO8OCpm7kc4kpbblPYa1c+xdyIUIs9YdKElkZPYjrhbiTVEtmaa5Bsz2fF3icpGM lWZM/ZHbfQxZU6BgyMew0IoIhS+Q= X-Google-Smtp-Source: AGHT+IHM4xyglbb5pffkcPfzACI/wBLHk//vDjZGT4FoVpHhmkFKx2NL+9FyUklB5eUGBbhXcbX0g7MwXMxUrkqaoD8= X-Received: by 2002:a05:6102:3a0b:b0:474:cb65:d400 with SMTP id b11-20020a0561023a0b00b00474cb65d400mr1843847vsu.24.1710846569394; Tue, 19 Mar 2024 04:09:29 -0700 (PDT) MIME-Version: 1.0 References: <20240314141516.31747-1-liuhailong@oppo.com> <20240315081803.2223-1-liuhailong@oppo.com> In-Reply-To: From: Barry Song <21cnbao@gmail.com> Date: Tue, 19 Mar 2024 19:09:18 +0800 Message-ID: Subject: Re: [PATCH v2] Revert "mm: skip CMA pages when they are not available" To: Michal Hocko , liuhailong@oppo.com Cc: akpm@linux-foundation.org, nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, surenb@google.com, zhaoyang.huang@unisoc.com, quic_charante@quicinc.com, yuzhao@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 670C6C000D X-Stat-Signature: ajsif8bgc4w4pb93djoy8d5tzeubu6c3 X-HE-Tag: 1710846570-985852 X-HE-Meta: U2FsdGVkX18eXXrgDX+0u43yKdhCLiePdvJXdPSiJ4xXln44TqI3gZizkwMvpxE9htr+V/uFdEG8+uxI+zomzN1ORQ5ErCsUmniGcpSfRjBYGkUXe1MHfjcLZHdsRJ+AOqx2Mire25cNHSu5gKo3+rjwCXlAg/plCDCfFSJW1ALfD0NSsr9F6/gY8r1YrvmElx6uBnt08/icWuklDAazOoY8uK9Bw8RqdcvzoIq7CThvO1ZVP66g6r1LL8xbiYcLrgKXVNTkB2oRaAuTR1QqMrFdzf/p5kYTTelvfy32mq7K2mNopMWqZwuSQ40eazTMYpR1/Zlt80rMHwJoJ1+urfeV1FHZ7nekEjUK1L1By3udY3jnnLdzz9ZQAjTGXdG32BQM28M21QiMm6OkZQ1/35TAUr8hie+rULRO/iVEuHhUMyFtMvBxyljem1QsMWDurcZ/M1xF6uKtZ7B6Xvw9wCHAjNl7VU+eJKXLkk0frRdwfTY2c5OpvkrUDWYNIuWXufG0rjG7cpc6YJlFjSV1DNrBO3T4pwB3rBcPTjdfOW3hxFRJAmv+dvVcp9puhR9rQFgsyDtJ2WhEQmbzWxzu8CmPKqPWkjXKxoyhNBU4PP02mEyvO2TuUh96D5/+Hn1scxEu25HatchHFN6ddaA8/UDYT5eBKkuO6y4jcFIXVAQhQS8D7dH+oI1Y914UdaKHEHmIiRiPTtIpoRObPYLopJ/IAlwz82rvIb9T387FSEHz8JdTQZU2LDtnI5gFSP3mQqKMeoCSiqiWG/UVBCTEHatRsZ/ej5peP2+A6X9VdQrrg4WOwiwbnyorzy4IX2DOvkG/K/ktZqDxvm2e9AZRO6eb5f7bHaAyzAPez7SinPwwPK14NkJM02edc1VV912j9lEHc6/yL6J7GcedpQTNFF/H+vnCOFw34wre0s+J0l0n+0iWuLf7zEvQbjhlPgMnbsmqDvXKGejMqDITIUX zYaZOk6b Eu3yjJ5gNoXEiusPhbOGP56Q7U1zn+6ndRUoDt0jMe3rC9hrYVts9shFwHiySqHKZHWEjsIgMwbmTU6wru/WEMjVe8Fj3wsd64YY93ctyI2cfKtH1mV4FrV5uAJ5u1VIAE7h2yLhugajKN9c450Qf+7ltQSCllJWdAhuw3ILblWsz4GULNUVfRz4Dejkd7+f51CCnskzjhCXFxLgKXfF3uB8mYIMcJReZ6sfhPnSJBUkkR9QZCPLqEIImA9l8zk0ZWbBfPxoHQRBgxCPwlABuprCOwML2OnF7uTMjYVa2xDJJ/Y3qNh3ACAyPRy9L1Occ2o9z841ZwZFbShDqNwLliwkKfZNYlT590T5O3mtg6rM8fGMCFFfSc0ey1L7wSvxmfZ76tJjb2ciZpxtJZ386TVNVtBkfhceLTEik0ZwG1UW9yNT3Oiny7JCk/tZ+TDQ49SP9lx9+HxDCz/kKHXLC/Ch/nQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000174, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 19, 2024 at 4:56=E2=80=AFPM Michal Hocko wrot= e: > > On Fri 15-03-24 16:18:03, liuhailong@oppo.com wrote: > > From: "Hailong.Liu" > > > > This reverts > > commit b7108d66318a ("Multi-gen LRU: skip CMA pages when they are not e= ligible") > > commit 5da226dbfce3 ("mm: skip CMA pages when they are not available") > > > > skip_cma may cause system not responding. if cma pages is large in lru_= list > > and system is in lowmemory, many tasks would direct reclaim and waste > > cpu time to isolate_lru_pages and return. > > > > Test this patch on android-5.15 8G device > > reproducer: > > - cma_declare_contiguous 3G pages > > - set /proc/sys/vm/swappiness 0 to enable direct_reclaim reclaim file > > only. > > - run a memleak process in userspace > > Does this represent a sane configuration? CMA memory is unusable for > kernel allocations and memleak process is also hard to reclaim due to > swap suppression. Isn't such a system doomed to struggle to reclaim any > memory? Btw. how does the same setup behave with the regular LRU > implementation? My guess would be that it would struggle as well. I assume the regular LRU implementation you are talking about is the LRU without skip_cma()? I remember Hailong mentioned something like " it also trigger memory psi event to allow admin do something to release memory" and " without patch the devices would kill camera process". So it seems the difference is if a killing will occur. Hailong, would you like to provide more detail? > -- > Michal Hocko > SUSE Labs >