From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10E92D66BAA for ; Wed, 27 Nov 2024 01:53:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 75E406B009F; Tue, 26 Nov 2024 20:53:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E91D6B00A0; Tue, 26 Nov 2024 20:53:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 562306B00A1; Tue, 26 Nov 2024 20:53:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 336506B009F for ; Tue, 26 Nov 2024 20:53:35 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EC868C11D3 for ; Wed, 27 Nov 2024 01:53:34 +0000 (UTC) X-FDA: 82830202812.20.B17DA57 Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) by imf13.hostedemail.com (Postfix) with ESMTP id 1F5D320008 for ; Wed, 27 Nov 2024 01:53:24 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=P6nBEbCY; spf=pass (imf13.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.171 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732672407; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F0AUCCL/mLvRf8gjgbHx2zcR9CYPuwNLmm93UWFUa8E=; b=rt8ee5S86aWKED55jytODTnUhFUKy9NfRqJ3IuOsGutiiqJvFe20OZaENoP5SGD3DL7BQW 2UTNMq3cyyR2SF94k+IhyAlenpx6sZNHEBHAHA7ep2VcMCz3DshRFFQqGuuGsz8qDpUGEb VBfd/PVKAIAsluNdNXLRtxR9Bw6pOK8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732672407; a=rsa-sha256; cv=none; b=VUBS4rZrd2uWQvLAyUk0W4fRbZv9MnTd7z12ujWEStPtpRx2MfwN6x4Ln3/L/efpHcaYdo 0/XWkws7dsh/3XBbDawu0hEKtI5Kco/ynPI9KWCxJ2GHwNDBgOlsvMmui8tyyh8omgwKFj c+4rLs30yct6kUHz/xd5dLOccgRHuS8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=P6nBEbCY; spf=pass (imf13.hostedemail.com: domain of 21cnbao@gmail.com designates 209.85.221.171 as permitted sender) smtp.mailfrom=21cnbao@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-vk1-f171.google.com with SMTP id 71dfb90a1353d-5152a869d10so856500e0c.1 for ; Tue, 26 Nov 2024 17:53:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732672412; x=1733277212; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=F0AUCCL/mLvRf8gjgbHx2zcR9CYPuwNLmm93UWFUa8E=; b=P6nBEbCYmXzwuOWFnIIal1O90fvhUk+Yj9tBKEtKpd38MjevUMieSBkJsYga9D6m7P Ih9X5YAsaaJnin3HaSgzMbkHqV4C/hvMed5gfjjd9jS4M7En1g5P+pzvQ3srNDxN+01/ Q5X+5qj78aQIMkhyftUXuwxXeVL8qG2qnV36GV4SwF6ZpCfDotSRzE2bH5962J1dvcF2 KgmoKd8mKW6kJO5+MWaIg6OwPp9v3zPkS+i8EuYAviauxcebNNR8WcZdd79mRebHavhq Ddc+FJw6F0p6icqusZNQhQq1HzGJWtzK37p8TIICwlz1lKmdw9Yg92GdKrZQiXpT7bSO iHQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732672412; x=1733277212; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F0AUCCL/mLvRf8gjgbHx2zcR9CYPuwNLmm93UWFUa8E=; b=cQ2oifbA/Ij86R0P1VWWZv1z1MswN4rI1wv1jj1s1EyG9KD+7ONt80ns8gByB90XUa 4zDb9nyB5D67HTegUAp/DdUmI+OurWaGgxY/7kl+ByGDq8Nhl0p6VGlL6S7QPZhIrOmh wiK2QOQsxiCpu5OpFgaUYO4Vrndw0xlLUyq7MG3JOnMg5zTV0VnRPjpPErvimc7RQbcm igkgnnktT5papzXeFZLPCoQjCTOVJv+87WsHNuBLBfrKD2rmRMSTyaAmYfmKmU6hX36e h77XCKvmIFEqmkp7K+CA9ezwerrRQcH+gt4o22jZGR2T//DVo20vt9liHLm/U4JISYNs 4cDA== X-Forwarded-Encrypted: i=1; AJvYcCWLsLo06y/i0uR6Uat09xrSjTUHPiQbkEY4ig2DFNpIajxvOtD8eO0IaJWo2dNy/BfGV7V0hrZxlA==@kvack.org X-Gm-Message-State: AOJu0YzBmPE7PnIphl4lawZZ+n0BGSu6xxZwA8IIr5fFSnJ00VsidLDK pZvz6bpYpdddgFjWO66dLS55/JgwNtrix1Ze8Y48LR4ctGm0G1gd/rQc61fAUURtArU+PHE9FOp hay6rR8O3Ur/0BKeR3twG0bbuW1w= X-Gm-Gg: ASbGnctyRGCErvgVxl8jmBEmGOodBQiTq8YDD1SNTtEqCocoNMWdslD/16s/I3PPEm+ 0kqbJopWwzyv8vWWMM+U6Nse35Yf8AqZ5TLMp9YBSyApNck/x2pO7/wUGleVlfvVT8g== X-Google-Smtp-Source: AGHT+IHdvyNnYVVhR24K2o4YcAKXe8qa4dBbKhzD+IJnr3jWjTUCAuE9PZexcBsndRj6uGAnMgkixQeVHn8RauTLJ9s= X-Received: by 2002:a05:6102:e0a:b0:4af:3f28:77cc with SMTP id ada2fe7eead31-4af4487db32mr2222713137.10.1732672412247; Tue, 26 Nov 2024 17:53:32 -0800 (PST) MIME-Version: 1.0 References: <20241121222521.83458-1-21cnbao@gmail.com> <20241121222521.83458-2-21cnbao@gmail.com> <20241126053701.GD440697@google.com> In-Reply-To: <20241126053701.GD440697@google.com> From: Barry Song <21cnbao@gmail.com> Date: Wed, 27 Nov 2024 14:53:21 +1300 Message-ID: Subject: Re: [PATCH RFC v3 1/4] mm: zsmalloc: support objects compressed based on multiple pages To: Sergey Senozhatsky Cc: akpm@linux-foundation.org, linux-mm@kvack.org, axboe@kernel.dk, bala.seshasayee@linux.intel.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, kanchana.p.sridhar@intel.com, kasong@tencent.com, linux-block@vger.kernel.org, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, surenb@google.com, terrelln@fb.com, usamaarif642@gmail.com, v-songbaohua@oppo.com, wajdi.k.feghali@intel.com, willy@infradead.org, ying.huang@intel.com, yosryahmed@google.com, yuzhao@google.com, zhengtangquan@oppo.com, zhouchengming@bytedance.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1F5D320008 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: nqzyqagpqmkjzgaf3e69qh4xcrxe7ri5 X-HE-Tag: 1732672404-233727 X-HE-Meta: U2FsdGVkX19qPhS0gwcNYmNL8A8x6AzA8dXkjrdQJtDA4odvJNim1fu8pMjWBt/G051VfVm/qEjN70Hb6+v4sNTSIbgbXq08q5gLn4eTVrbbjBjYe8YP0XDP5GINAjUmdUOBKzVscMrA7ih/N3lztpevv5O6m8RecgQupSk3eP4vQLL4y/AYOi86GCZlzLFRSj13FQGROSvFGhw++SGNWweLPIANzbun2Kv4b9W0oLpTwiYu8HF5MYcmwNbnGMvb2QWwZZd0c5QwX3nKa+JgtmWSV4djEyJhnhSFd5B0gLj570u9/Nmi6yIKC9Gm84954ytyWS40lLWShCH4nw+316JIplADuaIivwNXH1H5/jZPs43L9LdA9lO4/1jeM1MJrQftQRb7FJevbGLnltJlb8R6tA/TQwIvG+ku5M3yVPHdsJuKrgUct2vYXqDTS9VsfMUj9EJ3pRe7o5px2v9vpdGLMG/6lbF4BUoxv000VMWyPSJXE7tuR/KyEtS2KaOq7+fZc7Ogy5GlPF32QIcByQvgmTcpb0x3O/rVPJ+kE+ZQQ3iwMKFPzQZrfXvk0NPBhQhs2ytd54JiF87bUuecHmLVE9K+57Z3EZm0G+Yr3nk3/ekxnrpRlKaRPJP1CR9IxfnSeVPvECojIOTpTm9tmsxr5cYBZc+2b4IRhmMuyq9x4rM4qcguvMD+7AQabiOVitQfpVq5lciBEE0cSqVj/05ToBONNmJRWUGjz9Eb8uOoL/9RoiIyTHZNXGVSTuFqwOxk9iHi5r9iBncYiZxr+XW0Z1DNObGMfHZwxSsy24+R2kDc/1amiGkVBDDC6VEer9cJTaBPxe3VvefycTAFiajN6CiOVwR+4RwQHabrAY6B7m4OgQ4RqKMSb6IgvmQinWuiM+Yx+CUArMHnohYLpO9E+rmvatDBWRwotg5rwBQpMJll7mqUoQLKV8RQzLZSODvE/il3+40WL7kO+91 feHazVhb FU65AgSC44ApIou8B/MwfvG6UyR4lNlSVX+eQuC0GnxfV153bpea0hzB1ywFBPZf3xM0nNOcHvAA7T9ceWpuAM5/K5561pgejqghCO1zHq9FMXBHjb9kkzY4MWqXf1HmXAf2vYP5cSvXRCPUVA2KqJnir+Hiq5dRfc/TGkCEEChH1MtqXBFINW95xaxLKWalMbyCiYaA5gR4GeanvByxSqYP7R/lXdvtDrx0sTxSYGh3ZOYwlZBS80VCX9EuLazaNGEs5vcwqobvOwC+YzJ4bG7UDavSe7E5IiWJb/Uh9oBxsQ0vrdWkFACKO7jkKpP/oY63FeHbFF+ymiMrQYY5u7o6rUA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 26, 2024 at 6:37=E2=80=AFPM Sergey Senozhatsky wrote: > > On (24/11/22 11:25), Barry Song wrote: > > static void reset_page(struct page *page) > > { > > - __ClearPageMovable(page); > > + if (PageMovable(page)) > > + __ClearPageMovable(page); > > A side note: > ERROR: modpost: "PageMovable" [mm/zsmalloc.ko] undefined! My mistake. It could be if (!__PageMovable(page)). Ideally, we should suppo= rt movability for large block compression. Thanks Barry