From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 195BCECAAA3 for ; Fri, 26 Aug 2022 20:33:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6FCB26B0073; Fri, 26 Aug 2022 16:33:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ABDB6B0074; Fri, 26 Aug 2022 16:33:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 57428940007; Fri, 26 Aug 2022 16:33:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 496946B0073 for ; Fri, 26 Aug 2022 16:33:00 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2489EAC22A for ; Fri, 26 Aug 2022 20:33:00 +0000 (UTC) X-FDA: 79842892920.18.1C21848 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) by imf25.hostedemail.com (Postfix) with ESMTP id B20B2A002A for ; Fri, 26 Aug 2022 20:32:59 +0000 (UTC) Received: by mail-ej1-f45.google.com with SMTP id sd33so5198801ejc.8 for ; Fri, 26 Aug 2022 13:32:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=FH9MO19ipUPbNSVtDvQwc3Bw3OL77ONLKCGO58YGE44=; b=BuSgMPpHaFBWRCG4Zya+4Hcz0JuqQvR6ZxS6UpU30lbJeZPyrdHIpEkJvOQEXxffLZ OBZy18wVn2Nm9xCc8Z7ZJm+6vAqNH4jf/eiXXEpghaUrakkAi46bLrDltgm/FnEhn/0a 8f/E4RwUQBmZvLHhWE0fs0Yml+DPGBmZkg1RyGh6S8Ek4Kp9GlL5G0uyMbAG2wbNB7v9 7MXDe9YXPkCo2gDnO78pd3E4rrUJ0r/DnS12AsFq9rqGWRvv7sVuYQ0kqmbCpdUuYYy3 EiZaV6Axnd6nRO5uruyJDYvGuZ16TNfPPnybOmTLVSoCCllw3Kxd3AyTxLEa1W3x+iWe S8Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=FH9MO19ipUPbNSVtDvQwc3Bw3OL77ONLKCGO58YGE44=; b=IkPSQ+BwVdid4dbRkfg10oEulVpxGWR9tcuWRQJDeDE/vPnRrCYwd+/ntAnZBAzitj Y9ccIXXX6XwEkhdnimF9XFIQIwuhza+nnRMi5bWep4kGT0QVpO39Q1PKGxBCHp039G7s FA3Fmb6U1X1b0t0HvAmSniFluGa5/HfqBoeJLmhYSPAjEnluDWRUiaPygm9+iOB0EuNv JUwZ531k3LfszXzOTXV6o63TQO7S6OTUXjcxknXceZDCigeRxhhwvubf0gvQvaUGojj9 ZZYiqSFvNV3R6089Pdk78QkglZQQxXz780BX4Jci2MJt4gAgg0qCgl3sKyWZ5fn2U8vu eD/g== X-Gm-Message-State: ACgBeo1gh+3PIdgibxPC6jD8+BBm+oo3xoO3CIzS8Z8SuWHXwaJkYowA kHltDk7t+KV6EdqQfh02aENKL2X72OcOPsicQV7qdzmT/Q== X-Google-Smtp-Source: AA6agR43VVkMEfkCWjMmFcf4/NgkWhvqCYSTnzYGN0aee7HtPwQnVLF2Hb0tzOlZM2MGiheSLDq7TQW7w5dagMZP2hU= X-Received: by 2002:a17:907:7e8f:b0:733:16da:24bf with SMTP id qb15-20020a1709077e8f00b0073316da24bfmr6442681ejc.349.1661545978504; Fri, 26 Aug 2022 13:32:58 -0700 (PDT) MIME-Version: 1.0 References: <1661502678-19336-2-git-send-email-kaixuxia@tencent.com> <20220826170818.50050-1-sj@kernel.org> In-Reply-To: <20220826170818.50050-1-sj@kernel.org> From: Kaixu Xia Date: Sat, 27 Aug 2022 04:32:47 +0800 Message-ID: Subject: Re: [PATCH 1/2] mm/damon: simplify the parameter passing for 'check_accesses' To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, LKML , Kaixu Xia Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BuSgMPpH; spf=pass (imf25.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1661545979; a=rsa-sha256; cv=none; b=iCVT9q1w7V7TcXwnJaJGLcqRYZghhsdagnnvDWnZcEh+torXwBAbaUDmNj7sMoqy7D6ynW vQK3mBnxwrrLOuEEFNI5a9NHA0/yptkxTum7rK6XMjs7bCgp7wlAw2x3JOfX34mRvMHP9C MzErcepahxKCKWSSic+PXlXrxShdPF4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1661545979; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FH9MO19ipUPbNSVtDvQwc3Bw3OL77ONLKCGO58YGE44=; b=TRbfb4JojFeCFdAYMHh45kJ17D6NNnvFuV9rwGthtNhbqTR8UOpTyJC8ao1Xjs1lAHZK4d pVBfpH7yvJIq3CecrTvhz3XZcAa9ZhS6nhff8V1Nq/8GTj7sx4o1q426lgRKC8scpArOP4 qO8rP2i0EvmV8lXnd82JIm4Ck6jq06o= X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=BuSgMPpH; spf=pass (imf25.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.218.45 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam07 X-Stat-Signature: fd6xcfj9doidfu7g1tq8bp4aa9ce3up3 X-Rspamd-Queue-Id: B20B2A002A X-HE-Tag: 1661545979-43843 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 27, 2022 at 1:08 AM SeongJae Park wrote: > > Hi Kaixu, > > On Fri, 26 Aug 2022 16:31:17 +0800 xiakaixu1987@gmail.com wrote: > > > From: Kaixu Xia > > > > The parameter 'struct damon_ctx *ctx' is unnecessary in damon > > 'check_accesses' callback operation, so we can remove it. > > Thank you for the finding, but this wording is not 100% perfect, strictly > speaking. The callback operations indeed use the parameter, but the internal > functions called by the callbacks (__damon_{p,v}a_check_access()) aren't. > > Could you please update the message? Thanks for your comments. I will update it in the next version. > > > > > Signed-off-by: Kaixu Xia > > --- > > mm/damon/paddr.c | 5 ++--- > > mm/damon/vaddr.c | 5 ++--- > > 2 files changed, 4 insertions(+), 6 deletions(-) > > > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > > index dc131c6a5403..6b0d9e6aa677 100644 > > --- a/mm/damon/paddr.c > > +++ b/mm/damon/paddr.c > > @@ -166,8 +166,7 @@ static bool damon_pa_young(unsigned long paddr, unsigned long *page_sz) > > return result.accessed; > > } > > > > -static void __damon_pa_check_access(struct damon_ctx *ctx, > > - struct damon_region *r) > > +static void __damon_pa_check_access(struct damon_region *r) > > { > > static unsigned long last_addr; > > static unsigned long last_page_sz = PAGE_SIZE; > > @@ -196,7 +195,7 @@ static unsigned int damon_pa_check_accesses(struct damon_ctx *ctx) > > > > damon_for_each_target(t, ctx) { > > damon_for_each_region(r, t) { > > - __damon_pa_check_access(ctx, r); > > + __damon_pa_check_access(r); > > max_nr_accesses = max(r->nr_accesses, max_nr_accesses); > > } > > } > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > > index 3c7b9d6dca95..c8c2f306bb6d 100644 > > --- a/mm/damon/vaddr.c > > +++ b/mm/damon/vaddr.c > > @@ -532,8 +532,7 @@ static bool damon_va_young(struct mm_struct *mm, unsigned long addr, > > * mm 'mm_struct' for the given virtual address space > > * r the region to be checked > > */ > > -static void __damon_va_check_access(struct damon_ctx *ctx, > > - struct mm_struct *mm, struct damon_region *r) > > +static void __damon_va_check_access(struct mm_struct *mm, struct damon_region *r) > > I still prefer 80 columns rule[1]. Could you please break this line? > > > [1] https://docs.kernel.org/process/coding-style.html#breaking-long-lines-and-strings Sorry, I missed the warning in the new 100 characters rules :) Will fix it. > > > { > > static struct mm_struct *last_mm; > > static unsigned long last_addr; > > @@ -568,7 +567,7 @@ static unsigned int damon_va_check_accesses(struct damon_ctx *ctx) > > if (!mm) > > continue; > > damon_for_each_region(r, t) { > > - __damon_va_check_access(ctx, mm, r); > > + __damon_va_check_access(mm, r); > > max_nr_accesses = max(r->nr_accesses, max_nr_accesses); > > } > > mmput(mm); > > -- > > 2.27.0 > > > Thanks, > SJ