From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29478C19F2D for ; Sat, 13 Aug 2022 14:33:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74B366B0073; Sat, 13 Aug 2022 10:33:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FAE38E0001; Sat, 13 Aug 2022 10:33:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5E9E26B0078; Sat, 13 Aug 2022 10:33:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 504246B0073 for ; Sat, 13 Aug 2022 10:33:31 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 24B2FAB71A for ; Sat, 13 Aug 2022 14:33:31 +0000 (UTC) X-FDA: 79794812622.21.9473591 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by imf20.hostedemail.com (Postfix) with ESMTP id C57801C019F for ; Sat, 13 Aug 2022 14:33:30 +0000 (UTC) Received: by mail-ed1-f53.google.com with SMTP id t5so4434160edc.11 for ; Sat, 13 Aug 2022 07:33:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=za38B/WdiKJtfUmwIszIpVR/GOOwQNFkxMaiPO2BEsE=; b=SRS5VX4DgFVtp+A0rN1JhpRO941soVLdg90ecmG+XQ0O0Pk71FW0Pnz8yHfIzncjfm w9vBr4X/fCJunIlmhImV1SN4JHWF76kgYCXcIiI1d3N9VGZpSUARDumzbJr1NyXQ/y2c xl4sdAP3i5O12b6Ip2R/jya5p6xu5xMddi8Pxlw7eq/IEQ6HD+3yv8y+lu+TMSGolZmy T1my/uu5mISAvK1SJnfKyo4UErW6OWGA38vCibiC0oR7zQJqP/8REV5No7LCotDsP6w/ 5aNp4dTcnSdt2zTERyY/We+lAkR6JSCN2UFnjtWSoP/0ZZaPfZmJJe4TyS7j9xKwOFfG vjWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=za38B/WdiKJtfUmwIszIpVR/GOOwQNFkxMaiPO2BEsE=; b=ZaEOLywlCWUB+XH6lqe66628zYFW+D0B+RXGnOpDzwusA9K8Zkx/MXYkEJX6E6J7ZM PjN2E6Csc4uJa0fRLUmV/rpVxznMfv50nqYJi47vMdy5nj2EqkeBfYpU6FXgkh51ipZy rvGkcmB5Nkc+uOWK+EVwJ1Fl/UzofXJ5WXfDkVnY+13yZFoyzuWotNmBPO71PcrFftoU 4KrnRUb7HQ+a76WniG2sqfXrMIqh7/ShI29WIZ3ev1TDpt9R5HHd97zBwCq5Lixuq0KG JfP6ddVApYRUzj7rT2LmbvwhXfF5AmyRsfkZFpNDWffb0qGt6Gpb88C7/+TYHBK2mpU+ gjHw== X-Gm-Message-State: ACgBeo3mpvxQpvebcJ2uc2ro91xzTpDc4kmsrj5/SNBqwjJyfdsdD2+6 T/JPh6G0qb7h+FlqG5NExP4Jfd9ezOsaH5Dm9w== X-Google-Smtp-Source: AA6agR7/0O5iWzCnwrOz4bhtktALLvhmcNbjjxALsSbZe0aAZ1sGeKW6/lTWKsM2lcpAxJVv05nSRWz+4CDpDtjIXfY= X-Received: by 2002:a05:6402:240a:b0:437:d2b6:3dde with SMTP id t10-20020a056402240a00b00437d2b63ddemr7723134eda.62.1660401209608; Sat, 13 Aug 2022 07:33:29 -0700 (PDT) MIME-Version: 1.0 References: <1660290073-26347-1-git-send-email-kaixuxia@tencent.com> <20220812154841.116570-1-sj@kernel.org> In-Reply-To: <20220812154841.116570-1-sj@kernel.org> From: Kaixu Xia Date: Sat, 13 Aug 2022 22:33:18 +0800 Message-ID: Subject: Re: [PATCH] mm/damon/core: simplify the parameter passing for region split operation To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, LKML , Kaixu Xia Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660401210; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=za38B/WdiKJtfUmwIszIpVR/GOOwQNFkxMaiPO2BEsE=; b=RvpyGeLntiMNp68u/ZNbjwPLGj8hAEo/AufxRwuTGo4aeEliYZR1VaB2k3eq3hGuVfy18r +KZ5cGcfJ1dtAgQ4crU5tAipgR2Vycqh4lKFfklZNV/paZlvvol1mhswgya9yr5sH9Y6m4 dOpHlEv6av9dA/f5580yAnYh9gAxoJY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=SRS5VX4D; spf=pass (imf20.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1660401210; a=rsa-sha256; cv=none; b=PvkNSlkPLZGtdwozOc5DWwVz4UzhX5GhVycvgFsAyoeWsB3Ts8nQdfLcf7DWGQ8CpSn3TF B5WVN0X5BBPLc8JFAhdIqcXOwjmrLI7gUnHHcwCTOfDKiS51wNWh4MvNzQP53ZZVw7Qzvo 3IH/09GsR2CKQSyd7BC9LaqtOlUxOIw= X-Stat-Signature: 85s7bkyeqrrkf3t5qtn7j5pf3tujt8zw X-Rspamd-Queue-Id: C57801C019F Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=SRS5VX4D; spf=pass (imf20.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.208.53 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1660401210-445901 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001029, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 12, 2022 at 11:48 PM SeongJae Park wrote: > > Hi Kaixu, > > On Fri, 12 Aug 2022 15:41:13 +0800 xiakaixu1987@gmail.com wrote: > > > From: Kaixu Xia > > > > The parameter 'struct damon_target *t' is unnecessary in damon region > > split operation, so we can remove it. > > Good finding. But, 't' is used while 'ctx' is unused in > 'damon_split_region_at()' and 'damon_split_regions_of'. Below code change is > also removing 'ctx', not 't'. Could you please update the commit message for > that? > > Also, please fix the kernel test robot reported issues together: > https://lore.kernel.org/damon/202208121823.8YTRPB1J-lkp@intel.com/ > > Thanks. Will fix them in the next version. > Thanks, > SJ > > [...]