From: Kaixu Xia <xiakaixu1987@gmail.com>
To: SeongJae Park <sj@kernel.org>
Cc: akpm@linux-foundation.org, damon@lists.linux.dev,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>,
Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH] mm/damon/core: simplify the parameter passing for region split operation
Date: Sat, 13 Aug 2022 22:33:18 +0800 [thread overview]
Message-ID: <CAGjdHukHNavhfTB+uff_9F3+VPhzXzP9bPnUV1Mcz4dX7rF87w@mail.gmail.com> (raw)
In-Reply-To: <20220812154841.116570-1-sj@kernel.org>
On Fri, Aug 12, 2022 at 11:48 PM SeongJae Park <sj@kernel.org> wrote:
>
> Hi Kaixu,
>
> On Fri, 12 Aug 2022 15:41:13 +0800 xiakaixu1987@gmail.com wrote:
>
> > From: Kaixu Xia <kaixuxia@tencent.com>
> >
> > The parameter 'struct damon_target *t' is unnecessary in damon region
> > split operation, so we can remove it.
>
> Good finding. But, 't' is used while 'ctx' is unused in
> 'damon_split_region_at()' and 'damon_split_regions_of'. Below code change is
> also removing 'ctx', not 't'. Could you please update the commit message for
> that?
>
> Also, please fix the kernel test robot reported issues together:
> https://lore.kernel.org/damon/202208121823.8YTRPB1J-lkp@intel.com/
>
>
Thanks. Will fix them in the next version.
> Thanks,
> SJ
>
> [...]
next prev parent reply other threads:[~2022-08-13 14:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-12 7:41 xiakaixu1987
2022-08-12 10:47 ` kernel test robot
2022-08-12 12:50 ` kernel test robot
2022-08-12 15:48 ` SeongJae Park
2022-08-13 14:33 ` Kaixu Xia [this message]
2022-08-12 19:30 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGjdHukHNavhfTB+uff_9F3+VPhzXzP9bPnUV1Mcz4dX7rF87w@mail.gmail.com \
--to=xiakaixu1987@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=kaixuxia@tencent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox