From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D66E0ECAAD3 for ; Wed, 14 Sep 2022 04:02:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 448DD8D0001; Wed, 14 Sep 2022 00:02:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F90E6B0073; Wed, 14 Sep 2022 00:02:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2C0BC8D0001; Wed, 14 Sep 2022 00:02:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1CD576B0071 for ; Wed, 14 Sep 2022 00:02:20 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E6E361A03E9 for ; Wed, 14 Sep 2022 04:02:19 +0000 (UTC) X-FDA: 79909343598.10.CDA9502 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf20.hostedemail.com (Postfix) with ESMTP id AE98B1C00BF for ; Wed, 14 Sep 2022 04:02:18 +0000 (UTC) Received: by mail-wr1-f44.google.com with SMTP id e16so23691048wrx.7 for ; Tue, 13 Sep 2022 21:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=sb7rAbJZuS+StHRfXIZQwRnlRn6aCsFhpXPXtu19SaQ=; b=WcFpC1SKt4w7D427YmJ5Tdrd9kMBFrENC/xVio9ndDXv7ugPFzvlaqss6cwGm3PSy4 0RReYbd2KtIqubWe2dAuGIaSWON4ImCNrAGWxG043j2zg0iUfaVoui3LYf+MpEKE1my4 vOq4BFvk4hnEPlGfyvU65nLJUR5VengC673opgX8gRY0Gu6rxeyeTE59kSLbGTcH8FvL S3cjxj10MxzMNN3FBboqWWhbgbRVCcJ0vWfHqlCbrZMrzNMPvpO1yteL0XNWajeRWjE2 FHGlnfpHl5RQe6tF+jfJOPa2uip6r39wnJetNlVRGvd5o4VbOO7hP+IV9LLczjgj1Akg h0RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=sb7rAbJZuS+StHRfXIZQwRnlRn6aCsFhpXPXtu19SaQ=; b=63f5k1V/otWSh5yYSF9VGMvpypJH081cMgHWyjtVr20QqyfyQAM8hNGfkVkvYMlEYX ZNIF3Um9sHjsWrATk+Z+DR1SiZyL7/iY401qP1m70HTLke3MbmbFLFgXBwhnefVru6t3 CAUx5qKo3vY8ccOtoNM2HH8Q4JJgiQew43DVBBsw55PU9alLbHMz0eXjGx44Qs/Aj8kV eg4HR63XrGdh/DEZIJG4pNpyyOeEVFshVq2esma8OF0B4167dMjvZvkOELOEzj8miMWU tA8zBIBcgOhHUZYON0q0OyuNPbTTRjJA4ri9ozQ+XOUNe2pu5I8tsubfzbhUgBElIwVH LYdQ== X-Gm-Message-State: ACgBeo25AfNNJw9I30hGU2SyoNffQmkcmuGuExl17NpGnY7hbbJ125wd kk7KJ2HvmFt9Ghfj02mH/hgTEcd9VLtYGM3MLw== X-Google-Smtp-Source: AA6agR78iSAq9l5/YpX1vG1o7mn5nkeDb44f9QKmbUjxBORze5ZAHwUvoZc3FqrpklNof5cdYldFtGBx9yoIHcIX4S0= X-Received: by 2002:adf:8b07:0:b0:228:da7c:80ee with SMTP id n7-20020adf8b07000000b00228da7c80eemr19716209wra.25.1663128137340; Tue, 13 Sep 2022 21:02:17 -0700 (PDT) MIME-Version: 1.0 References: <1663060287-30201-5-git-send-email-kaixuxia@tencent.com> <20220913151114.103184-1-sj@kernel.org> In-Reply-To: <20220913151114.103184-1-sj@kernel.org> From: Kaixu Xia Date: Wed, 14 Sep 2022 12:02:05 +0800 Message-ID: Subject: Re: [PATCH 4/4] mm/damon/vaddr: indicate the target is invalid when 'nr_regions' is zero To: SeongJae Park Cc: akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, LKML , Kaixu Xia Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663128138; a=rsa-sha256; cv=none; b=wz6AoBtSlteuM7H5DHsnj+/UQhpzXj7wf23xzYyA8UxpKbiefp4ET86OurmFg4TRT85Und kJUy/K/lQ2Pg8FhT7QVQpa+y4CSpTUbYeFvJPVPJpzCowRJdvr7oaJ9w331OzLr4NCNgZB cU/gXltPnXvb36mj4zumf5pdwaGLDZ4= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WcFpC1SK; spf=pass (imf20.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663128138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sb7rAbJZuS+StHRfXIZQwRnlRn6aCsFhpXPXtu19SaQ=; b=Tf/yzjFzgWS5iCNsyCulSSg4OCW1qb48dRgLeVYGTHPgSWEAOUIhujAYrYNRSOzY8Q7HhN E5wHVTRYysv+iqdxJbG5qiNiDwZ1v0WF7ua6ZbQas+4fMrEOgXgPg5R5pFdZd8YQQJ4ogh NZh5oB0AO301pjhOg2Wqo96uoiOzVbw= X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WcFpC1SK; spf=pass (imf20.hostedemail.com: domain of xiakaixu1987@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=xiakaixu1987@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam02 X-Stat-Signature: 3f8qxiewftxne4xnod4q7am856aaumuu X-Rspamd-Queue-Id: AE98B1C00BF X-HE-Tag: 1663128138-83023 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Sep 13, 2022 at 11:11 PM SeongJae Park wrote: > > On Tue, 13 Sep 2022 17:11:27 +0800 xiakaixu1987@gmail.com wrote: > > > From: Kaixu Xia > > > > When 'init()' and 'update()' DAMON operations failed and the number > > of the damon_target regions is zero, > > Well, I think that could be a temporal failure. In the case, later call of > 'update()' could success? > Yeah, the kdamond while() loop calls 'update()' periodically to fix this temporary failure. But for extreme scenarios that 'update()' continues to fail, we should have some ways to detect this case. Thanks, Kaixu > > Thanks, > SJ > > > the kdamond would do nothing > > to this monitoring target in this case. It makes no sense to run > > kdamond when all of monitoring targets have no regions. So add the > > judgement in 'target_valid()' operation to indicate the target is > > invalid when 'nr_regions' is zero. > > > > > Signed-off-by: Kaixu Xia > > --- > > mm/damon/vaddr.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/mm/damon/vaddr.c b/mm/damon/vaddr.c > > index 39ea48d9cc15..65ff98d49ec0 100644 > > --- a/mm/damon/vaddr.c > > +++ b/mm/damon/vaddr.c > > @@ -598,6 +598,9 @@ static bool damon_va_target_valid(void *target) > > struct damon_target *t = target; > > struct task_struct *task; > > > > + if (!damon_nr_regions(t)) > > + return false; > > + > > task = damon_get_task_struct(t); > > if (task) { > > put_task_struct(task); > > -- > > 2.27.0