From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F897C369DC for ; Tue, 29 Apr 2025 14:50:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5574F6B000D; Tue, 29 Apr 2025 10:50:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 505A36B000E; Tue, 29 Apr 2025 10:50:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3CC5C6B0010; Tue, 29 Apr 2025 10:50:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1F6FB6B000D for ; Tue, 29 Apr 2025 10:50:31 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 900F614067F for ; Tue, 29 Apr 2025 14:50:32 +0000 (UTC) X-FDA: 83387367504.10.76ABD66 Received: from out-182.mta1.migadu.com (out-182.mta1.migadu.com [95.215.58.182]) by imf06.hostedemail.com (Postfix) with ESMTP id E0521180011 for ; Tue, 29 Apr 2025 14:50:28 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wczpRYnM; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745938229; a=rsa-sha256; cv=none; b=zE9xbTneEgz29eMo+XUVYtI2AOgZEFhu9Tc0gILR37pVnUuN73ywX4cgcwZ+r9DXnV466x 1VBypfzYRBmCeR1gBSK2MsoSWkZiG+TQPeprUy3JPwaWZPzu6DEgeiWRM2dP6SOTuWilQX yf6+6ZXXqaFc6vWKkXm5tRJAxDIN5Co= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=wczpRYnM; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf06.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.182 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745938229; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sG/t2zXSuC4284IbLbTWykBNuA1OkgkeykHvhILihlA=; b=wP/dMzIjTmBJUR71kBce1Pu4CNFmydkPKipqdCq0YXS5l22YKFOQuSl8CQfziGggFeH1OV mU7C//EwVg/UKPdMblJdKmTdze88FpgbAsARuZ1QxG0lmtqfH01gjs5fj47M2byt+Dkxrw id0cLG6TJ3CHHe61NboZ1AVZTT/O6p0= X-Forwarded-Encrypted: i=1; AJvYcCUeTA/PFAKe+I1/3LUlMYyCo1lHKIFV72bGHisLaggInHgRi93lrMD957so18WB6fuytaVLxqnfTg==@kvack.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1745938223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sG/t2zXSuC4284IbLbTWykBNuA1OkgkeykHvhILihlA=; b=wczpRYnMdLsuSqcKn48qq1wORHnsxDW6JsUewxk6PeAKZke6iq7RzJRtPpSrGpNVMlkHcs oDlGQlzykdzUg7rjp8HwD+2qY8y0VGX45iv4ntwJEwycOnZ6pRTJxrTnAT/0EZVxrerAvH Ut3jyUsod3NsZaQTg8c1BmBHwSs9d1U= X-Gm-Message-State: AOJu0Yw6oHrBlHNKQc5M3XFjf7ue+ZI20q+V3LL7XeEZMpuO5AcICzbY 34QALwAD+CPcqFzHx8gW805iFUpHkQjNxH9zc6Mk4+u9/6WpfGYz/FGSbr5BkYwvHp0sm2hIs8B RtmCCy1lHWcfKyKKK2+f9Ev90ZeE= X-Google-Smtp-Source: AGHT+IGNOvGy3kBxT/7U0dYFYLFlS3jS3+6ZPtjfckwWaQFxqtwhzH0vx78mbKcV1/Az431zoUcIbk2mXjaIZvhAeyg= X-Received: by 2002:a05:6102:5707:b0:4bd:22d5:fbd7 with SMTP id ada2fe7eead31-4daa9332342mr2397273137.11.1745938221113; Tue, 29 Apr 2025 07:50:21 -0700 (PDT) MIME-Version: 1.0 References: <20250416180229.2902751-1-shakeel.butt@linux.dev> In-Reply-To: X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt Date: Tue, 29 Apr 2025 07:50:09 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: ATxdqUHdcNwx1MHWsVfsCWAIdhFCYRv7C1N8Tk9pEbSWytPPXoXSMfUfvwyV-gs Message-ID: Subject: Re: [PATCH] memcg: multi-memcg percpu charge cache To: Hugh Dickins Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Jakub Kicinski , Eric Dumazet , Soheil Hassas Yeganeh , linux-mm@kvack.org, cgroups@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: E0521180011 X-Stat-Signature: nfyizkzo8bax89kp1r39wd3nu94ig93a X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1745938228-559316 X-HE-Meta: U2FsdGVkX19xG0a+lh/dKG5v2lAxe7NUIS/QVO4BdrjjycnZTKN6K8sRutnrj+rZB8Ghtu/0noBnsRbudePE3u7cuSRLBPv8+YQAERoq2tE93RcipYhegPu+yLsV5nc2M4ArGBifAg0K6ovSln82kyth99bm3ne2hrF110UOSXCFvER8171hsi5WLf9JX08lPWktIxZFJ3A+OOkMOftIucfDJcq6Cow1qBdaYc0UCBAW+gC9tKjjm84q3lc1j1iCBh0uY6LPwXUK4LpaPgsEeFCFP7s1ojrSumiyFvo3YvqdJs98uW6geUvMVIUl6fdDYiqUjFCUWKsOCtsIrBn+bzYdB7QZQk6n9oiuGpAk3AmW/CtNMNRbiSRBRg+cqW30wPEZTVb7wcdoF8eYLs6QmekZr68SJiXcScJc5FW/yoo2h8aPvL7TL9KmndUQXhBTK+GdKiUfLKkvs/ZFmtlM2gGe228LcSys2lnCrnLS56Pi0oCKzwS5dfwg8aj7TZTTDhNUGJRjcaVQw0TagujbKrD+2cHu0LAv1Xx2JZIOdm0ivfGHX3JZnmPzpQFlqvh+Od6UpJTdmQyvfbSvNAiirpzzttJuT66hAgN8KP0bKujYkQEuoNOanbyg1JNUbi/hl1KR1miDrpwMGhEge6XDPckzkMKCVYH7/RfgOejtZ6a7w4TM/OE3qhZD/0dKVuVnnPeMISKOejuXZzn/E0zGvFUQwX4MitnY/UNbhz78MB66bYhUTRJfPxoo77UZ8Sww1AC3bjx/iWJsDiZ1tgTwhgozMKsbtHlTUFFA0i/ufF5DiCfEDHBHfWyr4o0Z7M5eX0ZaY9R5SnokHJ5iD3C/vlU9+sD3MOnwjFpWAxzvdIwUQ0S9LwDcZoZqzVKxRVKwmOKREJB17PESjwteWpgapDI1MM1tX7e+iUk6LM0b6omJ0cP8b/LkBSsdklJXANPaVJEJ6r1WcVTbkvRzLAu hJhq6Nlm zqM2pHTfPCePokfCjPLnc6q6EYuqPkcjO2SYFOBWqHBM8C+SByFUhFF8HmVLxepOUxvV0lmdoYdBBV8zXb9Piwx1SU3aXcSGxenhlXZ6dPgHQbQganzdctRDPupaWJjiaq5ESPJFKS8SgzARwhVSHdsYw2ExOToYRztFYfsG9PmtSd2k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 29, 2025 at 2:40=E2=80=AFAM Hugh Dickins wro= te: > > [PATCH mm-unstable] memcg: multi-memcg percpu charge cache - fix 3 > > Fix 2 has been giving me lots of memcg OOM kills not seen before: > it's better to stock nr_pages than the uninitialized stock_pages. > > Signed-off-by: Hugh Dickins Thanks a lot Hugh for catching this. > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 178d79e68107..02c6f553dc53 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1952,7 +1952,7 @@ static void refill_stock(struct mem_cgroup *memcg, = unsigned int nr_pages) > } > css_get(&memcg->css); > WRITE_ONCE(stock->cached[i], memcg); > - WRITE_ONCE(stock->nr_pages[i], stock_pages); > + WRITE_ONCE(stock->nr_pages[i], nr_pages); > } > > local_unlock_irqrestore(&memcg_stock.stock_lock, flags);