From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30963C30658 for ; Fri, 5 Jul 2024 03:43:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A76CC6B0098; Thu, 4 Jul 2024 23:43:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A00EB6B0099; Thu, 4 Jul 2024 23:43:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 878DF6B009A; Thu, 4 Jul 2024 23:43:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 68AA36B0098 for ; Thu, 4 Jul 2024 23:43:17 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 055B5A15DF for ; Fri, 5 Jul 2024 03:43:17 +0000 (UTC) X-FDA: 82304303634.14.B1AB27A Received: from mail-ua1-f43.google.com (mail-ua1-f43.google.com [209.85.222.43]) by imf10.hostedemail.com (Postfix) with ESMTP id 4A4AFC0005 for ; Fri, 5 Jul 2024 03:43:15 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jUAWk3VT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@gmail.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=shakeel.butt@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1720150974; a=rsa-sha256; cv=none; b=E3E9JnJa3hVRwiO6LHBWuwSc5Kmkh+uozU2ZalVfKPfmXx5/VzIO0NTv+/XdtQDpvdw5sA TnQRbniL3l9MUdFlAiOGH/Rpsa85dBxt4mFwWes+RLosDYFStRUGW60IFVKIDk4/IfNqMx TQPp5LMb4z0V1EfahSqadY/ERSGB/Sg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jUAWk3VT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of shakeel.butt@gmail.com designates 209.85.222.43 as permitted sender) smtp.mailfrom=shakeel.butt@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1720150974; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p22ZqaLJJpSERBkYdzymubdS4vnjA3mYUiy7vTohqHs=; b=8GDICcoffRJnhJgOFPIGwaIuxNJg59Zm9XjnHumOvPGWQGeZIitKyjVkDIIJU3ypVALcJE E4GYxK8HirvkwVJMozgwVwR9QEkLHOe7uwPRJm5iPD6uFesOqk8oemeNsJe5RsK0uFULdq l7Bmh5xJ/bwAyvh2jcqxjEm0TlSD/4I= Received: by mail-ua1-f43.google.com with SMTP id a1e0cc1a2514c-8101c661979so352473241.0 for ; Thu, 04 Jul 2024 20:43:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1720150994; x=1720755794; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=p22ZqaLJJpSERBkYdzymubdS4vnjA3mYUiy7vTohqHs=; b=jUAWk3VTGctqjtmjtAZZdv1XS+c9LDnlb5DbOLKurIo5ZGukZLZ3RGN57lS+/QxxA0 xXaiXbHMavxB6KewZHzJTTzUYOv5p2i4yUQA8wAGa3QMGdaBWYWFKbJ687kvalB7/giA xs+87jf1E12H+U7K+q0MKovEvnMamhL3FEHg35MiNGEUxGQz0+zfBncHW7pK52pRCQHO 5S5YLymoODRBYbBWj+arSI38g0GZ8haKbsc2RuwRYhef8c9OGQlccq+tnpiGez0QuOsu wt2BU0XQzQfdnoHxKPqPbIS8YaznOBNWDoDZ9aR2w5V9PPQsV3v2dzR5liWmyBj4R8N3 0LiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720150994; x=1720755794; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p22ZqaLJJpSERBkYdzymubdS4vnjA3mYUiy7vTohqHs=; b=Y2m+KJfT4Vm9OAMY8wjWsBVBIi7zpBgMTeD8Brxy3CtZMOnW2+Ov3KYL+0dLIOJtnL SDdMlNK84ETuP6QmJoFLtuPCx4nEvvbpgGOibvzl+I+MacMb7eQo74q7UWSWwY+A83dc 3QX9K2r9tCIiomIA62AkbRwVDZiBVZuvVWNdOhLmTFes+5TfqkohCT08If65Uet9Bzw5 5LNssHkNGkBoB1FLm2QVJKrH4IWndqAteB867ODRUj2ISbgl0OGy8THtQFwT6+1HmHTh JErA40qv7Ua9NyJb6KgbNmHmD6bgsFVj879yEeW/dCXmoaVpGj2dbnT0IwH3H2j/ImNl fiqA== X-Forwarded-Encrypted: i=1; AJvYcCXVXjDTANbHozioQ9J4KpDX/2Ei8JWtElyXKomycoJg/amsrLIuN+VNo2hbWdxhFdJvzl02BffCrtW8ZghOasPlnfs= X-Gm-Message-State: AOJu0YylkSpQ4scnueF0K4dkjAcrUrDqkJ15OdsZoIAqX8Uke7h6mHRz kEuOu6MNoA0ZbgAav1nLGpkdGiPg2F+PCnSwQ5kzPb3ll0bIPUjpq+9QT/1lXFix4Ki9aXf07YQ N68AY8lZWfAIuZSo09i3dqBzZV8A= X-Google-Smtp-Source: AGHT+IG9n0kvLFpj1kc1RUXMhDUYn3ipmn5dTJMSWAGb3fd7LbIYsqtiyQ7y6AhCSXUyBeSOiYaeBUKk8gM9G9qXt+A= X-Received: by 2002:a05:6102:214c:b0:48f:4320:114c with SMTP id ada2fe7eead31-48fee667efdmr3534894137.15.1720150994204; Thu, 04 Jul 2024 20:43:14 -0700 (PDT) MIME-Version: 1.0 References: <20240628210317.272856-1-roman.gushchin@linux.dev> <20240628210317.272856-7-roman.gushchin@linux.dev> <20240704163534.e82b0d4108ab70319781d6a9@linux-foundation.org> In-Reply-To: <20240704163534.e82b0d4108ab70319781d6a9@linux-foundation.org> From: Shakeel Butt Date: Thu, 4 Jul 2024 20:43:03 -0700 Message-ID: Subject: Re: [PATCH v1 6/9] mm: memcg: put memcg1-specific struct mem_cgroup's members under CONFIG_MEMCG_V1 To: Andrew Morton Cc: Shakeel Butt , Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 4A4AFC0005 X-Stat-Signature: pht54wja7udw9son5ndsdjir63y1zdq6 X-Rspam-User: X-HE-Tag: 1720150995-398845 X-HE-Meta: U2FsdGVkX1/dnm6COKAHG7iAxw4BAsNY87N8yjrPtdlioysaYiszPQuqNV0e+lGKT2VdXju5YLyXjkHUmlbQ62LZ1stRa/a+GsFeyGSVhca64/C8fR+mTCdS2by9HwUpI8JlrC4yjEfPC34C/rs9/+I/iSsfPulz1Lor3IFAYxkxG6Rcp5OC8LcPCMpi+f5SvaW4bivASCztHUfd1AMBABj86jqyrBuvqdEVwUPCfAO3d6Rl0az/B/o52JY7cDyA+NZ+7PwqR8qyok7SSxLbjrfkZLKIm1c66kwmMvruFAJYu16lRpz6NuT326qvyYbhEFMRBslQmG9bcL4ZO5pAsuXEzue+8MzBgPqsvMk4OA0By2nymNltYRJc88WnTDd9+XCF2ekbOtfQy7jP+81tcRCuiDgsERVrsKQLpQb5Cna1y5n6Zx7lV6Uwvg/Tt6Go7WREAqzGZzTtWyzS2wF24w5+y5PNSjS0X8PCD172AVyk1LqNQ2wyq2MwMldYQ1wodwsIk3jyzsdLH0G4ku1BRptz7caeOtinmPzB/w7jQQoATCvn5eTDdJT12JVxlAwzvCKAm9M5zjKopLtfgEfNHGAVdt8KAiWz/3aF2SnhucAXnlL1K6YacippxCbkjo688VBCN+iTU9PphdQ/E1yST3WKQmvQEhxAvA4NWxjZcECQfnuHYv+5OZ7ABz+sp0iUshTli0QNi3HgIdQKLcov5hj221WRtzgIB8ktOq5LU2n2JBtGMB11uJi/X0dbP0+rbjtITVcUusHh/VIPqTX0Cd50nfekrNFZ7SDEvt+1f0/kCRWqCNxoH5gGJXXSVTLVrRWfWVPUE6yj5yE0QpXHNWfoTZJKY7nk8vCh2qdu4Zgfa7ReMSBLU5wVUc32Jx00SuzLGKVUIdhaJ5I3P6EZpC+5cmSiwbD5cYu9wuy9iuHI4xlvI/N5/+AQy1fsnmAlEXbchBMs5ZmizivBT2C /66fFaYw qrmmin+ykrFa5MoM4l7gOgFM5aH1jxcrWAkldtpVl1U6hVco8xenYgTE+y0mLABTYW0OqvtantIn1o2uhjY0aIUXQzOUBpz0KIr4qkpR2uLS2qv+p4lc11nykpolLKHpv1KQ6o6IlJopB/Ys5MBdwgswjyg6P1jtTz1oJQpv4M/CMculgvONsBKcuJRbBtQu4U78kn4TbADPsek/ZxMDzaIY/+xhbN1xbMLfKeyYIXWYVgnI8JBc+kVz0EKADz9N7caQ0dZLjMFzD+rej4ORqFfqd50CAvgRVXsL3ScoVSRNX9s4L4dcHbOXh3714ql1BGupJLqKXRVr15kUrBYbvC6vN/Gm88zM42XUHqGRwCBlljNSSGf6uxDIicHU/kiwdGPWM36sJoJx1pBqFhEOMZeOEQJ5BC+pl7jcr3w8/5VaZYFwA2WmHO1M1NKb/evPN7NLmmcB0YmkOlsYv241BTXMswIICzyb+LfL94yvWOzQxvT4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jul 4, 2024 at 4:35=E2=80=AFPM Andrew Morton wrote: > > On Fri, 28 Jun 2024 17:48:54 -0700 Shakeel Butt = wrote: > > > > - /* For oom notifier event fd */ > > > - struct list_head oom_notify; > > > - > > > - /* > > > - * Should we move charges of a task when a task is moved into thi= s > > > - * mem_cgroup ? And what type of charges should we move ? > > > - */ > > > - unsigned long move_charge_at_immigrate; > > > - /* taken only while moving_account > 0 */ > > > - spinlock_t move_lock; > > > - unsigned long move_lock_flags; > > > - > > > CACHELINE_PADDING(_pad1_); > > > > Let's also remove these _pad1_ and also _pad2_ as well as this > > rearrangement nullifies the reasons behind these paddings. We need to > > run some perf benchmarks to identify the newer false cache sharing > > ields. > > I guess this is going to be a followup patch (please). Already posted [1] and has been picked. [1] https://lore.kernel.org/linux-mm/20240701185932.704807-1-roman.gushchin= @linux.dev/