From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5018C2D0CD for ; Sat, 17 May 2025 15:51:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBBDD6B0088; Sat, 17 May 2025 11:51:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B44086B0089; Sat, 17 May 2025 11:51:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0C436B008A; Sat, 17 May 2025 11:51:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7F7D56B0088 for ; Sat, 17 May 2025 11:51:40 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 990F15C588 for ; Sat, 17 May 2025 15:51:40 +0000 (UTC) X-FDA: 83452839960.06.5D5C967 Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) by imf19.hostedemail.com (Postfix) with ESMTP id 91F7C1A0004 for ; Sat, 17 May 2025 15:51:38 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vuEZDq48; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747497098; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RHWJ7+ENK3ysA0wQdgi4xpA/oVgeGeZVO91GkRJOnw4=; b=gkRzoWNHOJSHE1cOrdiyq6QFCRZyiUl3W5bvOIkZPeT0X/r+zgk9GKKU0vVNfGkH0VJpmf C/Heso8eK8To2RWWVUnJmADZO6SNRy3WPo3Z/nqdGGLmcCWw161243k3kySOyP6j/SRRul JI0qoklb3w9Xxph+eNwbovWqNSPHY78= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vuEZDq48; spf=pass (imf19.hostedemail.com: domain of shakeel.butt@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747497098; a=rsa-sha256; cv=none; b=4POgUgqf4u9Pi4FNjo7SYiZwfjyMsI9hlS65PSz7n3FQQFtXwrcH10FcsW7BpzyZX2WBdX EnGftjhIj8K+C8hLW70P7n9V9/Urrg0Qt7lyViVAKLGWm5UI+zKFzqlIOm3bx4Gu2YTcug ZEzSBBNU9Yg57qVVUjGLNrBRe+S9BFQ= X-Forwarded-Encrypted: i=1; AJvYcCUwg3DLq4l/Z6XEU3YaqHGHm4Dld3+xBFtVnRcC7zr/SXyFtGZYx7Wtk8wIQUGu/y4CU/UT3+x5cQ==@kvack.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1747497096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RHWJ7+ENK3ysA0wQdgi4xpA/oVgeGeZVO91GkRJOnw4=; b=vuEZDq48usJ+YGZ2BvqjeStEPN3BHsIr1egiAo5fCTrL+/CBsbm2vKpF1rCrSWLphu/piy 6MWEzT5o+Rg8VD6y5lMYdNyMV292Lp44Hr8Hhwxtf4ZyOpjOTySO2T7cYx5w6gEvj+7nqo 6S21Ru/NhTIlF2EOckK/auBtYSu6Vtg= X-Gm-Message-State: AOJu0YxE2F2JGkausE9bZGwTx0pC5kU+MD3N+nC49gv8AWG1EAq7MqDo 5dwiIrZoyKLn28ik+96iVRYxLJ+RH0IGb6Rm4fL1+G5StpuwkNQaX7fL6FyRzc4c8qPxaV11iqD Czw0tMtdhEhEkHF3Gz42KNjAFcGtyWt8= X-Google-Smtp-Source: AGHT+IEHSSjPWy/qXRanpcH3xItL5zGinbj2b9UGOKzW+e5q4qnanKkoEfAc3rLX8Nkq+YI0L5gVkddT+rlmHM4pt58= X-Received: by 2002:a05:6102:1587:b0:4db:e01:f2db with SMTP id ada2fe7eead31-4dfa6944a54mr9571173137.0.1747497093752; Sat, 17 May 2025 08:51:33 -0700 (PDT) MIME-Version: 1.0 References: <20250517003446.60260-1-alexei.starovoitov@gmail.com> In-Reply-To: <20250517003446.60260-1-alexei.starovoitov@gmail.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt Date: Sat, 17 May 2025 08:51:23 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AX0GCFtpkNRiL3dVzhEom5a8SOJgCUkGBbnQWpoANlkSwijZVuftIoZkBvLUA-o Message-ID: Subject: Re: [PATCH] mm: Rename try_alloc_pages() to alloc_pages_nolock() To: Alexei Starovoitov Cc: bpf@vger.kernel.org, linux-mm@kvack.org, vbabka@suse.cz, harry.yoo@oracle.com, mhocko@suse.com, bigeasy@linutronix.de, andrii@kernel.org, memxor@gmail.com, akpm@linux-foundation.org, peterz@infradead.org, rostedt@goodmis.org, hannes@cmpxchg.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam10 X-Stat-Signature: o3ygp3qpw13nna1ka7rkij8i8mpqn4yq X-Rspamd-Queue-Id: 91F7C1A0004 X-Rspam-User: X-HE-Tag: 1747497098-165213 X-HE-Meta: U2FsdGVkX1+AEJso/LlDcBGAdIt62Oi6+Rih+h1AJ3fr6g9YjVOfOlUfVBWAA7f7OYWaxTK/vBBT0ZG0o0Un3ZHm3sQFug5xel9SNf/6lAxuLS0I5+kHpyJ928XkLrfIHYUQNGo8xXrITS5g75nVmvnecJjxny6oxEzt/qC1ntFBV26lXxb3SYUN8EMvpr79RMvpPvGQvwky5OZiUPJbPJ4RDjw9VCH2KoNCvtM00j58g3ADQoEHq4vMl8zsjUMZlrZeFA721PO4t7lXO3Ccm+5GhGXXIucfpWXqjGp72vhBS3vB8fkdCKGr1ZMPEe3uSlJbRCupdhaFADIjLwItBoR7TR3+wrJDyR32LF+3Tgxb6Kao0dftoxb/pbgmBOkTK3K9O4DKZmnjSuPpWXY2d2rcFXtQXLXIj9Vyf47tMLYvT/eRpURmadLdI3Dsk8opGETSckSGQ/eGWmEfw5IJpGMWf4CCh0tZYO9ieffpK8lEXRaCWdNNfL/O6CggjkdtOOAaMevsF6TAEWRuFCsCf9bVYMctHbEgQHPgMdUxAY2J9CJL5sRjmjAsJ2vc4cIzsBfP9qdC4SeFHz51QvRn7QMKPGbLrV50gdPxwJfnR89BQM+nn8er0XdrEbdiPSkB2NWNlI5OZkveytnQKVFzEjEIC78K0m7j6swaUAAIgfbq+VAuElwFX5yGGYE6iHWQYHikq7FwPXYzgVxUYPxeUT1ooakCLRcRdDAiWpbdxd09SrjRA6VhiDpnTUBno1o4Qb8EoYeTwFM8dGEu+P1j/iFNe7BAOvmBsvDfSvCkxPdzysQ41MpiLAL6znx3JMjd/QCMa9EYctYtuS0eRvaf5yP2fsgRuAfozVL0AcD5rqIaQMCv+lcwFnTXjtinryvQuXtgFdvi6SorAiZWy1bpSiBX/X+HJwvLhMfPqeWpxh8oyIK/HEXdn0MipYkcyVVvcBD1BBtmLruJDMvBIhI mbbngred qjqP3vZeKu72237n5agDO3dBE4LfBB2ItJAKRHTVDOuJiXdiKx+QkDkam1QidFsW2d0GhWyqvM6RiFoeIt40qAGpQoYs5ZSwbiuXtA0zzXkT8MqLQqHMd2wEwdB3hXF1+brjwEI49wgJh45Nwle/XOYo4Ggb8kdMQYkcqdlJdJwi6wgNuonH41wGw5eRbbip5X/wDsWwSyJNxJpcjcWkuePmcEsqF5fVkeOCYi99S+2VMmaYkcPZpgTzcwXWrBO++PygtA/6iT+aFeXm2MBew0+KjvcYSBAyo2tBHPIaRbkqOMGnPKXVGl6E8Hw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, May 16, 2025 at 5:34=E2=80=AFPM Alexei Starovoitov wrote: > > From: Alexei Starovoitov > > The "try_" prefix is confusing, since it made people believe > that try_alloc_pages() is analogous to spin_trylock() and > NULL return means EAGAIN. This is not the case. If it returns > NULL there is no reason to call it again. It will most likely > return NULL again. Hence rename it to alloc_pages_nolock() > to make it symmetrical to free_pages_nolock() and document that > NULL means ENOMEM. > > Acked-by: Vlastimil Babka > Signed-off-by: Alexei Starovoitov Reviewed-by: Shakeel Butt