From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A67ADC3ABC9 for ; Thu, 15 May 2025 14:31:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D1FF6B009D; Thu, 15 May 2025 10:31:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 182A46B009E; Thu, 15 May 2025 10:31:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 022626B009F; Thu, 15 May 2025 10:31:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D3EC96B009D for ; Thu, 15 May 2025 10:31:28 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 859E41401A3 for ; Thu, 15 May 2025 14:31:29 +0000 (UTC) X-FDA: 83445380298.23.4FF7F3B Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) by imf25.hostedemail.com (Postfix) with ESMTP id 3AE95A000D for ; Thu, 15 May 2025 14:31:26 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sa0W8uXK; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747319487; a=rsa-sha256; cv=none; b=W3KJREnxdRguVChjOoF6MhcFWfafIQGPU7UC1zxt8qM4a9xV/iB+6ySH65Gq/2qa5IOSbg RNbxo0z8yRLCl9UjbaQ2UgRPl0H5VWdcNAsU0cYdOAFEHA3aNBv5EcDJrDUzPt44sThPpr N9l0faC4pez0RdDpvRQBUKJv+DsY0Z8= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=sa0W8uXK; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf25.hostedemail.com: domain of shakeel.butt@linux.dev designates 91.218.175.177 as permitted sender) smtp.mailfrom=shakeel.butt@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747319487; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qFetwXF/VwiHsM2Y9xmcYYhX84ZJvWa2dyXEgkPZk18=; b=0zQ9d3xPv6LvW/kr2SS1Nw778n2JGRiEE71RnPi7AohiipnHiyyLNSc30U3oAVXjw4jnCE oh5q8vRzaVNIqiIri4XmQbnWgvz6YOZMNHCkWEBmVTHJkNC5ZFhrH08LeIbLZOqi/pQpLs 0JsIw3i5wYREzTAqT5Qe3JmVeafvVfg= X-Forwarded-Encrypted: i=1; AJvYcCVnox3Ucmx/SOdFokZGCVQb1No6a7vGWSR16qipS+Sv3iFYnhFguAvmrUDpQ2Iyw6kyP/VZOZbdyA==@kvack.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1747319484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qFetwXF/VwiHsM2Y9xmcYYhX84ZJvWa2dyXEgkPZk18=; b=sa0W8uXKn86STuIo5894rlO8crpisfB780BUQ4RYYaziD2T2fP2j1aQVr/G01yiGaPhrKz HRvQAHAgGEjlGM8FQRgD2RyVJ/2H8uP32/QBleL1YVXgU60euC7TNPgWLgXJFI09y0lOJl hJXHjhOiZhSRGcA1ldhhh+/uMwUqbpI= X-Gm-Message-State: AOJu0Yx6TMCDjZVfkNELvmVXgR2HYGVIRcrWKnwKA6BL3N2zTYyOhNSe GdtWLnA/swZHTz6a+8Yt4dhJdIQ+qMUi6noikkkFE389zr1615T6p5316jtnhD+iu4rz7CMUJ1a OjAHdPaPBdZ/ix6CT6csATCPdLZY= X-Google-Smtp-Source: AGHT+IGQIU2q5KzVhNqIoGtPyXwZcXsLMJcH4k4PnyFhVeQq9UMndtkORnyWj6lRGN+WELtJVJXaSFxNE3JUAPOlHYA= X-Received: by 2002:a54:4393:0:b0:403:5277:9424 with SMTP id 5614622812f47-404c21373f2mr3743430b6e.32.1747319480654; Thu, 15 May 2025 07:31:20 -0700 (PDT) MIME-Version: 1.0 References: <20250514184158.3471331-1-shakeel.butt@linux.dev> <20250514184158.3471331-2-shakeel.butt@linux.dev> <22f69e6e-7908-4e92-96ca-5c70d535c439@lucifer.local> In-Reply-To: <22f69e6e-7908-4e92-96ca-5c70d535c439@lucifer.local> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Shakeel Butt Date: Thu, 15 May 2025 07:31:09 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AX0GCFuAJwtLNKJwKPDMOLiftKy-4ToNrqm6RD1vIrynPcQ5WImKcXb6Sk0ZoHk Message-ID: Subject: Re: [PATCH v2 1/7] memcg: memcg_rstat_updated re-entrant safe against irqs To: Lorenzo Stoakes Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Vlastimil Babka , Alexei Starovoitov , Sebastian Andrzej Siewior , Harry Yoo , Yosry Ahmed , bpf@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Meta kernel team Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 3AE95A000D X-Rspam-User: X-Stat-Signature: 78txb38b9dao9wf8umxt8neixajwqxwp X-HE-Tag: 1747319486-377150 X-HE-Meta: U2FsdGVkX19bIEQ5nEuyovgt2dqprfCl3zj8xZCxJhNUZVtmQXoBEA7lTiJ2QuM3wNHHMheljT5L7CBgk3VhnV9PqSVBbWpZfHKSX0+YfhNA1NIf6UuVQhIZKwYnEQsJa/ddOwOIGuUkJAJ8Vc7GMmuil5E6pOxg7izIN0uoiREImjRRLnnYxkiog/U7G4/opjr8f8MXQHSD70UCwG+JIzWknHY5yj87oT00KKCAd8ZQ9DQyClf4dXA+DpQpJ/ap0XzGXTY9iH0ufT6lGSsdsCenH5JpWu0HTbdnLyScgoWO/xgvLe4bf0USS8UAuC85/teI/vU1lsV8GeR+Fu9dNzKH8+gAvaiZGLROL69YRXWIVPCmLbZVMeEqusTEwnsWtCg3HiOA5zZUWmAActsvSOE/kDMbhPj7yVJm0ZE995EkmyUwuIEUhCjOIIZRScr/YW0gFzVZoLOEyikz+4sQyURqi+/opVBTORzrpn+z++g9ZjjUYuA6+VVjOw0/Zc6MimxLsmRYBhqM8Xh0WnxKYcsONph12WADxfuGz4ZUvQfzsR5mqKhvHxnhHT2/IEdUrRatMZ6waldRN1GdWl6Z1x8dAsqRuaKnqok3/jjnSLUDIgduNx9M7H1AK/l8/w7npQ6JohH9pmzm/yyZLukKBjhePOI+4sXDGP3I1XA9cSv6YdifWqgAMmkeSyYhY0WNipq20vxRe9EfiTEIrxt4+1SXOyst0b6WY8l8wnzWvx15vOTAE7DCChHeqGOwfd7ZRT8qAr7giHb9CJ2p9SUFPZABmPNSbeHIm4CtTDKZOxqZstvNk8r7OEupLaq06mEljsbNWlStpl2zijDPnHi/qj+HD8VS/LKMeaLYhR5JTNTi2uz6hn68wViFxu/tdbdyX0H0xQK5luVpF7E3QFrY0V93+boidJIZE7dtGw9gHdaZe0EWbGuizvYE/82FZkaFRTh9AA9npg1qD9/j5B0 qxjVYh65 OGYQibce0JtplwV83v7ksJvY20ZoQjjBif+2GqeHFTybxnPSDw3P1aZKRhNW5urtWoXOxjeRl+d6NlvDadCQiRd6WcNXl23DkMdZ4VpUKqIvZDwXNDZIz7CwhxW1/Bc4Yuw8Zt07kj9WVBZZ/Agb798JrMHa0PENW4mEl9CiKdBnMXQxp9qfBmerCw2HTqqCQD3xF03/kT/nz96BF5BpvflA89A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, May 15, 2025 at 5:47=E2=80=AFAM Lorenzo Stoakes wrote: > > Shakeel - This breaks the build in mm-new for me: > > CC mm/pt_reclaim.o > In file included from ./arch/x86/include/asm/rmwcc.h:5, > from ./arch/x86/include/asm/bitops.h:18, > from ./include/linux/bitops.h:68, > from ./include/linux/radix-tree.h:11, > from ./include/linux/idr.h:15, > from ./include/linux/cgroup-defs.h:13, > from mm/memcontrol.c:28: > mm/memcontrol.c: In function =E2=80=98mem_cgroup_alloc=E2=80=99: > ./arch/x86/include/asm/percpu.h:39:45: error: expected identifier or =E2= =80=98(=E2=80=99 before =E2=80=98__seg_gs=E2=80=99 > 39 | #define __percpu_seg_override CONCATENATE(__seg_, __percpu_seg) > | ^~~~~~ > ./include/linux/args.h:25:24: note: in definition of macro =E2=80=98__CON= CAT=E2=80=99 > 25 | #define __CONCAT(a, b) a ## b > | ^ > ./arch/x86/include/asm/percpu.h:39:33: note: in expansion of macro =E2=80= =98CONCATENATE=E2=80=99 > 39 | #define __percpu_seg_override CONCATENATE(__seg_, __percpu_seg) > | ^~~~~~~~~~~ > ./arch/x86/include/asm/percpu.h:93:33: note: in expansion of macro =E2=80= =98__percpu_seg_override=E2=80=99 > 93 | # define __percpu_qual __percpu_seg_override > | ^~~~~~~~~~~~~~~~~~~~~ > ././include/linux/compiler_types.h:60:25: note: in expansion of macro =E2= =80=98__percpu_qual=E2=80=99 > 60 | # define __percpu __percpu_qual BTF_TYPE_TAG(percpu) > | ^~~~~~~~~~~~~ > mm/memcontrol.c:3700:45: note: in expansion of macro =E2=80=98__percpu=E2= =80=99 > 3700 | struct memcg_vmstats_percpu *statc, __percpu *pstatc_pcpu= ; > | ^~~~~~~~ > mm/memcontrol.c:3731:25: error: =E2=80=98pstatc_pcpu=E2=80=99 undeclared = (first use in this function); did you mean =E2=80=98kstat_cpu=E2=80=99? > 3731 | pstatc_pcpu =3D parent->vmstats_percpu; > | ^~~~~~~~~~~ > | kstat_cpu > mm/memcontrol.c:3731:25: note: each undeclared identifier is reported onl= y once for each function it appears in > > The __percpu macro seems to be a bit screwy with comma-delimited decls, a= s it > seems that putting this on its own line fixes this problem: > Which compiler (and version) is this? Thanks for the fix.