From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F455CA1005 for ; Fri, 30 Aug 2024 15:43:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACE546B017C; Fri, 30 Aug 2024 11:43:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7EB16B017D; Fri, 30 Aug 2024 11:43:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 946666B017E; Fri, 30 Aug 2024 11:43:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 741EA6B017C for ; Fri, 30 Aug 2024 11:43:39 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id D966E1A1AE2 for ; Fri, 30 Aug 2024 15:43:38 +0000 (UTC) X-FDA: 82509331716.09.780604E Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf14.hostedemail.com (Postfix) with ESMTP id 08F6510000B for ; Fri, 30 Aug 2024 15:43:36 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=cloudflare.com header.s=google09082023 header.b=cYDF3Q1T; dmarc=pass (policy=reject) header.from=cloudflare.com; spf=pass (imf14.hostedemail.com: domain of mfleming@cloudflare.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=mfleming@cloudflare.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725032595; a=rsa-sha256; cv=none; b=Clb/GtdnrbWet2TIGxET39GAK9sTTy0BfQM5QZXTBsXwvINxXDSo5cMqRXtuy1Rn5aduQS yo+caeFdNNr71zEZg6ENZIfEc1Rb0wxTbccVnMm0NV0LIhLmzzo0vUp0wafMJm880S+KyD iGx/05EbbBxArcGYfmYaGxQkz2vaBtA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=cloudflare.com header.s=google09082023 header.b=cYDF3Q1T; dmarc=pass (policy=reject) header.from=cloudflare.com; spf=pass (imf14.hostedemail.com: domain of mfleming@cloudflare.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=mfleming@cloudflare.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725032595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UAyUoW8dP6OgjntMMjWd6Y1oH6Hif1C3V2F+jPOy33I=; b=AHKuCficVK4nKNahlKf+7+iurH5PG8ZVO20gbTTdN9IcsogBvHaIUMuanRgzwkYmLHBtK+ wOgqH2+A++wWijfGqXNhdSBlzRZPTxbuUnHYUrWRbpO+QAdkZS7K7y9bD0khZtR1dEhCVU Be3Vg7J4pTmBXlSAtb+PNtGvS0vGmBA= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5c0a9ae3665so2084029a12.0 for ; Fri, 30 Aug 2024 08:43:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1725032615; x=1725637415; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UAyUoW8dP6OgjntMMjWd6Y1oH6Hif1C3V2F+jPOy33I=; b=cYDF3Q1TEJtLW5dOglWvi8Aob+reqo35RQE2uTDsgiIvFquPTYoiUpp8pFf+JWiV8p Hyx8OAEjzGtaeOlWKbAjrC4rm7cLHaWcQppBi6sNzPU5GzbU5V4RNxfQkREAhMWmyAcx G/CD4t4Hvbw7ZKKTFgFYMeatiF0nfWDNkxnJu1l5uK6bQDHCFX8k5yHPMLhGCv67y9IR cXtGiVYm7fKRk1w1cEnVuESks+LmZvnh74INNb6YRcOmLrwXC+VQ9zCsCFu5LtsBhWeF pu9SL8s5kr1ZBGEkjiJMk2lGd2KZSb+TVhxQQnuq6hePlUaeJVxuVPkzlEh834UOPPr3 wsUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725032615; x=1725637415; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UAyUoW8dP6OgjntMMjWd6Y1oH6Hif1C3V2F+jPOy33I=; b=eahe/iM242TzamAZHaWI1Nnu09WjYFmZ1DUNLn6eeh/TfOt3kBSh1/JpduysANqLY3 /rsSEfg9N9bRy61qPrqTsvVm2U2rhzcV/IoRQPrnLkZ+NAx6Dg6+IfpyzNWqfGxKWZ5i 6F/uZqqkKj90KD0xj1BSmPCfjEf/Q5/EhVkKizczqtc6ScCh4jo2FAjRkQLRJHpFT4U6 J+DrQJOyRrd+v2adnOKZUvpSEnnYIVThJt1ODFPkLiZFdBisURrFBK4ea+Iz4pOX6FeO 7Y9knmb58POrgcN1wRfDdgdWvi7/lxE9kxTiN4EDw5bbTD5r8PH1IOdqmNIYhcHsIR9F ZSlg== X-Gm-Message-State: AOJu0YyQcjzwsobdwCCLJf4BoHl/exNw7Qp/6gJUps2XNldNStGTVss5 AC26Lc9/DyG48I1ejhe82f7eYEpO7Huky93eRZn/jaAFLvelEGdPYiBo7mWgZOZvj/TvMBNiz/a Ml7QqPzieJKB8ez4KmSCeLLpclDNMe1vhHx5COw== X-Google-Smtp-Source: AGHT+IH/7R0+OoSUKCl11Fwwy1JvgGUo7u+8q/CarhODJs2lY+0BWc1zdbKXPnKO5D0MbsMQGhpJphMLnp2yj8gK094= X-Received: by 2002:a05:6402:5111:b0:5c2:12b5:3b83 with SMTP id 4fb4d7f45d1cf-5c21ed33cd0mr5203261a12.4.1725032615104; Fri, 30 Aug 2024 08:43:35 -0700 (PDT) MIME-Version: 1.0 References: <148e864e-c344-40df-92e9-f919314f6e7b@suse.cz> In-Reply-To: <148e864e-c344-40df-92e9-f919314f6e7b@suse.cz> From: Matt Fleming Date: Fri, 30 Aug 2024 16:43:24 +0100 Message-ID: Subject: Re: order-0 page alloc failures during interrupt context on v6.6.43 To: Vlastimil Babka Cc: linux-mm@kvack.org, "Christoph Lameter (Ampere)" , willy@infradead.org, kernel-team , Mel Gorman , Johannes Weiner , Charan Teja Kalla Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 08F6510000B X-Rspamd-Server: rspam01 X-Stat-Signature: x7yncmzypksdb6d1txwq6upexbb5yda1 X-HE-Tag: 1725032616-265857 X-HE-Meta: U2FsdGVkX19EEwHogFrv9NBbHYQ4oqNyJmNuWy3/ib4Oxw9Y8U53qD7uNwtbYBO1y8kyQN18/uePR8BLfg7Zpks9wwpAxGXULiQzL2MfNxh2DWAnH8ZcVfhGtowMzJmZg9PkzdvaAngQDOOcp5UDvBb9w4Gi2zzcEnEOjEttaRjsmtyovmFUHwbqupgymJzxzo0waWXTkZSJbl+X7RlQmpiJeptpvo57+M4TfEYwBPqRmp5P0mY7Z2bAUgVC/wWvDvItLtvzfoSVuc2Xn8z19S3bRH85bGDgmDuvk/pwWNHlzPEL5M+pBQwfaK875j3r21e4BcbqjxmmHWTHFQ8AlZJS2o8EZpfIoBjUIitt/HUv0Lng4NA+i/4yne8LYqjxGPmU4FK5xi49hS81g8pyPN4LoT+vN9nkocY67qgIZpsgeuWvxi7+aG287zQEQ5rYVJwEVdWArdMT/uvVAJunDnQWPNKaLKTTAd8Y2jzv7D9AGmNOSUsz9E+QvuGBlKn3qWnIZT3Uf5wzvkOQeFcj0b3AR++6v4Es/ieazKjPyJbFN1LSY8xHYq9pey99h6lm0itTS0WZYAt4YTIn+T1Ry+bkGc4eeFrFKRgvkCoYp7lX3tEwUaYfKzeUBgOyjSbhBF92f8Io346ca4pwxsjLEk3b19kGnnmBOyqVp3oifC3osWnet/gH6aB+t1KJRuNyf9ZfZpcRfjnXOJXw5P9SyNnXTTxuwhCSrR6+kc2FOq7TaMYMuNqlvIatT8p0+LqFflbqNC2s5HzfYzsZeSvIILrIus71l6vD8nWSLuJrMZs4oAFlh3joDwhiydn9PZKgJ0W4+/JzNqS3vY7GAS2qquQ9B3m0/zNTbiFtTU5sBaVrUsIqdK0xgDEjL9s/punib/oYivTlYyJIJVBjCyPBp7jKtUuN3R8weuyiYVR8q8wvxeRys0R/DKml69e9QEbxEa2AlX8bTIyw8YuPXfd fFnMzFFQ +8IUenY3RfO9Ho0unl2KX82uBcggMENLI2XcuClXoDN3kIww3gdT6YitcYTkyT2Oh7P6/+aJX5GSZPVqNY/IzvL5gqE4r5Awk0dUDWehakdBlaDTlaoHjleNnhgBTMzHFcK+NgS9cqtaaWsy/IEO+xStQZ+Fhloq259PhnY6uikSLHiMWtZWIKPuNP4khbvrEq4Cw59OpgcgPoZmmML7TND1jB/arKob0zt7UAG1DabLRsvrhdpoUG5TQEQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.006557, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 4:48=E2=80=AFPM Vlastimil Babka wr= ote: > AFAICS: > > - __zone_watermark_unusable_free() for ALLOC_RESERVES (which includes > ALLOC_NON_BLOCK which GFP_ATOMIC allocations have) does not subtract the > reserve_highatomic, so the allocations pass the watermarks > - but in rmqueue_buddy() only ALLOC_OOM is able to fallback into highatom= ic > - unreserve_highatomic_pageblock() is only called from reclaim and there'= s > no reclaim for GFP_ATOMIC > > (also worth checking if kswapd even does anything if free > high, but it'= s > all highatomic, maybe not? so it can't help us here) As far as I can tell we'll wake kswapd but like you said because free > high it thinks the pgdat is balanced. How is the system supposed to recover in this situation? Wait for a non-atomic alloc to fail and enter direct reclaim?