From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8706EC433EF for ; Thu, 14 Apr 2022 02:41:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D9BF06B0073; Wed, 13 Apr 2022 22:41:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D4A536B0074; Wed, 13 Apr 2022 22:41:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C12F06B0075; Wed, 13 Apr 2022 22:41:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0025.hostedemail.com [216.40.44.25]) by kanga.kvack.org (Postfix) with ESMTP id B3EC46B0073 for ; Wed, 13 Apr 2022 22:41:04 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 41519A7C5D for ; Thu, 14 Apr 2022 02:41:04 +0000 (UTC) X-FDA: 79353932448.28.CE4A9A4 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf11.hostedemail.com (Postfix) with ESMTP id B3B9940002 for ; Thu, 14 Apr 2022 02:41:03 +0000 (UTC) Received: by mail-lf1-f47.google.com with SMTP id t25so6748304lfg.7 for ; Wed, 13 Apr 2022 19:41:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mCEuHD36brVtOxyd++nob/+Gm+DiKQiXoh2FckYZDmo=; b=qd4NjLduoTAivuhSPCDziNZX9mUcFXnmlw0uTDhfvoEc3UafX5fs5Re0iD5b+7/sVb AuBdeBCPpzky8ysbFOez7GVVHVyGoUYg8jXiZ8+TMpoaxEu1zbClTRkD1CF1JWKtXY3T m/RpH8GcI/cwf2hrMURfH8Kaf4wc6DfrsF4Z0pOB2uWuMnsv08kT1pFZX8x184An2FbJ Z4jP1pywbNvYV9F/jBKYOv6eC4LRaQELvQaJkSfASd2BXKcbC8X4+zLYDvR8++t/Jo8j NSLXuSrD/vgzZfXgs95l/lyN4dMgLLGeVEx0ZGBpIspJHN7BwklFYrjUOCf9YDeH5OG6 Cl5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mCEuHD36brVtOxyd++nob/+Gm+DiKQiXoh2FckYZDmo=; b=fG8XlkCHKUagmbqv2uLExSvc0/Jl/HSYDUeanl3n0BX62tJOlZOoqWcEFzRfPeyi7I AfdBNcTBN4oK2HLAm5SrxZV4MFj1yNbdcnnzNFCNNUH9WKUpykdRFLfg0SUHD7R7TInX DDuC1HmRG8C+imlWx+BBFfVvrELVUD54eyvpBJGisCFKCwHIhLmOd/osSd2rRjumVKQX e+SQE2601qnNEm6ilgYLqBfbkplpJ/SAdEeOVxs7/J84DIMSZcM3MnPFZNOXwyGDGTAF pngqsnKXeiWbp9Arlxs7707SgEY5+qcUrU1n61eNvw+PAHL8g+/H1YMaPU0JPfBa5TcS 1NJQ== X-Gm-Message-State: AOAM533+sHnNF9izRx9XjhdqnDf4ABD1DyUjYFYegaJkDU5P6e9rEIu7 pfvV4j+XxWWs/t3EDfxH+lTmRopI2FpEosaiC7A= X-Google-Smtp-Source: ABdhPJy/TxGaYjTzpc+8A8MTSoJRPdE5fFBg22cQwIv0h2c92kph7QuwX3ILyCMgrSuPwtGXMdSS1pMVcrZUnUSseEA= X-Received: by 2002:a05:6512:10c8:b0:44a:9305:77bd with SMTP id k8-20020a05651210c800b0044a930577bdmr482301lfg.404.1649904061833; Wed, 13 Apr 2022 19:41:01 -0700 (PDT) MIME-Version: 1.0 References: <20220413122925.33856-1-patrick.wang.shcn@gmail.com> <20220413122826.792a859d90b6c2822b1c796a@linux-foundation.org> In-Reply-To: <20220413122826.792a859d90b6c2822b1c796a@linux-foundation.org> From: patrick wang Date: Thu, 14 Apr 2022 10:40:50 +0800 Message-ID: Subject: Re: [PATCH] mm: kmemleak: take a full lowmem check in kmemleak_*_phys() To: Andrew Morton Cc: catalin.marinas@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: qjspx4d7t48ibgij7ptcic1e8wukcytk Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qd4NjLdu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf11.hostedemail.com: domain of patrick.wang.shcn@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=patrick.wang.shcn@gmail.com X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B3B9940002 X-HE-Tag: 1649904063-884814 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Apr 14, 2022 at 3:28 AM Andrew Morton wrote: > > On Wed, 13 Apr 2022 20:29:25 +0800 Patrick Wang wrote: > > > The kmemleak_*_phys() apis do not check the address for lowmem's min > > boundary, while the caller may pass an address below lowmem, which > > will trigger an oops: > > Do you believe this fix should be backported into -stable kernels? Yes, I think so. The callers may not quite know the actual address they pass(e.g. from devicetree). So the kmemleak_*_phys() apis should guarantee the address they finally use is in lowmem range.