From: patrick wang <patrick.wang.shcn@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: catalin.marinas@arm.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: kmemleak: take a full lowmem check in kmemleak_*_phys()
Date: Thu, 14 Apr 2022 10:40:50 +0800 [thread overview]
Message-ID: <CAGcnep_rWWYBr+NFYzh7wNhoenFpwbxy=15a6w5vpJAH8P1dDg@mail.gmail.com> (raw)
In-Reply-To: <20220413122826.792a859d90b6c2822b1c796a@linux-foundation.org>
On Thu, Apr 14, 2022 at 3:28 AM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Wed, 13 Apr 2022 20:29:25 +0800 Patrick Wang <patrick.wang.shcn@gmail.com> wrote:
>
> > The kmemleak_*_phys() apis do not check the address for lowmem's min
> > boundary, while the caller may pass an address below lowmem, which
> > will trigger an oops:
>
> Do you believe this fix should be backported into -stable kernels?
Yes, I think so. The callers may not quite know the actual address they
pass(e.g. from devicetree). So the kmemleak_*_phys() apis should guarantee
the address they finally use is in lowmem range.
next prev parent reply other threads:[~2022-04-14 2:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 12:29 Patrick Wang
2022-04-13 19:28 ` Andrew Morton
2022-04-14 2:40 ` patrick wang [this message]
2022-04-14 17:26 ` Catalin Marinas
2022-05-27 4:00 ` Yee Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGcnep_rWWYBr+NFYzh7wNhoenFpwbxy=15a6w5vpJAH8P1dDg@mail.gmail.com' \
--to=patrick.wang.shcn@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox