From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2EACC433EF for ; Wed, 6 Jul 2022 14:44:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2123B6B0071; Wed, 6 Jul 2022 10:44:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C2056B0073; Wed, 6 Jul 2022 10:44:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B2896B0074; Wed, 6 Jul 2022 10:44:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F01736B0071 for ; Wed, 6 Jul 2022 10:44:24 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BF7BA20ECA for ; Wed, 6 Jul 2022 14:44:24 +0000 (UTC) X-FDA: 79656945648.08.75551E8 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by imf06.hostedemail.com (Postfix) with ESMTP id 49EAC18000E for ; Wed, 6 Jul 2022 14:44:23 +0000 (UTC) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-31c8bb90d09so88527097b3.8 for ; Wed, 06 Jul 2022 07:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i8nzXgal2msjMVDTnA8zsOLTUVP8huhCkUI38Q9wMik=; b=Pc9q9ysdte082azRicyZZICVd0daCGl7wh/AM/oxOaXyVEwzAhOcHZ+nii+IRPnHa3 3tiS1tBa0ujmS7LwzFPmvKgX3wZUzpKZZJ3+0TQmjr7xnTLP9B3hv2WFBscXb/aytkCD wGSBFsQ3WMZRrrDrmKR7RHgXmzqiKlv2E4g3wg8Ixi5PlNXj74dbHmiKYpopa4xSZTQJ C/qntZB16I9WfaNOiLrOfkcrDHCn2hbehIUb9tz0VVjPT/W2tVJB7+YHMALlVWU0BawF BYmxQBJSERQdftDQrD5LrxhUuPzMF2/y6NtmgssZ7Hrh/Lm2i4WMFGTGmspY2+Z96V9N mc1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i8nzXgal2msjMVDTnA8zsOLTUVP8huhCkUI38Q9wMik=; b=AoidStvYUdDiLvDrVO4EE912H8U6YolMGJvO1ieys9ok2wHTA6tj1CydeywD2z13nQ Fq7PJ2jQ0MGyT4EfyqFmEORfPsQr30KitMyfAQi5w2/ccPeYffYsxnALXgt6r8AJPGQb COgXy9yHO4CqSPGszEKsw7izJNvxaeuZTtHNkHQaeT0Kl3NCOsbD1kjrXnGksS92MFcs G8ZCyKJ+XQ5NE8XYTJpFkNcTO4x85NJaG8uPPulIHDKKQWM7snZN9+zDnmGEGF7fnyDa EFVt7HYHZAf+FYHlxI0dsZGnl/bVslN3PTqZU/cZd6/I71o00tbOExLH2RBL6+StsrxV USeA== X-Gm-Message-State: AJIora9PS4udCvaZZALe9U7edID1/pPEAzBPbgDCxFL4HYJ9PanrzYbo 47MDSbNwE4lq5njdtC5syBnFFIKQt2/eXJFMfEo= X-Google-Smtp-Source: AGRyM1viPF79fBhh3sHU+fwkYIJzyOdYW+WrW4Kj3mFD7AgqhqC906Ryyu79zItn569gEBs9hCMYZZARlLvnwdjsOaU= X-Received: by 2002:a81:5841:0:b0:31c:a7ed:85ee with SMTP id m62-20020a815841000000b0031ca7ed85eemr16906217ywb.215.1657118662439; Wed, 06 Jul 2022 07:44:22 -0700 (PDT) MIME-Version: 1.0 References: <20220705113158.127600-1-patrick.wang.shcn@gmail.com> <20220705142000.4679acaaf1238a73a555ea58@linux-foundation.org> In-Reply-To: <20220705142000.4679acaaf1238a73a555ea58@linux-foundation.org> From: patrick wang Date: Wed, 6 Jul 2022 22:44:11 +0800 Message-ID: Subject: Re: [PATCH] mm: percpu: use kmemleak_ignore_phys() instead of kmemleak_free() To: Andrew Morton Cc: dennis@kernel.org, tj@kernel.org, cl@linux.com, Catalin Marinas , "open list:MEMORY MANAGEMENT" , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657118663; a=rsa-sha256; cv=none; b=ASZwSRqZOmsDFXGLlMDn6YBfy+uW6NJexgHK53OPfpo46hGTvwS7spEIYSWdpqhHIjF5uA 8qe+uD4aun+f1mXAxzFihrEt09BXkNBPPlI0AiJmhh6U669Z4jJQOoVXeDW1jPoWlarXz7 ZlV8UYdwVQxC9hqbIGRkdIMPwaRxh6w= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Pc9q9ysd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of patrick.wang.shcn@gmail.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=patrick.wang.shcn@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657118663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i8nzXgal2msjMVDTnA8zsOLTUVP8huhCkUI38Q9wMik=; b=CZuY3m2na8L/oOsp0n37YTGp3fiqiuKdgZ9OmUzx4xnmfWVmPsd5R79aDDdQpINVLgBkt1 eAmeQoL/grEq8gUIKowygnGQNePACV+0oapfpfaPoNyPHRPMuz2XR1BgmtPcqa6jodKhXs dq68fW0zNUqzWlEH4ci5Ftdd+yJVW1A= X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 49EAC18000E Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Pc9q9ysd; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of patrick.wang.shcn@gmail.com designates 209.85.128.179 as permitted sender) smtp.mailfrom=patrick.wang.shcn@gmail.com X-Stat-Signature: w98ajmz67pfny4s73nkrun1rdosuhwic X-HE-Tag: 1657118663-59110 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 6, 2022 at 5:20 AM Andrew Morton wrote: > > On Tue, 5 Jul 2022 19:31:58 +0800 Patrick Wang wrote: > > > Kmemleak recently added a rbtree to store the objects > > allocted with physical address. Those objects can't be > > freed with kmemleak_free(). Use kmemleak_ignore_phys() > > instead of kmemleak_free() for those objects. > > Thanks. What are the user-visible runtime effects of this? According to the comments, percpu allocations are tracked by kmemleak separately. Kmemleak_free() was used to avoid the unnecessary tracking. If kmemleak_free() fails, those objects would be scanned by kmemleak, which is unnecessary but shouldn't lead to other effects. I didn't observe any anomaly without this commit on riscv and arm64. > > And are we able to identify a commit for the Fixes: line? 0c24e061196c (mm: kmemleak: add rbtree and store physical address for objects allocated with PA) Current in mm-stable. Thanks, Patrick