From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1066DC43334 for ; Wed, 8 Jun 2022 23:44:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F5D66B0073; Wed, 8 Jun 2022 19:44:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A4DC6B0074; Wed, 8 Jun 2022 19:44:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 545076B0075; Wed, 8 Jun 2022 19:44:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 459096B0073 for ; Wed, 8 Jun 2022 19:44:26 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1C50F3587F for ; Wed, 8 Jun 2022 23:44:26 +0000 (UTC) X-FDA: 79556700132.15.2A56BDC Received: from mail-yb1-f175.google.com (mail-yb1-f175.google.com [209.85.219.175]) by imf05.hostedemail.com (Postfix) with ESMTP id ACCA110002A for ; Wed, 8 Jun 2022 23:44:25 +0000 (UTC) Received: by mail-yb1-f175.google.com with SMTP id v22so39107422ybd.5 for ; Wed, 08 Jun 2022 16:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7YvbnxXMryXWMsjSaz1Ekl/JpgVzZCjALJ/1ZepPv50=; b=mZDxGrd4G/FXAlzUGMy+s+aMzzkBbXRGQX1OHO/y9mtGdDWKN3FDCN49F8E5CjRHEe nXIaKYS8iAszBSSddmfyFAr35b96F0Fj4JpoiqlWkSvK9rnxrF2UJYwS7U5b29ABsqvO WrpZRK1cyQlnMVutnjeNjFPN0tD6vt9oyV3mN4rn0udSaYEZEKLPQTYSM4Lm1lTHBYA6 An/8ykts9cW76kb+mmVHFwJ9vNYiLuVquNc+hnlLIGuceVY11yjleVLHRwPYSHx0/o1H pvAm7XyC4oW8zfsk0xxLOktBIZQz7msgNo+iRgkFBYMjGH+6Twtty7ZRAWUukOWh2yR7 K86g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7YvbnxXMryXWMsjSaz1Ekl/JpgVzZCjALJ/1ZepPv50=; b=M8KrHqocxVC2x9bq7OEg+aGU8rX9NYeOQc9GIg/j/NxGfuTuoxK3sZvkMI1eaBcmKU JpG1WwwYwA8cJdjka/foY4aH1hKWEBvE4awhhnMHPKo+2y+z9lY7y4F6T1uJHLY28xrW 050vdGXqVRmXBX5JhlZ9jc/+3yq3lov3bZXbJGAHaPx4ymtIbwyqEuh6j63rMKSQHn/A z9k22z9jDFWWMPQnLcAVAv/2AWHNA4LdvGq+bDbt19NEI/UVJ1XdcvesDg/8wpi2sLO+ 4mbscYoOR/Ah2CDQ6ZX4hVO+sw/d+stcoCgN1JwBoUeLTgOk6E+iAWKCQz+j9jALRiEI bPhA== X-Gm-Message-State: AOAM5315fIoual7WETZzKW1ID+7Kl/00sVsrC6lniB++zVlQoYUsuK8V nc7aBa5KBGpwpa9XTneVoFOk5ftYY4j10q2/gng= X-Google-Smtp-Source: ABdhPJwc9TJDrPzjl4vqLj9UMS5h1WkqxuMJZP7pVSyFdUGCnCSClulRkmpIszlQy5si4ukb56KYJSYcxr16AXvmi2g= X-Received: by 2002:a05:6902:12ca:b0:65c:a34c:39cf with SMTP id j10-20020a05690212ca00b0065ca34c39cfmr36298170ybu.476.1654731864951; Wed, 08 Jun 2022 16:44:24 -0700 (PDT) MIME-Version: 1.0 References: <20220603035415.1243913-1-patrick.wang.shcn@gmail.com> In-Reply-To: From: patrick wang Date: Thu, 9 Jun 2022 07:44:11 +0800 Message-ID: Subject: Re: [PATCH v2 0/4] mm: kmemleak: store objects allocated with physical address separately and check when scan To: Kuan-Ying Lee Cc: "catalin.marinas@arm.com" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , =?UTF-8?B?WWVlIExlZSAo5p2O5bu66Kq8KQ==?= Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1654731865; a=rsa-sha256; cv=none; b=hf6HBwb+zGn0cKJYIsW4Lh5PRs9LwTnxWl1LzMXOSaPIpAaVp7i7TPQ/oXoA1iKlapO4vB KUZHXLR7sAv5JhAOElOADS3uH4bnRn8YYRhMJxs4NwRMkmPbXx/TOHZ0neCBvKP8UlJQmV k4hvV7zY2baNrHlzFVOZHrzwxVGyZKY= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mZDxGrd4; spf=pass (imf05.hostedemail.com: domain of patrick.wang.shcn@gmail.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=patrick.wang.shcn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1654731865; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7YvbnxXMryXWMsjSaz1Ekl/JpgVzZCjALJ/1ZepPv50=; b=ODcm0odHWLaZnUHUKlBD1zemNwX0PhxThiruWDefrjBaGWEG7mOisjwNDizSSFi5KU6txa 3ezQDYlViSNbL25fq1WgPAoPfg1P23su328nIg8Bhmj+2eYtF3ajuZj2kQituYNrZWyxyU 2VzgbKyn3Wfelb2BztvKo5Lg/yV8CTw= X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: ACCA110002A X-Stat-Signature: 613zjuay4stsf78xhdffe38rnza9park X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mZDxGrd4; spf=pass (imf05.hostedemail.com: domain of patrick.wang.shcn@gmail.com designates 209.85.219.175 as permitted sender) smtp.mailfrom=patrick.wang.shcn@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1654731865-625945 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 8, 2022 at 10:46 AM Kuan-Ying Lee wrote: > > On Fri, 2022-06-03 at 11:54 +0800, Patrick Wang wrote: > > The kmemleak_*_phys() interface uses "min_low_pfn" and > > "max_low_pfn" to check address. But on some architectures, > > kmemleak_*_phys() is called before those two variables > > initialized. The following steps will be taken: > > > > 1) Add OBJECT_PHYS flag and rbtree for the objects allocated > > with physical address > > 2) Store physical address in objects if allocated with OBJECT_PHYS > > 3) Check the boundary when scan instead of in kmemleak_*_phys() > > > > This patch set will solve: > > https://lore.kernel.org/r/20220527032504.30341-1-yee.lee@mediatek.com > > > https://lore.kernel.org/r/9dd08bb5-f39e-53d8-f88d-bec598a08c93@gmail.com > > Hi Patrick, > > If this patchset fix the above issue, I think we need to add > the below fixes tag. > > Fixes: 23c2d497de21 ("mm: kmemleak: take a full lowmem check in > kmemleak_*_phys()") Hi Kuan-Ying, Thanks for taking a look. This series should solve the false positive on ppc32 and arm64. And the false positive on arm64 is triggered by commit 23c2d497de21. So I will add the fixes tag. Thanks, Patrick