From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9042E81E1B for ; Fri, 6 Oct 2023 17:22:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 257958D00D0; Fri, 6 Oct 2023 13:22:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 208078D00C9; Fri, 6 Oct 2023 13:22:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D02E8D00D0; Fri, 6 Oct 2023 13:22:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EE95A8D00C9 for ; Fri, 6 Oct 2023 13:22:09 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B5F4D1603EE for ; Fri, 6 Oct 2023 17:22:09 +0000 (UTC) X-FDA: 81315704778.27.6C10F8A Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by imf06.hostedemail.com (Postfix) with ESMTP id E7AA6180022 for ; Fri, 6 Oct 2023 17:22:07 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RSdWu0jf; spf=pass (imf06.hostedemail.com: domain of glider@google.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696612927; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EknEuy8+VO/WBZWGFtfzssW3dtzNayZawyALF7dqvnA=; b=OqAlABHiV5ErNBTohm8wUUpi+5m70KFn0xZpg8eRc/r/sQWRkqSQiuv+HBHNWxn9wXiZML tjA+xfnByWZrk9IKuFphp1jLqMb2dcQNXIyptYf4T02BmzjL+5+2JZmQIzrvXHfgL7VASt 9oPewSrbsA8FUQ2KATlejCNRpTnS7+M= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=RSdWu0jf; spf=pass (imf06.hostedemail.com: domain of glider@google.com designates 209.85.219.53 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696612927; a=rsa-sha256; cv=none; b=52h+XKsBzKkOP9+n7pwN1lB1glodD+oJq84X4KoMJa9uxBb5uIr+5I9bUph5v5BR7A9twb sjNjP0lrNY4Sb22KgF4KIbjtdIAyDU1kkbb5Tf6Xkf7Nx3iDY81Y8bH4o4ozMYIXWy44kf LXmNop/X0GA3okTA6kdsSfpefobwLxs= Received: by mail-qv1-f53.google.com with SMTP id 6a1803df08f44-65b05a45046so12627166d6.2 for ; Fri, 06 Oct 2023 10:22:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696612927; x=1697217727; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EknEuy8+VO/WBZWGFtfzssW3dtzNayZawyALF7dqvnA=; b=RSdWu0jfWGSEbQSrJ8Zqcak5eqkLZdfUYA4XUAdNd9nLiRvIuTMgV1n/s1x37Fs2cX 7DtM6PD9hSPCDZutMBa42eNfp2+iWLU/XFOQQghT3gps9BcSFrSm5yYAzEpRkWS5Tb4x 7b9CXag1evF3zGpL9IrRn+208rAOfp2EAqNZOQ0ETCtHf7QtM8ENQHqydPxWkHOp1qeF 6Bj8T4kzOmqi4P/BSMBbY8j5CszzuOqODf9F9e1rgk21pb7QR46b4gEb4n7+25PHfa9t n/kTqPsgjs25SZgKNCORlBn5ss9es+ouUW5JSBftdjuwkHXujKODf6DaQ68YO1abfLcR 6cvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696612927; x=1697217727; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EknEuy8+VO/WBZWGFtfzssW3dtzNayZawyALF7dqvnA=; b=cO+VztW2KHrZFQf9+lQhJL+TLZAmoufQkUhFawRW1LZxZIWrp316kt26rzZoQtbdI+ 3SzN1GqTZFp68/OYCkrF+8Xm2GqYa0mp1Ztx7jc9Ly2JvZYzi3c1ELQfWF6vjQfTSzS6 2NhkL/xsdmHgcD6Vqle3JXyxcY5qymYCuEztwNJGTvhOuVqiFk9pXTsMx/nx/9hMBYIo u1eeqhbe/LvmQhvHvE+AX8+ceEkFeLsajhoElCdpl/Y4TtEMiP3k6Uo+mIhOmsnZOVsg EOJ3NNIB2Lu+oFIYlXPhofkxVoB+vBScrQQGVS3KyxubpbeXf8h05yQMQ2hm0kvWTyEx yYzg== X-Gm-Message-State: AOJu0YzSTlIP9cPySE3GQdlrkz77s1mjSJvwEH2WNb4V8Q8HMWSOZJF3 Xp+3BM9EdidEf4yr0paswZPIUxcVqBS985//aFABkQ== X-Google-Smtp-Source: AGHT+IHgHuSZWW0zfjtiu53Q/dfXf6JAdjtdD5ymPm4GEksstftSEGfNyqhSiXc3DrR0aWOMGHN5RryhqLR06mwr6h0= X-Received: by 2002:a05:6214:180e:b0:65b:ed3:9a02 with SMTP id o14-20020a056214180e00b0065b0ed39a02mr8264327qvw.17.1696612926911; Fri, 06 Oct 2023 10:22:06 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Fri, 6 Oct 2023 19:21:25 +0200 Message-ID: Subject: Re: [PATCH v2 06/19] lib/stackdepot: fix and clean-up atomic annotations To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E7AA6180022 X-Rspam-User: X-Stat-Signature: mn3j6k6swkwz8fhg5ki4kk7a6ff7zpst X-Rspamd-Server: rspam01 X-HE-Tag: 1696612927-795412 X-HE-Meta: U2FsdGVkX1/ubvsGfPxl6umfcFp2o92WYsZcTeczMfgK6O6+x0caVBV1t1+Tj2JhMsuvccUqzga2cqugt4pg+Mp56buC0NXRWdm21KEAQxMCPTABabrfHiCqpXWAgSj5/bR6D6oGe1d6vSxhiM8AVTISVXAnXApHRFuJBzhrTN7ETDtR3Elht9KRDLtQJhLBusonM3xhsOyNeevIerAyTY8dj98DhzRg7y/DVfe2aHu0vsSpTSBWFN3vg92b12vKaLtGxC8CEKLbzsYE1LyhUmXcJlTo9AlZQSgToUrz+9rxkXuOmK6mc1ZL0MYnk0FvyIGaFk7YSJOs0eA56olQC6B6C3jypY0IWG9hQ4zixRdpTJYwSgh+FEAU3eRctEiirOO/O1MxSJPm8OkV/1zPGiVlv0UsJltqubY+/z02pa3OpyujGs2XzVlGL6BV35HJEm7AUaKn+4N3ObzoWdwEvKsdy65pT57fPpecvndSQ7fZKuS7AgPWX++p93kioFwPuobHCaG6S7882Hnvo1x9XMoBnuLjbKAGs14eqiOyxpQ//32obaYP/NuiOtwRqa9o9g7baV6cQZrmZs7ujGse2OuYRMwfKG0mfuf2d/NF9RxYWbseUnk8uCdnr9vaTAmKxzJNCoaSqygOezfHBdND4cDYB1WgY9jBUE2sa89Ch1yuaYbnK+1uBUK62V9uj/9NyfoOghrxroJIt1EyeeXiZ2uT6jRrulQdpb+LSqqoPyYlwWdiO1vtjFDAVfpXM9MPzu4IeHKWaU+OfY9E/z+mPl9sdkVmxgvPllGm1URJOUotbTVgelyyhiIX0ka0WozOAmbsX7LGUQ0wYBivpHA0DJfiv72EVpGw2AVBHVijNDidsuja+c790mWI1kywiOvvIyVuOMWrtQK9SEP6ijhPX2HsfDj5V6NbHAw2KZaaMXHq3p5FdM5EFl3Tv7xyMS5hnpzgarmK7YLwSKdd+8f LRLJW7vb Hv0bLdVRh6ZcR/GH0y3NES/8QiOI4jjOkYAmjpofgOU1vWqGA1Y4eh0vU5OH1CpaRCCbRcThpbhgYHrG92kWrnpNfAflzAva8DLZlYqeN6BpRena+ahaTVuznG5+AftLJFFWMpo7tibo8+hkzB5fFFb6U08RO4TaMmQEq4J2ThLiVWqBRUodNra+iVD07E5bghoqLRvs03LZjwPSnxmTnfnu/1Fkf+x+2kGbLYprVaoBpvYNuXWOG5TmSqyfZK/Xx3YvvsCKGU74e79+htx6XU1JTiQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.006777, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Oct 6, 2023 at 6:14=E2=80=AFPM Alexander Potapenko wrote: > > On Wed, Sep 13, 2023 at 7:15=E2=80=AFPM wrot= e: > > > > From: Andrey Konovalov > > > > Simplify comments accompanying the use of atomic accesses in the > > stack depot code. > > > > Also drop smp_load_acquire from next_pool_required in depot_init_pool, > > as both depot_init_pool and the all smp_store_release's to this variabl= e > > are executed under the stack depot lock. Maybe add this to the comment before "if (!next_pool_required)" ?