From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBB88E95A91 for ; Mon, 9 Oct 2023 10:10:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 493198D0048; Mon, 9 Oct 2023 06:10:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 41BDA8D0031; Mon, 9 Oct 2023 06:10:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 331598D0048; Mon, 9 Oct 2023 06:10:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 24EE48D0031 for ; Mon, 9 Oct 2023 06:10:33 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id EFBE51CA5C6 for ; Mon, 9 Oct 2023 10:10:32 +0000 (UTC) X-FDA: 81325503504.05.EF75DC1 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by imf21.hostedemail.com (Postfix) with ESMTP id 140581C0020 for ; Mon, 9 Oct 2023 10:10:30 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gk7xOuq7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of glider@google.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696846231; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pKAlUAosFjrafJFjKgxhfBSe7ZC79o6SyWOfRs4IFUY=; b=JqQISThJUILXPmI3Rm4AptnfB6qEai+5MStJg/zjABoJzz9VNSPP+TSg6nO9tk/2DTIVLf kDnhOyMh38YEQE7JrB9MtjyIpa6A193/3HyU0h/hgdJBTnSA+PZcl4dIrF8ui+wjm+P769 UqiInVvCUB4i1sFrscLWEGvesxWKFIg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gk7xOuq7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of glider@google.com designates 209.85.219.46 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696846231; a=rsa-sha256; cv=none; b=8oLNM5tFZRCq1kfKa0A7M/TLW8Nze6/powXvqQmKR0kZgJiiJHZqWmuWljk5q7NceZX6G3 8YThWVPiVVv6N/QxDcMTqx3DvQltsyYPMySN+tUBg0M7Avvs/wVW31j7ODoZKmq3L2Hfa0 M+HqkdrEA8xA48PER+2Ywn/Cm2gzRrc= Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-65af75a0209so22920406d6.3 for ; Mon, 09 Oct 2023 03:10:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696846230; x=1697451030; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pKAlUAosFjrafJFjKgxhfBSe7ZC79o6SyWOfRs4IFUY=; b=gk7xOuq784kXCekiP46wnId6fBGp8I/mewdBo8jOpatOkGqSrnnpea7gg9zG3YInGN gIBDybr085hRAUFto4SOwkV+EAYlE1EUx8nXiF1DyTqn3LIAtad2AuVDo2NRj9qwALyd +o0RwJ9zHOT4RC2rTy9Q6N/F6FifV0lqvgqt4WIEPGymQT3TjGBXRCCIfRsz/wYsUBxb 4CHiKA+3xIso7Wj2JviMCh2ugKNK9HncdFz4eOFXs4WvvRL+5R+D3LvFtkbRZBhvCXdg vWhNd7i0DanzyUrMNOLtjLVCRlpPLV1aoKyLgk+RdsnLjjXvBQTRAi4Sepm+YaNf4P3L MoLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696846230; x=1697451030; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pKAlUAosFjrafJFjKgxhfBSe7ZC79o6SyWOfRs4IFUY=; b=ZhGmJkRF8DvEWC5zdLxNSnmE9XwIISXCdxLla1bErcZhbaRm8qUXWGPSTekKHYRwhF Hz0ljUF9Vhv5ofF29tHapWSgwm5K3fIy83DmLd9qk6OieI3ZjzaoIQOzNnHMUa5PFJDd qD40uj38mPPgOGm1UUaW6MzRigQgekGxqltgIgUVTQ99xKGpwOwnQVXyH9/mtrcxVhEv t3+VVFqD9o8Dgj15gfUmIV73iEGU5i5mhdBVAcoBSRtsTF3p7GSYS3EznQ/ctRrRwmdM 9/8b3ANFnnCGBf9XOYLUBr7UQ5nqMx7zFRkf6baBEWrRlZ9Y1s8bBbMw5k1pbgno4rph JXlA== X-Gm-Message-State: AOJu0YzQw01q/V8NtY7AGFMMrrVVg2rGgY/8eTGLuNvBDwsdZsyqJscT V5S89pbZtiHbtprBS443FOKQMOvals55+DFMub5bdg== X-Google-Smtp-Source: AGHT+IHzCKfbb+v+9IMIyj2N0ism/FX43FExAaYXjJyBBHMoi2uYhQ+vjSvgkSAqiwGlDlVqe38vGbp02bC590c3wg0= X-Received: by 2002:a05:6214:301b:b0:65b:1594:264e with SMTP id ke27-20020a056214301b00b0065b1594264emr15604865qvb.51.1696846230114; Mon, 09 Oct 2023 03:10:30 -0700 (PDT) MIME-Version: 1.0 References: <2a161c99c47a45f8e9f7a21a732c60f0cd674a66.1694625260.git.andreyknvl@google.com> In-Reply-To: <2a161c99c47a45f8e9f7a21a732c60f0cd674a66.1694625260.git.andreyknvl@google.com> From: Alexander Potapenko Date: Mon, 9 Oct 2023 12:09:54 +0200 Message-ID: Subject: Re: [PATCH v2 14/19] lib/stackdepot, kasan: add flags to __stack_depot_save and rename To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 140581C0020 X-Stat-Signature: dfp6pjzumj61any1n1zkbau3noa96j79 X-Rspam-User: X-HE-Tag: 1696846230-679869 X-HE-Meta: U2FsdGVkX1/jed/ezzMrJ0PsMLGGwAZYw+WjyhtNf+xdiFmBIXKoqn5Do5pNfAsUW3TLEGsXEYLT8VUSEgnWvgCnQp633rUZxd2KsWN33TgZ2Z9oo3vxUyPsSss3APb4F9MOU81T1Ed12ZKOF6yIgARhi7r6o1nNLdfalQ1R6Fp5ceMBzrqPHS/qaPhBALT9tvMEjFz+CfpB4fJUelaPL6Ktcu+aXj6KA4Qo79kYdZk9+Dj7qkRUfghMHeAws5Qsl1Ce4iOW+bQPCgKH4ExcQ2NN4Z3s95bwnaocEzsbxmgyVF5NRXBqR+YQKiUEacQyKyAMAOFGin1LDy9RnY8tjEQcArDRzkPqE5CR3cFl8v2t+qw23UXQSWPIAKahLItQqVTA4PlKbtBxOlPhLYZFXgwbpwTHUP6Hnimmy5N797Rkf9Kjl3Po38frxkUYlfHmvm3pc85kwKIotwDC5c86wQPHx4xHEYupqjLTkGAfjiebbNJjWb+ZehtaiqMloctCk6RALo5VVja5eyGIYEQao1ZXGufg3pZYxfad//kgofbkE/P5R4Njz9y22+NdBlrqFwAJN8NcsszhACFDR5xEY7FdpMBP0QZtc7O4tv47Bm2d28il2DCX1kufoBDr14LC22LpAaNyWtT8FD4OHIeUQ93HBvB03RMNveRZ6+CvaOGwg1ck3dhhGPyHwV2nv83vYBfmjzgldahtUwEMJmSlI1AROcfVbcpU1VjOYv0VUQqnfS8hl6z+kwoht9iHw//WazlgnMBxCI2xX8DsehIyYdW2pc6QSjq+Yj+NU/5iZwfRxFOK81Kume34ab+LAOm5y/nZk1AAyYGzJPXVe8Dmha/cwANChPs8aFr/rfpnY62FrnaJa6Prc4Vju63D5llut/BWtdeo1KbeQbnbnClelr1nmiW+77GBwXznectsE0+N+PnLbUEYmoaSa+Iv64ZbxUQvXgZ3LHlnPhlbaos ppl1NsSd TYetQLoZRB/NEzFIV2kpIR9mNHyQHmhKhNhwDbG5tXLV2JG/Crqun05753jHKMnD7bJvx3LnkZ1WsUrC2U6CQZZLEGEK974ZD6In+nrBxdFbM+sk1asqDBMd8gucWbqbyv4mD7z3+Se94TvULWq8rMNOMjxW4wTq1xR9GRbnUSgUlwtSAKVYa2MBT1vQGYG+RhvgF0eLNCQKRH+Otvq7hwMeODYFGi57e8wOnts1GCkL6Woo8XwjF0Do4jtKH1ZB/gEgLl1P8n/XQrSHcGBpe95xwmFgKugN1G3CpCcbQkw1r0JZJ2VuthkZiKZzx+MLOOJqvYmZexIQq9Zc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Sep 13, 2023 at 7:17=E2=80=AFPM wrote: > > From: Andrey Konovalov > > Change the bool can_alloc argument of __stack_depot_save to a > u32 argument that accepts a set of flags. > > The following patch will add another flag to stack_depot_save_flags > besides the existing STACK_DEPOT_FLAG_CAN_ALLOC. > > Also rename the function to stack_depot_save_flags, as __stack_depot_save > is a cryptic name, > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko (assuming you'll address Marco's comment) ... > void kasan_record_aux_stack_noalloc(void *addr) > { > - return __kasan_record_aux_stack(addr, false); > + return __kasan_record_aux_stack(addr, 0); Maybe make the intent to not allocate more explicit by declaring some STACK_DEPOT_FLAG_CAN_NOT_ALLOC =3D 0? (Leaving this up to you)