From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E34EC38142 for ; Tue, 31 Jan 2023 11:34:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 237656B0072; Tue, 31 Jan 2023 06:34:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E7DF6B0073; Tue, 31 Jan 2023 06:34:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AFAA6B0074; Tue, 31 Jan 2023 06:34:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id EF4D06B0072 for ; Tue, 31 Jan 2023 06:34:11 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B7858A050C for ; Tue, 31 Jan 2023 11:34:11 +0000 (UTC) X-FDA: 80414885502.28.3567D0B Received: from mail-vs1-f50.google.com (mail-vs1-f50.google.com [209.85.217.50]) by imf12.hostedemail.com (Postfix) with ESMTP id F03B640009 for ; Tue, 31 Jan 2023 11:34:08 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Hu3jY71l; spf=pass (imf12.hostedemail.com: domain of glider@google.com designates 209.85.217.50 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675164849; a=rsa-sha256; cv=none; b=ZpFBVNj2GHoqxugRv/tNkYCywPskzkpVS5vSUGJ/htQO8N+NsF8rHKmgTJ3ig5XI4Iyo2m Z8AnYRRuzjIAdDi1almYu7GCKjZ85lbGxnD7w4JL6nOd9R4xkvQC3xOkIMoHWHOv8g4Hei isKAJqp9QKjyvg2QrwK7gyKoyQ1/IpI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Hu3jY71l; spf=pass (imf12.hostedemail.com: domain of glider@google.com designates 209.85.217.50 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675164849; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i8eUarQKx4zlWnr8p6102+JRBW/gc9YxRunt0DbrPaA=; b=xGFUpTsgiQO96UrTEgFqUpv8NPAWeP/MKxgtjPSiHerYxmc77Gyj1QN6xYnuotVMv2PwrP 6A+9UFj0P7s5bp09s4oeHhVQE3oXJxXn4NlWwYIV83s2LY2ljGVFyV4AYnfnP3+iasRp60 aQGCuwXh6AudYvBcoUavS+YcuMupHys= Received: by mail-vs1-f50.google.com with SMTP id h19so13938528vsv.13 for ; Tue, 31 Jan 2023 03:34:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=i8eUarQKx4zlWnr8p6102+JRBW/gc9YxRunt0DbrPaA=; b=Hu3jY71lNtAtQxbsDMTMKp2xklIgIO3mPHIJ79EvZmZNNyhd1TYzer4rk+msSCIaZi 6BpkIKPeadpYBXTEv3kKK7PtmeQJEngDwb9+OwDKiTrseJp3XtJMuiPWQl70kLvu0WJG y6Fs3pCfGfTPPpJ4VgOTzowNbiD+qYeJ0mD29iB+t8Cvdx3bnW5lBq5bDQridA6KALXA HhIsQWPGYUwIxY47pyV6JcDoSFdSIG3M2+cglWIGXCLY5s2yTTkXH5A5NwcXG95DNtPr /xEvmkqqTB8ICwRhrlWcpW6lwqL6G4NmHvOx1sHXbObgz50sSPsLpMG4J51F/sPAl/Vf LilQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i8eUarQKx4zlWnr8p6102+JRBW/gc9YxRunt0DbrPaA=; b=QrzYV3AYg8srcWCFDh09lxHiDABL/NpffIlhinA75PERZwTa42eyzycp9x81Eo80l9 cq53K0jjfBgQMr4axIbShVJDGA0krDvwrf9wCQSmn7+b2lGtSzJIC6Jp9gqGoB8xBs74 KcAMC9StnJ2SrRPW31E6faJqUQtj+H1T+3U/rF7AX6DNsa6fbLUWJ/PEY1IcJjc8LagH pGrmt3rrL489/LeVgpP3l8Iq+1rkxuH1AWBwp5LPjF0hWhgqM0y9XWVRduSFm3H/KOmZ pbhusG5Ck3tk9TRBfisDzngheAGGSRoxZbLmAjnDJa2xgSShwaXdfGlynVA97kTAQttT KXtA== X-Gm-Message-State: AFqh2kpey6DYfLDAAAaQaDGZNSN8qzbobWVhxcY6uZIBRLcnFwP6doQB +SUd5bSLFF5vZ2tOH8e24+aNklK7jfEVnUEDawC16A== X-Google-Smtp-Source: AMrXdXs7gAgf42FKDCJFRrDo6We9zx/CBIN3LvglGtvy3VnkIDYcWFMb/mBbqvaR0o2rHVBOl7Lgw1BwcMrz543P2iw= X-Received: by 2002:a67:ec91:0:b0:3d0:a896:51da with SMTP id h17-20020a67ec91000000b003d0a89651damr7123043vsp.44.1675164847883; Tue, 31 Jan 2023 03:34:07 -0800 (PST) MIME-Version: 1.0 References: <5456286e2c9f3cd5abf25ad2e7e60dc997c71f66.1675111415.git.andreyknvl@google.com> In-Reply-To: <5456286e2c9f3cd5abf25ad2e7e60dc997c71f66.1675111415.git.andreyknvl@google.com> From: Alexander Potapenko Date: Tue, 31 Jan 2023 12:33:31 +0100 Message-ID: Subject: Re: [PATCH 09/18] lib/stackdepot: rename hash table constants and variables To: andrey.konovalov@linux.dev Cc: Marco Elver , Andrey Konovalov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: F03B640009 X-Rspamd-Server: rspam01 X-Stat-Signature: n5hpgr3n5ep7xdsnep3sx9x5co78zhcu X-HE-Tag: 1675164848-984593 X-HE-Meta: U2FsdGVkX18+kt53GX49Q48doIUeFJMwsS5i2MlHr5o5C3uExPeKbO7PfD4B9WGldHnx1/hVK4uXuuIjePD4iRMGex3xbHF9Jn+evTO37CU2CQdQJYBaMOE+RCueUHyFgWFsMMt6F800cFLG0tAk+1lV1mJ6LI/fE2w1EQo4+BkRl8mD2qBxWyb5tWgbj1UyWZbQR3hBoaf8bOQwPQHAdRnR+fvRxDtdNYxmIaJ6xMmWXfAYfirpb8O/SH4BmMM3dO4z9GKbjZ/eOERPcVokZ47X5mlxcFGzUMXCk6x2+l2xQthk+44Ojy1ihsDVM+cwBonfVZCrL3YbiGvnnHAkUB3YpQ/eSlPxfTlfejhDDyl2yS0fRf1SV0IJ58Lv5MszzrpdTmtamk2RaAjq0Ab8LEBlbTPrccFCQr8TR/dBGwka8Az8TPlJKV7Vi+k1uLS8OFR+VBr12pTqWKQ1Zp9dmto4O7KvufPzy8ZYQrD2D+kUxt0u3peSE+VZlSAoRIoqp0leOJtP91IC0ibcBwqvbw6SoLqUvjN9PxHIj1nZA8X5EvoiVbkQ6uoAPzSlPWVwWyN8ykBUKCZMy831rhi8mIyE387+tBntGKHnl3prix4hMC+neKgJx8caVCrJkS8h/er4XmUOl94x7AYMCHvu/YkgloPxxV2bJsaYuc/EBOksaBiJDxjXTwMYnaOnv/QDEoGp0sTxhC3+R9mSijUCblNbI038haerBQdrulq57e+qVKSV+r1TM1AUDnSrNU7D133Yb6u04CxAkgh3jH9jBXQoOrJPsQlImoK80Z9JPKuLt4tXnH4JrGeBx03/SxnQg48d8Nd55wqA0VQxAzab5h3IbyVFvWK34FASZoN0VfjmegOgC5xvgpPLfKR7DYHK+cHdpTN03Ewh0W+LkhkArkbQxX+beI36SkpP67D4YFeV8Tiw/VhxlkcUf6Kt7iQ1xVKPaOBItPUEj6ti5/5 inK0lNTC LyRY2AhjayeRZodP0Zv3By+AEXMPl2KBFfhyZ2zoXHAQUaVizWQHaofG3YP9syQ8hBSAMucbJeq3NhgQ6RSgyjJcBR0IeMCSTMULvf56VZ9YOGD1x/RniAMINwAbOBVpgxA61f7/pXXA+3ewQvo+UP8xCy4UxaZ8Cema8qaBU+vowp8Hz6B9unB0MvNeDJ2OdNPmFk0t39F+YhQ/BIx/8J24ihhmH93Gbf3PSCjlFVQpfhCd2/3KXeEVVKPJD/AKbX8jE0sUugNrxp3b6PyxUGj0x5t8yGl7p5e84rE+33QbgR8Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 9:50 PM wrote: > > From: Andrey Konovalov > > Give more meaningful names to hash table-related constants and variables: > > 1. Rename STACK_HASH_SCALE to STACK_TABLE_SCALE to point out that it is > related to scaling the hash table. It's only used twice, and in short lines, maybe make it STACK_HASH_TABLE_SCALE to point that out? :) > 2. Rename STACK_HASH_ORDER_MIN/MAX to STACK_BUCKET_NUMBER_ORDER_MIN/MAX > to point out that it is related to the number of hash table buckets. How about DEPOT_BUCKET_... or STACKDEPOT_BUCKET_...? (just bikeshedding, I don't have any strong preference). > 3. Rename stack_hash_order to stack_bucket_number_order for the same > reason as #2. > > No functional changes. > > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko