From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49964C47071 for ; Thu, 16 Nov 2023 09:05:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D24CC6B0291; Thu, 16 Nov 2023 04:05:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD55A6B029A; Thu, 16 Nov 2023 04:05:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9DB16B029C; Thu, 16 Nov 2023 04:05:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A6A6C6B0291 for ; Thu, 16 Nov 2023 04:05:53 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 82BD3C0BF3 for ; Thu, 16 Nov 2023 09:05:53 +0000 (UTC) X-FDA: 81463234986.03.484825A Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf22.hostedemail.com (Postfix) with ESMTP id C27A8C0009 for ; Thu, 16 Nov 2023 09:05:51 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qM0mkjcD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of glider@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700125551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CJvcy5OQThQMBzLC/CmhcyXSfL+uAyptQQ2e5phxAM4=; b=blGZXXDSfsLUusIBwhqt8qwi421jqz+3MIUe2WO/gTzTx4OlvC0giORcY865DuePG76zkX SvFo/sfkNX3SlXX7pE7AUAEZMEPhkC3oK0h56ks8eNB58D7ZdEH8EyW/z7HFc1Di3CoTOQ WUJVo42BSKcPphQdrgoBuKloTI0VhRE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=qM0mkjcD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf22.hostedemail.com: domain of glider@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700125551; a=rsa-sha256; cv=none; b=bjX/fs/XBjMBhqsjF+yxlhNbMOehqOfkP7cGDkreDeVnY/AgZP6fNE1iUk/iQJPgwBvNix +2DQ5y3YrD+FwTGW+5Qgs1vgs96BYP5kvYskVdRsesMTY53OED3Rp9O39Xn6ZPLnRWnIl+ ZDBhCRpmsZCrnFUszzU2OktRL9Yr4M4= Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-5a7eef0b931so6075097b3.0 for ; Thu, 16 Nov 2023 01:05:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700125551; x=1700730351; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=CJvcy5OQThQMBzLC/CmhcyXSfL+uAyptQQ2e5phxAM4=; b=qM0mkjcDgjjNe4t3MSt4wDAM9Q4TS5EokxSfeQ83DRtl+/dC7UwnKk0A22Qgj54cuq MsMQQyQ5TH8k4HtGNjlNFpj+XhQfpcUwQ6+TOUR04QCy2AgloFJgbdoJNMoty2uH7s3c oW0Am7HFVlge+WfmzXfzb48HqjsKMN6Q6at2ZaCbjBQriejipa9rolwvqPIJVSs/ByaA Csk3wB0fCALOuOPR3edII8qMc0A+SQzu9QhX/BM/2FS6qlZDSd6+IEbnu+iEM//WFQgo 6rnAZpaarsm22KBUCpmHTOkocaSJ3AS20kVa+Fua496o4g+sKLu5e6koasAnE74EJg9U 8WTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700125551; x=1700730351; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CJvcy5OQThQMBzLC/CmhcyXSfL+uAyptQQ2e5phxAM4=; b=HIhPk9CKubCCNeT+wndo03zydAFNogfXKgQXrlG74XhjvANQNS3KF0n93vPI///s3i 1uAqLJJVk1wirxplLzupULNXo6utzY1Kemzk3AYh7HmXnveLi+pdBOiMxE0Kxnh8j/l+ i5Fv4Qbo88QdVBkAiXxeCew65SbY/fKQfE3qNT9zYC/RkxU1tDBVYLd3WJQB5B/jW8T4 WZbZnhJFciKzlI/fuGtwRY6pp4GUY/l7MPaXg1+96122gcZTYjfI89+tK5un72+MQs9s EIverTom3DQCv5Bppym6Zo/wldYMs+kOz950S5KJiQRoJJXK8iXAgdyt1yvQRW8Dcd59 CI1Q== X-Gm-Message-State: AOJu0YyaRHUA+nLPsKKt6Fe/nQ5fyJSg6vaaclfdicNytir9C57yu5WM BF0Mrgj3X/xDWWBGlTOGKsU9x42E+QMu8Bzy+rZDxQ== X-Google-Smtp-Source: AGHT+IGJR4QLM16FKTPZT3Tz/J1QFBPNhj+bwePlZEFgi7iCb5pKMX+w3+XgoMz2yIXIyLcBCWd/7G270rmy6YIVNjQ= X-Received: by 2002:a81:8a41:0:b0:5a8:3f0a:618e with SMTP id a62-20020a818a41000000b005a83f0a618emr16007472ywg.37.1700125550745; Thu, 16 Nov 2023 01:05:50 -0800 (PST) MIME-Version: 1.0 References: <20231115203401.2495875-1-iii@linux.ibm.com> <20231115203401.2495875-31-iii@linux.ibm.com> In-Reply-To: From: Alexander Potapenko Date: Thu, 16 Nov 2023 10:05:14 +0100 Message-ID: Subject: Re: [PATCH 30/32] s390/unwind: Disable KMSAN checks To: Ilya Leoshkevich Cc: Alexander Gordeev , Andrew Morton , Christoph Lameter , David Rientjes , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C27A8C0009 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: mcz5yqazmgj93it9ndrprdna5mrehxp4 X-HE-Tag: 1700125551-613113 X-HE-Meta: U2FsdGVkX1/3mny87BvZ/gKRM7eBPvwiGaNXnk6TJAxbroMTV5ko0W9utpjwrrKj6+QR/i34xjaEKkvs0JY01z7dZZxPvBdYwo2c4HDBjXNb9UEKxbsuIVlA9j64osNp5MiqWWJa5Z2+dwpkbvMqKigWA64PvF510VT/k527kMtrpRj3G8MqrlRQopLbtv1jqgoV0yxYPa4iinhUddqznp7/PBX7ek6jmZ7G9HCl01z1Fsd9OKiugXYtP4XkDodQK0DoGCIwiPO2CzCBWoOSGyJl1Um3Mz7Pe2oi/IwEYEmZJ5wc69YAwpmmRk8WxF+6fQDN5DY+tkIRo8JYxWnSUqje5Sp3kPEPWiTAg403t3vTuh2FuL+B4o3K3NWxGSPo2JpCeppiHuoPaIMiuTtYzDWBq4h74eV/b9C/PdcvKVOw61iDZ0cl7fmbU/xHkAvckzC4wNWoz9TiOjUmveMEz324lNHfcUqVjt3DTHRu4Zh3594f1kYTgN/E44bPiuamdLzIFxuOcslH8a07KeAOOdYGYzFthcrfNxUFmBDpwwcaPBGMMBVbXzaf+HWa9Y87wXwgveaH6T8jh5GGHfgXR6bWFUfF7QyBlqzk8GqdKyFCtYu0kDnnugyPBv7RwEQBokZbQvZhEyrUCZfnPLk6+aYuYN14rRAh1O2Mape7vOcJTGx3lBm8XMwTkaKLei4P3OS7yjw3SVpDv3gzoFp0PmbyvXQ8kMXvQc0mGK7lMPDIlwDCxoFkgxuZLSV8cNJqsAwCy4tVYBJCuT7Tj+0Fs/2XlSnn4b2q9QL9eb9ZoP67g2tnXJY8F/JvYagkSv7DMQjiWmOrwdgB36BydU4WbQ9QqDZN+x3vuBsE06KB/N8DNQuDIqS4WPe8NMEpsqejtdxL4NHJTeHZjV1SYb6o3wC6zFcfDlCFZXBlip7VMCfdcgIDihuuxSmvZi/nE0I82w+I2RKYZNpfWXaytru 0sxHq2B+ AfnZpD6ilVujXUXhmlPlOLt75qKnA84mDNgA/p2Ui2GUJoysYRWLYqaRPfStXAAlIikzqU+WNvb1UMypQ/sDXYYhg7gSfadPVkb2ts2++Wt36Q1uZU8jfn+AFhkW80qcPb0xKG1X02UDxl3W8eaIkXV+PVDT/IIO5eIph9hEHkMWNmwKoVxXQ4VN3KZYrQD6GYGdjpNHZvrK9nnKNQ2mFm4VvXzcjs0mFc+n+UZsMApIiCvhOWvix3l30XXYUcwfB4u7l6TZORJpr2eC2LBUNLf2pkkh8gOK9iEzLFeUarFejtIwIzpAxshFbPt9WRXynHpBExaTKzKsrmucgwOmT8DgSeb6ulKa+lYpj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000193, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 16, 2023 at 10:04=E2=80=AFAM Alexander Potapenko wrote: > > On Wed, Nov 15, 2023 at 9:35=E2=80=AFPM Ilya Leoshkevich wrote: > > > > The unwind code can read uninitialized frames. Furthermore, even in > > the good case, KMSAN does not emit shadow for backchains. Therefore > > disable it for the unwinding functions. > > > > Signed-off-by: Ilya Leoshkevich > > --- > > arch/s390/kernel/unwind_bc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/s390/kernel/unwind_bc.c b/arch/s390/kernel/unwind_bc.= c > > index 0ece156fdd7c..7ecaab24783f 100644 > > --- a/arch/s390/kernel/unwind_bc.c > > +++ b/arch/s390/kernel/unwind_bc.c > > @@ -49,6 +49,7 @@ static inline bool is_final_pt_regs(struct unwind_sta= te *state, > > READ_ONCE_NOCHECK(regs->psw.mask) & PSW_MASK_PSTATE; > > } > > > > +__no_kmsan_checks > > Please add some comments to the source file to back this annotation, > so that the intent is not lost in git history. Apart from that, Reviewed-by: Alexander Potapenko --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg