From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37510C5519F for ; Wed, 18 Nov 2020 16:08:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 59A98247CB for ; Wed, 18 Nov 2020 16:08:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Ga/ygbCV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59A98247CB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 67F626B007D; Wed, 18 Nov 2020 11:08:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E0826B007E; Wed, 18 Nov 2020 11:08:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 480F36B0080; Wed, 18 Nov 2020 11:08:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 16E0F6B007D for ; Wed, 18 Nov 2020 11:08:01 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id AC300180AD83A for ; Wed, 18 Nov 2020 16:08:00 +0000 (UTC) X-FDA: 77498020320.05.ocean12_000153e2733b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 904E5180269F5 for ; Wed, 18 Nov 2020 16:08:00 +0000 (UTC) X-HE-Tag: ocean12_000153e2733b X-Filterd-Recvd-Size: 5197 Received: from mail-qv1-f68.google.com (mail-qv1-f68.google.com [209.85.219.68]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Nov 2020 16:07:58 +0000 (UTC) Received: by mail-qv1-f68.google.com with SMTP id b11so1247659qvr.9 for ; Wed, 18 Nov 2020 08:07:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ikA7PYEQ/L2cKfevJds4p4NjydPxn3K6IT3FVnbYGLo=; b=Ga/ygbCVw0SJLI6Sg1BiEo9a8aJcvDsfyOV6zv//+nmL8wUHPjIgTaZ/XXtUrQ9+Vi 0ffXudpc5ulLW+lwF+Jmkk/Gx3u73hALEFcCPRqp+P81LRFZD9lH19U6aqkMKKHfLGBk KeiSiz3xMTfElx0KVlj1tKlk5d1nYhc1IsGwQIymI7lRn1R5BA6fXQiMNA+rl1OOsSol JoeD/ieNbCmL2i1jbpj0rRQlqEh1laM4/OWKSrTcx1ptdhFEkcHqFefSH2c4YkTJHu+5 A8KfLpOi3FjwQwz5DKUNOum4/mkUkKH2PTRIE5TOk1xJHkp6MVCBvs9+RI+lyMMvwMbB xe4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ikA7PYEQ/L2cKfevJds4p4NjydPxn3K6IT3FVnbYGLo=; b=eI6w2ADkV1Iya+JXXT4a8qvbaHgmTouaBSDC+ofuY2BBv/Z769BKTWvqlw8y/Ag9vo zsdefnv+12yGRVVIVKqxLlgRsJF0sFWJ1A3kLSpevLRjXBeAycnubXQSzc3Kc30xGfBj p1OxuI9IWDpt/6tN1/y7mIl7n8zAWdZFfxoxVznUyGOmNe89mD0Zat9yp3w45FnQfY+A kUPJ08NHTSV1iuye/tyzK9OkFABWN3qXWJvFD4DJA/pqoujYkqdtQmwEBu0E6cxUND5s 4g2kCzMyTB5Mtdm3MhilTdrwnPIYoxjaI+VdfPhAFScfi74dIb/oz4UW74thhmKZptew cTdg== X-Gm-Message-State: AOAM530N1Hes2auCb7ziCMMq6C6KR2h0AtraOKTlW07IgTDAgCJsgwaH u8am7HGsHjcpNX9VZXzoZN4sZKpsIjSZK88KkiGg7w== X-Google-Smtp-Source: ABdhPJxtPz7dsC8P6DpwOkE46r+tPF2sdUMjx4umzCMfj/BErLsoh6ihlvSNw5ny9XLN+fyz+HOqFNic9Cpv573jq6g= X-Received: by 2002:a0c:9e53:: with SMTP id z19mr5497551qve.23.1605715677182; Wed, 18 Nov 2020 08:07:57 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Alexander Potapenko Date: Wed, 18 Nov 2020 17:07:45 +0100 Message-ID: Subject: Re: [PATCH mm v10 31/42] kasan, mm: untag page address in free_reserved_area To: Andrey Konovalov Cc: Andrew Morton , Catalin Marinas , Will Deacon , Vincenzo Frascino , Dmitry Vyukov , Andrey Ryabinin , Marco Elver , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 13, 2020 at 11:17 PM Andrey Konovalov w= rote: > > From: Vincenzo Frascino > > free_reserved_area() memsets the pages belonging to a given memory area. > As that memory hasn't been allocated via page_alloc, the KASAN tags that > those pages have are 0x00. As the result the memset might result in a tag > mismatch. > > Untag the address to avoid spurious faults. > > Cc: Andrew Morton > Signed-off-by: Vincenzo Frascino > Signed-off-by: Andrey Konovalov Reviewed-by: Alexander Potapenko > --- > Change-Id: If12b4944383575b8bbd7d971decbd7f04be6748b > --- > mm/page_alloc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 855627e52f81..4a69fef13ac7 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -7653,6 +7653,11 @@ unsigned long free_reserved_area(void *start, void= *end, int poison, const char > * alias for the memset(). > */ > direct_map_addr =3D page_address(page); > + /* > + * Perform a kasan-unchecked memset() since this memory > + * has not been initialized. > + */ > + direct_map_addr =3D kasan_reset_tag(direct_map_addr); > if ((unsigned int)poison <=3D 0xFF) > memset(direct_map_addr, poison, PAGE_SIZE); > > -- > 2.29.2.299.gdc1121823c-goog > --=20 Alexander Potapenko Software Engineer Google Germany GmbH Erika-Mann-Stra=C3=9Fe, 33 80636 M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Paul Manicle, Halimah DeLaine Prado Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg