From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFD22C6FA8E for ; Thu, 2 Mar 2023 14:49:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 892836B0075; Thu, 2 Mar 2023 09:49:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 840026B0078; Thu, 2 Mar 2023 09:49:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7080D6B007B; Thu, 2 Mar 2023 09:49:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 61CC46B0075 for ; Thu, 2 Mar 2023 09:49:08 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 357E7120B7D for ; Thu, 2 Mar 2023 14:49:08 +0000 (UTC) X-FDA: 80524240776.28.F144919 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf22.hostedemail.com (Postfix) with ESMTP id 5C00DC0013 for ; Thu, 2 Mar 2023 14:49:06 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=of2jhdzO; spf=pass (imf22.hostedemail.com: domain of glider@google.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677768546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2l3NQJUTH3/qN89xY5bS6AJLfJmHgspkf61yJ8LdA9c=; b=Y6XQ3Lxv2RwXToC/Dj2Ny7OmmDwXulpdLv7wVzczUFJnFpWN2CBUAvVbVOHs7SN5+Dl2MX IqbAMxGIYH1RtUJ6r2t9WGtRpIQeT/3HY8f7tOO5UpjbzOCu/Mv5lCVNLbCG0Br301FCGi BrjiB/bix4j4dWWztvyynzRIZdqsMMg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=of2jhdzO; spf=pass (imf22.hostedemail.com: domain of glider@google.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677768546; a=rsa-sha256; cv=none; b=1ZP+quFjPG9st7GKivSU9n0p0CzaZiLLuZi9Vud/nbZkHCPfFR6TJJeTkmj1Wn9LlZID4W OhJMRqIW9Gs7p7RXMQO0eWuTlTDqnhlhvULVKEn/YOxKw3p1FmrkUAkM05RZr8Fx3BNbTF S2A+c10b6ytJEGyPuOU8kAJjnJOo0W0= Received: by mail-io1-f54.google.com with SMTP id g6so6801532iov.13 for ; Thu, 02 Mar 2023 06:49:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2l3NQJUTH3/qN89xY5bS6AJLfJmHgspkf61yJ8LdA9c=; b=of2jhdzOcdjd7DQ6Tq21PylhQsmdLVKDDUtwGRfyti5a2grEHicj+B5+0rN5PDc5/Y LBw6tRMCjLlZ5ez7ZKnYjla+ELS9V0Ld2CEgNGmgaR4w82Kf3LXYHjPL8bJe8V5Jb/WR TRYslK1gqqOKs5Ahu4RwvElOU+k+JyqSJurGBe4/9r4Hz1kEVoU5OyT76rxrpkleI6Q8 AnA5URzhdkZmdteg3mxnzbH3at7Nyft5++/ZMwlWqGwrRbdNnODJ4rafR59Fo0sNpK7n ZZqKsJa5KxyNuAFhmiUlqdV2e4NR215YdRFfqvPmsHA/wmtFOLvHUPfCEXJ0DRYcEcVp VSzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2l3NQJUTH3/qN89xY5bS6AJLfJmHgspkf61yJ8LdA9c=; b=B+AlvCdXuIDdwBg1LSC8d1uaKZNsBKEwV6HBq8PFlR/WuCsPl70msYXFcOtCWOwVZv AMGKOTB7ut0j0Oew1962BoDn+SoJud9278EbVH26vE+Xaf2prfoPLiw3Q6Zfbb0X0Xfp aS7RHDMu2K1j+DV9dT/KjdnWPBdhVLFFseIufQeL1E/ykelmLkdU4suNNSNyUhVqe9UO vKYrXCf/v62dVs7UuP/bwn2+W2+ztroUb2DYhchX+rGFXoPR/LC7V+XZ+Mv/7/H7BCN2 ic0eRiNY/l6Uu/1Zj8dEC3hp+UI+Pc8Uef6Qd4L41dlvp79K8dlWHlsr8bzGWZRt4rg2 3agw== X-Gm-Message-State: AO0yUKVm6vTm+5fpt73OnYZaoHU0nfFTKFHocgXWmYUP4YD/8eqNP7qq ST8mqeJfZLQ2aVNreMKcj6HbHBNSdOmKVuAui1iuUw== X-Google-Smtp-Source: AK7set9vxIW4luvgv9ZCJRtoXbzkPMhY416bO+ZbNnqrH34wjctqll14EMcVeH8tsDabgrQ0nlI9q4fRKqF1GawM9zg= X-Received: by 2002:a02:940a:0:b0:3ea:f622:3c7 with SMTP id a10-20020a02940a000000b003eaf62203c7mr4693665jai.5.1677768545351; Thu, 02 Mar 2023 06:49:05 -0800 (PST) MIME-Version: 1.0 References: <20230301143933.2374658-1-glider@google.com> <20230301143933.2374658-2-glider@google.com> In-Reply-To: From: Alexander Potapenko Date: Thu, 2 Mar 2023 15:48:29 +0100 Message-ID: Subject: Re: [PATCH 2/4] kmsan: another take at fixing memcpy tests To: Marco Elver Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com, akpm@linux-foundation.org, dvyukov@google.com, nathan@kernel.org, ndesaulniers@google.com, kasan-dev@googlegroups.com Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5C00DC0013 X-Stat-Signature: 33mfr68ttefnxzipftiwshmaqrpi4kjc X-HE-Tag: 1677768546-770007 X-HE-Meta: U2FsdGVkX18TqeKPhUs4YDcO9F7rJIGLwB7qsxAr0LOP3Igs+PQid1wAgCQ+IX1UEDz/e9HDVkHco9o52aN7LncdOIwxW8G/i5FUzE8NrCL6eUMhitkCkyhvXSUFs1gHCuTVTBMLeCP/J9jCwtAjOJhNq9FDb5TEg3aq5MDi/D16u/1suBewr3twxyDyhzuxrMazUobFfrV2DP48IVZn9ioHSPbv34Sols6YmU5htMCO5NLdxCrD6Ks6d2iiVji01l43MFP2QLILHHaNLHCUTM5U15VeOVjOtn7YXLyfobahdbVEt2RWYbIfNemPY/gmAy6lP1TMkqp3c4lf8aWnrtYBktTQZO6FLe16IrSa7CAT6cfRjJDyMwsl/Ka730G0DoJOo2rAvFmIuhq9gQMqItTi90n/HF2px5yKW0zL6XmLsznk6+Fhk8btndtLBHYw0awW0dBxM9O0Bdru/IDnrhTz76BEtQpLmQ1G6zAspmowtgXKGss64BZO7gFfPJwdXF5G+z/8Mkwu+LRe8U3+wCArPTEDUg+VHV6V0RD1Fh43AGkGjr47p34/3RVxsu9ax0xxa152ZTPD11IO7U49D3dxICfqaJ45wYjP1sWbyI+t0QcN1pR9QBvwrch3Iv6K6r71/14tN8jbwBCcXcnT/duIUxBX7Fj23tP6cPjh8o51zqQdtObVnWqiiJeiMdFFuZbtoWEdtoc/dr1IMl2c6/6T6F/limp3yYF1kAxItnISmMn64j1G3+RdMi+sP9hacxRzcmj+4RIeCdbsB40onltXTliuhTuU7Dudh4oDfe5sgE/eS8VyHQ+A05z/NS4O2z73KoPSbfETCrjCkCBPtdSVKgvgvTXjq2QJU6G3zqtqYY0dycJWRJaGWcKvRbdizyGX4c7DbUgNYOqcgPDe3rR5nNeTIjb33tM6a55BitCkPcU/vhZnU97gjTYN3/BiubMGdoaSZqjEiwS71ls kuPIMOTA Ihb3AgA3I2s9C/nsJjmXms2vYp1xkzubrCd9NpRd3ok1IOS58rFiHigfSkDWh46gMy3Q+Hy91ujRtHs4jQy8RrNx8pzvvBV7qn65ubA1q9puhj1kkgnLHN6JMQESNAziY+sNCJBvsv33YwcfqZ5op06Axvwy+ojnJ0L+ewViOaPu7b6RM9YYzhXX4EDc/4PgLx06z1JqIDnPUmBx8t6/wc5PSN6ItpbHMjTttDhmAvJVlbusPbYYNIQKqyg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > +#define DO_NOT_OPTIMIZE(var) asm("" ::: "memory") > > That's just a normal "barrier()" - use that instead? Ok, will do (I still think I'd better hide it behind a macro so that we can change the implementation of DO_NOT_OPTIMIZE in the future if the compiler starts outsmarting us again. > > +/* > > + * Test case: ensure that memcpy() correctly copies initialized values. > > + */ > > +static void test_init_memcpy(struct kunit *test) > > +{ > > + EXPECTATION_NO_REPORT(expect); > > + volatile int src; > > + volatile int dst = 0; > > + > > + // Ensure DO_NOT_OPTIMIZE() does not cause extra checks. > > ^^ this comment seems redundant now, given DO_NOT_OPTIMIZE() has a > comment (it's also using //-style comment). Moved it to the test description: /* * Test case: ensure that memcpy() correctly copies initialized values. * Also serves as a regression test to ensure DO_NOT_OPTIMIZE() does not cause * extra checks. */ I think it's still relevant here.