From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99A81C54756 for ; Thu, 22 May 2025 08:19:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0ED9C6B0082; Thu, 22 May 2025 04:19:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C5D46B008A; Thu, 22 May 2025 04:19:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F1D7C6B008C; Thu, 22 May 2025 04:19:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D384B6B0082 for ; Thu, 22 May 2025 04:19:07 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 243DD120B18 for ; Thu, 22 May 2025 08:19:07 +0000 (UTC) X-FDA: 83469843534.21.5B1687F Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by imf09.hostedemail.com (Postfix) with ESMTP id 5846D140002 for ; Thu, 22 May 2025 08:19:05 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=adTDnlUW; spf=pass (imf09.hostedemail.com: domain of glider@google.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747901945; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oJTN6hV71jQUNgSy1LNPLAIveMnFUYRGpDK+06PX/VA=; b=ugU3RKwg9LxiWlPQcSV1lyDjX/tGZ578osh3eePcO0OoV4MX0Opxf/fTsTeLrAtMInqclX v4fmj8wXPj0PVMh0+idaByDTgyr1P0oIleHSTlxNyFE9DwQoqw6EillkrPS+ry/C0rRBRd QEtjB55Qi10Kp8qjNyHkRFw0sMoGhI4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747901945; a=rsa-sha256; cv=none; b=zg9EwjdxKM7adyG2pM/G5qsayAFVm1PAw4N0ACOApacCHmcXrCmfpwpapVdk5439atNmF7 QNCCLdpvAW/RHGouUELAd+pCnlPyfeoSZVj3um5+ZRYfj6pFNLxCDytCfaZyfQ3YraGofT h2Yt1SL/Y2M0STjCoxfd1v4++BEZS6Y= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=adTDnlUW; spf=pass (imf09.hostedemail.com: domain of glider@google.com designates 209.85.219.47 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qv1-f47.google.com with SMTP id 6a1803df08f44-6ecf99dd567so87336826d6.0 for ; Thu, 22 May 2025 01:19:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747901944; x=1748506744; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oJTN6hV71jQUNgSy1LNPLAIveMnFUYRGpDK+06PX/VA=; b=adTDnlUWPwh3BA0YN/f5R1O4kc3+xspc6n6ATh0PfCZsi84z803oYz2uuTAduY39b6 tco8wMo1dH5B1y5DS8Tl0rk6w99MBotVFTln0So4EZ7EsMzYOkZBZ8rNvp7/wzWg2qqo KSdH495ZyH6x8ngbbCwRFp1nnzmKm/eKUVISq1NTy3XtxdEqvvZSmA490+sthJ66A4jr GfVxOWVBjKnIjP+Xz+VFH97eJCpn9M/YK+Y4vg+rXA8KgVmpsoA/fI//jmo4vX9Yg9vU hZCckrU2e+9gDba9YbHN0m1UUIva/TdHIwhu6yj4vG7Osoa1baBfLW6TnLuIX5/xmzXc b+rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747901944; x=1748506744; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oJTN6hV71jQUNgSy1LNPLAIveMnFUYRGpDK+06PX/VA=; b=svnfoFyDlFX/M+L2bMkHVMTHKgyp1UkDBrP6b+gxvqiA7cAaLjqorvFxBElXDJP5VY JerUK5QLrfueFdBTaYN5mYzt7pFQJUgIkEX/2rtKX+E+sq8RcTfvudYc48M9hSbLdBhl t9j+/HNzHhmeJ6BBOJRsq5NukqGZhwd9Hc5+Oa/PnTBfByqkUCuBEFIbjhXS6WTQJNAu rDaPSxlEHDRdhJTyc5lGB9ASSDwSxn2hWMqZFFe4YNFmo8Zu5BufEMVC5JzThwjNsRbR +U/nx/e1FohR9Lvwq01RjF2qe/tNHgLc+fhiJjSqeA6og0Zb5yHrlc9lRuZdsZLoDH0n qKXw== X-Gm-Message-State: AOJu0Yz9fUtBUc1EHgRoTrQWHMusJ7gNpFO4O4zARmv5YS1HB0xBGSCR d2zWp16KNnLNY3fYsN1kYs0hF2kYfZNXJvVDS4BpbWk68nHZcCK2hAn2qh6dGJmeUYhEwEgVt0B 91qS9xL/k3LqWU+KeZLFBXqfoWlmGgX81Zf+i4oFK X-Gm-Gg: ASbGncs6IH5Y3mdd3KTlZTGo4xH3b8iWDN/a60ISNcZ4fykTphr5rdcxHrv9NHflntY O5wnDMF9MBuljoWWKoXcPEELr2X7kun7e/CC9ghIsh6UZJMQNNqP2mukyegTJPio0hZu5KyrBKy RMdA1kxG4AO6LdGXHJ0tX+bPEQnSP0sYCFVEV72YvuIziLctqkMK4lWPE7OSAnwh+3GN1JJuC75 Q== X-Google-Smtp-Source: AGHT+IHQHS5Z4OfCDsSLJETYOT+4adkEmE5LR6YcwjJSerg+rRFXldUX9SiNeZoXTpvEKIrHUxfsfRBmdUdLiYq7J2c= X-Received: by 2002:ad4:5f8e:0:b0:6f0:e2d4:5936 with SMTP id 6a1803df08f44-6f8b0881a22mr402532476d6.22.1747901944252; Thu, 22 May 2025 01:19:04 -0700 (PDT) MIME-Version: 1.0 References: <20250507133043.61905-1-lukas.bulwahn@redhat.com> <20250508164425.GD834338@ax162> <61db74cd-2d6c-4880-8e80-12baa338a727@app.fastmail.com> In-Reply-To: <61db74cd-2d6c-4880-8e80-12baa338a727@app.fastmail.com> From: Alexander Potapenko Date: Thu, 22 May 2025 10:18:27 +0200 X-Gm-Features: AX0GCFuwLEa7GMNWl3kzXafes8eikGOYdLyOEbupah07l52RPChxZx4Uvrgxo3o Message-ID: Subject: Re: [PATCH] Makefile.kcov: apply needed compiler option unconditionally in CFLAGS_KCOV To: Arnd Bergmann Cc: Linux Memory Management List , Andrew Morton , Nathan Chancellor , Lukas Bulwahn , Masahiro Yamada , Nicolas Schier , Andrey Konovalov , linux-kbuild@vger.kernel.org, kasan-dev@googlegroups.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn , Dmitry Vyukov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5846D140002 X-Stat-Signature: qq97dwyysgp3kjsaypzqw9bezccey731 X-Rspam-User: X-HE-Tag: 1747901945-698903 X-HE-Meta: U2FsdGVkX19fo/2RW80lmYLSpRb1fsEMauqXLM+S/Gl9CHS0W1GsO4sus4iYSsDqoEiIbY9o8h4wFtMqe3OCIZwur0SOR9Quj77em9CnvnoQZ3gwEESNkRuNGWMixBqv3dse9OS81RKzYLiS7WQrHKkQsZaeN9zzO4PutzYiG89yDm/92in4IddUhqoS/nbBFI/HKhJkVfXJRsTUNJJrZoo5q/gpwKd/fN4aetgOBTM1ErxDhICDyCq8xm0KejiEMTXwD6phY3v6sF55JjeztPZHFfj7rG5DauqP4Wc0hUo5AOi+wHIKmhlbOT3WCwfrgCt3Z9ITwTK5AZauCYZFiUdlEkbHvQp10jD/KWcJcZ/2YeAc6Nsg5xQzIT4CKrLzpMRV/AnschLVEJlTJhE6wSTfe7PKa7sAVIg3qBIyp5HokBEVwiSm7zLZp5ZhqcBQD11w0v5hOo2fpdfkVZUtRJEeB/pu6PgIf0/wgwomKGfzA1ogB9ZDFXb9a9FZB+4vRvMpoxRPUcTjVRfkvamTR/dr3RSAkcvVD3nPoJB9w/X1C+fvXTCVshOpkhZmg9XG3+XQB+PyeAvGxhoeKR3ZXyhr0v+/BrlwvPLToeo5FdAKHsnBpTgow3N+IxYB4nvPwsyjGZkZpgdrRybwadVaFoKgKSQgw7eYj0iTMaf3hzkuhhQ2yWX/sPAtjnE5rRWtkbVaxeYCeXv0uQrV51yB4qaiTeetSOEhQJmmDK/EkwM7ZB8rG9FNR4oJ1GOdIYmQZmpWQFciebPd0hltGUvHqFAhYOrSWToLBkYjxe6ZVMFZGxsP64VLLHRIUPKVpwjqmJ3qflwkXOPIOy4XDZl0SmYFHfXVuzAveE1z1VnqBxZS7ABrWhmfOacqHxCT/LjHZh2LnvMKMZuhDLiJTbSwMVPCLt8hKQqocFeRopJx5mB31yIPlstS8PApl+qCpIuClIcZF8rwe/24OIiU90B /uPcNEDD 0DsEyopz4uX8+wK10jBztsqOl1RNQA7/SSP1In8FGQH42/j72Xv2UTu84ct9COS2mpc3x4HVVY4PQnQvhPW40QzxYcN9OtWTWJeDD8vFBso9PUgbXViHiBmaHLNyRQN3i8kMw+d/B9rBs3eF+7CfYPfff12o3XAqIhOTp+lLVjEgi87jECF/eRbrxkeSYesvcWSQWoEtaJJU+oac/1C1xrojCvmtcR3xQudPTBF81ywiZWCjwvmC/DKTLkQ1s77b2yQdc91EyENBMJ3DD+HbHxs6HOHqgjJHw/ppFFHPP4VosZAtEtq403+Izw+yoawBe3wcwfcOffVeTEDQAiIVBEdSWBddQfYWuJsIAhkrSOUFDzPoDxBxm7g8QSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, May 21, 2025 at 4:11=E2=80=AFPM Arnd Bergmann wrote= : > > On Wed, May 21, 2025, at 12:02, Alexander Potapenko wrote: > > On Tue, May 20, 2025 at 4:57=E2=80=AFPM 'Dmitry Vyukov' via kasan-dev > > wrote: > >> > >> On Thu, 8 May 2025 at 18:44, Nathan Chancellor wro= te: > >> > > >> > On Wed, May 07, 2025 at 03:30:43PM +0200, Lukas Bulwahn wrote: > >> > > From: Lukas Bulwahn > >> > > > >> > > Commit 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin") remo= ves the > >> > > config CC_HAS_SANCOV_TRACE_PC, as all supported compilers include = the > >> > > compiler option '-fsanitize-coverage=3Dtrace-pc' by now. > >> > > > >> > > The commit however misses the important use of this config option = in > >> > > Makefile.kcov to add '-fsanitize-coverage=3Dtrace-pc' to CFLAGS_KC= OV. > >> > > Include the compiler option '-fsanitize-coverage=3Dtrace-pc' uncon= ditionally > >> > > to CFLAGS_KCOV, as all compilers provide that option now. > >> > > > >> > > Fixes: 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin") > >> > > Signed-off-by: Lukas Bulwahn > >> > > >> > Good catch. > >> > > >> > Reviewed-by: Nathan Chancellor > >> > >> Reviewed-by: Dmitry Vyukov > >> > >> Thanks for fixing this! > > > > @akpm, could you please take this patch at your convenience? > > I have applied it on the asm-generic tree now, as this contains > the original broken commit. Sorry for missing it earlier. Thanks!