* Re: [PATCH] Makefile.kcov: apply needed compiler option unconditionally in CFLAGS_KCOV
[not found] ` <CACT4Y+a=FLk--rrN0TQiKcQ+NjND_vnSRnwrrg1XzAYaUmKxhw@mail.gmail.com>
@ 2025-05-21 10:02 ` Alexander Potapenko
2025-05-21 14:10 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Potapenko @ 2025-05-21 10:02 UTC (permalink / raw)
To: Linux Memory Management List, Andrew Morton
Cc: Nathan Chancellor, Lukas Bulwahn, Masahiro Yamada,
Nicolas Schier, Andrey Konovalov, Arnd Bergmann, linux-kbuild,
kasan-dev, kernel-janitors, linux-kernel, Lukas Bulwahn,
Dmitry Vyukov
On Tue, May 20, 2025 at 4:57 PM 'Dmitry Vyukov' via kasan-dev
<kasan-dev@googlegroups.com> wrote:
>
> On Thu, 8 May 2025 at 18:44, Nathan Chancellor <nathan@kernel.org> wrote:
> >
> > On Wed, May 07, 2025 at 03:30:43PM +0200, Lukas Bulwahn wrote:
> > > From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> > >
> > > Commit 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin") removes the
> > > config CC_HAS_SANCOV_TRACE_PC, as all supported compilers include the
> > > compiler option '-fsanitize-coverage=trace-pc' by now.
> > >
> > > The commit however misses the important use of this config option in
> > > Makefile.kcov to add '-fsanitize-coverage=trace-pc' to CFLAGS_KCOV.
> > > Include the compiler option '-fsanitize-coverage=trace-pc' unconditionally
> > > to CFLAGS_KCOV, as all compilers provide that option now.
> > >
> > > Fixes: 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin")
> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> >
> > Good catch.
> >
> > Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>
> Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
>
> Thanks for fixing this!
@akpm, could you please take this patch at your convenience?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile.kcov: apply needed compiler option unconditionally in CFLAGS_KCOV
2025-05-21 10:02 ` [PATCH] Makefile.kcov: apply needed compiler option unconditionally in CFLAGS_KCOV Alexander Potapenko
@ 2025-05-21 14:10 ` Arnd Bergmann
2025-05-22 8:18 ` Alexander Potapenko
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2025-05-21 14:10 UTC (permalink / raw)
To: Alexander Potapenko, Linux Memory Management List, Andrew Morton
Cc: Nathan Chancellor, Lukas Bulwahn, Masahiro Yamada,
Nicolas Schier, Andrey Konovalov, linux-kbuild, kasan-dev,
kernel-janitors, linux-kernel, Lukas Bulwahn, Dmitry Vyukov
On Wed, May 21, 2025, at 12:02, Alexander Potapenko wrote:
> On Tue, May 20, 2025 at 4:57 PM 'Dmitry Vyukov' via kasan-dev
> <kasan-dev@googlegroups.com> wrote:
>>
>> On Thu, 8 May 2025 at 18:44, Nathan Chancellor <nathan@kernel.org> wrote:
>> >
>> > On Wed, May 07, 2025 at 03:30:43PM +0200, Lukas Bulwahn wrote:
>> > > From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
>> > >
>> > > Commit 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin") removes the
>> > > config CC_HAS_SANCOV_TRACE_PC, as all supported compilers include the
>> > > compiler option '-fsanitize-coverage=trace-pc' by now.
>> > >
>> > > The commit however misses the important use of this config option in
>> > > Makefile.kcov to add '-fsanitize-coverage=trace-pc' to CFLAGS_KCOV.
>> > > Include the compiler option '-fsanitize-coverage=trace-pc' unconditionally
>> > > to CFLAGS_KCOV, as all compilers provide that option now.
>> > >
>> > > Fixes: 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin")
>> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
>> >
>> > Good catch.
>> >
>> > Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>>
>> Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
>>
>> Thanks for fixing this!
>
> @akpm, could you please take this patch at your convenience?
I have applied it on the asm-generic tree now, as this contains
the original broken commit. Sorry for missing it earlier.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Makefile.kcov: apply needed compiler option unconditionally in CFLAGS_KCOV
2025-05-21 14:10 ` Arnd Bergmann
@ 2025-05-22 8:18 ` Alexander Potapenko
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Potapenko @ 2025-05-22 8:18 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linux Memory Management List, Andrew Morton, Nathan Chancellor,
Lukas Bulwahn, Masahiro Yamada, Nicolas Schier, Andrey Konovalov,
linux-kbuild, kasan-dev, kernel-janitors, linux-kernel,
Lukas Bulwahn, Dmitry Vyukov
On Wed, May 21, 2025 at 4:11 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Wed, May 21, 2025, at 12:02, Alexander Potapenko wrote:
> > On Tue, May 20, 2025 at 4:57 PM 'Dmitry Vyukov' via kasan-dev
> > <kasan-dev@googlegroups.com> wrote:
> >>
> >> On Thu, 8 May 2025 at 18:44, Nathan Chancellor <nathan@kernel.org> wrote:
> >> >
> >> > On Wed, May 07, 2025 at 03:30:43PM +0200, Lukas Bulwahn wrote:
> >> > > From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> >> > >
> >> > > Commit 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin") removes the
> >> > > config CC_HAS_SANCOV_TRACE_PC, as all supported compilers include the
> >> > > compiler option '-fsanitize-coverage=trace-pc' by now.
> >> > >
> >> > > The commit however misses the important use of this config option in
> >> > > Makefile.kcov to add '-fsanitize-coverage=trace-pc' to CFLAGS_KCOV.
> >> > > Include the compiler option '-fsanitize-coverage=trace-pc' unconditionally
> >> > > to CFLAGS_KCOV, as all compilers provide that option now.
> >> > >
> >> > > Fixes: 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin")
> >> > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
> >> >
> >> > Good catch.
> >> >
> >> > Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> >>
> >> Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
> >>
> >> Thanks for fixing this!
> >
> > @akpm, could you please take this patch at your convenience?
>
> I have applied it on the asm-generic tree now, as this contains
> the original broken commit. Sorry for missing it earlier.
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-22 8:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20250507133043.61905-1-lukas.bulwahn@redhat.com>
[not found] ` <20250508164425.GD834338@ax162>
[not found] ` <CACT4Y+a=FLk--rrN0TQiKcQ+NjND_vnSRnwrrg1XzAYaUmKxhw@mail.gmail.com>
2025-05-21 10:02 ` [PATCH] Makefile.kcov: apply needed compiler option unconditionally in CFLAGS_KCOV Alexander Potapenko
2025-05-21 14:10 ` Arnd Bergmann
2025-05-22 8:18 ` Alexander Potapenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox