From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A6DDC197A0 for ; Thu, 16 Nov 2023 08:56:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D7CC28000F; Thu, 16 Nov 2023 03:56:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 887E928000E; Thu, 16 Nov 2023 03:56:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74FDA28000F; Thu, 16 Nov 2023 03:56:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 64CDE28000E for ; Thu, 16 Nov 2023 03:56:43 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 397C61CB91C for ; Thu, 16 Nov 2023 08:56:43 +0000 (UTC) X-FDA: 81463211886.08.8E7FB59 Received: from mail-yw1-f182.google.com (mail-yw1-f182.google.com [209.85.128.182]) by imf07.hostedemail.com (Postfix) with ESMTP id 67ECC4000C for ; Thu, 16 Nov 2023 08:56:41 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EaqGKCHf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of glider@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700125001; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0H8tt9dZT0qWTNb8kikU8kJP6qFA036d+J9DtuTzo40=; b=6hNT6PwjATi7pz9/1FqAnWx0qZwNX3K/68yosNXZSypYzsyzNwlyaZv9VzXs5oFitHPuXj iZGjxsy1Gb7GGSKe1/gVxkZC1tdtzWRgLg3aT25A4FoyS7/1D+XbECLg2D96OSIOCZ3K7Y DvjurMe3aF2HCORHneJQBU/oQ71A1UM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EaqGKCHf; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf07.hostedemail.com: domain of glider@google.com designates 209.85.128.182 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700125001; a=rsa-sha256; cv=none; b=scV+ScSI7+GaaCX+nh0bFCyVdyUpT/JeAYxtJnMv80kiC0924kMNY51lx0V35HH/FYDaDm w45s+//kyC76pSqjFcrQHBvhjFbsFsN92UwOyqcK8E+jGnF/xnOiPg+ZvCkkmj6Y5cjO+0 7VUqEPYXqednMif/NyfzCtS6itOfsvo= Received: by mail-yw1-f182.google.com with SMTP id 00721157ae682-5a82c2eb50cso5679607b3.2 for ; Thu, 16 Nov 2023 00:56:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700125000; x=1700729800; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0H8tt9dZT0qWTNb8kikU8kJP6qFA036d+J9DtuTzo40=; b=EaqGKCHfhx7dvPE85r7Dd4LAB3ClAb/qikIz/Zp7Vq7HC5hRLs1InHoQ3/LB4CZIMn aTbvxTDBIvdBCQtZpaVgcSAY5+SwQmPut4wkAzOE9oO1yxQ2s3ghLVpUbj9cXGQiQ3YW v9buQfifI5QZjrhK6i8fk7l3Yh7rtaVLgMjKvQCcDyLDKEyab+KMYx+399Nj2bYpO0/Z BythaP9iAIpOXY6WRArtUn/Of1pPH07KDsiWG9c9eKsD5tPkAXDbGLpsOwN4urd25gB/ eJyuqhWOVMrXhwOVnIanUAsw8wjLFJlG7Byn3I/C38uRSURODaxUTHtDbBS94VAZNxG5 BVlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700125000; x=1700729800; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0H8tt9dZT0qWTNb8kikU8kJP6qFA036d+J9DtuTzo40=; b=uWzMGyatsKNDd6Q/DuwCz6nh2uorW0V0SI3S1hcz6lWMO2pEOZJAl+dsvQYLA86Eo5 mr179LXoz5vMeHeD2adC2Y0Zi5Gzml4FqxB6cI5YjZLFuC2pbOq5KTy4Nf1SeOJXs96K 9QQhRjI/snjoH4R66cQ1WIS1G2253flE6EBfOCADkE9qdck5cJdNiJSI1y1l2hXvGK/q 6O+nSTYF4NJprTlZE93/V92X3JBpiGEiXYtU1litBNH3DwtKtnTVxgU6Ry8hDwIfTayf +FmraB/cFc5gfJPoM/RbtwJsuc7iYTzKFeQHrNKBroZQDjpiLOir2OYqQGmApNhi0HiM lRwg== X-Gm-Message-State: AOJu0YxtRy4uvgZ8o3nL6u5uJHvE/SjyKqydPrWilU8E8faKJplDVOJk 46otu84/1qiod6g3hP32jyhGhrQeLnCuln2OIOU8OA== X-Google-Smtp-Source: AGHT+IHzzP8uN5KL7oySFlmUovw/aF4rbyrEjZrNGe1wJC40tLjll2AY1uSp3JjEkwmZJ6aR8KyKW2fBLOpcuaHXMsg= X-Received: by 2002:a25:b18e:0:b0:d9c:a3b8:f39d with SMTP id h14-20020a25b18e000000b00d9ca3b8f39dmr13846249ybj.65.1700125000447; Thu, 16 Nov 2023 00:56:40 -0800 (PST) MIME-Version: 1.0 References: <20231115203401.2495875-1-iii@linux.ibm.com> <20231115203401.2495875-13-iii@linux.ibm.com> In-Reply-To: <20231115203401.2495875-13-iii@linux.ibm.com> From: Alexander Potapenko Date: Thu, 16 Nov 2023 09:56:04 +0100 Message-ID: Subject: Re: [PATCH 12/32] kmsan: Allow disabling KMSAN checks for the current task To: Ilya Leoshkevich Cc: Alexander Gordeev , Andrew Morton , Christoph Lameter , David Rientjes , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka , Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 67ECC4000C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: rzzp6qepdwtsmkrztdat5ja84hfood3m X-HE-Tag: 1700125001-981164 X-HE-Meta: U2FsdGVkX18IuAEQ1BiZlls6KULYVQhrWZ/0nluNdi9pACdK/st5rVEJcWKZqFfH15dGSBlG1a2rGmff4wOMlbfLxY3EH+zFPnMY3IWJ8j5EhEPxGrHhJxflH8UgqzM4t4fV2APo3yNKFeDWPYbKFIwAWPThB0hmHOI6Tl8Od5juY+wLSS+nbGXik2/65eMcpA18Lo2gmYFn2Qtv/76jaBSjk7OnNMbAdUgI87y2VI5DqgcjXM5fLR/a85zcVrkGbwzU1slfbwzI7FbDOsUmRStq5te0EgJfxAdBHcJlsKExBzVe0Zf6EeNqOO/KjnJ8Mw6Ip3MTcU5sgvT2ZcbmmoU4YpxBKXYBSGnq/R6P/SRF4VwSPRwmgHGdBJT4C9srOQk/T9l1oO16AX/DJ6B/R2wvXYqqRPUr6NxG6cJuOnRjXswZmKiKYFDApudptYZwwAEVwsaYG+NGx57NItOHrMjyByXk31W4t3mWU063qe7UbysK/u7b0ixEbb87V2/NCF1cC/TPFzjfUrxHg8BEuvA6VlhVQw9GjZ7U2esE7zM24nnzQQLE4ZCQhCOuf5cicZmDO6za8m6zd8CgeZL3wndFRkE2+zLeqTxahDehTTDetGwTOJWAf41dV2QzfV1Ztd3DNBSm6hD6CrkuBYOI7oCrspEgpKD0jB+lMt4RJA9T1rjIeKR6/nmFj4cNWMEgtmlLNLrfW2YhLGzfvbCy/zTdaCy/wfM9HuSrxNT8s58mm6WH445OWEkQV04nFuMclhgWgRQo37683qZGkshoAoUVYcQBfWqt60xm5fDViaSDb5/9yF38JMBJGWYkrzLc7DQNmETEGyR8K2dHpkz1qJWKw5Ogk1iCPjHOqX1e0OSEXbl17tNMN6kouxXsb3Ar8bOBRFIne6+yEhxm4Xy6AmqTy2mH/ZJzu4smcH9zLvGzlYcOAX4rWLqxfEGWW2wj8zlxp9Z1QUX79EhHqK/ SCfV0BIL N0I1Qc3J/P/zc8fJOVCCun7HMWeZsQpYEHK9UKKAj95AIl7aabHlan82hFD1UN5RikCP9JTaqewa4BNRcP8H0bXObcqxhOtKzkQrOejb7MELiB+VsYOKOXQ3mqrICVsPvCEC3h1HexoLAYlijJ2iZJWRfP7PP8gFJrFEhxOqTpNB/LQXeTxbqEeSu2dpJtTngC1PkRXy4jyzF6oMY9nEA6B2F50AQ5qY75UfuJd3atO1sw/vtpegfxSgLnOenhfwSiQ8kks9hGBWl+2Kug8icQIF+YOUIgibdXuk+5BMBHXtBF3q8pR6yDzjcDuZnCzf9Byuq X-Bogosity: Ham, tests=bogofilter, spamicity=0.001545, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 15, 2023 at 9:34=E2=80=AFPM Ilya Leoshkevich wrote: > > Like for KASAN, it's useful to temporarily disable KMSAN checks around, > e.g., redzone accesses. This example is incorrect, because KMSAN does not have redzones. You are calling these functions from "mm: slub: Let KMSAN access metadata", which mentiones redzones in kfree(), but the description is still somewhat unclear. Can you provide more insight about what is going on? Maybe we can fix those accesses instead of disabling KMSAN?