From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ABF43C2D0CD for ; Wed, 21 May 2025 10:02:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 276D06B0089; Wed, 21 May 2025 06:02:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2266A6B008A; Wed, 21 May 2025 06:02:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1152D6B008C; Wed, 21 May 2025 06:02:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E36D66B0089 for ; Wed, 21 May 2025 06:02:54 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E7BEA80DB2 for ; Wed, 21 May 2025 10:02:53 +0000 (UTC) X-FDA: 83466476226.22.A6E660A Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf09.hostedemail.com (Postfix) with ESMTP id F1761140015 for ; Wed, 21 May 2025 10:02:51 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=diodY5aL; spf=pass (imf09.hostedemail.com: domain of glider@google.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747821772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hGVCzMZOE97pm/+7xdNe3qSpEf0+u5dNQxNicc26ENo=; b=Q/TAWO6GmsVDk2sJVkLsTWS9+Pib9apLJW6wFYnuqTlVs+ZZEmqS3IJlm4lEc6u5JjMMPb NPYT2Jve4glmPJfjK7OZW6IjsuRGX/kd8IQaEH61QqRBfi1zD4vzo1/Nuxh/7JiKPJZ4aZ t6bxxcPwHYaiDJ/tvuBFK3vZ9X+1Eh8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747821772; a=rsa-sha256; cv=none; b=GdwqpkZcUX7XnN2E6zh7/+3H+CvSs9Fu9SpVAG+89OLKo7koH6sv8s+PhDTox/K3DzC++j mBZ4DwShJk3c7H9vQYUXJnauzYgBD8Ty/DMoct+OrdHfBoIOaugP1Kf2vXKx86bmJ78qwV y4aUzfk6tzbGftkklui4EMG7Bj8kyTk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=diodY5aL; spf=pass (imf09.hostedemail.com: domain of glider@google.com designates 209.85.219.41 as permitted sender) smtp.mailfrom=glider@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6f8ae08e38dso67336396d6.2 for ; Wed, 21 May 2025 03:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1747821771; x=1748426571; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hGVCzMZOE97pm/+7xdNe3qSpEf0+u5dNQxNicc26ENo=; b=diodY5aLSqo3huF6iN1DkxYaD+C35iy/eMJjTJFdWwaYGhEoIsK58Q45D2lfsaeX+W c7G6VetJFINpnTadVFECO/KDjch8ZXAv+Y6CWQqTZrkMU697ouVOSHjtye/R6mTvnr8z 5R6NdNds63Dzo2xJtdItdXG+IAJiDpho0ilK1tLk+az4jBLwkd3E1uLrP1TAnQWiWeiq kJR+fOs9haZ75SlZX3IHTmT3Zil1RIp+xuT7SaI7Ss8lIxUL7dwR7GDE9PyzHAmeuxlZ HjB0dCC2j/SyUuyulo/YgZMPuVvJ6TcwalCLlJmEbCtUrkshTmNNr0ZyMFGztcDANer5 co8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747821771; x=1748426571; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hGVCzMZOE97pm/+7xdNe3qSpEf0+u5dNQxNicc26ENo=; b=C1demfu+z5vkurCzDfn03zDFIIKPmujYb+VuT/I3TN9hGwEuqc+t7cblMISNYb/3m4 OFl1xZm6eTD5b3I8J/Cm3K2nu+y4EdNksApL8WbNu2Zurlv3WFwxoXez8iT7/yPTZiAP MVcKN5roNEazduC+aVC3p6IQIZhv0G4FLkdl820+BVy1tVqJmKKXzva6nwDAnoTmap0O 6+STvMbra106TZAI/CfSexdx1xy2eD/MxWMWWsALsbyhCWBTvdQN6jj4R0YrMsKUcGNe ph/VVbQkG2zvJDIaEd5L8gxYt1w7n+XeVqo1QnIb3j9uiAZ2+n2hKJZ010QffVwMkQGr O2LA== X-Gm-Message-State: AOJu0YysNEayJGGjkjSuaI5XyMvfOMzbAd6FZcXDRvZpMmLG7jkCSV+u yQTvh79aDWG9EUhnDzn9rOQFsnvGtYd3PkGD2vTeUiQaM8VJn5xvesmy6pw+4wOO+mHCtUKndUr WFTw802Uy/qpe8KHQRuZzJBU9aXdUMLIDobCP/Zi9wgCYBMGJ+Zg85Wo2 X-Gm-Gg: ASbGnctVp18ceSTQjQZ3jwMJNnhT2htxk5xIWiIVljhQPghU//cP142uTfhsZsAZjxS 5awyiw2YlKYnvKLbXYoTGjmMgPOcgpnVJ6Y1KCHF8zWwNAWXFAj47Qk2465gFp+DFb9vwIBCC/i ykgJM6YDJ9T5jeJvB2TKYB4FNlhzPGyb67zVqhUwvkgj1fcx7N97Yh4pQb3w4IJ70x14qCPQI5 X-Google-Smtp-Source: AGHT+IEm4BKFb5X1q0agtW63FdYJCI40qvC1DEbS34ledOoHRbdXdLG/0r4eGJo+uqR/WgsmzZYCGMgXB6A4yApRqfk= X-Received: by 2002:a05:6214:40b:b0:6df:97a3:5e5a with SMTP id 6a1803df08f44-6f8b08ceb3amr357793746d6.28.1747821770566; Wed, 21 May 2025 03:02:50 -0700 (PDT) MIME-Version: 1.0 References: <20250507133043.61905-1-lukas.bulwahn@redhat.com> <20250508164425.GD834338@ax162> In-Reply-To: From: Alexander Potapenko Date: Wed, 21 May 2025 12:02:14 +0200 X-Gm-Features: AX0GCFubuxvb81f_x5em7Iy6MU7avDIHjdMdNZqeGYpj71-tqlOCNdY-AOhiHCU Message-ID: Subject: Re: [PATCH] Makefile.kcov: apply needed compiler option unconditionally in CFLAGS_KCOV To: Linux Memory Management List , Andrew Morton Cc: Nathan Chancellor , Lukas Bulwahn , Masahiro Yamada , Nicolas Schier , Andrey Konovalov , Arnd Bergmann , linux-kbuild@vger.kernel.org, kasan-dev@googlegroups.com, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn , Dmitry Vyukov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ugxxbyn53frtacgd6baurfcrihzz4ffc X-Rspamd-Queue-Id: F1761140015 X-Rspam-User: X-Rspamd-Server: rspam02 X-HE-Tag: 1747821771-405915 X-HE-Meta: U2FsdGVkX1/oQpkqBhWD9v825eKmtjIYbJymvRQNL4G6kfGWBxCYlsIPBgRwil7CjEtmR/CveUM3M6YmpJAWQx4aGhXpZStrXvuHj5fvQmWrvcjJtX6LH1evfUdQBEiO1GLq+OgSzjz+Np50BlinicH2qP3n6L8o3lGpnJL4UT1xdkTrgqMj4MM8jtevvODWiNqyJ0KTEKlaaBbp+lBpK1zIuGg/oSsWSuaxfwSwewCqQCGPAGuCtbQN5BKaPFM7hrKNaGEmiBVusbB6xncqLJtUgW0pJTXZ1dM42Enb0GE6XWdIYQOVTm9SDyCbVNcUFa2sHX6xxdWrntamXgAWEbnRzDKGLzuI2DJOX5WQFK5J1PfVFfQ28zUM4E9QNA08HqEBlR049hHRQqma+tVY94sKa9ZbPW3mwqFbttgyHMJJ0YC186J3dyisNFPsT7Dxq1gUwLdEo8T00pc5yCKUANUyiO+pRRGYImuXPqcczV//dQh0TeZtF5CI9RWHAE17rdzkkqtXcqCSH47D9LelqQddbI+iEYA1z3rWTyCny0q1r5YseC8ER1ubb0jM4OeWjYhJrJ+Te0rzecUw/EOT685NYlJU2zby0pFWsmWpeS8VbxPQQMgWHEzIs2bTBCfrZk08sTSgXcldmyFgk2tpUifY+DNyF2lvY9e1kA9viKmUbgTG0rZVLqH3HxOaUtiv1/KPpVK2e2CMagp8NWVWlXyakJyqVpDmUTPcCdTZXS0fLqNFqAxfzLdkKua2weUde6ymK6Miv3mGhvjYoo3uyZ+w+zQ5M8KJQ2SfNtBoALhzpKUXjnMpxaXxr7MLyFLoQYJw4E7Gmiv3PhFDjgIR1Ns39jCi8KBqH6S+C4RlPZeQV68Q3nuJZMw79U34BVEfXRsJ0f7N8eA61uJZE5tCn3FOKwumaxfJzhDEyV99DQrElF+FEy6lMR8q0JlwNVC7wWz13SingMDG/IcBxxp tFLV3Jkl dZTtrH6ostTJhFukry8P+I09xN5YApQb+AjTSthM6vJbht4jOLw/00F+XiowbTorDH2ATwJfkrZfbxLnnQA9FeeA0kjapE4QyQMB39LDSe76Ih+kmP14tLN317Ur4S8KzNZSefM1JYUHbsdy/LO7BjTEGG9tBjfx721/v10IyulYhnWlU08xgN7chhpxyBDeFfrWpZFXlmIKcvpGp9MzehOZ2dHIulGXCre+PpoFDzQ9GMNmq2BanlJmg0w83w5I38Ne/6QKz0IncAL1k0zHsL7+Zu8131lVEqUN/Kc/PbraMDckIRGFpl/prLeqRXWbVDpLtnkzv6OsqVMO+f1dL7ysTMsTMRdMMNIFGlQKx0V0crt4KDHbPzcL0ZQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, May 20, 2025 at 4:57=E2=80=AFPM 'Dmitry Vyukov' via kasan-dev wrote: > > On Thu, 8 May 2025 at 18:44, Nathan Chancellor wrote: > > > > On Wed, May 07, 2025 at 03:30:43PM +0200, Lukas Bulwahn wrote: > > > From: Lukas Bulwahn > > > > > > Commit 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin") removes= the > > > config CC_HAS_SANCOV_TRACE_PC, as all supported compilers include the > > > compiler option '-fsanitize-coverage=3Dtrace-pc' by now. > > > > > > The commit however misses the important use of this config option in > > > Makefile.kcov to add '-fsanitize-coverage=3Dtrace-pc' to CFLAGS_KCOV. > > > Include the compiler option '-fsanitize-coverage=3Dtrace-pc' uncondit= ionally > > > to CFLAGS_KCOV, as all compilers provide that option now. > > > > > > Fixes: 852faf805539 ("gcc-plugins: remove SANCOV gcc plugin") > > > Signed-off-by: Lukas Bulwahn > > > > Good catch. > > > > Reviewed-by: Nathan Chancellor > > Reviewed-by: Dmitry Vyukov > > Thanks for fixing this! @akpm, could you please take this patch at your convenience?