From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FFA3CD1284 for ; Tue, 2 Apr 2024 07:04:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EB7366B008A; Tue, 2 Apr 2024 03:04:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E672A6B0092; Tue, 2 Apr 2024 03:04:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D2FEF6B0093; Tue, 2 Apr 2024 03:04:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B49D76B008A for ; Tue, 2 Apr 2024 03:04:55 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3A9E3A0D5F for ; Tue, 2 Apr 2024 07:04:55 +0000 (UTC) X-FDA: 81963704550.04.2E2CF7E Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) by imf24.hostedemail.com (Postfix) with ESMTP id 5667518001B for ; Tue, 2 Apr 2024 07:04:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=c4FGvf7o; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of glider@google.com designates 209.85.210.53 as permitted sender) smtp.mailfrom=glider@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712041493; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IPQbo+kDUd7xbiYKUftvSuYMx6VaFrLZDhUMPLmP0Sc=; b=UvTmR/cTFgfBhIQFwTWs1kw5ngRaw/KhrWfvJVNOyB/mLn1xt2wq0EqVNfU10sHkDD8C1j SLACwuQ6jDs6WJyVwlCMCVL4Iqgff1QlepvT3gvG4P5qNVgjWCltOZuakZPAAAwrbx6IE8 JkUOuKuiJZznOqQWIciviAe7Tl2KbGA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=c4FGvf7o; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of glider@google.com designates 209.85.210.53 as permitted sender) smtp.mailfrom=glider@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712041493; a=rsa-sha256; cv=none; b=DC78XyULi+ES8IcNdTCg8f0s/lv0DxGnKlPfM2lWFmjhsdtBJt4CiMMmTxXPamz3btSn8C TNjEOG58c4UEqGDhZuyT+22tPmE3yt9FwVmyOZai8PSquBS83MpUdXZw90Ue0WGS5Ziqga QKfp7lIo3u8l82e2VB0Pphxe2Lw9a78= Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-6e675181ceaso3146191a34.2 for ; Tue, 02 Apr 2024 00:04:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1712041492; x=1712646292; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IPQbo+kDUd7xbiYKUftvSuYMx6VaFrLZDhUMPLmP0Sc=; b=c4FGvf7oFwl485g69SMjowuIyt8rg11s9NqwuveSvaCbyaRx6jQlpyMrvU1dGFGKdw CjG0+3WkUrlbCqZjt94VA9ttlFB+lpMJQfMKx/8X4JakSKcd0PPtAaW7sID3PCOKkA5E APZDw+nNNedf/r+jndvs27CiE4eyqZzRPqWFY5qTw6aP6WOL2XKS2tukmE8wAmJRQ+cj 6+c5UDIxt4YLiVOAQ/Qj2e98Hvxf037+7hEg/I0cD2+aeEiIWeXUTixyxTH14OCTedLw Y3YKMm/UZSQq+SdYVkgTf+JsFKwVi+sRv1cRdUy2kvQWcODbQ2o0t5+99uWRsP1mKPNy YPcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712041492; x=1712646292; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IPQbo+kDUd7xbiYKUftvSuYMx6VaFrLZDhUMPLmP0Sc=; b=RvUrM3cc2MwPdVGhJnW72x2fR1iSXx0evTA3CyEvv2eAmZiv5K9CnvZl0oBVMW3yGT RbgFa3ucKgT5oV4r2bKijRdKGodvorNrftqthrcGMU4ki9rqcBIdDq7xyVZwadnOvieq EMGAIzNWCkDNNSuxEQDGLeqmiwVajAPvqOnPDnPM2j9H25JCKLa9NhNMLUmb7/BeYl4I rXhjTPHlXMCcHEQoSIlMDCQytHFZp4ui0slMsRvHAJ8Mh4AfhaNnKqi3c4ba4OoYVyIJ dktG/XYG0TdrnzrwwVYq/5uZRAE4JTQKexmuxme/N+Jh8AfDeditQD6DmvcJH0S9A4Y4 zVTA== X-Forwarded-Encrypted: i=1; AJvYcCWF4GYThFhMdLAWq+Xb3FiRccbvJ7yL6f1QfJr91NMfQlhoYPZgyGX2vVQQzTdps27p1lcYAItaEWjjfgAiKu822iw= X-Gm-Message-State: AOJu0YwXU0JElw2exZ7kMHEah2idIAWQxEbejrRsaaRkIfSP36lSetve XcCo+GFiMclmz9D/WRzBzkXoZVf6//WNOmIl9Z2zSh0E9aR+RbWPeZZl01/PzH0xTpWuudpNdfY 8nKi+DmwnBWsWlOyVEH7vOu2Y6d2/5dkyLL+h X-Google-Smtp-Source: AGHT+IGhF/OHGGLMOXdiFHrcqBKBvthhiZItBAVgZ8l5E6BDcDM15/znNEvCA6KvzPFRohHecG0ggecYLBssiggM8EA= X-Received: by 2002:a9d:61cd:0:b0:6e6:a9e2:8bc6 with SMTP id h13-20020a9d61cd000000b006e6a9e28bc6mr11525473otk.0.1712041491990; Tue, 02 Apr 2024 00:04:51 -0700 (PDT) MIME-Version: 1.0 References: <20240402001500.53533-1-pcc@google.com> In-Reply-To: From: Alexander Potapenko Date: Tue, 2 Apr 2024 09:04:09 +0200 Message-ID: Subject: Re: [PATCH] stackdepot: Rename pool_index to pool_index_plus_1 To: Vlastimil Babka Cc: Peter Collingbourne , Andrey Konovalov , Oscar Salvador , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michal Hocko , Marco Elver , Omar Sandoval Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 5667518001B X-Stat-Signature: bptbdgeftsqff8ehtn3b4xrhprwhc3am X-Rspam-User: X-HE-Tag: 1712041493-113497 X-HE-Meta: U2FsdGVkX199XsjLOmkW3BbhbvltjRasJpjfH34r6/W5/uDBhB9ZUFgnJA8K3sy86ZDWze9sYfAWp/PdrzXv6iT+ptYXq7GbtNGR2EXWpHKYf5mpCq/FdqPPbdvFz6U7xQWW13gUx7M/kPCxDUwcXmGAgANQV8rHu1O+o1sN9JoMK2xUstDWMwUwskPk0ZGSgRt/8Ujpwld/aej0/FQudBPoqTVCjUbAS3k71h6sSGyuLKo3eT6INkppV2a8nM2wIjkAL008rahbnQwXx0pDHAq7rt4F/F0MQmAwRwAPIPeSPCT5CrRrRn3llCpU8MxPIcOTU7/LGA+jA+EKD/cWr9DZJfB4bP1LN9VnfFN7IzVgwfUFoygsbmhqqhuDK3eWYNnKECbKWnwWiQtPP172Q3iG4x/fPhswe7XTws9qs0OjRY3N0oN1Ug5nyZyJPpGGMgSXd4vRqluYdWg3g5QEiDRhvYRP6W6rUXTAYavejj2sEfbQHBJ1tzWbUr3duaFF9Whk2+I4+WLo3ZnePWoNc0qEe9EWCcIyqIrs088cLUlzJvukc5s3b7CenrRZyG/Pg6FKuRoAys/NRVC1Otsl0G5EvdgD+BXAmrkZTsPn7VTj3N6ofLw7bMdEo1Dt6Oq1RMXg6c5vcwQ7HiDgmeO/op7PA7O6QTrv5pdgDKASFW65CwH3OttFHc/Vy2scFh4HIjuTIHR+7qk8Oin86r2U2deq/Yktf42WHL24r+yECrFINMegMCyD7IGR20KGUjhKjZjZp/wfntmWuoWMzOmzeRWDEvS3NRwCNFyQgGfuC+xEqC8d8OYs7KlpEUzCkOC6eCOFwDrKctJS/F71Jz/BkoZjDzyhk6gL+IiSQInwxvYPbKxu3ObIHdUBRM7YHftxfXC0GphA0Z+0+xMUAmZl37J0a9RLUHmu0RVkcv8SXnTCljSJXK+ORJvH6v2Ufbf0g0qeDbiKOoLirRZkP7W +PUXjnQH 6SKwwWXC+EMN4TdKfdDxS7dyYaICSeoV8sIZDTL+9F+oW/4CpVsQI6L6TsLqd0hd4ftkG/O2Ds2/j/+ZipXFwny9I+WZGaHjDQpfZyzh35UVxraJaVZ7inNYoPxQ/VZOSxUsXZu54wD5zu3GPBH6OjKnF/dPoKM8qFykRRnznsXqDBkW74RVtehwORaQ+/1C/bmo6WRn5mpsDFTWq9dtV7+8+HNHQcdCHRWeloxtnRecA6L5kNCwSKUCp6so7The9IeNfa2S60CB5HeEVAWdFTrRlgbrS0KkRb/0TDw8lWOrSYgUwZzgcRa33hr/ctXZAkGiPNhQvgKQpLozkH2d1S2lPEP10N2sHqi3B X-Bogosity: Ham, tests=bogofilter, spamicity=0.007659, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 2, 2024 at 8:54=E2=80=AFAM Vlastimil Babka wro= te: > > On 4/2/24 2:14 AM, Peter Collingbourne wrote: > > Commit 3ee34eabac2a ("lib/stackdepot: fix first entry having a > > 0-handle") changed the meaning of the pool_index field to mean "the > > pool index plus 1". This made the code accessing this field less > > self-documenting, as well as causing debuggers such as drgn to not > > be able to easily remain compatible with both old and new kernels, > > because they typically do that by testing for presence of the new > > field. Because stackdepot is a debugging tool, we should make sure > > that it is debugger friendly. Therefore, give the field a different > > name to improve readability as well as enabling debugger backwards > > compatibility. > > > > Signed-off-by: Peter Collingbourne > > Link: https://linux-review.googlesource.com/id/Ib3e70c36c1d230dd0a118dc= 22649b33e768b9f88 > > Acked-by: Vlastimil Babka Reviewed-by: Alexander Potapenko